D22475: Use metadata.json when creating the metadata from KPackage::metadata()

[David Edmundson]

davidedmundson added a comment.


  That was less than 5 hours from posting to give up on a review!
  
  We're not in a rush.

INLINE COMMENTS

> package.cpp:52
> +{
> +static QSet blacklist = {"metadata", "metadatajson"};
> +return blacklist.contains(name);

that's a whitelist

> package.cpp:64
>  addFileDefinition("metadata", QStringLiteral("metadata.desktop"), 
> i18n("Desktop file that describes this package."));
> +addFileDefinition("metadatajson", QStringLiteral("metadata.json"), 
> i18n("JSON file that describes this package."));
>  }

According to the docs

> Starting in 4.6, if an entry with the given key already exists, the path is 
> added to it as a search alternative.

so we can also search for metadata.json without changing the key. which will 
then work for all other code that uses "metadata" as a key.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D22475

To: apol, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22419: Fix cant enter directory error on Android FTP servers

[NXiss7]

nxiss7 changed the visibility from "Public (No Login Required)" to "All Users".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks
Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22419: Fix cant enter directory error on Android FTP servers

[NXiss7]

nxiss7 added a comment.


  ES File Manager 3.2.5 has this issue.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks
Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22419: Fix cant enter directory error on Android FTP servers

[NXiss7]

nxiss7 added a comment.


  You're right.
  But some applications don't work well.
  I think this would make KIO more "works out of the box" and help end-user...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks
Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22419: Fix cant enter directory error on Android FTP servers

[Sune Vuorela]

svuorela added a comment.


  According to the RFC, the server should ignore case:
  
  > Upper and lower case alphabetic characters are to be treated
  >  identically. Thus any of the following may represent the retrieve
  > command:
  > 
  >   RETR Retr retr ReTr rETr
  
  I'm not sure how many buggy servers we should add workarounds for. One thing 
is the -a option which I'm not sure is actually standardized.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks
Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/4/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 15 Jul 2019 19:38:52 +
 Build duration:
45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D22475: Use metadata.json when creating the metadata from KPackage::metadata()

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:898e5133e796: Use metadata.json when creating the 
metadata from KPackage::metadata() (authored by apol).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22475?vs=61797&id=61827

REVISION DETAIL
  https://phabricator.kde.org/D22475

AFFECTED FILES
  src/kpackage/package.cpp

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22477: Add a config to only show completions matching word beginning

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Default is `false,` so does not change behaviour unless someone toggles the 
switch, right?
  
  I would rename the option to `WordCompletionMatchFromWordStartOnly` though, 
as from what I can tell completion often only does from start, and matching 
also in the word is an extra feature.
  
  Actually, perhaps that whole option could/should be even an enum for 3 cases:
  a) from full word start
  b) from subword start (CamelCase, _) 
  c) match anywhere in word.
  I vaguely remember some cases where I got annoyed by cross-subword hits 
accidentally creating a match.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: Add a config to only show completions matching word beginning

[Christoph Cullmann]

cullmann added reviewers: KDevelop, kossebau, mwolff, kfunk.
cullmann added a comment.


  Given KDevelop uses the completion a lot more extensive than Kate, I would 
like to have some input from there, too ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22477: Add a config to only show completions matching word beginning

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This disables the current behaviour where if no match is found,
  completions that "contain" the word to-be-completed, and that are at
  a word beginning (marked by a capital letter or an underscore), are added
  to the list of completion items; e.g. Foo will match BarFoo and Bar_Foo.
  
  BUG: 381024
  FIXED-IN: 5.61.0

TEST PLAN
  - Open a document in kate and type the following:
  
  Foo
  BarFoo
  Bar_Foo
  
  - Enable the new config option and type Foo; check if BarFoo or Bar_Foo are 
offered as completions
  - Diable the config and repeat the above step.

REPOSITORY
  R39 KTextEditor

BRANCH
  autocompletion-backwards-matching (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22477

AFFECTED FILES
  autotests/src/completion_test.cpp
  src/completion/katecompletionmodel.cpp
  src/dialogs/completionconfigtab.ui
  src/dialogs/katedialogs.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: New framework: KCalCore

[Aleix Pol]

On Fri, Jul 12, 2019 at 9:03 PM Allen Winter  wrote:
>
> On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote:
> > With the 19.08 release approaching (and thus the deadline for incompatible
> > changes if we go ahead with this plan), I'd like to raise this again for
> > getting to a decision :)
> >
> > Summary of what happened in the past weeks:
> > - the Person/Attendee slicing issue was fixed by making both independent 
> > types
> > - several "leaf" types were turned into implicitly shared value types rather
> > than being used heap-allocated inside shared pointers
> > - the dependency on the Akonadi supertrait.h header file was removed
> > - the virtual_hook usage in the incidence de/serialization code was replaced
> > by new virtual methods
> >
> > Unless I missed something, the remaining unaddressed feedback is down to:
> > - Rename KCalCore to something else. I'm ok with executing the rename, but
> > somebody needs to tell me the new name :)
>
> I don't remember the reason for changing the name.
> I vote for not changing the name. KCalCore is as good as any, imo
>
> > - Alexander P's fundamental objections to the current KCalCore API
> >
> > How do we proceed?
> >
> > Thanks,
> > Volker
> >
> > On Sunday, 7 April 2019 14:45:09 CEST Volker Krause wrote:
> > > Hi,
> > >
> > > I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> > >
> > > KCalCore is an implementation of the iCalendar standard based on libical,
> > > covering the data model, input/output and the rather complex recurrence
> > > algorithms defined in that standard. It's used outside of KDE PIM as well,
> > > e.g. by Zanshin or the Plasma Mobile calendar app.
> > >
> > > KCalCore depends on Qt and libical only, making it a Tier 1 functional
> > > framework.
> > >
> > > KCalCore used to be part of part of kdepimlibs in the KDE4 era, so it's 
> > > well
> > > prepared for complying with the API and ABI guarantees.
> > >
> > > I'd suggest the same timeline as proposed for KContacts [1]. During the 
> > > PIM
> > > sprint we did a number of fixes and cleanups as part of the review for KF5
> > > that make 19.08 the earliest release after which we can switch as well, so
> > > we are looking at a switch in Sep/Oct this year.

If you don't remember, just scroll up a bit. :P

I went through the thread and that's what we said:
- It's a framework to understand the ical format, this is not conveyed
by the current name
- The Core postfix doesn't add anything and we are already using it
for differentiating different framework targets (e.g. KF5::ConfigCore
and KF5::ConfigGui)

I see KCal, KCalendar, KiCalendar, KiCal, KCalendarEvents,
KCalendarIncidences being suggested. It's not going to be me who
chooses one though. ;)

Aleix

D22475: Use metadata.json when creating the metadata from KPackage::metadata()

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise we'd end up using the slow path.

TEST PLAN
  metadata still gets loaded but using the faster path.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22475

AFFECTED FILES
  src/kpackage/package.cpp

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

[Daniel Vrátil]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:811e78ef0ee3: Calendar events: allow plugins to show 
event details (authored by dvratil).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21901?vs=60890&id=61798#toc

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21901?vs=60890&id=61798

REVISION DETAIL
  https://phabricator.kde.org/D21901

AFFECTED FILES
  src/calendarevents/calendareventsplugin.cpp
  src/calendarevents/calendareventsplugin.h

To: dvratil, #frameworks, mart, apol
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:2631be903f94: new class KBusyIndicatorWidget similar to 
QtQuick's BusyIndicator (authored by sitter).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22375?vs=61789&id=61794

REVISION DETAIL
  https://phabricator.kde.org/D22375

AFFECTED FILES
  docs/pics/kbusyindicatorwidget.png
  src/CMakeLists.txt
  src/kbusyindicatorwidget.cpp
  src/kbusyindicatorwidget.h
  tests/CMakeLists.txt
  tests/kbusyindicatorwidgettest.cpp

To: sitter, cfeck, apol
Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
sbergeron, michaelh, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Christoph Feck]

cfeck accepted this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
sbergeron, michaelh, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Harald Sitter]

sitter updated this revision to Diff 61789.
sitter added a comment.


  typos--

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22375?vs=61659&id=61789

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22375

AFFECTED FILES
  docs/pics/kbusyindicatorwidget.png
  src/CMakeLists.txt
  src/kbusyindicatorwidget.cpp
  src/kbusyindicatorwidget.h
  tests/CMakeLists.txt
  tests/kbusyindicatorwidgettest.cpp

To: sitter, cfeck, apol
Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
sbergeron, michaelh, bruns

D22471: [KProcessList] Split command line and process name

[David Edmundson]

davidedmundson added a comment.


  > So now name() will often return an empty string?
  
  That's certainly not the intention.
  
  The system is:
  
  Firstly we do the fallback. Reading from /proc/N/state  . Though this is 
rubbish and truncates things.
  Both name and command are set to this.
  
  Then we read /proc/N/cmdline
  
  Then we extract the command.
  We set the name to the first segment of the command (between the final / and 
the first null byte
  We set the command to the full thing, but with all null bytes becoming spaces
  
  On windows, name and command will return the same thing.

INLINE COMMENTS

> apol wrote in kprocesslist_unix.cpp:142
> if it's -1, when you do ++ it will become 0 anyway.

It would, but it would then requires a huge comment explaining it.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D22471

To: davidedmundson
Cc: apol, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/33/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 15 Jul 2019 13:12:05 +
 Build duration:
9 min 9 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.61.0.xmllogs/KF5WindowSystem/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7205/9577)55%
(3558/6415)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3052/3144)53%
(1292/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(786/1391)45%
(302/668)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3360/4685)61%
(1961/3237)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D22471: [KProcessList] Split command line and process name

[Aleix Pol Gonzalez]

apol added a comment.


  So now name() will often return an empty string?

INLINE COMMENTS

> kprocesslist_unix.cpp:142
> +int processNameStart = cmd.lastIndexOf('/', zeroIndex);
> +if (processNameStart == -1) {
> +processNameStart = 0;

if it's -1, when you do ++ it will become 0 anyway.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D22471

To: davidedmundson
Cc: apol, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/4/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 15 Jul 2019 13:12:05 +
 Build duration:
3 min 4 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.61.0.xmllogs/KF5WindowSystem/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7205/9577)55%
(3557/6415)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3051/3144)52%
(1290/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(786/1391)45%
(302/668)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3361/4685)61%
(1962/3237)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/3/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 15 Jul 2019 13:12:05 +
 Build duration:
2 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

D22472: Port KXMessages away from QWidget

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:3c5f3f8ba4cd: Port KXMessages away from QWidget (authored 
by davidedmundson).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22472?vs=61787&id=61788

REVISION DETAIL
  https://phabricator.kde.org/D22472

AFFECTED FILES
  src/platforms/xcb/kxmessages.cpp

To: davidedmundson, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22472: Port KXMessages away from QWidget

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22472

To: davidedmundson, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22472: Port KXMessages away from QWidget

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It's only needed for an xcb_window
  
  This allows use of libtaskmanager in a QGuiApplication

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22472

AFFECTED FILES
  src/platforms/xcb/kxmessages.cpp

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22003: Change selected text color to black

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  Abandoning because it can negatively affect other widget styles.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D22003

To: ndavis, #vdg, #breeze, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 132 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/132/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 15 Jul 2019 11:58:15 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13389)18%
(1824/9896)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1419/3490)28%
(794/2841)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2022)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/9/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 15 Jul 2019 11:58:15 +
 Build duration:
6 min 0 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3629/13388)18%
(1823/9896)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1419/3490)28%
(794/2841)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)28%
(574/2021)18%
(316/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/5/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 15 Jul 2019 11:58:15 +
 Build duration:
2 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D22471: [KProcessList] Split command line and process name

[David Edmundson]

davidedmundson updated this revision to Diff 61784.
davidedmundson added a comment.


  Swap member order

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22471?vs=61783&id=61784

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22471

AFFECTED FILES
  autotests/kprocesslisttest.cpp
  src/lib/util/kprocesslist.cpp
  src/lib/util/kprocesslist.h
  src/lib/util/kprocesslist_p.h
  src/lib/util/kprocesslist_unix.cpp

To: davidedmundson
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22471: [KProcessList] Split command line and process name

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> kprocesslist_p.h:46
>  qint64 pid;
> +QString command;
>  QString name;

Order name before since that's how the methods are ordered

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D22471

To: davidedmundson
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22471: [KProcessList] Split command line and process name

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Currently KProcessList had a method called "name" which confusingly
  returns the entire command line.
  
  In many cases where we want to use this class we need both. (See D22327 
)
  
  This class exposes both "name" and "command" with the respective
  properties.
  
  In order to do this correctly we need to split the process name before
  the null characters are replaced with spaces.

TEST PLAN
  Unit test
  Manually invoked ps list output

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22471

AFFECTED FILES
  autotests/kprocesslisttest.cpp
  src/lib/util/kprocesslist.cpp
  src/lib/util/kprocesslist.h
  src/lib/util/kprocesslist_p.h
  src/lib/util/kprocesslist_unix.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D12992: New elisa icon

[Linus Shoravi]

lshoravi added a comment.


  I believe we'll need @abetts .svg file- I can't seem to find it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: abetts, paullesur, januz, mgallien, alex-l, andreask, kde-frameworks-devel, 
mfraser, mnesbitt, LeGast00n, carneirogustavo, sbergeron, jguidon, ctakano, 
Tizon, oussemabouaneni, ashwind, fbampaloukas, sourabhboss, aureliencouderc, 
tgraves, hantzv, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, 
astippich, James, ngraham, bruns, kmf, lemuel

D22421: generate list of data files on the fly

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R264:a46504bdfcb3: generate list of data files on the fly 
(authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22421?vs=61658&id=61781#toc

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22421?vs=61658&id=61781

REVISION DETAIL
  https://phabricator.kde.org/D22421

AFFECTED FILES
  setup.py

To: sitter, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, sbergeron, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D22425: personsmodel: Add phoneNumber

[Jonah Brüchert]

jbbgameich closed this revision.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22425

To: jbbgameich, #plasma:_mobile, #kde_pim, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns