D22599: Make first and last name available separately

[Jonah Brüchert]

jbbgameich added reviewers: Plasma: Mobile, apol.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22599

To: jbbgameich, #plasma:_mobile, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22599: Make first and last name available separately

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Required for the Plasma Mobile phonebook app where both are separate fields

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22599

AFFECTED FILES
  src/backends/abstractcontact.cpp
  src/backends/abstractcontact.h
  src/persondata.cpp
  src/persondata.h

To: jbbgameich
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 62159.
brute4s99 marked 4 inline comments as done.
brute4s99 added a comment.


  udpated

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22105?vs=61972&id=62159

BRANCH
  arcpatch-D22105

REVISION DETAIL
  https://phabricator.kde.org/D22105

AFFECTED FILES
  CMakeLists.txt
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, 
sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22551: expose new KBusyIndicatorWidget

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R298:92785f974d65: expose new KBusyIndicatorWidget (authored 
by sitter).

REPOSITORY
  R298 KDesignerPlugin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22551?vs=62039&id=62157

REVISION DETAIL
  https://phabricator.kde.org/D22551

AFFECTED FILES
  src/kde.widgets
  src/kdewidgets.qrc
  src/pics/CMakeLists.txt
  src/pics/kbusyindicatorwidget.png

To: sitter, alexmerry, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kdewebkit » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20WindowsMSVCQt5.11/39/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 20 Jul 2019 22:07:08 +
 Build duration:
1 min 23 sec and counting

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.13 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.13/7/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 20 Jul 2019 22:01:59 +
 Build duration:
6 min 44 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WebKit-5.61.0.xmlcompat_reports/KF5WebKit_compat_report.htmllogs/KF5WebKit/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/1)0%
(0/6)0%
(0/6)0%
(0/752)0%
(0/709)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/6)0%
(0/6)0%
(0/752)0%
(0/709)

KDE CI: Frameworks » kdewebkit » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/4/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 20 Jul 2019 22:02:01 +
 Build duration:
4 min 26 sec and counting

KDE CI: Frameworks » kdewebkit » kf5-qt5 WindowsMSVCQt5.11 - Build # 38 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20WindowsMSVCQt5.11/38/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 20 Jul 2019 21:45:27 +
 Build duration:
21 min and counting

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.12 - Build # 26 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.12/26/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 20 Jul 2019 22:00:42 +
 Build duration:
3 min 0 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WebKit-5.61.0.xmlcompat_reports/KF5WebKit_compat_report.htmllogs/KF5WebKit/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/1)0%
(0/6)0%
(0/6)0%
(0/752)0%
(0/709)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/6)0%
(0/6)0%
(0/752)0%
(0/709)

KDE CI: Frameworks » kdewebkit » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/3/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 20 Jul 2019 21:45:26 +
 Build duration:
1 min 51 sec and counting
   CONSOLE OUTPUT
  [...truncated 134 lines...][2019-07-20T21:47:15.249Z] BUILD_NUMBER  = '3'[2019-07-20T21:47:15.249Z] LOGNAME   = 'jenkins'[2019-07-20T21:47:15.249Z] LANG  = 'en_US.UTF-8'[2019-07-20T21:47:15.249Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2019-07-20T21:47:15.249Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/display/redirect'[2019-07-20T21:47:15.249Z] MAIL  = '/var/mail/jenkins'[2019-07-20T21:47:15.249Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/3/display/redirect?page=changes'[2019-07-20T21:47:15.249Z] JENKINS_URL   = 'https://build.kde.org/'[2019-07-20T21:47:15.249Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-07-20T21:47:15.249Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.13'[2019-07-20T21:47:15.249Z] HUDSON_HOME   = '/home/production/data'[2019-07-20T21:47:15.249Z] BUILD_ID  = '3'[2019-07-20T21:47:15.249Z] OLDPWD= '/usr/home/jenkins'[2019-07-20T21:47:15.249Z] PWD   = '/usr/home/jenkins/workspace/Frameworks/kdewebkit/kf5-qt5 FreeBSDQt5.13'[2019-07-20T21:47:15.249Z] _ = '/usr/local/bin/java'[2019-07-20T21:47:15.249Z] TERM  = 'su'[2019-07-20T21:47:15.249Z] NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.13'[2019-07-20T21:47:15.249Z] BUILD_TAG = 'jenkins-Frameworks-kdewebkit-kf5-qt5 FreeBSDQt5.13-3'[2019-07-20T21:47:15.249Z] BUILD_DISPLAY_NAME= '#3'[2019-07-20T21:47:15.249Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/3/display/redirect'[2019-07-20T21:47:15.249Z] USER  = 'jenkins'[2019-07-20T21:47:15.249Z] HOME  = '/home/jenkins'[2019-07-20T21:47:15.249Z] BUILD_URL = 'https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/3/'[2019-07-20T21:47:15.249Z] JOB_URL   = 'https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/'[2019-07-20T21:47:15.249Z] HUDSON_URL= 'https://build.kde.org/'[2019-07-20T21:47:15.249Z] SHELL = '/usr/local/bin/bash'[2019-07-20T21:47:15.249Z] WORKSPACE = '/usr/home/jenkins/workspace/Frameworks/kdewebkit/kf5-qt5 FreeBSDQt5.13'[2019-07-20T21:47:15.249Z] MM_CHARSET= 'UTF-8'[2019-07-20T21:47:15.249Z] STAGE_NAME= 'Configuring Build'[2019-07-20T21:47:15.249Z] NODE_NAME = 'FreeBSD Builder 1'[2019-07-20T21:47:15.249Z] BLOCKSIZE = 'K'[2019-07-20T21:47:15.249Z] EXECUTOR_NUMBER   = '0'[2019-07-20T21:47:15.249Z] SHLVL = '0'[2019-07-20T21:47:15.249Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-07-20T21:47:15.249Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'[2019-07-20T21:47:15.249Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-07-20T21:47:15.249Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-07-20T21:47:15.249Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-07-20T21:47:15.249Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-07-20T21:47:15.249Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-07-20T21:47:15.249Z] QT_SELECT = 'qt5'[2019-07-20T21:47:15.249Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-07-20T21:47:15.249Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-07-20T21:47:15.249Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-07-20T21:47:15.249Z] [2019-07-20T21:47:15.249Z] [2019-07-20T21:47:15.249Z] == Commencing Configuration:[2019-07-20T21:47:15.249Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/kdewebkit/kf5-qt5 FreeBSDQt5.13"[2019-07-20T21:47:15.515Z] -- The C compiler identification is Clang 6.0.1[2019-07-20T21:47:15.515Z] -- The CXX compiler identification is

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.12/25/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 20 Jul 2019 21:45:26 +
 Build duration:
2 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 196 lines...][2019-07-20T21:47:34.410Z] HOME  = '/home/jenkins/'[2019-07-20T21:47:34.410Z] JENKINS_URL   = 'https://build.kde.org/'[2019-07-20T21:47:34.410Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.12'[2019-07-20T21:47:34.410Z] OSTYPE= 'linux'[2019-07-20T21:47:34.410Z] JOB_NAME  = 'Frameworks/kdewebkit/kf5-qt5 SUSEQt5.12'[2019-07-20T21:47:34.410Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-07-20T21:47:34.410Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.12/25/display/redirect'[2019-07-20T21:47:34.410Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2019-07-20T21:47:34.410Z] WORKSPACE = '/home/jenkins/workspace/Frameworks/kdewebkit/kf5-qt5 SUSEQt5.12'[2019-07-20T21:47:34.410Z] HUDSON_URL= 'https://build.kde.org/'[2019-07-20T21:47:34.410Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-07-20T21:47:34.410Z] NODE_NAME = 'Docker Swarm-d860085bfc16'[2019-07-20T21:47:34.410Z] HOST  = 'd860085bfc16'[2019-07-20T21:47:34.410Z] LESSOPEN  = 'lessopen.sh %s'[2019-07-20T21:47:34.410Z] USER  = 'jenkins'[2019-07-20T21:47:34.410Z] MORE  = '-sl'[2019-07-20T21:47:34.410Z] CSHEDIT   = 'emacs'[2019-07-20T21:47:34.410Z] SHLVL = '2'[2019-07-20T21:47:34.410Z] BUILD_TAG = 'jenkins-Frameworks-kdewebkit-kf5-qt5 SUSEQt5.12-25'[2019-07-20T21:47:34.410Z] WINDOWMANAGER = 'xterm'[2019-07-20T21:47:34.410Z] PAGER = 'less'[2019-07-20T21:47:34.410Z] EXECUTOR_NUMBER   = '0'[2019-07-20T21:47:34.410Z] CVS_RSH   = 'ssh'[2019-07-20T21:47:34.410Z] LIBGL_DEBUG   = 'quiet'[2019-07-20T21:47:34.410Z] STAGE_NAME= 'Configuring Build'[2019-07-20T21:47:34.410Z] NODE_LABELS   = 'Docker Swarm-d860085bfc16 SUSEQt5.12'[2019-07-20T21:47:34.410Z] XCURSOR_THEME = 'DMZ-Black'[2019-07-20T21:47:34.410Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-07-20T21:47:34.410Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-07-20T21:47:34.410Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-07-20T21:47:34.410Z] PROFILEREAD   = 'true'[2019-07-20T21:47:34.410Z] MAIL  = '/var/mail/jenkins'[2019-07-20T21:47:34.410Z] HOSTTYPE  = 'x86_64'[2019-07-20T21:47:34.410Z] BUILD_ID  = '25'[2019-07-20T21:47:34.410Z] LESSKEY   = '/etc/lesskey.bin'[2019-07-20T21:47:34.410Z] OLDPWD= '/home/jenkins'[2019-07-20T21:47:34.410Z] LC_CTYPE  = 'C.UTF-8'[2019-07-20T21:47:34.410Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-07-20T21:47:34.410Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-07-20T21:47:34.410Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-07-20T21:47:34.410Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-07-20T21:47:34.410Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-07-20T21:47:34.410Z] QT_SELECT = 'qt5'[2019-07-20T21:47:34.410Z] LANG  = 'en_US.UTF-8'[2019-07-20T21:47:34.410Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-07-20T21:47:34.410Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-07-20T21:47:34.410Z] [2019-07-20T21:47:34.410Z] [2019-07-20T21:47:34.410Z] == Commencing Configuration:[2019-07-20T21:47:34.410Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/kdewebkit/kf5-qt5 SUSEQt5.12"[2019-07-20T21:47:34.665Z] -- The C compiler identification is GNU 9.1.1[2019-07-20T21:47:34.665Z] -- The CXX compiler identification is GNU 9.1.1[2019-07-20T21:47:34.665Z] -- Check for working C compiler: /usr/bin/cc[2019-07-20T21:47:34.665Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-07-20T21:47:34.665Z] -- Detecting C compiler ABI info[2019-07-20T21:47:34.921Z] -- Detecting C compiler ABI info - done[2019-07-2

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.13 - Build # 6 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.13/6/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 20 Jul 2019 21:45:27 +
 Build duration:
1 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 196 lines...][2019-07-20T21:46:51.127Z] HOME  = '/home/jenkins/'[2019-07-20T21:46:51.127Z] JENKINS_URL   = 'https://build.kde.org/'[2019-07-20T21:46:51.127Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.13'[2019-07-20T21:46:51.127Z] OSTYPE= 'linux'[2019-07-20T21:46:51.127Z] JOB_NAME  = 'Frameworks/kdewebkit/kf5-qt5 SUSEQt5.13'[2019-07-20T21:46:51.127Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-07-20T21:46:51.127Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.13/6/display/redirect'[2019-07-20T21:46:51.127Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.13/display/redirect'[2019-07-20T21:46:51.127Z] WORKSPACE = '/home/jenkins/workspace/Frameworks/kdewebkit/kf5-qt5 SUSEQt5.13'[2019-07-20T21:46:51.127Z] HUDSON_URL= 'https://build.kde.org/'[2019-07-20T21:46:51.127Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-07-20T21:46:51.127Z] NODE_NAME = 'Docker Swarm-9fe7d50607e7'[2019-07-20T21:46:51.127Z] HOST  = '9fe7d50607e7'[2019-07-20T21:46:51.127Z] LESSOPEN  = 'lessopen.sh %s'[2019-07-20T21:46:51.127Z] USER  = 'jenkins'[2019-07-20T21:46:51.127Z] MORE  = '-sl'[2019-07-20T21:46:51.127Z] CSHEDIT   = 'emacs'[2019-07-20T21:46:51.127Z] SHLVL = '2'[2019-07-20T21:46:51.127Z] BUILD_TAG = 'jenkins-Frameworks-kdewebkit-kf5-qt5 SUSEQt5.13-6'[2019-07-20T21:46:51.127Z] WINDOWMANAGER = 'xterm'[2019-07-20T21:46:51.127Z] PAGER = 'less'[2019-07-20T21:46:51.127Z] EXECUTOR_NUMBER   = '0'[2019-07-20T21:46:51.127Z] CVS_RSH   = 'ssh'[2019-07-20T21:46:51.127Z] LIBGL_DEBUG   = 'quiet'[2019-07-20T21:46:51.127Z] STAGE_NAME= 'Configuring Build'[2019-07-20T21:46:51.127Z] NODE_LABELS   = 'Docker Swarm-9fe7d50607e7 SUSEQt5.13'[2019-07-20T21:46:51.127Z] XCURSOR_THEME = 'DMZ-Black'[2019-07-20T21:46:51.127Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-07-20T21:46:51.127Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-07-20T21:46:51.127Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-07-20T21:46:51.127Z] PROFILEREAD   = 'true'[2019-07-20T21:46:51.127Z] MAIL  = '/var/mail/jenkins'[2019-07-20T21:46:51.127Z] HOSTTYPE  = 'x86_64'[2019-07-20T21:46:51.127Z] BUILD_ID  = '6'[2019-07-20T21:46:51.127Z] LESSKEY   = '/etc/lesskey.bin'[2019-07-20T21:46:51.127Z] OLDPWD= '/home/jenkins'[2019-07-20T21:46:51.127Z] LC_CTYPE  = 'C.UTF-8'[2019-07-20T21:46:51.127Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-07-20T21:46:51.127Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-07-20T21:46:51.127Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-07-20T21:46:51.127Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-07-20T21:46:51.127Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-07-20T21:46:51.127Z] QT_SELECT = 'qt5'[2019-07-20T21:46:51.127Z] LANG  = 'en_US.UTF-8'[2019-07-20T21:46:51.127Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-07-20T21:46:51.127Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-07-20T21:46:51.127Z] [2019-07-20T21:46:51.127Z] [2019-07-20T21:46:51.127Z] == Commencing Configuration:[2019-07-20T21:46:51.127Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/kdewebkit/kf5-qt5 SUSEQt5.13"[2019-07-20T21:46:51.127Z] -- The C compiler identification is GNU 9.1.1[2019-07-20T21:46:51.386Z] -- The CXX compiler identification is GNU 9.1.1[2019-07-20T21:46:51.386Z] -- Check for working C compiler: /usr/bin/cc[2019-07-20T21:46:51.386Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-07-20T21:46:51.386Z] -- Detecting C compiler ABI info[2019-07-20T21:46:51.386Z] -- Detecting C compiler ABI info - done[2019-07-20T21

D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON)

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R300:6d14a648156e: Add option to build Qt Designer plugin 
(BUILD_DESIGNERPLUGIN, default ON) (authored by kossebau).

REPOSITORY
  R300 KDEWebKit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22581?vs=62118&id=62156

REVISION DETAIL
  https://phabricator.kde.org/D22581

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/designer/kdewebkit.widgets

To: kossebau, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22582: Remove designer plugin generation for KF5WebKit

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R298:729f723f7675: Remove designer plugin generation for 
KF5WebKit (authored by kossebau).

REPOSITORY
  R298 KDesignerPlugin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22582?vs=62115&id=62155

REVISION DETAIL
  https://phabricator.kde.org/D22582

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdewebkit.widgets
  src/kdewebkitwidgets.qrc

To: kossebau, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/5/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 20 Jul 2019 21:42:11 +
 Build duration:
1 min 56 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 144 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/144/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 20 Jul 2019 21:09:49 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfilewidgettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33520/61108)39%
(17085/43975)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9372/9820)48%
(4299/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8561/14465)51%
(4708/9219)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4595/8216)42%
(2000/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1204)39%
(373/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4290)36%
(1316/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/4/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 20 Jul 2019 21:12:54 +
 Build duration:
5 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/6/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 20 Jul 2019 21:09:49 +
 Build duration:
7 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[Christoph Cullmann]

cullmann added a comment.


  Thanks!

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: cullmann, wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[David Faure]

dfaure added a comment.


  Backported. 
https://commits.kde.org/kde-cli-tools/42ef318a9d1c454f96b60181d8231a59233720ea

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22567: TypeScript: fix keywords in conditional expressions

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22567

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22568: Fix generator and test paths of CMake

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0b7e23a81a94: Fix generator and test paths of CMake 
(authored by nibags).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22568?vs=62078&id=62146#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22568?vs=62078&id=62146

REVISION DETAIL
  https://phabricator.kde.org/D22568

AFFECTED FILES
  autotests/folding/highlight.cmake.fold
  autotests/html/highlight.cmake.html
  autotests/input/highlight.cmake
  autotests/reference/highlight.cmake.ref
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  generators/cmake.xml.tpl
  generators/cmake.yaml
  html/highlight.cmake.html
  input/highlight.cmake
  reference/highlight.cmake.ref

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22567: TypeScript: fix keywords in conditional expressions

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks reasonable, thanks!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  condexp-typescript

REVISION DETAIL
  https://phabricator.kde.org/D22567

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22568: Fix generator and test paths of CMake

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Yep, accident ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-paths-cmake

REVISION DETAIL
  https://phabricator.kde.org/D22568

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

[NXiss7]

nxiss7 added a comment.


  In D22419#498730 , @aacid wrote:
  
  > nxisss can we have your real name and email for commit this to the codebase?
  
  
  Enes Selim
  nxi...@gmail.com

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[Gleb Popov]

arrowd added a comment.


  I'm not familiar with KDE release engineering, so I'm asking to do merging 
someone else.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

[Albert Astals Cid]

aacid added a comment.


  nxisss can we have your real name and email for commit this to the codebase?

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22460: DrKonqi: improved lldb integration

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22460

To: rjvbb, kde-frameworks-devel, #plasma, dfaure
Cc: plasma-devel, kde-mac, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22586: KRun QML proxy: fix path/URL confusion

[David Faure]

dfaure updated this revision to Diff 62138.
dfaure added a comment.


  You'd think I would remember my own APIs :-)

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22586?vs=62123&id=62138

BRANCH
  D22586

REVISION DETAIL
  https://phabricator.kde.org/D22586

AFFECTED FILES
  src/qmlcontrols/kioplugin/krunproxy.cpp
  src/qmlcontrols/kioplugin/krunproxy.h

To: dfaure, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22586: KRun QML proxy: fix path/URL confusion

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM other than that.

INLINE COMMENTS

> krunproxy.cpp:35
>  QMimeDatabase db;
> -QMimeType mime = db.mimeTypeForFile(filePath);
> -const QString fileMymeType = mime.name();
> +QMimeType mime = db.mimeTypeForFile(fileUrl.isLocalFile() ? 
> fileUrl.toLocalFile() : fileUrl.path());
> +const QString fileMimeType = mime.name();

would it make sense to use db.mimeTypeForUrl?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22586

To: dfaure, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 143 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/143/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 20 Jul 2019 17:23:06 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33505/61107)39%
(17073/43975)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9370/9820)48%
(4292/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8548/14464)51%
(4703/9219)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4596/8216)42%
(1999/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4290)36%
(1316/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[Wolfgang Bauer]

wbauer added a comment.


  What about the stable 5.16 branch?
  It has only be committed to master so far AFAICS, so the fix would only end 
up in Plasma 5.17 which is still 3 months away...

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 142 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/142/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 20 Jul 2019 17:05:48 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfilewidgettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33517/61108)39%
(17082/43975)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9370/9820)48%
(4295/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8562/14465)51%
(4710/9219)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4594/8216)42%
(1999/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4290)36%
(1316/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/5/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 20 Jul 2019 17:12:12 +
 Build duration:
5 min 54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

[David Faure]

dfaure accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

[NXiss7]

nxiss7 updated this revision to Diff 62133.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22419?vs=62067&id=62133

REVISION DETAIL
  https://phabricator.kde.org/D22419

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/4/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 20 Jul 2019 17:05:48 +
 Build duration:
6 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D7820: man ioslave: spurious numbers included in clang(1) man page

[Jonathan Marten]

marten abandoned this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D7820

To: marten, #plasma, kfm-devel, mkoller
Cc: ltoscano, kde-frameworks-devel, plasma-devel, aprcela, fprice, LeGast00n, 
sbergeron, jraleigh, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, 
meven, michaelh, spoorun, navarromorales, ZrenBot, firef, ngraham, andrebarros, 
bruns, himcesjf, emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 141 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/141/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 20 Jul 2019 15:52:28 +
 Build duration:
9 min 1 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfilewidgettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33519/61108)39%
(17071/43969)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9370/9820)48%
(4292/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8557/14465)51%
(4704/9219)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4596/8217)42%
(2000/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/3/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 20 Jul 2019 15:52:27 +
 Build duration:
7 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18114: FakeInput: add support for pointer move with absolute coordinates

[Roman Gilg]

romangg added a comment.


  @jgrulich With D22571  looking promising 
do you want to put the keyboard parts of this diff into a separate one? There 
is still the question about keysyms and key events but we should discuss this 
in the new diff. Maybe we can have both: Keysyms for special keys / 
combinations like Alt+Tab and text input via text-input protocol?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: romangg, graesslin, zzag, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

Re: New framework: KCalCore

[Albert Astals Cid]

El dissabte, 20 de juliol de 2019, a les 12:14:09 CEST, David Faure va escriure:
> Hi everyone,
> 
> I just discussed this with Volker IRL and I found a solution to address my 
> initial concern with the name, the fact that a developer (who's new to all 
> this) seeing "Cal" might not understand this as meaning Calendar.
> At the same time, KCalendar is unclear (does it display a calendar? is it 
> about calendar systems? etc.). And we already discussed the problem with the 
> other alternatives (a new developer wouldn't understand Incidences, iCal 
> isn't 
> the only format behind all this, etc.)
> 
> So I suggested KCalendarCore, and Volker agreed.
> 
> Unless there are strong objections, we'll go with that.

All names are bad to some degree, let's just choose one and make sure the API 
documentation states clearly what this is for and that should be enough.

Cheers,
  Albert

> 
> Cheers,
> David.
> 
> On jeudi 18 juillet 2019 23:24:15 CEST Dominik Haumann wrote:
> > To me this sounds as if KCal is the best choice: KCal - a library with iCal
> > support. It's short, closest to iCal, and does not clash with calendar
> > systems.
> > 
> > Greetings
> > Dominik
> > 
> > Allen Winter  schrieb am Do., 18. Juli 2019, 18:40:
> > > On Thursday, July 18, 2019 12:18:36 PM EDT Volker Krause wrote:
> > > > On Wednesday, 17 July 2019 01:51:42 CEST Aleix Pol wrote:
> > > > > On Tue, Jul 16, 2019 at 6:10 PM Volker Krause  wrote:
> > > > > > On Monday, 15 July 2019 18:43:42 CEST Aleix Pol wrote:
> > > > > > > On Fri, Jul 12, 2019 at 9:03 PM Allen Winter 
> > > 
> > > wrote:
> > > > > > > > On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote:
> > > > > > > > > With the 19.08 release approaching (and thus the deadline for
> > > > > > > > > incompatible
> > > > > > > > > changes if we go ahead with this plan), I'd like to raise this
> > > 
> > > again
> > > 
> > > > > > > > > for
> > > > > > > > > getting to a decision :)
> > > > > > > > > 
> > > > > > > > > Summary of what happened in the past weeks:
> > > > > > > > > - the Person/Attendee slicing issue was fixed by making both
> > > > > > > > > independent
> > > > > > > > > types - several "leaf" types were turned into implicitly
> > > > > > > > > shared
> > > > > > > > > value
> > > > > > > > > types rather than being used heap-allocated inside shared
> > > 
> > > pointers
> > > 
> > > > > > > > > - the dependency on the Akonadi supertrait.h header file was
> > > 
> > > removed
> > > 
> > > > > > > > > - the virtual_hook usage in the incidence de/serialization
> > > 
> > > code was
> > > 
> > > > > > > > > replaced by new virtual methods
> > > > > > > > > 
> > > > > > > > > Unless I missed something, the remaining unaddressed feedback
> > > 
> > > is
> > > 
> > > > > > > > > down
> > > > > > > > > to:
> > > > > > > > > - Rename KCalCore to something else. I'm ok with executing the
> > > > > > > > > rename,
> > > > > > > > > but
> > > > > > > > > somebody needs to tell me the new name :)
> > > > > > > > 
> > > > > > > > I don't remember the reason for changing the name.
> > > > > > > > I vote for not changing the name. KCalCore is as good as any,
> > > > > > > > imo
> > > > > > > > 
> > > > > > > > > - Alexander P's fundamental objections to the current KCalCore
> > > 
> > > API
> > > 
> > > > > > > > > How do we proceed?
> > > > > > > > > 
> > > > > > > > > Thanks,
> > > > > > > > > Volker
> > > > > > > > > 
> > > > > > > > > On Sunday, 7 April 2019 14:45:09 CEST Volker Krause wrote:
> > > > > > > > > > Hi,
> > > > > > > > > > 
> > > > > > > > > > I'd like to propose KCalCore for review to move from KDE PIM
> > > 
> > > to
> > > 
> > > > > > > > > > KF5.
> > > > > > > > > > 
> > > > > > > > > > KCalCore is an implementation of the iCalendar standard
> > > 
> > > based on
> > > 
> > > > > > > > > > libical,
> > > > > > > > > > covering the data model, input/output and the rather complex
> > > > > > > > > > recurrence
> > > > > > > > > > algorithms defined in that standard. It's used outside of
> > > 
> > > KDE PIM
> > > 
> > > > > > > > > > as
> > > > > > > > > > well,
> > > > > > > > > > e.g. by Zanshin or the Plasma Mobile calendar app.
> > > > > > > > > > 
> > > > > > > > > > KCalCore depends on Qt and libical only, making it a Tier 1
> > > > > > > > > > functional
> > > > > > > > > > framework.
> > > > > > > > > > 
> > > > > > > > > > KCalCore used to be part of part of kdepimlibs in the KDE4
> > > 
> > > era, so
> > > 
> > > > > > > > > > it's well prepared for complying with the API and ABI
> > > 
> > > guarantees.
> > > 
> > > > > > > > > > I'd suggest the same timeline as proposed for KContacts [1].
> > > > > > > > > > During
> > > > > > > > > > the PIM
> > > > > > > > > > sprint we did a number of fixes and cleanups as part of the
> > > 
> > > review
> > > 
> > > > > > > > > > for
> > > > > > > > > > KF5
> > > > > > > > > > that make 19.08 the earliest release after which we can
> > > 
> > > switch as
> > > 
> > > > > > > > > > well, so
> > > > > > > 

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  So it's a bug in the android FTP server? Nice ;-)
  
  They should learn from Qt, where QString::toUpper uses the C locale, and one 
has to use QLocale for locale-aware conversion.
  
  Please move the comment about Turkish locale 2 lines down, though, just above 
the uppercase LIST command, since that's what the comment is about.

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks, dfaure
Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

Re: New framework: KCalCore

[David Faure]

On samedi 20 juillet 2019 17:02:40 CEST Alexander Potashev wrote:
> сб, 20 июл. 2019 г. в 13:14, David Faure :
> > I just discussed this with Volker IRL and I found a solution to address my
> > initial concern with the name, the fact that a developer (who's new to all
> > this) seeing "Cal" might not understand this as meaning Calendar.
> > At the same time, KCalendar is unclear (does it display a calendar? is it
> > about calendar systems? etc.). And we already discussed the problem with
> > the other alternatives (a new developer wouldn't understand Incidences,
> > iCal isn't the only format behind all this, etc.)
> > 
> > So I suggested KCalendarCore, and Volker agreed.
> 
> Hi David,
> 
> How about KCalendarFormats?

Sounds like just a repository of formats, which this isn't.

> In my opinion KCalendarCore is bad because it would suggest there must
> be other KCalendar[...] libraries that depend on KCalendarCore, in a
> manner similar to
>  - QtCore <- QtGui,QtQuick and
>  - KIOCore <- KIOWidgets,KIOGui.

The EventViews library (in kdepim) is exactly such a library.
It could be called KCalendarWidgets or KCalendarViews :-)
But even if it's not named like that, that doesn't make the "Core" in 
KCalendarCore wrong at all.

(The todo view is in korganizer itself)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> KDEInstallDirs.cmake:721
> +if(NOT KDE_INSTALL_USE_QT_SYS_PATHS)
> +message(NOTICE "Installing in ${CMAKE_INSTALL_PREFIX}. Run 
> ${CMAKE_CURRENT_BINARY_DIR}/prefix.sh to set the environment for 
> ${CMAKE_PROJECT_NAME}.")
> +endif()

'NOTICE' doesn't exist in CMake < 3.15.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22580

To: apol, #frameworks, albertvaka
Cc: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[Gleb Popov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:6d86fd453417: kioclient: Don't convert `:x:y` to 
`?line=x&column=y` for URLs starting with… (authored by arrowd).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22525?vs=61957&id=62126

REVISION DETAIL
  https://phabricator.kde.org/D22525

AFFECTED FILES
  kioclient/urlinfo.h

To: arrowd, #frameworks, dfaure
Cc: kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: New framework: KCalCore

[Alexander Potashev]

сб, 20 июл. 2019 г. в 13:14, David Faure :
> I just discussed this with Volker IRL and I found a solution to address my
> initial concern with the name, the fact that a developer (who's new to all
> this) seeing "Cal" might not understand this as meaning Calendar.
> At the same time, KCalendar is unclear (does it display a calendar? is it
> about calendar systems? etc.). And we already discussed the problem with the
> other alternatives (a new developer wouldn't understand Incidences, iCal isn't
> the only format behind all this, etc.)
>
> So I suggested KCalendarCore, and Volker agreed.

Hi David,

How about KCalendarFormats?

In my opinion KCalendarCore is bad because it would suggest there must
be other KCalendar[...] libraries that depend on KCalendarCore, in a
manner similar to
 - QtCore <- QtGui,QtQuick and
 - KIOCore <- KIOWidgets,KIOGui.

-- 
Alexander Potashev

D22587: KRun QML proxy: port away from deprecated KRun API

[David Faure]

dfaure created this revision.
dfaure added a reviewer: davidedmundson.
dfaure requested review of this revision.

REVISION SUMMARY
  We want runApplication() instead of runService(), and there's
  already a method doing that in this class --- confusingly named
  openService()

TEST PLAN
  Builds. Not tested.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22587

AFFECTED FILES
  src/qmlcontrols/kioplugin/krunproxy.cpp

To: dfaure, davidedmundson
Cc: #frameworks

D22586: KRun QML proxy: fix path/URL confusion

[David Faure]

dfaure created this revision.
dfaure added a reviewer: davidedmundson.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  I'm assuming the QString argument is always a complete URL.
  The only two users of this code are in extragear/base/plasma-mobile and
  they pass something called url.

TEST PLAN
  Not tested, other than building.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22586

AFFECTED FILES
  src/qmlcontrols/kioplugin/krunproxy.cpp
  src/qmlcontrols/kioplugin/krunproxy.h

To: dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON)

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R300 KDEWebKit

BRANCH
  adddesignerpluginbuild

REVISION DETAIL
  https://phabricator.kde.org/D22581

To: kossebau, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22582: Remove designer plugin generation for KF5WebKit

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  removewebkit

REVISION DETAIL
  https://phabricator.kde.org/D22582

To: kossebau, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default off)

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 62118.
kossebau added a comment.


  Comparing with kdelibs4support, there the designer plugin is always build,
  so defaulting  BUILD_DESIGNERPLUGIN=ON feels more consistent

REPOSITORY
  R300 KDEWebKit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22581?vs=62114&id=62118

BRANCH
  adddesignerpluginbuild

REVISION DETAIL
  https://phabricator.kde.org/D22581

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/designer/kdewebkit.widgets

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON)

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "Add option to build Qt Designer plugin 
(BUILD_DESIGNERPLUGIN, default off)" to "Add option to build Qt Designer plugin 
(BUILD_DESIGNERPLUGIN, default ON)".
kossebau edited the test plan for this revision.

REPOSITORY
  R300 KDEWebKit

REVISION DETAIL
  https://phabricator.kde.org/D22581

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

[NXiss7]

nxiss7 retitled this revision from "Fix can't enter directory error on Android 
FTP servers with Turkish locale" to "Fix can't enter directory error on some 
FTP servers with Turkish locale".

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks
Cc: aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

Re: kdewebkit tarball gone missing?!

[Friedrich W. H. Kossebau]

Am Samstag, 20. Juli 2019, 15:00:45 CEST schrieb Friedrich W. H. Kossebau:
> As immediate solution for kdewebkit though, given it is tier 3, using
> KF5DesignerPlugin as another (optional) dep should be fine though, will see
> to prepare a related patches this WE.

First versions up:
https://phabricator.kde.org/D22581 (adding plugin to kdewebkit)
https://phabricator.kde.org/D22582 (removing from kdesignerplugin)

Cheers
Friedrich

D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default off)

[Friedrich W. H. Kossebau]

kossebau created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Being a "Porting Aids", the KF tier3 kdesignerplugin can no longer
  do the service of providing such a plugin, as this means depending on us.
  So we serve ourselve here for those still using KDEWebKit and preferring
  to have a proper representation when using Qt Designer.

TEST PLAN
  Building with cmake -DBUILD_DESIGNERPLUGIN=ON generates a working plugin,
  which appears in "Views (KDE - Deprecated)" group.
  Still also builds with BUILD_DESIGNERPLUGIN=OFF

REPOSITORY
  R300 KDEWebKit

BRANCH
  adddesignerpluginbuild

REVISION DETAIL
  https://phabricator.kde.org/D22581

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/designer/kdewebkit.widgets

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22582: Remove designer plugin generation for KF5WebKit

[Friedrich W. H. Kossebau]

kossebau created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  KF5WebKit has been tagged as "Porting Aids", so as normal KF tier3
  oroduct kdesignerplugin shall no longer depend on it, even optionally.
  
  KF5WebKit at the same time gets modified to generate a designer plugin
  during its own build, to be enabled with BUILD_DESIGNERPLUGIN=ON cmake flag.

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  removewebkit

REVISION DETAIL
  https://phabricator.kde.org/D22582

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdewebkit.widgets
  src/kdewebkitwidgets.qrc

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22083: introduce concept of header and footer for kpageview

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi Marco, 
  Patch works like a charm in standard config dialogs. 
  As a somewhat off topic remark though, it does not work in kcmultidialog (in 
framework kcmutils), even though it derives from kpageddialog. 
  This shows up for instance in the "window manager settings" you can get from 
the decoration menu (Alt+F3), or simply when running oxygen-setting or 
breeze-settings.
  Looking into kcmultidialog, it seems there is some internal handling of 
margins in there, for a reason unknown to me. Maybe you want to investigate 
there too (in a different patch)
  
  Hugo

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  mart/pageviewfooter

REVISION DETAIL
  https://phabricator.kde.org/D22083

To: mart, #plasma, #frameworks, #vdg, ngraham
Cc: hpereiradacosta, cfeck, ndavis, ngraham, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns

D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:0fb0e618bb0c: Re-map default "Switch input mode" 
shortcut to not confict with konsolepart (authored by ngraham).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22574?vs=62091&id=62113

REVISION DETAIL
  https://phabricator.kde.org/D22574

AFFECTED FILES
  src/view/kateview.cpp

To: ngraham, #kate, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D22419: Fix can't enter directory error on Android FTP servers with Turkish locale

[NXiss7]

nxiss7 retitled this revision from "Fix cant enter directory error on Android 
FTP servers" to "Fix can't enter directory error on Android FTP servers with 
Turkish locale".

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks
Cc: aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

Re: kdewebkit tarball gone missing?!

[Friedrich W. H. Kossebau]

Am Samstag, 20. Juli 2019, 08:19:24 CEST schrieb Volker Krause:
> On Friday, 19 July 2019 16:03:34 CEST Friedrich W. H. Kossebau wrote:
> > Am Freitag, 19. Juli 2019, 09:05:39 CEST schrieb Volker Krause:
> > > Even independent of the dependency rules, webkit support in the 
designer
> > > plugin is a good point to look at.
> > > 
> > > There's three options I see:
> > > (1) remove webkit support from the designer plugin entirely
> > > (2) move webkit support from the designer plugin to a separate plugin
> > > part
> > > of the webkit repo
> > > (3) ignore the problem given it's an optional dependency
> > > 
> > > I'd vote vote for (1) as we obviously don't want to promote usage of 
the
> > > obsolete module, so not offering it in the designer palette anymore
> > > seems
> > > a
> > > step in that direction (and wouldn't break existing code).
> > 
> > IMHO the complete module kdesigner-plugin is a bit broken approach:
> > * being separate from the actual widget code and thus running chance of
> > not
> > getting updated in case widgets get extended/added/deprecated
> > * defeating the idea of independent modules in KDE Frameworks a bit, if
> > you
> > want to have designer support for KItemViews, but pulling in all the 
other
> > widget-providing modules from KDE Frameworks.
> > 
> > IMHO it should be an optional feature to build per widget providing
> > module.
> > And then the plugins should simply become part of the devel packages per
> > module.
> > 
> > I'd be willing to work on (2) to give a sample. And then work on all the
> > other
> 
> Independent of whether we want to keep designer integration for webkit, I
> completely agree with this, same as QML bindings, this should be next to 
the
> module it belongs to.
> 
> Implementation should be straightforward, an example is here https://
> cgit.kde.org/libkdepim.git/tree/src/libkdepim/designer (although the manual
> rpath handling there looks unexpected).

Oh, was not aware KF5DesignerPlugin also provides reuse by other code.

KF5DesignerPlugin comes with a disadvantage though, by adding a build-time 
dependency on it. So would spoil bootstrapping a fresh complete build of KDE 
Frameworks, thus kicking it out of the solution set.

I had been rather thinking to create something purely CMake based, so ECM 
could be used as injection vector, without adding another dep, only bloating 
ECM some more ;) There are other C++-code generating macros already there, so 
would not be a novelty. Personal side goal: make this usable also for the 
Okteta designer plugin, which does some extra needed foo to have some sample 
data to show.

As immediate solution for kdewebkit though, given it is tier 3, using 
KF5DesignerPlugin as another (optional) dep should be fine though, will see 
to prepare a related patches this WE.

Cheers
Friedrich

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Albert Vaca Cintora]

albertvaka accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22580

To: apol, #frameworks, albertvaka
Cc: albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, 
bencreasy, michaelh, ngraham, bruns

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Aleix Pol Gonzalez]

apol marked an inline comment as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22580

To: apol, #frameworks
Cc: albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, 
bencreasy, michaelh, ngraham, bruns

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Aleix Pol Gonzalez]

apol updated this revision to Diff 62110.
apol added a comment.


  Improve wording

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22580?vs=62108&id=62110

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22580

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: apol, #frameworks
Cc: albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, 
bencreasy, michaelh, ngraham, bruns

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Albert Vaca Cintora]

albertvaka added inline comments.

INLINE COMMENTS

> KDEInstallDirs.cmake:721
> +if(NOT KDE_INSTALL_USE_QT_SYS_PATHS)
> +message(NOTICE "Installing in ${CMAKE_INSTALL_PREFIX}, remember set the 
> environment. See ${CMAKE_CURRENT_BINARY_DIR}/prefix.sh")
> +endif()

Installing in `${CMAKE_INSTALL_PREFIX}`. You will need to run `./prefix.sh` to 
set the environment for this app.

?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22580

To: apol, #frameworks
Cc: albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, 
bencreasy, michaelh, ngraham, bruns

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  It's especially when KDE_INSTALL_USE_QT_SYS_PATHS=OFF that the different 
environment variables will have to be initialised.
  This adds a message that should tell users about the script so they have a 
hint of what is going on.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22580

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: apol, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kio_sftp.cpp:1946
>  // check if destination is ok ...
>  QT_STATBUF buff;
> +QFileInfo copyFile(sCopyFile);

Please remove this variable, since you're not calling QT_STAT anymore.

You'll notice that you're still using buff.st_size, which should become 
QFileInfo's size() method instead...

> kio_sftp.cpp:1973
>  }
>  bResume = canResume( buff.st_size );
>  }

Red alert! Red alert! Uninitialized data being used!

> kio_sftp.cpp:2067
>  // check if source is ok ...
>  QT_STATBUF buff;
> +QFileInfo copyFile(sCopyFile);

Same here

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, 
sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  OK, I'm wrong (not the first time this happens) :-)
  
  `kwrite /home/dfaure/.zshrc:20` works
  `kwrite sftp://localhost/home/dfaure/.zshrc:20` doesn't work indeed.
  
  The patch looks fine then.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[David Faure]

dfaure added a subscriber: kwrite-devel.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[Gleb Popov]

arrowd added a comment.


  In D22525#498393 , @dfaure wrote:
  
  > I suppose the kate developers like the fact that this currently works over 
FTP, SFTP, FISH, SMB, etc.
  >  So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries 
have a different meaning, one that we can't know client-side).
  
  
  I'm confused. I just tried SFTP and SMB without the patch and it also doesn't 
work. As I said, it is invalid to rewrite URLs for remote schemas.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: New framework: KCalCore

[David Faure]

Hi everyone,

I just discussed this with Volker IRL and I found a solution to address my 
initial concern with the name, the fact that a developer (who's new to all 
this) seeing "Cal" might not understand this as meaning Calendar.
At the same time, KCalendar is unclear (does it display a calendar? is it 
about calendar systems? etc.). And we already discussed the problem with the 
other alternatives (a new developer wouldn't understand Incidences, iCal isn't 
the only format behind all this, etc.)

So I suggested KCalendarCore, and Volker agreed.

Unless there are strong objections, we'll go with that.

Cheers,
David.

On jeudi 18 juillet 2019 23:24:15 CEST Dominik Haumann wrote:
> To me this sounds as if KCal is the best choice: KCal - a library with iCal
> support. It's short, closest to iCal, and does not clash with calendar
> systems.
> 
> Greetings
> Dominik
> 
> Allen Winter  schrieb am Do., 18. Juli 2019, 18:40:
> > On Thursday, July 18, 2019 12:18:36 PM EDT Volker Krause wrote:
> > > On Wednesday, 17 July 2019 01:51:42 CEST Aleix Pol wrote:
> > > > On Tue, Jul 16, 2019 at 6:10 PM Volker Krause  wrote:
> > > > > On Monday, 15 July 2019 18:43:42 CEST Aleix Pol wrote:
> > > > > > On Fri, Jul 12, 2019 at 9:03 PM Allen Winter 
> > 
> > wrote:
> > > > > > > On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote:
> > > > > > > > With the 19.08 release approaching (and thus the deadline for
> > > > > > > > incompatible
> > > > > > > > changes if we go ahead with this plan), I'd like to raise this
> > 
> > again
> > 
> > > > > > > > for
> > > > > > > > getting to a decision :)
> > > > > > > > 
> > > > > > > > Summary of what happened in the past weeks:
> > > > > > > > - the Person/Attendee slicing issue was fixed by making both
> > > > > > > > independent
> > > > > > > > types - several "leaf" types were turned into implicitly
> > > > > > > > shared
> > > > > > > > value
> > > > > > > > types rather than being used heap-allocated inside shared
> > 
> > pointers
> > 
> > > > > > > > - the dependency on the Akonadi supertrait.h header file was
> > 
> > removed
> > 
> > > > > > > > - the virtual_hook usage in the incidence de/serialization
> > 
> > code was
> > 
> > > > > > > > replaced by new virtual methods
> > > > > > > > 
> > > > > > > > Unless I missed something, the remaining unaddressed feedback
> > 
> > is
> > 
> > > > > > > > down
> > > > > > > > to:
> > > > > > > > - Rename KCalCore to something else. I'm ok with executing the
> > > > > > > > rename,
> > > > > > > > but
> > > > > > > > somebody needs to tell me the new name :)
> > > > > > > 
> > > > > > > I don't remember the reason for changing the name.
> > > > > > > I vote for not changing the name. KCalCore is as good as any,
> > > > > > > imo
> > > > > > > 
> > > > > > > > - Alexander P's fundamental objections to the current KCalCore
> > 
> > API
> > 
> > > > > > > > How do we proceed?
> > > > > > > > 
> > > > > > > > Thanks,
> > > > > > > > Volker
> > > > > > > > 
> > > > > > > > On Sunday, 7 April 2019 14:45:09 CEST Volker Krause wrote:
> > > > > > > > > Hi,
> > > > > > > > > 
> > > > > > > > > I'd like to propose KCalCore for review to move from KDE PIM
> > 
> > to
> > 
> > > > > > > > > KF5.
> > > > > > > > > 
> > > > > > > > > KCalCore is an implementation of the iCalendar standard
> > 
> > based on
> > 
> > > > > > > > > libical,
> > > > > > > > > covering the data model, input/output and the rather complex
> > > > > > > > > recurrence
> > > > > > > > > algorithms defined in that standard. It's used outside of
> > 
> > KDE PIM
> > 
> > > > > > > > > as
> > > > > > > > > well,
> > > > > > > > > e.g. by Zanshin or the Plasma Mobile calendar app.
> > > > > > > > > 
> > > > > > > > > KCalCore depends on Qt and libical only, making it a Tier 1
> > > > > > > > > functional
> > > > > > > > > framework.
> > > > > > > > > 
> > > > > > > > > KCalCore used to be part of part of kdepimlibs in the KDE4
> > 
> > era, so
> > 
> > > > > > > > > it's well prepared for complying with the API and ABI
> > 
> > guarantees.
> > 
> > > > > > > > > I'd suggest the same timeline as proposed for KContacts [1].
> > > > > > > > > During
> > > > > > > > > the PIM
> > > > > > > > > sprint we did a number of fixes and cleanups as part of the
> > 
> > review
> > 
> > > > > > > > > for
> > > > > > > > > KF5
> > > > > > > > > that make 19.08 the earliest release after which we can
> > 
> > switch as
> > 
> > > > > > > > > well, so
> > > > > > > > > we are looking at a switch in Sep/Oct this year.
> > > > > > 
> > > > > > If you don't remember, just scroll up a bit. :P
> > > > > > 
> > > > > > I went through the thread and that's what we said:
> > > > > > - It's a framework to understand the ical format, this is not
> > 
> > conveyed
> > 
> > > > > > by the current name
> > > > > > - The Core postfix doesn't add anything and we are already using
> > > > > > it
> > > > > > for differentiating different framework targets (e.g.
> > 
> > KF5::ConfigCore
> > 
> > > > > >

D17595: Upstream Dolphin's file rename dialog

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> renamefiledialog.cpp:59
> +KFileItemList items;
> +bool allExtensionsDifferent;
> +QSpinBox* spinBox;

group the bools together for less padding

> meven wrote in renamefiledialog.cpp:60
> I really wish we would enforce use of a code formater, community wise ...
> This is something I miss from rust:  `cargo fmt`
> Such as astyle.

Just run `uncrustify-kf5` from the repo kde-dev-scripts.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I suppose the kate developers like the fact that this currently works over 
FTP, SFTP, FISH, SMB, etc.
  So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries 
have a different meaning, one that we can't know client-side).

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22577: Remove unused pnm.desktop file

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D22577

To: rempt, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22577: Remove unused pnm.desktop file

[Boudewijn Rempt]

rempt created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rempt requested review of this revision.

REVISION SUMMARY
  Looks like this file isn't used, so let's remove it.

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D22577

AFFECTED FILES
  src/imageformats/pnm.desktop

To: rempt
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22551: expose new KBusyIndicatorWidget

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22551

To: sitter, alexmerry, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:7b9cb48d95e4: Get mobipocket extractor up-to-date, but 
keep disabled (authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17500?vs=61690&id=62098#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17500?vs=61690&id=62098

REVISION DETAIL
  https://phabricator.kde.org/D17500

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/extractorcoveragetest.cpp
  autotests/mobiextractortest.cpp
  autotests/samplefiles/test.mobi
  src/extractors/CMakeLists.txt
  src/extractors/mobiextractor.cpp

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, LeGast00n, 
sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D21002: Remove kde4 migration agent completely

[Luca Beltrame]

lbeltrame closed this revision.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D21002

To: bruns, #frameworks, cfeck, ngraham, aacid
Cc: siddharthasahu, aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n, 
sbergeron, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

[Luca Beltrame]

lbeltrame added a comment.


  Should be fixed with ff6b077d9200856dc6e393a04c6b3ae82d9792ed 
.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D21002

To: bruns, #frameworks, cfeck, ngraham, aacid
Cc: siddharthasahu, aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n, 
sbergeron, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

[Luca Beltrame]

lbeltrame reopened this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  This breaks GPG wallets completely. They are no longer accounted for by 
kwalletd: reverting this change makes them work again.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D21002

To: bruns, #frameworks, cfeck, ngraham, aacid
Cc: siddharthasahu, aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n, 
sbergeron, michaelh, ngraham, bruns