D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Nice work! I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right

D22105: Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 retitled this revision from "WIP : Fix SFTP Plugin of KIO for Windows" to "Fix SFTP Plugin of KIO for Windows". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 marked 2 inline comments as done. brute4s99 added a comment. I'll not leave it like this from next time, that's for sure. :p REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino,

D22105: Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 added a comment. :p REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread David Faure
dfaure added a comment. Indeed. I assumed it wasn't in your actual commit log (bad idea, for this exact reason). Phabricator often shows outdated descriptions compared to the commit log (unless people use `arc diff --verbatim`) so I stopped complaining about the description Clearly I

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
This revision was automatically updated to reflect the committed changes. Closed by commit R320:d6d724b9d4b9: WIP : Fix SFTP Plugin of KIO for Windows (authored by brute4s99). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=62254=62255 REVISION

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 added a comment. should've removed WIP before landing  REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 added a comment. yeah I can push! I'm a GSoCer lol REPOSITORY R320 KIO Extras BRANCH arcpatch-D22105 REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks for your persistence :-) Do you have commit access? Otherwise can I have your name and email, for the git author information? REPOSITORY R320 KIO Extras BRANCH

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 62254. brute4s99 marked an inline comment as done. brute4s99 added a comment. updated! REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=62237=62254 BRANCH arcpatch-D22105 REVISION DETAIL

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:2028 > } > -else if (QT_STAT( QFile::encodeName(sPart), ) == 0) { // > should a very small ".part" be deleted? > +else

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread Nathaniel Graham
ngraham added a reviewer: ndavis. ngraham added a comment. The 16px version is used in menus. The 22px version is used in toolbar buttons. 24px is unnecessary; it's only used by some 3rd-party apps I think. The ones that are already in there at that size are legacy and maybe we should just

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Nathaniel Graham
ngraham added a comment. +1 for adding both a fixed-width spacer as well as an expanding spacer. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst, dfaure Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron,

D20078: RFC fix race on kcrash auto-restarts

2019-07-21 Thread David Edmundson
davidedmundson added a comment. ++ Needs some cleanup, but the logic is all sound. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D20078 To: sitter Cc: davidedmundson, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-07-21 Thread David Faure
dfaure added a comment. In D14631#499600 , @emateli wrote: > More or less but they don't have to be in the same directory. Think of it as a sequence of `KIO::moveAs` operations. Any N files can be moved anywhere. Right. >> I could

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 62237. brute4s99 marked 3 inline comments as done. brute4s99 added a comment. updated REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=62187=62237 BRANCH arcpatch-D22105 REVISION DETAIL

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-07-21 Thread Emirald Mateli
emateli added a comment. In D14631#499038 , @dfaure wrote: > KIO::move (implemented by CopyJob) can move N files to a single destination directory, but they get the same name at that dest. > KIO::moveAs (implemented by CopyJob too) can

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 6 - Fixed!

2019-07-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/6/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 21 Jul 2019 18:52:26 + Build duration: 4 min 14 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Unstable!

2019-07-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/5/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 21 Jul 2019 18:52:26 + Build duration: 1 min 51 sec and counting JUnit Tests Name:

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 added inline comments. INLINE COMMENTS > dfaure wrote in kio_sftp.cpp:2257 > This is marked as Done, but it's not Done. In fact it matches my own > suggestion above, so I agree with Albert ;-) so sorry, it seems I updated a previous version of the diff. REPOSITORY R320 KIO Extras

D22620: Add function to suggest a unique filename

2019-07-21 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R244:03b9bdee4f52: Add function to suggest a unique filename (authored by nicolasfella). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22620?vs=6=62223

D22620: Add function to suggest a unique filename

2019-07-21 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH suggestname REVISION DETAIL https://phabricator.kde.org/D22620 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22620: Add function to suggest a unique filename

2019-07-21 Thread Nicolas Fella
nicolasfella updated this revision to Diff 6. nicolasfella added a comment. - Don't steal David's copyright - Remove TODO REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22620?vs=62218=6 BRANCH suggestname REVISION DETAIL

D22620: Add function to suggest a unique filename

2019-07-21 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileutilstest.cpp:2 > +/* This file is part of the KDE libraries > +Copyright (c) 2019 Nicolas Fella > + Liar :-) I wrote the first version of this

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Almost there :-) INLINE COMMENTS > kio_sftp.cpp:406 > +#ifdef Q_OS_WIN > +// TODO Check if this works for other OSes too. > +fileType = QT_STAT_LNK; Yes,

D22620: Add function to suggest a unique filename

2019-07-21 Thread Nicolas Fella
nicolasfella updated this revision to Diff 62218. nicolasfella added a comment. - Add test REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22620?vs=62215=62218 BRANCH suggestname REVISION DETAIL https://phabricator.kde.org/D22620 AFFECTED FILES

D22620: Add function to suggest a unique filename

2019-07-21 Thread Nicolas Fella
nicolasfella edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D22620 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22620: Add function to suggest a unique filename

2019-07-21 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please "move" (copy) the autotest as well, see kio/autotests/globaltest.cpp Typo in the commit log: s/it's/its/ REPOSITORY R244 KCoreAddons REVISION DETAIL

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread David Faure
dfaure added a comment. Ah yeah, about the name, I expected a fixed-width spacer until I saw the video. And maybe someone wants to provide that as well... so "Expanding spacer" would actually make sense for this feature. Or maybe you even want to provide both right away, while at it...

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. A video showing the feature, in the merge request! I'm blown away! Code looks fine. INLINE COMMENTS > kxmlguibuilder.cpp:349 > +} else if (tagName == d->tagSpacer) { > +if

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2019-07-21 Thread Jaime Torres Amate
jtamate closed this revision. jtamate added a comment. In D10742#499346 , @aacid wrote: > @jtamate Does that "let's continue in that other review" mean we should cancel this one? Still shows on the list of reviews to consider Yes, it

D22620: Add function to suggest a unique filename

2019-07-21 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This is a copy of KIO::suggestName. It doesn't use anything from KIO

D22618: remove dangling remote widgets code

2019-07-21 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY can't be enabled anywhere + not actually doing anything as there is no backing for it

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread David Hurka
davidhurka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread David Hurka
davidhurka added a subscriber: Okular. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D19005: android: don't default to gcc anymore

2019-07-21 Thread Albert Astals Cid
aacid closed this revision. aacid added a comment. Talked with Aleix, we're deciding to drop this for the moment REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19005 To: apol, #frameworks, vkrause Cc: aacid, kde-frameworks-devel, kde-buildsystem,

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread David Hurka
davidhurka added a comment. I’m not sure whether I did everything correctly. If I did, this is too complicated. The guidelines in the community wiki and the HIG are missing:

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread David Hurka
davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This is my try to add the icons I requested in D21196#484674

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2019-07-21 Thread Albert Astals Cid
aacid added a comment. @jtamate Does that "let's continue in that other review" mean we should cancel this one? Still shows on the list of reviews to consider REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10742 To: jtamate, #frameworks, dfaure Cc: aacid,

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Nathaniel Graham
ngraham added a comment. Also, I would recommend doing most of the comment changes in a separate patch. They are good and useful, but not related to adding this awesome new spacer item. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc:

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Nathaniel Graham
ngraham added a comment. +100! How about naming it "Flexible space" or "Expanding spacer" to make it a bit clearer? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron,

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Nathaniel Graham
ngraham added subscribers: Frameworks, dfaure, VDG. Herald removed a subscriber: Frameworks. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: kbuildsycoca global in a modern world

2019-07-21 Thread David Faure
On mardi 16 juillet 2019 13:08:02 CEST Harald Sitter wrote: > I was wondering if kbuildsycoca's global code still has a reason to exist. I wondered the same when I redesigned most of ksycoca some time ago, and I chose to keep the feature. The thinking is the following: imagine a kiosk-mode device

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

2019-07-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 21 Jul 2019 15:01:05 + Build duration: 1 min 50 sec and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 16 - Still Unstable!

2019-07-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/16/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 21 Jul 2019 14:12:05 + Build duration: 20 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 139 - Still Unstable!

2019-07-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/139/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 21 Jul 2019 14:12:05 + Build duration: 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.12 - Build # 31 - Fixed!

2019-07-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.12/31/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 21 Jul 2019 14:10:00 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.13 - Build # 5 - Fixed!

2019-07-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.13/5/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 21 Jul 2019 14:10:00 + Build duration: 7 min 43 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

2019-07-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 21 Jul 2019 14:12:05 + Build duration: 4 min 49 sec and counting JUnit Tests

KDE CI: Frameworks » bluez-qt » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Fixed!

2019-07-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 21 Jul 2019 14:10:00 + Build duration: 2 min 37 sec and counting JUnit Tests Name:

D22611: Remove deprecated tests

2019-07-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:0e14ab6eca26: Remove deprecated tests (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22611?vs=62191=62192

D22611: Remove deprecated tests

2019-07-21 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22611 To: davidedmundson, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

D22611: Remove deprecated tests

2019-07-21 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Plasma::KPackage is deprecated in favour of KPackage. There

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Felix Ernst
felixernst edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Felix Ernst
felixernst updated this revision to Diff 62188. felixernst added a comment. Use insertWidget(before, spacer) instead of addWidget(spacer) REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22609?vs=62185=62188 BRANCH master REVISION DETAIL

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 62187. brute4s99 added a comment. updated REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=62159=62187 BRANCH arcpatch-D22105 REVISION DETAIL https://phabricator.kde.org/D22105 AFFECTED FILES

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 marked 6 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas,

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Felix Ernst
felixernst planned changes to this revision. felixernst added a comment. Need to fix wrong return type in KXMLGUIBuilder::createCustomElement REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: kde-frameworks-devel, LeGast00n, sbergeron,

D22599: Make first and last name available separately

2019-07-21 Thread Aleix Pol Gonzalez
apol added a comment. In D22599#499008 , @pino wrote: > How would first + last name work, when > a) you have multiple first names > b) you have multiple last names > c) you have only one "name" -- http://wookware.org/name.html As

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Felix Ernst
felixernst edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Felix Ernst
felixernst edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Felix Ernst
felixernst edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22609 To: felixernst Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22609: Add spacers as a customization option for toolbars

2019-07-21 Thread Felix Ernst
felixernst created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. felixernst requested review of this revision. REVISION SUMMARY This commit adds spacers to the kxmlgui framework so all applications using it will be able to use any amount

Qt dependency policy

2019-07-21 Thread David Faure
Taking into account the feedback from the SUSE packagers (about how dropping support for Qt 5.9 LTS the very month Qt 5.12 LTS comes out is a problem since not everyone can upgrade to Qt 5.12 LTS right away) I have modified the policy to temporarily support 4 versions when the oldest (and

D22599: Make first and last name available separately

2019-07-21 Thread Jonah Brüchert
jbbgameich added a comment. In case a, all first names would probably be in a string separated by spaces, same for multiple last names. In case c, I guess only the last name would be set maybe. I have been only working with the KContacts based vcard backend, where givenName and

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:266 > > -qCDebug(KIO_SFTP_LOG) << "name=" << name << " instruction=" << > instruction << " prompts=" << n; > +qDebug() <<

D21795: [KAuth] Add support for action details in Polkit1 backend.

2019-07-21 Thread Harald Sitter
sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. The way details are enumerated needs changing IMO. And this effectively bumps the required polkitqt version through exactly one call, so maybe an #if conditional to not have the

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Piyush Aggarwal
brute4s99 added inline comments. INLINE COMMENTS > pino wrote in kio_sftp.cpp:2050-2051 > what is this commented code for? it uses buff.st_atime . Since I'm removing use of buff, I'm not sure how to handle this. For now I've commented out setting the file access time instruction for now.

D22606: add missing semicolon

2019-07-21 Thread Pino Toscano
pino added a comment. Patch landed, and build successfully everywhere. Congratulations for your first patch :) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D22606 To: antonioh, pino Cc: pino, kde-frameworks-devel, #baloo, LeGast00n, sbergeron,

D22606: add missing semicolon

2019-07-21 Thread Pino Toscano
pino closed this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D22606 To: antonioh, pino Cc: pino, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22606: add missing semicolon

2019-07-21 Thread Antonio Huete Jimenez
antonioh added a comment. No, I don't have permissions to push that I know of, here are my details: Antonio Huete Jimenez REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D22606 To: antonioh, pino Cc: pino, kde-frameworks-devel, #baloo, LeGast00n, sbergeron,

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-07-21 Thread David Faure
dfaure added a comment. KIO::move (implemented by CopyJob) can move N files to a single destination directory, but they get the same name at that dest. KIO::moveAs (implemented by CopyJob too) can move/rename a single file to a specific filename at destination. What you're suggesting

D22606: add missing semicolon

2019-07-21 Thread Pino Toscano
pino accepted this revision. pino added a comment. This revision is now accepted and ready to land. Do you have permissions to push patches on your own? If not, please specify your email so I can properly attribute this patch to you. REPOSITORY R286 KFileMetaData REVISION DETAIL

D22606: add missing semicolon

2019-07-21 Thread Antonio Huete Jimenez
antonioh created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. antonioh requested review of this revision. REVISION SUMMARY There was a missing semicolon in the non xattr case REPOSITORY R286 KFileMetaData REVISION DETAIL

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

2019-07-21 Thread Christophe Giboudeaux
cgiboudeaux added a comment. Thinking again: KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS. Running prefix.sh is useful even if KDE_INSTALL_USE_QT_SYS_PATHS is true. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D22599: Make first and last name available separately

2019-07-21 Thread Pino Toscano
pino added a comment. How would first + last name work, when a) you have multiple first names b) you have multiple last names c) you have only one "name" -- http://wookware.org/name.html REPOSITORY R307 KPeople BRANCH master REVISION DETAIL https://phabricator.kde.org/D22599

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-07-21 Thread Emirald Mateli
emateli added a comment. Before continuing work I'd like to hear some opinions on this. 1. From @dfaure or other people at frameworks: How do we handle batch rejame jobs. Should I create a new patch to submit a basic batch move job that simply moves files around without any additional

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

2019-07-21 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22580 To: apol, #frameworks, albertvaka, cgiboudeaux Cc: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy,

D22599: Make first and last name available separately

2019-07-21 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH master REVISION DETAIL https://phabricator.kde.org/D22599 To: jbbgameich, #plasma:_mobile, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

2019-07-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 21 Jul 2019 08:36:37 + Build duration: 29 min and counting JUnit Tests Name: projectroot

D22586: KRun QML proxy: fix path/URL confusion

2019-07-21 Thread Aleix Pol Gonzalez
apol added a comment. In D22586#498715 , @dfaure wrote: > You'd think I would remember my own APIs :-) ;-) REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22586 To: dfaure, davidedmundson Cc: apol,

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

2019-07-21 Thread Aleix Pol Gonzalez
apol marked an inline comment as done. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22580 To: apol, #frameworks, albertvaka Cc: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh,

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

2019-07-21 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 62169. apol added a comment. Support older cmakes REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22580?vs=62110=62169 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22580 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 145 - Fixed!

2019-07-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/145/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 21 Jul 2019 08:36:38 + Build duration: 20 min and counting BUILD ARTIFACTS

D19903: Fix build with msvc

2019-07-21 Thread Albert Astals Cid
aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. yep, having it build with gcc is important :) REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19903 To: vonreth, mlaurent, davidedmundson,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 13 - Unstable!

2019-07-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/13/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 21 Jul 2019 08:36:38 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Unstable!

2019-07-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 21 Jul 2019 08:10:07 + Build duration: 38 min and counting JUnit Tests Name:

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > kio_sftp.cpp:2047 > +QString error_msg = receivedFile.errorString(); > +qDebug() << QStringLiteral("Couldn't update modified > time : ") << error_msg; > +} no need for QStringLiteral here,

D22419: Fix can't enter directory error on some FTP servers with Turkish locale

2019-07-21 Thread Albert Astals Cid
aacid closed this revision. REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks, dfaure Cc: dfaure, aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-07-21 Thread Hannah von Reth
vonreth added a comment. Please revert the changes to qCDebug REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 15 - Still Unstable!

2019-07-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/15/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 21 Jul 2019 08:10:08 + Build duration: 5 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 138 - Still Unstable!

2019-07-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/138/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 21 Jul 2019 08:10:07 + Build duration: 5 min 49 sec and counting BUILD ARTIFACTS

D18114: FakeInput: add support for pointer move with absolute coordinates

2019-07-21 Thread Jan Grulich
jgrulich added a comment. In D18114#498642 , @romangg wrote: > @jgrulich With D22571 looking promising do you want to put the keyboard parts of this diff into a separate one? There is still the question