D22717: Add Date term to KActivities Stats to filter on resource event date

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22723: Fix RunnerManager::queryFinished()

apol added a comment. > If you don't like it I won't object landing this internal class, but please add a long comment explaining why it was done like this. QObjects live in their own thread and shouldn't be used outside. https://doc.qt.io/qt-5/qobject.html#thread In your patch we

D22768: Forward declare KLocalizedString and make I18n a private dependency.

daandemeyer created this revision. daandemeyer added a reviewer: Frameworks. daandemeyer added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. daandemeyer requested review of this revision. REVISION SUMMARY When refactoring Kate's CMake scripts, I was looking into why a

D22765: Docs: fix bad example code

This revision was automatically updated to reflect the committed changes. Closed by commit R296:2d39e2f0ad56: Docs: fix bad example code (authored by adridg). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22765?vs=62614=62623 REVISION DETAIL

D22698: Support passing target to ki18n_wrap_ui macro

daandemeyer added a comment. OK, thanks for the information. I'm still getting familiar with this whole process. REVISION DETAIL https://phabricator.kde.org/D22698 To: daandemeyer, ilic Cc: ltoscano, alexmerry, turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

D22698: Support passing target to ki18n_wrap_ui macro

ltoscano added a comment. In D22698#502791 , @daandemeyer wrote: > @alexmerry I think I added the wrong reviewer for this. I noticed your name in the git blame of `k18n_wrap_ui`, perhaps you know who I should add as a reviewer for ki18n

D22733: Delete redundant and monochrome versions of applications-internet

This revision was automatically updated to reflect the committed changes. Closed by commit R266:30e216eb71f1: Delete redundant and monochrome versions of applications-internet (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D22733: Delete redundant and monochrome versions of applications-internet

ngraham added a comment. All right, everything's been fixed. A goodly number of the users in that list were already using it appropriately for large colorful icons, so I didn't touch those. REPOSITORY R266 Breeze Icons BRANCH only-colorful-applications-intetnet-icon (branched from

D22698: Support passing target to ki18n_wrap_ui macro

daandemeyer added a subscriber: alexmerry. daandemeyer added a comment. @alexmerry I think I added the wrong reviewer for this. I noticed your name in the git blame of `k18n_wrap_ui`, perhaps you know who I should add as a reviewer for ki18n revisions? REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/15/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 26 Jul 2019 18:59:11 + Build duration: 7 min 2 sec and counting JUnit Tests Name:

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. Please do a last minute review, I believe this patch is ready to merge now.  REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel,

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.11 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.11/50/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 26 Jul 2019 17:55:05 + Build duration: 5 min 37 sec and counting JUnit Tests

D22715: Save and load page margins

cullmann added a comment. Should we add the printer name to the settings keys? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22715 To: hoffmannrobert, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, sbergeron, domson,

D22724: [WIP] Add ECMAddQtDesignerPlugin

kossebau updated this revision to Diff 62618. kossebau added a comment. - API DOX: explain arguments - add argument to make it work for Okteta's extra code - avoid rebuilding if generated file did not change - place generated files in subdir for namespacing REPOSITORY R240 Extra CMake

D22715: Save and load page margins

dhaumann added a comment. Btw, I recently wrote a mail to John Layt with the following content. The linked bug may be closed with this change: Hi John, quick question to the QPrinter: We still have issues in Kate (and other KDE apps I assume), that the margins of the QPrintDialog

D22763: [KDirOperator] Use more human-readable sort order descriptions

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO BRANCH arcpatch-D22763 REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicolasfella Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22763: [KDirOperator] Use more human-readable sort order descriptions

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yes, it does work in Gwenview. How odd. Anyway, not an issue with your patch, for sure. Patch LGTM! REPOSITORY R241 KIO BRANCH arcpatch-D22763 REVISION DETAIL

D22715: Save and load page margins

dhaumann added a comment. Since the former patch was originally from me: I agree to accept it, but it has it's drawbacks: if you have multiple printers, having different margins is not possible, since this is not saved per printer. REPOSITORY R39 KTextEditor REVISION DETAIL

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven added a comment. In D22763#502738 , @ngraham wrote: > I tried this out but I'm not actually seeing the menu items in the open/save dialogs change at all. :/ Have you tried with gwenview ? For some reason, it does not work in kate

D22765: Docs: fix bad example code

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH fix-apidocs REVISION DETAIL https://phabricator.kde.org/D22765 To: adridg, davidedmundson Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 26 Jul 2019 15:28:26 + Build duration: 7 min 16 sec and counting JUnit Tests Name:

D22763: [KDirOperator] Use more human-readable sort order descriptions

ngraham added a comment. I tried this out but I'm not actually seeing the menu items in the open/save dialogs change at all. :/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicolasfella Cc: kde-frameworks-devel, LeGast00n,

D22764: Stabilize test KFileWidgetTest::testDropFile

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bbe3e6edfd63: Stabilize test KFileWidgetTest::testDropFile (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22764?vs=62610=62615 REVISION DETAIL

D22764: Stabilize test KFileWidgetTest::testDropFile

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Excellent, thanks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D22764 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n,

D22765: Docs: fix bad example code

adridg created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY - setupBindings() doesn't take an engine parameter - setupBindings() is deprecated and suggests to call setupContext()

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicolasfella Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven added inline comments. INLINE COMMENTS > nicolasfella wrote in kdiroperator.cpp:1979 > Remove commented code Thanks ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicolasfella Cc: kde-frameworks-devel, LeGast00n,

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven updated this revision to Diff 62612. meven marked an inline comment as done. meven added a comment. Small formatting correction REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22763?vs=62611=62612 BRANCH arcpatch-D22763 REVISION DETAIL

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven updated this revision to Diff 62611. meven added a comment. Remove dead commented code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22763?vs=62609=62611 BRANCH arcpatch-D22763 REVISION DETAIL https://phabricator.kde.org/D22763 AFFECTED FILES

D22763: [KDirOperator] Use more human-readable sort order descriptions

nicolasfella added a comment. Code looks sensible, haven't tried it yet INLINE COMMENTS > kdiroperator.cpp:1979 > > +/* > KToggleAction *descendingAction = new KToggleAction(i18n("Descending"), > this); > d->actionCollection->addAction(QStringLiteral("descending"), >

D22764: Stabilize test KFileWidgetTest::testDropFile

meven added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22764 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22764: Stabilize test KFileWidgetTest::testDropFile

meven created this revision. meven added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The test introduced in D20838 was not completely

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicolasfella Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven created this revision. meven added reviewers: ngraham, Frameworks, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Inspired by D22006 TEST

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7069d6f0cb3d: Add view-pages-* icons, as needed in Okular for page layout selection (authored by davidhurka, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ngraham added a comment. Thanks very much! So now we can expect to see an Okular patch, right? :) REPOSITORY R266 Breeze Icons BRANCH add-icons-for-pagelayouts REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis, ngraham Cc: #okular, kde-frameworks-devel,

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks ready to land! In D22617#502629 , @davidhurka wrote: > - Add missing .ColorScheme-Text { to 24px versions of snap-page.svg > >

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka updated this revision to Diff 62603. davidhurka added a comment. - Add missing .ColorScheme-Text { to 24px versions of snap-page.svg And then the class name was missing, together with the opening brace: `.ColorScheme-Text {`. This is not a comfortable workflow... Would it

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka marked 2 inline comments as done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis, ngraham Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka updated this revision to Diff 62602. davidhurka added a comment. - Add missing id=currentColorScheme to 24px versions of snap-page These snap-page.svg files weren’t in 16px nor 22px, so I forgot them when I replaced `type="text/css"` with `type="text/css"

D22587: KRun QML proxy: port away from deprecated KRun API

davidedmundson accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D22587 To: dfaure, davidedmundson Cc: #frameworks

D22587: KRun QML proxy: port away from deprecated KRun API

dfaure added a comment. @davidedmundson ping? REVISION DETAIL https://phabricator.kde.org/D22587 To: dfaure, davidedmundson Cc: #frameworks

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/6/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 26 Jul 2019 09:55:14 + Build duration: 7 min 46 sec and counting BUILD ARTIFACTS

D22755: [platforms/xcb] Use XRES extension to get real window PID

This revision was automatically updated to reflect the committed changes. Closed by commit R278:b485043e5633: [platforms/xcb] Use XRES extension to get real window PID (authored by davidedmundson). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D22755: [platforms/xcb] Use XRES extension to get real window PID

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D22755 To: davidedmundson, zzag Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

davidedmundson marked 2 inline comments as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D22755 To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

davidedmundson updated this revision to Diff 62588. davidedmundson edited the summary of this revision. davidedmundson removed a subscriber: zzag. davidedmundson added a comment. update REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/39/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 26 Jul 2019 09:24:20 + Build duration: 3 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/11/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 26 Jul 2019 09:22:07 + Build duration: 3 min 25 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 38 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/38/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 26 Jul 2019 09:17:03 + Build duration: 7 min 15 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 26 Jul 2019 09:19:05 + Build duration: 2 min 35 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 26 Jul 2019 09:17:03 + Build duration: 1 min 58 sec and counting JUnit Tests Name:

D22687: KService: remove broken concept of global sycoca database

dfaure closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D22687 To: dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22759: Fix infinite recursion when using a dummy DB because ksycoca is inaccessible

dfaure closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D22759 To: dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

zzag added a comment. > Querying the NET_WM_ATOM with the NETWM classes remains unchanged _NET_WM_PID? INLINE COMMENTS > kwindowinfo.cpp:85 > +specs.mask = XCB_RES_CLIENT_ID_MASK_LOCAL_CLIENT_PID; > +auto cookie = xcb_res_query_client_ids(QX11Info::connection(), 1, > );

D22687: KService: remove broken concept of global sycoca database

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Ohh that makes sense. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22687 To: dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, sbergeron,

D22759: Fix infinite recursion when using a dummy DB because ksycoca is inaccessible

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22759 To: dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D19784: Avoid calling QT_LSTAT and accessing recent documents

meven added a comment. Since this patch icons for folders in recent documents have been replaced with the application-octet-stream icon. SkipMimeTypeFromContent should be avoided for local directories. We need a better way to detect if the folder is a network folder before making

D22687: KService: remove broken concept of global sycoca database

dfaure added a comment. Wow, good catch, thanks for being the pre-commit CI ! ;-) Amazingly, it's not because this commit introduces a regression. It's because the removed unittest method changes what sees the next test method. It used to delete the local sycoca file, which the next

D22759: Fix infinite recursion when using a dummy DB because ksycoca is inaccessible

dfaure created this revision. dfaure added a reviewer: sitter. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY The unittest for this will be in the next commit

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 26 Jul 2019 07:57:56 + Build duration: 1 min 35 sec and counting JUnit Tests Name:

D22723: Fix RunnerManager::queryFinished()

fvogt added a comment. In D22723#502365 , @aacid wrote: > I honestly don't see the problem with this patch, one may argue that the ThreadWeaver API is awkward, ok, but this is using it correctly AFAICS, i.e. have a

D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

fvogt created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Currently KRunner uses QObjectDecorator wrongly and changing the design to fix that would not only be a lot of work, but

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven added a comment. In D22143#502336 , @kossebau wrote: > In D22143#502314 , @meven wrote: > > > > Relying on undocumented names of generated sources files does not get my +1. That needs