KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/16/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 01 Aug 2019 02:54:24 + Build duration: 4 min 24 sec and counting BUILD ARTIFACTS acc/KF5Purpose-

D22868: Revamp Kirigami.AboutPage

hein updated this revision to Diff 62883. hein added a comment. Don't hit Kirigami.Label (deprecated) REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22868?vs=62880&id=62883 BRANCH aboutpage REVISION DETAIL https://phabricator.kde.org/D22868 AFFECTED

D22868: Revamp Kirigami.AboutPage

hein added a reviewer: leinir. REPOSITORY R169 Kirigami BRANCH aboutpage REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D22868: Revamp Kirigami.AboutPage

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Super duper better now. REPOSITORY R169 Kirigami BRANCH aboutpage REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham Cc: ngraham,

D22868: Revamp Kirigami.AboutPage

hein added a comment. Discover: F7130049: Screenshot_20190801_100601.png Material style: F7130053: Screenshot_20190801_100645.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde

D22868: Revamp Kirigami.AboutPage

hein added a comment. Before: F7130036: Screenshot_20190801_15.png After: F7130037: Screenshot_20190801_100033.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868

D22868: Revamp Kirigami.AboutPage

hein created this revision. hein added reviewers: Frameworks, VDG, mart, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY - Use a FormLayout to work nicely in both portrait and landscape orientations - Don

D22609: Add expanding spacers as a customization option for toolbars

ngraham accepted this revision. ngraham added a comment. I think we should make everything uppercase, and if the separators need visual differentiation, making them lowercase is kind of a hack. **However**, that change would need to be made in a separate patch because it affects more tha

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

hein created this revision. hein added reviewers: Frameworks, mart. Herald added a project: Kirigami. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22867 AFFECTED FILES src/controls/private/GlobalDrawerActionI

D22865: remove drawing a black line segment at the end of the plot

miklosm created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. miklosm requested review of this revision. REVISION SUMMARY I have no idea what the purpose of this code was. It was added in 6117a42bee54a456

D22864: use zero-based coordinate system on the plot

miklosm created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. miklosm requested review of this revision. REVISION SUMMARY This patch also supports negative values, but the plot drawing code can't properly handle them. REPOSITORY R296 KDec

D22859: Add Q_PROPERTIES interface to KDescendantsProxyModel

kossebau added inline comments. INLINE COMMENTS > kdescendantsproxymodel.h:75 > > +Q_PROPERTY(QAbstractItemModel *model READ sourceModel WRITE > setSourceModel NOTIFY sourceModelChanged) > +Q_PROPERTY(bool displayAncestorData READ displayAncestorData WRITE > setDisplayAncestorData NOT

D22822: Add "users-other" icon

ndavis added a comment. I'll review this when I'm back from my vacation. I don't have my laptop with me. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22822 To: GB_2, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22859: Add Q_PROPERTIES interface to KDescendantsProxyModel

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D22859 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22862: [server] Wrap proxyRemoveSurface in smart pointer

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D22862 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22862: [server] Wrap proxyRemoveSurface in smart pointer

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY proxyRemoteSurface is a fake wayland surface created for the drag a

D22822: Add "users-other" icon

filipf added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22822 To: GB_2, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22860: introduce FallbackTapHandler

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY This element is intended to be used as "click on empty areas to dismiss" use case. a MouseA

D22855: Make "edit-none" a symlink to "dialog-cancel"

This revision was automatically updated to reflect the committed changes. Closed by commit R266:2513b6c6f0c2: Make "edit-none" a symlink to "dialog-cancel" (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22855?vs=62853&id=62867 REVISIO

D22848: Rust: add missing keywords and minor improvements

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I trust this is a good improvement. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D22848 To: nibags, #framework_syntax_highlighti

D22855: Make "edit-none" a symlink to "dialog-cancel"

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH make-edit-none-symlink-to-dialog-cancel (branched from master) REVISION DETAIL https://phabricator.kde.org/D22855 To: GB_2, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGa

D22859: Add Q_PROPERTIES interface to KDescendantsProxyModel

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY For eventual use in a KItemModels QML plugin TEST PLAN Compliles. Used it in a QML project (exported

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

davidedmundson added a comment. > Do we need appletInterface.loading to be false while the wallpaper is still loading? I think so. Most properties map 1:1 with what was explicitly set. Without that we don't have an accessor for the containment QML code to find out what it has set it

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/41/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 31 Jul 2019 14:07:41 + Build duration: 8 min 33 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/13/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 31 Jul 2019 14:07:41 + Build duration: 7 min 49 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 31 Jul 2019 14:07:41 + Build duration: 1 min 47 sec and counting JUnit Tests Name: proje

D22570: Expose X-KDE-Wayland-Interfaces

This revision was automatically updated to reflect the committed changes. Closed by commit R309:9c3ed5f40e63: Expose X-KDE-Wayland-Interfaces (authored by apol). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22570?vs=62084&id=62854 REVISION DETAIL https:/

D22855: Make "edit-none" a symlink to "dialog-cancel"

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22855 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22855: Make "edit-none" a symlink to "dialog-cancel"

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY A "disable" icon better represents "none" and then we don't have two cross icons with different c

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

apol added a comment. In D22852#504668 , @davidedmundson wrote: > > Will it? isLoading returns m_loading anyway... > > it's virtual, the ContainmentInterface::isLoading does not return that. It does, including the wallpaper, which is

D22723: Fix RunnerManager::queryFinished()

apol updated this revision to Diff 62851. apol added a comment. Hopefully make it more understandable by having the job run from a lambda rather than subclassing a whole new object REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22723?vs=62491&id=62851 BRA

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62850. leinir added a comment. - Parent the QuickQuestionAsker to qApp - Add in a QuestionAsker on NewStuffList REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62846&id=62850 BRANCH knsquick-feature-parity

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

davidedmundson updated this revision to Diff 62848. davidedmundson added a comment. Fixup REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22852?vs=62842&id=62848 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22852 AFFEC

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62846. leinir added a comment. - Fix up the NewStuffItem installer busy indicator a bit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62844&id=62846 BRANCH knsquick-feature-parity-with-kns (branched from m

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

davidedmundson added a comment. > Will it? isLoading returns m_loading anyway... it's virtual, the ContainmentInterface::isLoading does not return that. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22852 To: davidedmundson, #plasma Cc: brou

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

apol added a comment. In D22852#504645 , @davidedmundson wrote: > If the containment itself is loaded and set to false but the wallpaper is not, I thought it was more correct for the loading property of the containment to return false.

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

broulik added inline comments. INLINE COMMENTS > containmentinterface.cpp:1225 > +if (m_wallpaperInterface) { > +loading &= m_wallpaperInterface->isLoading(); > +} Shouldn't this be `|=`? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org

D20026: Go up in folder hierachy when in "edit mode"

krutovmikhail added a comment. Hi @ngraham, Sorry for long time no update. I'll be getting back to this soon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D22471: [KProcessList] Split command line and process name

broulik added a comment. Should we ship this now? After frameworks tagging I guess. Also, can you add a `CHANGELOG: KProcessInfo::name() now returns only the name of the executable. For the full command line use KProcessInfo::command()` so it shows up nicely in the release announcement chan

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

davidedmundson added a comment. That's something I deliberately did, though it might still be stupid :) I have a property on containment isLoading If the containment itself is loaded and set to false but the wallpaper is not, I thought it was more correct for the loading property of

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

apol added a comment. +1 LGTM overall INLINE COMMENTS > wallpaperinterface.h:52 > Q_PROPERTY(KDeclarative::ConfigPropertyMap *configuration READ > configuration NOTIFY configurationChanged) > +Q_PROPERTY(bool loading MEMBER m_loading NOTIFY isLoadingChanged) > Use READ isLoading(

D20078: fix race on kcrash auto-restarts

sitter added a comment. Yeah, was thinking the same thing :) REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20078 To: sitter, davidedmundson Cc: davidedmundson, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D20078: fix race on kcrash auto-restarts

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Don't ship till after tagging though, better to have a minor bug we know than risk something worse. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https:/

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62844. leinir added a comment. - Add in a getter for category displaynames - Add category/filter/sort dropdowns to NewStuffList - A bit of minor prettification for NewStuffItem REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator

D22852: Allow applets/containments/wallpaper to defer UIReadyConstraint

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This is needed so that we don't remove the splash till the wallpa

D20078: fix race on kcrash auto-restarts

sitter retitled this revision from "RFC fix race on kcrash auto-restarts" to "fix race on kcrash auto-restarts". sitter edited the test plan for this revision. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D20078 To: sitter Cc: davidedmundson, broulik, kde-framewor

D20078: RFC fix race on kcrash auto-restarts

sitter updated this revision to Diff 62840. sitter added a comment. clean up a bit REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20078?vs=54930&id=62840 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20078 AFFECTED FILES autotests/

D22805: set autorcc by default

sitter updated this revision to Diff 62838. sitter added a comment. document behavior and when it was introduced, also enable autouic REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=62729&id=62838 BRANCH master REVISION DETAIL http

D22805: set autorcc and autouic by default

sitter retitled this revision from "set autorcc by default" to "set autorcc and autouic by default". sitter edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: vkrause, kossebau, apol, kde-frameworks-deve

D22791: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH createdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22791 To: kossebau, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngrah

KCrash crash racing

Moin Moin! I've been haunting down a nasty backtrace problem in drkonqi where it entirely fails to create a backtrace and am now fairly confident this is in fact a design flaw with kcrash, but I have no awesome ideas on how to solve this properly. Long story short: there is a space of time betwee

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

This revision was automatically updated to reflect the committed changes. Closed by commit R264:1c08ce74d29f: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7 (authored by kossebau). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22836?

D22805: set autorcc by default

sitter added a comment. Indeed, both good points. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

lbeltrame accepted this revision. lbeltrame added a comment. Not the prettiest, but I've seen worse. ;) REPOSITORY R264 KApiDox BRANCH handlenonasciipathwpython27 REVISION DETAIL https://phabricator.kde.org/D22836 To: kossebau, ochurlaud, bshah, aacid, lbeltrame Cc: lbeltrame, davidre

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

bshah accepted this revision. bshah added a comment. As a short term workaround, this is fine, in terms of porting to python3 it will also need changes on our server zivo.kde.org which is hosting api.kde.org, right now every scripts including krazy2 and apidox generation scripts are too much