D22905: [Permissions editor] Port icons to use QIcon::fromTheme()

ngraham created this revision. ngraham added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The permissions editor was using custom low-resolution pixmaps, which did

KDE CI: Frameworks » kunitconversion » kf5-qt5 WindowsMSVCQt5.11 - Build # 45 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20WindowsMSVCQt5.11/45/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 02 Aug 2019 21:09:54 + Build duration: 48 min and counting JUnit Tests

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 21:22:10 + Build duration: 7 min 36 sec and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 21:18:27 + Build duration: 8 min 21 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/5/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 02 Aug 2019 21:12:32 + Build duration: 9 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 21:12:32 + Build duration: 6 min 0 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/42/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 02 Aug 2019 21:08:53 + Build duration: 7 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/14/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 02 Aug 2019 21:08:52 + Build duration: 5 min 25 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 21:08:52 + Build duration: 1 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/3/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 21:07:15 + Build duration: 2 min 25 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 21:05:18 + Build duration: 1 min 52 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/3/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 20:42:41 + Build duration: 55 sec and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 59 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/59/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 02 Aug 2019 20:32:56 + Build duration: 4 min 56 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 20:32:56 + Build duration: 1 min 47 sec and counting JUnit Tests Name:

D22653: Add view-barcode-qr icons

ndavis added a comment. The 32px icons need to be 32x32, not 54x54. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis, ngraham Cc: lavender, ngraham, broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 17:40:00 + Build duration: 2 min 32 sec and counting JUnit Tests

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.12 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.12/28/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 02 Aug 2019 17:23:39 + Build duration: 6 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.13 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.13/9/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 02 Aug 2019 17:23:39 + Build duration: 2 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdewebkit » kf5-qt5 WindowsMSVCQt5.11 - Build # 41 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20WindowsMSVCQt5.11/41/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 02 Aug 2019 17:23:40 + Build duration: 1 min 16 sec and counting

KDE CI: Frameworks » kdewebkit » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/6/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 17:23:39 + Build duration: 31 sec and counting

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.12 - Build # 27 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.12/27/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 02 Aug 2019 17:17:04 + Build duration: 2 min 16 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kdewebkit » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20WindowsMSVCQt5.11/40/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 02 Aug 2019 17:17:05 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kdewebkit » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20FreeBSDQt5.13/5/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 17:17:05 + Build duration: 50 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kdewebkit » kf5-qt5 SUSEQt5.13 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20SUSEQt5.13/8/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 02 Aug 2019 17:17:04 + Build duration: 38 sec and counting CONSOLE OUTPUT [...truncated 218

D22698: Support passing target to ki18n_wrap_ui macro

daandemeyer added a comment. Ping REVISION DETAIL https://phabricator.kde.org/D22698 To: daandemeyer, ilic Cc: ltoscano, alexmerry, turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22884: [RFC] Don't show title on page by default

ngraham added a comment. In D22884#505856 , @broulik wrote: > Note that `KTitleWidget` originally used normal font size for a descriptive text. At some point that was then changed to large heading font which prompted developers to just (ab)use

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. In D7446#503575 , @meven wrote: > I am working on allow to filter by resource activity date D22717 and D22775 (I will add this soonish into

D22884: [RFC] Don't show title on page by default

broulik added a comment. Note that `KTitleWidget` originally used normal font size for a descriptive text. At some point that was then changed to large heading font which prompted developers to just (ab)use it as a headline rather than a full description. REPOSITORY R236 KWidgetsAddons

D22884: [RFC] Don't show title on page by default

ndavis added a comment. In D22884#505718 , @aspotashev wrote: > In D22884#505656 , @ndavis wrote: > > > Perhaps it is technically a bug, but it seems to me that most of the time (at least in all of

D22864: use zero-based coordinate system on the plot

ngraham added reviewers: Plasma, davidedmundson. ngraham added a comment. Got it, thanks! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22864 To: miklosm, #plasma, davidedmundson Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22822: Add "user-others" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:4c1c97eb9d9b: Add user-others icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22822?vs=62966=62978 REVISION DETAIL

D22884: [RFC] Don't show title on page by default

ngraham added a comment. On the other hand, when the title differs between what's displayed on the page and what's displayed in the sidebar/category switcher, this is not really a good thing. So when the title is displayed on the page, we always have one of two issues: - If the two

D22822: Add "user-others" icon

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH add-users-other-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D22822 To: GB_2, #vdg, ndavis, ngraham Cc: ngraham, kde-frameworks-devel, #vdg,

D22865: remove drawing a black line segment at the end of the plot

miklosm added a comment. In D22865#505628 , @davidedmundson wrote: > > and it looks unrelated to the rest of that changeset. > > It does. > > Do you have a commit account? > If so, I would suggest you merge after Saturday's tagging.

D22864: use zero-based coordinate system on the plot

miklosm added a comment. In D22864#505559 , @ngraham wrote: > Can you describe what problem this is fixing, or what improvement it produces? It's not clear from your Summary section. The problem this is fixing: F7141055: network

D22868: Revamp Kirigami.AboutPage

hein added a comment. I'll remove that part of the patch later tonight and talk Marco into fixing it differently. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella Cc: nicolasfella,

D22868: Revamp Kirigami.AboutPage

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. This breaks the display of main actions on mobile REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart,

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Wrong. Still present in KF frameworks 5.61: KIO’s FTP connection feature is now more tolerant of broken FTP server implementations (Enes Selim, KDE Frameworks 5.61) (from https://pointieststick.com/2019/07/28/kde-usability-productivity-week-81/)

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. Bug still present in plasma 5.16.4. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: rikmills, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22884: [RFC] Don't show title on page by default

aspotashev added a comment. In D22884#505656 , @ndavis wrote: > Perhaps it is technically a bug, but it seems to me that most of the time (at least in all of the KDE programs I have installed), the title is just the section name, "Configure

D22653: Add view-barcode-qr icons

lavender added a comment. In D22653#505659 , @ndavis wrote: > I try not to be too aggressive with optimization when it comes to diffs from other people because the process of making an icon is currently quite tedious and the optimizations

D22653: Add view-barcode-qr icons

ndavis added a comment. actually, you can disregard my inline comments on the 32px icons, I didn't realize you had already removed the duplicate fill currentColor bits. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis,

D22653: Add view-barcode-qr icons

ndavis added inline comments. INLINE COMMENTS > view-barcode-qr.svg:7 > + > + style="fill:currentColor;fill-opacity:1;stroke:none;stroke-width:2" d="M 2 2 > L 2 6 L 6 6 L 6 2 L 2 2 z M 8 2 L 8 3 L 9 3 L 9 2 L 8 2 z M 8 3 L 7 3 L 7 5 L > 8 5 L 8 3 z M 8 5 L 8 6 L 9 6 L 9 5 L 8 5 z M 8 6

D22653: Add view-barcode-qr icons

ngraham accepted this revision. ngraham added a comment. LGTM! Let's wait for @ndavis's full review before landing thiw REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis, ngraham Cc: lavender, ngraham, broulik, ndavis,

D22884: [RFC] Don't show title on page by default

GB_2 added a comment. In D22884#505656 , @ndavis wrote: > In D22884#505651 , @cfeck wrote: > > > The header title is usually more descriptive (longer) than the icon name, so no. > > > Perhaps

D22822: Add "user-others" icon

GB_2 retitled this revision from "Add "users-other" icon" to "Add "user-others" icon". GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22822 To: GB_2, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n,

D22822: Add "users-other" icon

GB_2 updated this revision to Diff 62966. GB_2 added a comment. Rename icon to `user-others` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22822?vs=62782=62966 BRANCH add-users-other-icon (branched from master) REVISION DETAIL

D22747: Fix KCMulti sidebar margins

ngraham abandoned this revision. ngraham added a comment. Not needed. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D22747 To: ngraham, mart Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22884: [RFC] Don't show title on page by default

ngraham edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22884 To: ngraham, #vdg, mart, cfeck Cc: ndavis, cfeck, mmustac, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-barcode-qr icons

ndavis added a comment. In D22653#505439 , @lavender wrote: > [snip] > And the 32 one has a transform that can be applied: > > http://www.w3.org/2000/svg; id="svg938" width="54" height="54">.ColorScheme-Text{color:#232629} > > > I

D22884: [RFC] Don't show title on page by default

ndavis added a comment. In D22884#505651 , @cfeck wrote: > The header title is usually more descriptive (longer) than the icon name, so no. Perhaps it is a bug, but it seems to me that most of the time (at least in all of the KDE

D22884: [RFC] Don't show title on page by default

cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. The header title is usually more descriptive (longer) than the icon name, so no. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22884 To:

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 10:07:52 + Build duration: 32 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 02 Aug 2019 09:55:25 + Build duration: 40 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 58 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/58/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 02 Aug 2019 09:55:28 + Build duration: 21 min and counting BUILD ARTIFACTS

D22865: remove drawing a black line segment at the end of the plot

davidedmundson accepted this revision as: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. > and it looks unrelated to the rest of that changeset. It does. Do you have a commit account? If so, I would suggest you merge after

D22884: [RFC] Don't show title on page by default

mmustac added a comment. I agree that it looks quite strange or at least unusual to me. Find myself always sliding to the left do regonize which topic is selected currently it seems not self explaining and I would miss the header. REPOSITORY R236 KWidgetsAddons REVISION DETAIL