D23136: Jam: Fix local with variable without initilisation and highlight SubRule

2019-08-13 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1f5f6172e88d: Jam: Fix local with variable without 
initilisation and highlight SubRule (authored by jpoelen, committed by 
cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23136?vs=63685=63690#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23136?vs=63685=63690

REVISION DETAIL
  https://phabricator.kde.org/D23136

AFFECTED FILES
  autotests/folding/Jamroot.fold
  autotests/html/Jamroot.html
  autotests/input/Jamroot
  autotests/reference/Jamroot.ref
  data/syntax/jam.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D23136: Jam: Fix local with variable without initilisation and highlight SubRule

2019-08-13 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Testcase looks ok, there we go ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_jam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23136

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

2019-08-13 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/18/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 14 Aug 2019 03:06:42 +
 Build duration:
7 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D23137: C++: contracts are not in C++20

2019-08-13 Thread jonathan poelen
jpoelen updated this revision to Diff 63689.
jpoelen added a comment.


  - increase version

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23137?vs=63686=63689

BRANCH
  cpp_no_contract (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23137

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D23137: C++: contracts are not in C++20

2019-08-13 Thread jonathan poelen
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  For C ++ 23 or C ++ 26 with perhaps a syntax change

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp_no_contract (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23137

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D23136: Jam: Fix local with variable without initilisation and highlight SubRule

2019-08-13 Thread jonathan poelen
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_jam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23136

AFFECTED FILES
  autotests/folding/Jamroot.fold
  autotests/html/Jamroot.html
  autotests/input/Jamroot
  autotests/reference/Jamroot.ref
  data/syntax/jam.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

2019-08-13 Thread jonathan poelen
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  - fix #| (previous untranslated string)
  - fix hexadecimal entity
  - fix html tag in `a < b`
  - use  rather than  for auto-completion
  - string without " at the end of the line is an error
  - # followed by something other than " |:.," is an extension

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  gettext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23135

AFFECTED FILES
  autotests/folding/highlight.po.fold
  autotests/html/highlight.po.html
  autotests/input/highlight.po
  autotests/reference/highlight.po.ref
  data/syntax/gettext.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread Noah Davis
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D23116#511480 , @trickyricky26 
wrote:
  
  > I thought about that, too, and while the red used in the icon is exactly 
`NegativeText`, the blue in the current icon is darker and has a less vibrant 
hue than `ButtonFocus`, so I'm not quite comfortable with using that for the 
blue color. Do we have this darker blue as a CSS color that we can use in this 
way? I see this dark blue is also used in the `channelmixer` icon, which has 
its colors hardcoded as well. I also don't think it would make sense to only 
use stylesheet colors for only one of these two colors.
  
  
  It's a real shame that we can't specify dedicated icon colors in the 
colorscheme, otherwise that would be a nice blue to use. Or maybe it can be 
done, but it would be complicated. I don't think it's absolutely necessary to 
use ButtonFocus right now.
  
  > Btw, in the relevant HIG page 
(https://hig.kde.org/style/icon.html#action-and-status-icons) the color 
`ColorScheme-ButtonFocus` in the page you linked is called 
`ColorScheme-Highlight` and there are other anme differences, too. Is one of 
these inaccurate, or do they both work?
  
  I need to update the HIG. We switched from Highlight to ButtonFocus because 
Highlight uses the Selection Background color. In the future, I'm going to 
change the Breeze/Breeze Dark colorschemes so that Focus Decoration color and 
Selection Background color are different. This prevents blue icon elements from 
blending in with the selection background.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-depth-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns


D23134: fix additionalDeliminator attribute

2019-08-13 Thread jonathan poelen
jpoelen added a comment.


  I don't understand why there's so much difference in what's displayed :/

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23134

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D23134: fix additionalDeliminator attribute

2019-08-13 Thread jonathan poelen
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  The initialization of the `Rule::m_wordDelimiter` cache was done before the 
delimiters were extracted, which can invalidate the character number.
  
  BUG: 399348

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_wordDelimiters (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23134

AFFECTED FILES
  src/lib/rule.cpp

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread TrickyRicky
trickyricky26 added a comment.


  In D23116#511430 , @GB_2 wrote:
  
  > Maybe instead of hardcoding the blue and red colors you can use the 
stylesheet colors `ButtonFocus` and `NegativeText`: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets
  
  
  I thought about that, too, and while the red used in the icon is exactly 
`NegativeText`, the blue in the current icon is darker and has a less vibrant 
hue than `ButtonFocus`, so I'm not quite comfortable with using that for the 
blue color. Do we have this darker blue as a CSS color that we can use in this 
way? I see this dark blue is also used in the `channelmixer` icon, which has 
its colors hardcoded as well. I also don't think it would make sense to only 
use stylesheet colors for only one of these two colors.
  
  Btw, in the relevant HIG page 
(https://hig.kde.org/style/icon.html#action-and-status-icons) the color 
`ColorScheme-ButtonFocus` in the page you linked is called 
`ColorScheme-Highlight` and there are other anme differences, too. Is one of 
these inaccurate, or do they both work?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns


D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

2019-08-13 Thread Vlad Zagorodniy
zzag added inline comments.

INLINE COMMENTS

> kwindowsystem.h:233
>   * when the parent is deleted are unaffected and normally use
>   * the QWidget parent.
>   *

> and normally use the QWidget parent.

I think this statement is inaccurate. Documentation needs more love. :-)

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23108

To: dfaure, broulik, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Fixed!

2019-08-13 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.13/19/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 13 Aug 2019 20:33:46 +
 Build duration:
49 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

2019-08-13 Thread Christoph Cullmann
cullmann commandeered this revision.
cullmann added a reviewer: gregormi.
cullmann added a comment.


  I think we need to start here from scratch.
  Gregor, if you have some time again, open a new request please!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: cullmann, #kate, #kdevelop, gregormi
Cc: loh.tar, anthonyfieroni, ngraham, cullmann, flherne, dhaumann, 
kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, 
demsking, sars


D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

2019-08-13 Thread Christoph Cullmann
cullmann abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: cullmann, #kate, #kdevelop, gregormi
Cc: loh.tar, anthonyfieroni, ngraham, cullmann, flherne, dhaumann, 
kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, 
demsking, sars


D23034: implicit fallthough if there is fallthoughContext

2019-08-13 Thread Christoph Cullmann
cullmann closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23034

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D23034: implicit fallthough if there is fallthoughContext

2019-08-13 Thread Christoph Cullmann
cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  auto_fallthrough (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23034

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D23034: implicit fallthough if there is fallthoughContext

2019-08-13 Thread Christoph Cullmann
cullmann added a comment.


  Some whitespace stuff, git diff -w looks OK.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23034

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Fixed!

2019-08-13 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.13/5/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 13 Aug 2019 20:33:46 +
 Build duration:
8 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.13 - Build # 22 - Fixed!

2019-08-13 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.13/22/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 13 Aug 2019 20:33:46 +
 Build duration:
7 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5SyntaxHighlighting-5.62.0.xmlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)76%
(34/45)76%
(34/45)78%
(2715/3492)67%
(1803/2684)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)92%
(708/773)59%
(408/694)examples.codeeditor0%
(0/2)0%
(0/2)0%
(0/203)0%
(0/88)examples.codepdfprinter0%
(0/3)0%
(0/3)0%
(0/39)0%
(0/6)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)73%
(222/304)76%
(198/260)src.lib90%
(27/30)90%
(27/30)85%
(1785/2088)74%
(1197/1608)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 126 - Fixed!

2019-08-13 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/126/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 13 Aug 2019 20:33:46 +
 Build duration:
3 min 27 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5SyntaxHighlighting-5.62.0.xmlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)76%
(34/45)76%
(34/45)78%
(2715/3492)67%
(1803/2684)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)92%
(708/773)59%
(408/694)examples.codeeditor0%
(0/2)0%
(0/2)0%
(0/203)0%
(0/88)examples.codepdfprinter0%
(0/3)0%
(0/3)0%
(0/39)0%
(0/6)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)73%
(222/304)76%
(198/260)src.lib90%
(27/30)90%
(27/30)85%
(1785/2088)74%
(1197/1608)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Failure!

2019-08-13 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.13/18/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 13 Aug 2019 20:24:36 +
 Build duration:
8 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 285 lines...][2019-08-13T20:33:20.517Z] Scanning dependencies of target repository_benchmark_autogen[2019-08-13T20:33:20.517Z] Scanning dependencies of target codeeditor_autogen[2019-08-13T20:33:20.517Z] Scanning dependencies of target folding_test_autogen[2019-08-13T20:33:20.517Z] Scanning dependencies of target syntaxrepository_test_autogen[2019-08-13T20:33:20.517Z] [ 43%] Automatic MOC for target htmlhighlighter_test[2019-08-13T20:33:20.517Z] [ 44%] Automatic MOC for target repository_benchmark[2019-08-13T20:33:20.517Z] [ 45%] Automatic MOC for target codepdfprinter[2019-08-13T20:33:20.517Z] Scanning dependencies of target theme_test_autogen[2019-08-13T20:33:20.517Z] Scanning dependencies of target testhighlighter_test_autogen[2019-08-13T20:33:20.517Z] [ 46%] Automatic MOC for target folding_test[2019-08-13T20:33:20.517Z] [ 48%] Automatic MOC for target kate-syntax-highlighter[2019-08-13T20:33:20.517Z] [ 49%] Automatic MOC for target syntaxrepository_test[2019-08-13T20:33:20.517Z] [ 50%] Automatic MOC for target codeeditor[2019-08-13T20:33:20.517Z] [ 51%] Automatic MOC for target testhighlighter_test[2019-08-13T20:33:20.517Z] [ 53%] Automatic MOC for target theme_test[2019-08-13T20:33:20.851Z] [ 53%] Built target codepdfprinter_autogen[2019-08-13T20:33:20.851Z] Scanning dependencies of target highlighter_benchmark_autogen[2019-08-13T20:33:21.140Z] [ 53%] Built target kate-syntax-highlighter_autogen[2019-08-13T20:33:21.140Z] [ 54%] Automatic MOC for target highlighter_benchmark[2019-08-13T20:33:21.140Z] Scanning dependencies of target wildcardmatcher_test_autogen[2019-08-13T20:33:21.433Z] [ 55%] Automatic MOC for target wildcardmatcher_test[2019-08-13T20:33:21.433Z] [ 55%] Built target syntaxrepository_test_autogen[2019-08-13T20:33:21.433Z] Scanning dependencies of target kate-syntax-highlighter[2019-08-13T20:33:21.433Z] [ 56%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter_autogen/mocs_compilation.cpp.o[2019-08-13T20:33:21.433Z] [ 58%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter.cpp.o[2019-08-13T20:33:22.017Z] [ 58%] Built target testhighlighter_test_autogen[2019-08-13T20:33:22.281Z] [ 58%] Built target htmlhighlighter_test_autogen[2019-08-13T20:33:22.555Z] [ 58%] Built target folding_test_autogen[2019-08-13T20:33:22.555Z] Scanning dependencies of target codepdfprinter[2019-08-13T20:33:22.555Z] [ 59%] Building CXX object examples/codepdfprinter/CMakeFiles/codepdfprinter.dir/codepdfprinter_autogen/mocs_compilation.cpp.o[2019-08-13T20:33:22.555Z] Scanning dependencies of target syntaxrepository_test[2019-08-13T20:33:22.555Z] [ 60%] Building CXX object autotests/CMakeFiles/syntaxrepository_test.dir/syntaxrepository_test_autogen/mocs_compilation.cpp.o[2019-08-13T20:33:22.555Z] [ 62%] Building CXX object examples/codepdfprinter/CMakeFiles/codepdfprinter.dir/codepdfprinter.cpp.o[2019-08-13T20:33:22.555Z] [ 62%] Built target repository_benchmark_autogen[2019-08-13T20:33:22.555Z] [ 63%] Building CXX object examples/codepdfprinter/CMakeFiles/codepdfprinter.dir/main.cpp.o[2019-08-13T20:33:22.555Z] [ 63%] Built target codeeditor_autogen[2019-08-13T20:33:22.835Z] [ 64%] Linking CXX executable ../bin/syntaxrepository_test[2019-08-13T20:33:22.836Z] Scanning dependencies of target testhighlighter_test[2019-08-13T20:33:22.836Z] [ 65%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter_test_autogen/mocs_compilation.cpp.o[2019-08-13T20:33:22.836Z] [ 65%] Built target theme_test_autogen[2019-08-13T20:33:22.836Z] [ 67%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter.cpp.o[2019-08-13T20:33:22.836Z] Scanning dependencies of target repository_benchmark[2019-08-13T20:33:22.836Z] [ 68%] Building CXX object autotests/CMakeFiles/repository_benchmark.dir/repository_benchmark_autogen/mocs_compilation.cpp.o[2019-08-13T20:33:22.836Z] /usr/bin/ld: error: undefined symbol: main[2019-08-13T20:33:22.836Z] >>> referenced by crt1.c:76 (/usr/src/lib/csu/amd64/crt1.c:76)[2019-08-13T20:33:22.836Z] >>>   /usr/lib/crt1.o:(_start)[2019-08-13T20:33:22.836Z] [ 69%] Building CXX object autotests/CMakeFiles/repository_benchmark.dir/repository_benchmark.cpp.o[2019-08-13T20:33:23.094Z] c++: error: linker command failed with exit code 1 (use -v to see invocation)[2019-08-13T20:33:23.094Z] gmake[2]: *** [autotests/CMakeFiles/syntaxrepository_test.dir/build.make:84: bin/syntaxrepository_test] Error 1[2019-08-13T20:33:23.094Z] gmake[1]: *** [CMakeFiles/Makefile2:1575: autotests/CMakeFiles/syntaxrepository_test.dir/all] Error 2[2019-08-13T20:33:23.094Z] gmake[1]: *** Waiting for 

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 125 - Failure!

2019-08-13 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/125/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 13 Aug 2019 20:24:37 +
 Build duration:
3 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 330 lines...][2019-08-13T20:27:27.774Z] [ 30%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/definition.cpp.o[2019-08-13T20:27:27.774Z] [ 31%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/repository.cpp.o[2019-08-13T20:27:27.774Z] [ 32%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/state.cpp.o[2019-08-13T20:27:29.446Z] [ 34%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/syntaxhighlighter.cpp.o[2019-08-13T20:27:29.946Z] [ 35%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/theme.cpp.o[2019-08-13T20:27:29.946Z] [ 36%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/wildcardmatcher.cpp.o[2019-08-13T20:27:30.998Z] [ 37%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/themedata.cpp.o[2019-08-13T20:27:30.998Z] [ 39%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/ECMQmLoader-syntaxhighlighting5_qt.cpp.o[2019-08-13T20:27:31.497Z] [ 40%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/ksyntaxhighlighting_logging.cpp.o[2019-08-13T20:27:33.153Z] [ 41%] Linking CXX shared library ../../bin/libKF5SyntaxHighlighting.so[2019-08-13T20:27:33.153Z] [ 41%] Built target KF5SyntaxHighlighting[2019-08-13T20:27:33.153Z] Scanning dependencies of target codeeditor_autogen[2019-08-13T20:27:33.153Z] Scanning dependencies of target htmlhighlighter_test_autogen[2019-08-13T20:27:33.153Z] Scanning dependencies of target codepdfprinter_autogen[2019-08-13T20:27:33.153Z] Scanning dependencies of target kate-syntax-highlighter_autogen[2019-08-13T20:27:33.153Z] Scanning dependencies of target wildcardmatcher_test_autogen[2019-08-13T20:27:33.153Z] Scanning dependencies of target folding_test_autogen[2019-08-13T20:27:33.153Z] [ 43%] Automatic MOC for target htmlhighlighter_test[2019-08-13T20:27:33.153Z] [ 44%] Automatic MOC for target kate-syntax-highlighter[2019-08-13T20:27:33.153Z] [ 45%] Automatic MOC for target codepdfprinter[2019-08-13T20:27:33.153Z] [ 46%] Automatic MOC for target codeeditor[2019-08-13T20:27:33.153Z] [ 48%] Automatic MOC for target folding_test[2019-08-13T20:27:33.153Z] [ 49%] Automatic MOC for target wildcardmatcher_test[2019-08-13T20:27:33.153Z] [ 49%] Built target kate-syntax-highlighter_autogen[2019-08-13T20:27:33.653Z] [ 49%] Built target codepdfprinter_autogen[2019-08-13T20:27:33.653Z] Scanning dependencies of target theme_test_autogen[2019-08-13T20:27:33.653Z] Scanning dependencies of target syntaxrepository_test_autogen[2019-08-13T20:27:33.653Z] [ 50%] Automatic MOC for target theme_test[2019-08-13T20:27:33.653Z] [ 51%] Automatic MOC for target syntaxrepository_test[2019-08-13T20:27:33.653Z] [ 51%] Built target syntaxrepository_test_autogen[2019-08-13T20:27:33.653Z] Scanning dependencies of target testhighlighter_test_autogen[2019-08-13T20:27:33.653Z] [ 53%] Automatic MOC for target testhighlighter_test[2019-08-13T20:27:33.653Z] [ 53%] Built target codeeditor_autogen[2019-08-13T20:27:33.653Z] [ 53%] Built target wildcardmatcher_test_autogen[2019-08-13T20:27:33.653Z] [ 53%] Built target folding_test_autogen[2019-08-13T20:27:33.653Z] [ 53%] Built target htmlhighlighter_test_autogen[2019-08-13T20:27:33.653Z] Scanning dependencies of target repository_benchmark_autogen[2019-08-13T20:27:33.653Z] Scanning dependencies of target highlighter_benchmark_autogen[2019-08-13T20:27:33.653Z] [ 54%] Automatic MOC for target repository_benchmark[2019-08-13T20:27:33.653Z] [ 55%] Automatic MOC for target highlighter_benchmark[2019-08-13T20:27:33.653Z] [ 55%] Built target theme_test_autogen[2019-08-13T20:27:33.653Z] Scanning dependencies of target kate-syntax-highlighter[2019-08-13T20:27:33.653Z] Scanning dependencies of target codeeditor[2019-08-13T20:27:33.653Z] [ 56%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter_autogen/mocs_compilation.cpp.o[2019-08-13T20:27:33.653Z] [ 58%] Building CXX object examples/codeeditor/CMakeFiles/codeeditor.dir/codeeditor_autogen/mocs_compilation.cpp.o[2019-08-13T20:27:33.654Z] [ 59%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter.cpp.o[2019-08-13T20:27:33.654Z] Scanning dependencies of target codepdfprinter[2019-08-13T20:27:33.654Z] [ 59%] Built target testhighlighter_test_autogen[2019-08-13T20:27:33.654Z] [ 60%] Building CXX object examples/codepdfprinter/CMakeFiles/codepdfprinter.dir/codepdfprinter_autogen/mocs_compilation.cpp.o[2019-08-13T20:27:33.654Z] Scanning dependencies of target htmlhighlighter_test[2019-08-13T20:27:34.153Z] [ 62%] Building CXX object 

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.13 - Build # 21 - Failure!

2019-08-13 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.13/21/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 13 Aug 2019 20:24:36 +
 Build duration:
1 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 303 lines...][2019-08-13T20:25:36.651Z] Insert indices...[2019-08-13T20:25:36.651Z] Documentation successfully generated.[2019-08-13T20:25:36.651Z] [  5%] Built target KF5SyntaxHighlighting_QCH[2019-08-13T20:25:36.651Z] Scanning dependencies of target katehighlightingindexer[2019-08-13T20:25:36.651Z] [  6%] Building CXX object src/indexer/CMakeFiles/katehighlightingindexer.dir/katehighlightingindexer_autogen/mocs_compilation.cpp.o[2019-08-13T20:25:36.915Z] [  7%] Building CXX object src/indexer/CMakeFiles/katehighlightingindexer.dir/katehighlightingindexer.cpp.o[2019-08-13T20:25:38.818Z] [  8%] Linking CXX executable ../../bin/katehighlightingindexer[2019-08-13T20:25:39.079Z] [  8%] Built target katehighlightingindexer[2019-08-13T20:25:39.079Z] [ 10%] Generating index.katesyntax[2019-08-13T20:25:49.077Z] [ 11%] Generating qrc_theme-data.cpp[2019-08-13T20:25:49.077Z] [ 12%] Generating qrc_syntax-data.cpp[2019-08-13T20:25:49.077Z] Scanning dependencies of target SyntaxHighlightingData[2019-08-13T20:25:49.077Z] [ 13%] Building CXX object data/CMakeFiles/SyntaxHighlightingData.dir/SyntaxHighlightingData_autogen/mocs_compilation.cpp.o[2019-08-13T20:25:49.077Z] [ 15%] Building CXX object data/CMakeFiles/SyntaxHighlightingData.dir/qrc_syntax-data.cpp.o[2019-08-13T20:25:51.603Z] [ 16%] Building CXX object data/CMakeFiles/SyntaxHighlightingData.dir/qrc_theme-data.cpp.o[2019-08-13T20:25:51.603Z] [ 16%] Built target SyntaxHighlightingData[2019-08-13T20:25:51.877Z] Scanning dependencies of target KF5SyntaxHighlighting[2019-08-13T20:25:51.877Z] [ 17%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/KF5SyntaxHighlighting_autogen/mocs_compilation.cpp.o[2019-08-13T20:25:52.809Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/keywordlist.cpp.o[2019-08-13T20:25:53.736Z] [ 20%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/rule.cpp.o[2019-08-13T20:25:55.097Z] [ 21%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/definition.cpp.o[2019-08-13T20:25:56.988Z] [ 22%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/repository.cpp.o[2019-08-13T20:25:57.915Z] [ 24%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/state.cpp.o[2019-08-13T20:25:57.915Z] [ 25%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/htmlhighlighter.cpp.o[2019-08-13T20:25:58.481Z] [ 26%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/format.cpp.o[2019-08-13T20:25:58.481Z] [ 27%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/foldingregion.cpp.o[2019-08-13T20:25:58.736Z] [ 29%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/syntaxhighlighter.cpp.o[2019-08-13T20:25:58.993Z] [ 30%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/theme.cpp.o[2019-08-13T20:25:58.993Z] [ 31%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/wildcardmatcher.cpp.o[2019-08-13T20:25:59.573Z] [ 32%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/themedata.cpp.o[2019-08-13T20:25:59.573Z] [ 34%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/definitiondownloader.cpp.o[2019-08-13T20:25:59.835Z] [ 35%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/contextswitch.cpp.o[2019-08-13T20:25:59.835Z] [ 36%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/ksyntaxhighlighting_logging.cpp.o[2019-08-13T20:26:00.429Z] [ 37%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/ECMQmLoader-syntaxhighlighting5_qt.cpp.o[2019-08-13T20:26:00.429Z] [ 39%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/context.cpp.o[2019-08-13T20:26:00.995Z] [ 40%] Building CXX object src/lib/CMakeFiles/KF5SyntaxHighlighting.dir/abstracthighlighter.cpp.o[2019-08-13T20:26:02.389Z] [ 41%] Linking CXX shared library ../../bin/libKF5SyntaxHighlighting.so[2019-08-13T20:26:02.951Z] [ 41%] Built target KF5SyntaxHighlighting[2019-08-13T20:26:02.951Z] Scanning dependencies of target codeeditor_autogen[2019-08-13T20:26:02.951Z] Scanning dependencies of target kate-syntax-highlighter_autogen[2019-08-13T20:26:02.951Z] [ 43%] Automatic MOC for target codeeditor[2019-08-13T20:26:02.951Z] [ 44%] Automatic MOC for target kate-syntax-highlighter[2019-08-13T20:26:03.207Z] [ 44%] Built target kate-syntax-highlighter_autogen[2019-08-13T20:26:03.207Z] Scanning dependencies of target testhighlighter_test_autogen[2019-08-13T20:26:03.207Z] Scanning dependencies of target syntaxrepository_test_autogen[2019-08-13T20:26:03.207Z] [ 45%] Automatic MOC for target testhighlighter_test[2019-08-13T20:26:03.207Z] [ 46%] Automatic MOC for target 

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.13 - Build # 4 - Failure!

2019-08-13 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.13/4/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 13 Aug 2019 20:24:36 +
 Build duration:
1 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 188 lines...][2019-08-13T20:25:43.256Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-08-13T20:25:43.256Z] WINDIR= 'C:\WINDOWS'[2019-08-13T20:25:43.256Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-08-13T20:25:43.256Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-08-13T20:25:43.256Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-08-13T20:25:43.256Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-08-13T20:25:43.256Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-08-13T20:25:43.256Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-08-13T20:25:43.256Z] WORKSPACE = 'C:\CI\workspace\Frameworks\syntax-highlighting\kf5-qt5 WindowsMSVCQt5.13'[2019-08-13T20:25:43.256Z] __DOTNET_ADD_64BIT= '1'[2019-08-13T20:25:43.256Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-08-13T20:25:43.256Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-08-13T20:25:43.256Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\syntax-highlighting;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils'[2019-08-13T20:25:43.256Z] XDG_DATA_DIRS = 'C:\CI\Software Installs\syntax-highlighting\share;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\share;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils\share'[2019-08-13T20:25:43.256Z] PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils\lib\pkgconfig'[2019-08-13T20:25:43.256Z] QT_PLUGIN_PATH= 'C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\bin\plugins'[2019-08-13T20:25:43.256Z] QMAKEFEATURES = 'C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\mkspecs/features'[2019-08-13T20:25:43.256Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-08-13T20:25:43.256Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-08-13T20:25:43.256Z] [2019-08-13T20:25:43.256Z] [2019-08-13T20:25:43.256Z] == Commencing Configuration:[2019-08-13T20:25:43.256Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/syntax-highlighting/" -G "NMake Makefiles JOM" -DBUILD_QCH=TRUE "C:\CI\workspace\Frameworks\syntax-highlighting\kf5-qt5 WindowsMSVCQt5.13"[2019-08-13T20:25:43.765Z] -- The C compiler identification is MSVC 19.16.27027.1[2019-08-13T20:25:44.269Z] -- The CXX compiler identification is MSVC 19.16.27027.1[2019-08-13T20:25:44.269Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe[2019-08-13T20:25:45.945Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe -- works[2019-08-13T20:25:45.945Z] -- Detecting C compiler ABI info[2019-08-13T20:25:47.636Z] -- Detecting C compiler ABI info - done[2019-08-13T20:25:47.636Z] -- Detecting C compile features[2019-08-13T20:25:50.023Z] -- Detecting C compile features - done[2019-08-13T20:25:50.023Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe[2019-08-13T20:25:52.427Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe -- works[2019-08-13T20:25:52.427Z] -- Detecting CXX compiler ABI info[2019-08-13T20:25:54.115Z] -- Detecting CXX compiler ABI info - done[2019-08-13T20:25:54.115Z] -- Detecting CXX compile features[2019-08-13T20:25:56.534Z] -- Detecting CXX compile features - done[2019-08-13T20:25:56.534Z] Installing in C:/CI/Software Installs/syntax-highlighting. Run C:/CI/workspace/Frameworks/syntax-highlighting/kf5-qt5 WindowsMSVCQt5.13/build/prefix.sh to set the environment for 

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

2019-08-13 Thread Christoph Cullmann
cullmann closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann


D22662: Add common GLSL file extensions (.vs, .gs, .fs)

2019-08-13 Thread Steve Mokris
smokris added a comment.


  Sounds good, thanks.  I just emailed you at your KDE address.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann


D22662: Add common GLSL file extensions (.vs, .gs, .fs)

2019-08-13 Thread Christoph Cullmann
cullmann added a comment.


  If you pass me name + email, will push it.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann


D22662: Add common GLSL file extensions (.vs, .gs, .fs)

2019-08-13 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Sorry, then I did misread that in the diff, I thought QTest::newRow("fs") << 
QStringLiteral("test.fs") << QStringLiteral("FSharp"); enforces that FSharp is 
used, not the other way around ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann


D22662: Add common GLSL file extensions (.vs, .gs, .fs)

2019-08-13 Thread Steve Mokris
smokris requested review of this revision.
smokris added a comment.


  In D22662#511424 , @cullmann wrote:
  
  > I am not sure we want to override F# for .fs.
  >  Either we should not add that or we shall lower the priority of this 
highlighting to loose against F#.
  
  
  The test I added verifies that F# is still being chosen for the `.fs` 
extension (and that GLSL, added by this change, loses to F#'s higher priority).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann


D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread Björn Feber
GB_2 added a comment.


  Maybe instead of hardcoding the blue and red colors you can use the 
stylesheet colors `ButtonFocus` and `NegativeText`: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns


D22662: Add common GLSL file extensions (.vs, .gs, .fs)

2019-08-13 Thread Christoph Cullmann
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I am not sure we want to override F# for .fs.
  Either we should not add that or we shall lower the priority of this 
highlighting to loose against F#.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann


D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-13 Thread Piyush Aggarwal
brute4s99 created this revision.
brute4s99 added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REVISION SUMMARY
  without this patch, most notifications show every notification twice. This 
seems to be an internal problem of knotification, but until that is fixed, this 
is the next best solution IMHO.

TEST PLAN
  without this patch, every mobile notification from KDE Connect should show up 
twice.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23133

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23124: Remove unused DBus XML file

2019-08-13 Thread Volker Krause
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Not only unused, but also seems to contain an interface that doesn't exist 
(anymore).

REPOSITORY
  R289 KNotifications

BRANCH
  noknotixml

REVISION DETAIL
  https://phabricator.kde.org/D23124

To: nicolasfella, #frameworks, broulik, vkrause
Cc: vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23131: Define install location for JAR/AAR files for Android

2019-08-13 Thread Volker Krause
vkrause added reviewers: Build System, Android.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23131

To: vkrause, #build_system, #android
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, 
ngraham, bruns


D23131: Define install location for JAR/AAR files for Android

2019-08-13 Thread Volker Krause
vkrause created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This follows where Qt installs those, and thus androiddeployqt looks for
  them. Currently this is hardcoded in knotifications for example, seems
  cleaner to have this here.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23131

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, 
ngraham, bruns


D23112: Add a event Spy for GtkFileChooser recent files

2019-08-13 Thread Ivan Čukić
ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  Thanks for geting involved this much!

INLINE COMMENTS

> GtkEventSpy.cpp:129
> +// remove "'" caracters wrapping the command
> +exec = exec.mid(1, exec.size() -2 );
> +

It might be dangerous to assume that the command is wrapped with single quotes

> GtkEventSpy.cpp:133
> +// See 
> https://techbase.kde.org/Development/Tutorials/Services/Traders#The_KTrader_Query_Language
> +QString query = QString("exist Exec and ((Exec ~~ '%1') or (exist 
> GenericName and '%1' ~~ GenericName) or (exist Name and '%1' ~~ 
> Name))").arg(exec);
> +KService::List services = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"), query);

const auto query

> GtkEventSpy.cpp:134
> +QString query = QString("exist Exec and ((Exec ~~ '%1') or (exist 
> GenericName and '%1' ~~ GenericName) or (exist Name and '%1' ~~ 
> Name))").arg(exec);
> +KService::List services = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"), query);
> +

This should also be `const`, other local variables as well

> GtkEventSpy.cpp:143
> +// remove space and any caracter after
> +int spaceIdex = exec.indexOf(" ");
> +if (spaceIdex != -1) {

Let's hope commands will never have spaces in them :)

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D23112: Add a event Spy for GtkFileChooser recent files

2019-08-13 Thread Méven Car
meven updated this revision to Diff 63669.
meven added a comment.


  Add a logging category

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63654=63669

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D21795: [KAuth] Add support for action details in Polkit1 backend.

2019-08-13 Thread Nathaniel Graham
ngraham added a comment.


  @chinmoyr, any word on  this?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter
Cc: ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, michaelh, bruns


D21760: Add KListOpenFiles::listProcessesWithOpenFiles

2019-08-13 Thread David Hallas
hallas marked 3 inline comments as done.
hallas added inline comments.

INLINE COMMENTS

> dfaure wrote in klistopenfiles.cpp:49
> This reminds me of KCoreAddons' new KProcessInfo class, although that one 
> doesn't actually do this.
> 
> I see that FreeBSD and OSX have lsof (and the man page doesn't say those 
> options are missing there) so it should be fine, everywhere except Windows.
> 
> In general I don't really like starting executables like this, but indeed 
> writing a clone of lsof sounds like much work.

I don't like starting executables either, it is slow, brittle and an implicit 
dependency - but I also think in this case it is the only feasible option :/

But is it ok not to support Windows? Or maybe the Windows implementation would 
emit a debug warning and then always emit an empty list?

> dfaure wrote in klistopenfiles.h:40
> Reading the unittest, I definitely agree that a signal would be better. Then 
> you could use QSignalSpy::wait() without the need to use QEventLoop by hand 
> :-)
> 
> This is really a job. I would inherit KJob for this, actually. It's the way 
> we do such things everywhere else.

Thanks for the feedback! I will look into making a solution using a signal 
instead and push an updated commit.

Regarding implementing this as a KJob subclass, do you have a good example of 
this? Would the result be delivered in a special signal, or is there a standard 
mechanism for this in KJob?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-08-13 Thread Nathaniel Graham
ngraham added a comment.


  @emateli Ping :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, LeGast00n, michaelh, bruns


D21760: Add KListOpenFiles::listProcessesWithOpenFiles

2019-08-13 Thread David Hallas
hallas added a subscriber: cfeck.
hallas added a comment.


  In D21760#493817 , @cfeck wrote:
  
  > You wrote "ported from Device Notifier". I haven't check in detail yet, but 
do other copyright holders need to be mentioned?
  
  
  I have added the copyright holders from:
  plasma-workspace/dataengines/devicenotifications/ksolidnotify.cpp

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-08-13 Thread Nathaniel Graham
ngraham added a comment.


  @bruns ping! :)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, michaelh


D23124: Remove unused DBus XML file

2019-08-13 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This file appears to be unused

TEST PLAN
  KNotifications builds and installs fine

REPOSITORY
  R289 KNotifications

BRANCH
  noknotixml

REVISION DETAIL
  https://phabricator.kde.org/D23124

AFFECTED FILES
  src/org.kde.KNotify.xml

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

2019-08-13 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/17/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 13 Aug 2019 11:26:21 +
 Build duration:
55 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 124 - Fixed!

2019-08-13 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/124/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 13 Aug 2019 11:45:29 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5SyntaxHighlighting-5.62.0.xmlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)76%
(34/45)76%
(34/45)78%
(2714/3491)67%
(1803/2684)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)92%
(707/772)59%
(408/694)examples.codeeditor0%
(0/2)0%
(0/2)0%
(0/203)0%
(0/88)examples.codepdfprinter0%
(0/3)0%
(0/3)0%
(0/39)0%
(0/6)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)73%
(222/304)76%
(198/260)src.lib90%
(27/30)90%
(27/30)85%
(1785/2088)74%
(1197/1608)

KDE CI: Frameworks » threadweaver » kf5-qt5 WindowsMSVCQt5.13 - Build # 3 - Fixed!

2019-08-13 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20WindowsMSVCQt5.13/3/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 13 Aug 2019 11:44:07 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-13 Thread Méven Car
meven updated this revision to Diff 63654.
meven added a comment.


  Readd include QDebug used by qWarning

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63647=63654

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


KDE CI: Frameworks » threadweaver » kf5-qt5 WindowsMSVCQt5.13 - Build # 2 - Failure!

2019-08-13 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20WindowsMSVCQt5.13/2/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 13 Aug 2019 11:22:20 +
 Build duration:
4 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-08-13T11:26:50.507Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe -- works[2019-08-13T11:26:50.507Z] -- Detecting CXX compiler ABI info[2019-08-13T11:26:50.507Z] -- Detecting CXX compiler ABI info - done[2019-08-13T11:26:50.507Z] -- Detecting CXX compile features[2019-08-13T11:26:50.507Z] -- Detecting CXX compile features - done[2019-08-13T11:26:50.507Z] -- [2019-08-13T11:26:50.507Z] [2019-08-13T11:26:50.507Z] Installing in C:/CI/Software Installs/threadweaver. Run C:/CI/workspace/Frameworks/threadweaver/kf5-qt5 WindowsMSVCQt5.13/build/prefix.sh to set the environment for ThreadWeaver.[2019-08-13T11:26:50.507Z] -- Looking for __GLIBC__[2019-08-13T11:26:50.507Z] -- Looking for __GLIBC__ - not found[2019-08-13T11:26:50.507Z] -- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support[2019-08-13T11:26:50.507Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-08-13T11:26:50.507Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-08-13T11:26:50.507Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed[2019-08-13T11:26:50.507Z] -- Performing Test COMPILER_HAS_DEPRECATED[2019-08-13T11:26:50.507Z] -- Performing Test COMPILER_HAS_DEPRECATED - Success[2019-08-13T11:26:50.507Z] -- Found Doxygen: C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/bin/doxygen.exe (found suitable version "1.8.14", minimum required is "1.8.13") found components:  doxygen missing components:  dot[2019-08-13T11:26:50.507Z] -- Found QHelpGenerator executable: C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/bin/qhelpgenerator.exe[2019-08-13T11:26:50.507Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2019-08-13T11:26:50.507Z] -- The following features have been enabled:[2019-08-13T11:26:50.507Z] [2019-08-13T11:26:50.507Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-08-13T11:26:50.507Z] [2019-08-13T11:26:50.507Z] -- The following REQUIRED packages have been found:[2019-08-13T11:26:50.507Z] [2019-08-13T11:26:50.507Z]  * Doxygen (required version >= 1.8.13)[2019-08-13T11:26:50.507Z]Needed for API dox QCH file generation[2019-08-13T11:26:50.507Z]  * QHelpGenerator, Part of Qt5 tools[2019-08-13T11:26:50.507Z]Needed for API dox QCH file generation[2019-08-13T11:26:50.507Z]  * Qt5Gui (required version >= 5.13.0)[2019-08-13T11:26:50.507Z]  * Qt5Test (required version >= 5.11.0)[2019-08-13T11:26:50.507Z]  * ECM (required version >= 1.1.0), Extra CMake Modules., [2019-08-13T11:26:50.507Z]  * Qt5Core[2019-08-13T11:26:50.507Z]  * Qt5Network[2019-08-13T11:26:50.507Z]  * Qt5Xml[2019-08-13T11:26:50.507Z]  * Qt5Widgets[2019-08-13T11:26:50.507Z]  * Qt5[2019-08-13T11:26:50.507Z] [2019-08-13T11:26:50.507Z] -- Configuring done[2019-08-13T11:26:50.507Z] -- Generating done[2019-08-13T11:26:50.507Z] -- Build files have been written to: C:/CI/workspace/Frameworks/threadweaver/kf5-qt5 WindowsMSVCQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-08-13T11:27:08.142Z] [2019-08-13T11:27:08.142Z] C:\CI\workspace\Frameworks\threadweaver\kf5-qt5 WindowsMSVCQt5.13>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-08-13T11:27:08.142Z] **[2019-08-13T11:27:08.142Z] ** Visual Studio 2019 Developer Command Prompt v16.0.3[2019-08-13T11:27:08.142Z] ** Copyright (c) 2019 Microsoft Corporation[2019-08-13T11:27:08.142Z] **[2019-08-13T11:27:09.512Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-08-13T11:27:09.512Z] [2019-08-13T11:27:09.512Z] jom 1.1.3 - empower your cores[2019-08-13T11:27:09.512Z] [2019-08-13T11:27:09.512Z] jom: parallel job execution disabled for Makefile[2019-08-13T11:27:09.512Z] Scanning dependencies of target KF5ThreadWeaver_autogen[2019-08-13T11:27:09.512Z] Scanning dependencies of target KF5ThreadWeaver_QCH[2019-08-13T11:27:09.512Z] [  2%] Automatic MOC for target KF5ThreadWeaver[2019-08-13T11:27:09.769Z] [  2%] Built target KF5ThreadWeaver_autogen[2019-08-13T11:27:09.769Z] [  2%] Generating src/KF5ThreadWeaver.qch, src/KF5ThreadWeaver.tags[2019-08-13T11:27:10.034Z] Scanning dependencies of target KF5ThreadWeaver[2019-08-13T11:27:10.605Z] [ 13%] Built target KF5ThreadWeaver_QCH[2019-08-13T11:27:10.605Z] [  2%] Building CXX object 

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 123 - Failure!

2019-08-13 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/123/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 13 Aug 2019 11:02:52 +
 Build duration:
1 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 355 lines...][2019-08-13T11:04:15.119Z] [ 48%] Automatic MOC for target folding_test[2019-08-13T11:04:15.119Z] [ 50%] Automatic MOC for target testhighlighter_test[2019-08-13T11:04:15.119Z] [ 51%] Automatic MOC for target theme_test[2019-08-13T11:04:15.119Z] [ 52%] Automatic MOC for target wildcardmatcher_test[2019-08-13T11:04:15.119Z] [ 52%] Built target kate-syntax-highlighter_autogen[2019-08-13T11:04:15.119Z] [ 52%] Built target codepdfprinter_autogen[2019-08-13T11:04:15.119Z] Scanning dependencies of target repository_benchmark_autogen[2019-08-13T11:04:15.119Z] [ 53%] Automatic MOC for target repository_benchmark[2019-08-13T11:04:15.119Z] Scanning dependencies of target highlighter_benchmark_autogen[2019-08-13T11:04:15.119Z] [ 55%] Automatic MOC for target highlighter_benchmark[2019-08-13T11:04:15.379Z] [ 55%] Built target codeeditor_autogen[2019-08-13T11:04:15.379Z] [ 55%] Built target wildcardmatcher_test_autogen[2019-08-13T11:04:15.379Z] [ 55%] Built target theme_test_autogen[2019-08-13T11:04:15.379Z] [ 55%] Built target folding_test_autogen[2019-08-13T11:04:15.379Z] [ 55%] Built target htmlhighlighter_test_autogen[2019-08-13T11:04:15.379Z] [ 55%] Built target syntaxrepository_test_autogen[2019-08-13T11:04:15.379Z] Scanning dependencies of target kate-syntax-highlighter[2019-08-13T11:04:15.379Z] [ 55%] Built target testhighlighter_test_autogen[2019-08-13T11:04:15.380Z] [ 56%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter_autogen/mocs_compilation.cpp.o[2019-08-13T11:04:15.380Z] Scanning dependencies of target codeeditor[2019-08-13T11:04:15.380Z] [ 56%] Built target repository_benchmark_autogen[2019-08-13T11:04:15.380Z] Scanning dependencies of target codepdfprinter[2019-08-13T11:04:15.380Z] [ 56%] Built target highlighter_benchmark_autogen[2019-08-13T11:04:15.380Z] [ 57%] Building CXX object src/cli/CMakeFiles/kate-syntax-highlighter.dir/kate-syntax-highlighter.cpp.o[2019-08-13T11:04:15.380Z] Scanning dependencies of target htmlhighlighter_test[2019-08-13T11:04:15.380Z] Scanning dependencies of target wildcardmatcher_test[2019-08-13T11:04:15.380Z] [ 58%] Building CXX object examples/codeeditor/CMakeFiles/codeeditor.dir/codeeditor_autogen/mocs_compilation.cpp.o[2019-08-13T11:04:15.380Z] Scanning dependencies of target folding_test[2019-08-13T11:04:15.380Z] Scanning dependencies of target theme_test[2019-08-13T11:04:15.380Z] [ 60%] Building CXX object examples/codepdfprinter/CMakeFiles/codepdfprinter.dir/codepdfprinter_autogen/mocs_compilation.cpp.o[2019-08-13T11:04:15.380Z] [ 61%] Building CXX object autotests/CMakeFiles/folding_test.dir/folding_test_autogen/mocs_compilation.cpp.o[2019-08-13T11:04:15.380Z] [ 62%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/wildcardmatcher_test_autogen/mocs_compilation.cpp.o[2019-08-13T11:04:15.380Z] [ 63%] Building CXX object autotests/CMakeFiles/htmlhighlighter_test.dir/htmlhighlighter_test_autogen/mocs_compilation.cpp.o[2019-08-13T11:04:15.380Z] Scanning dependencies of target syntaxrepository_test[2019-08-13T11:04:15.380Z] [ 65%] Building CXX object autotests/CMakeFiles/theme_test.dir/theme_test_autogen/mocs_compilation.cpp.o[2019-08-13T11:04:15.380Z] Scanning dependencies of target testhighlighter_test[2019-08-13T11:04:15.380Z] [ 66%] Building CXX object autotests/CMakeFiles/syntaxrepository_test.dir/syntaxrepository_test_autogen/mocs_compilation.cpp.o[2019-08-13T11:04:15.380Z] [ 67%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter_test_autogen/mocs_compilation.cpp.o[2019-08-13T11:04:15.380Z] [ 68%] Building CXX object autotests/CMakeFiles/folding_test.dir/foldingtest.cpp.o[2019-08-13T11:04:15.380Z] [ 71%] Building CXX object autotests/CMakeFiles/theme_test.dir/theme_test.cpp.o[2019-08-13T11:04:15.380Z] [ 71%] Building CXX object autotests/CMakeFiles/htmlhighlighter_test.dir/htmlhighlighter_test.cpp.o[2019-08-13T11:04:15.380Z] [ 72%] Building CXX object autotests/CMakeFiles/wildcardmatcher_test.dir/wildcardmatcher_test.cpp.o[2019-08-13T11:04:15.380Z] [ 73%] Building CXX object examples/codepdfprinter/CMakeFiles/codepdfprinter.dir/codepdfprinter.cpp.o[2019-08-13T11:04:15.380Z] [ 75%] Building CXX object autotests/CMakeFiles/testhighlighter_test.dir/testhighlighter.cpp.o[2019-08-13T11:04:15.380Z] [ 76%] Building CXX object autotests/CMakeFiles/syntaxrepository_test.dir/syntaxrepository_test.cpp.o[2019-08-13T11:04:15.958Z] /home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 SUSEQt5.12/src/cli/kate-syntax-highlighter.cpp: In function ���int main(int, char**)���:[2019-08-13T11:04:15.958Z] /home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 

D21661: add snoretoast backend for KNotifications on Windows

2019-08-13 Thread Volker Krause
vkrause added a comment.


  In D21661#511172 , @brute4s99 
wrote:
  
  > In D21661#510813 , @vkrause 
wrote:
  >
  > > It looks like this made D-Bus and Phonon hard required dependencies on 
Android again!?
  >
  >
  > 
https://cgit.kde.org/knotifications.git/commit/?id=a56a379097d5159f1efa247a109c82e02872dfd2
  >
  > this should fix that.
  
  
  It does, thanks!

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: vkrause, nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns


KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Still unstable!

2019-08-13 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/5/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 13 Aug 2019 10:21:38 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.KNotificationTest

D21661: add snoretoast backend for KNotifications on Windows

2019-08-13 Thread Piyush Aggarwal
brute4s99 added a comment.


  In D21661#510813 , @vkrause wrote:
  
  > It looks like this made D-Bus and Phonon hard required dependencies on 
Android again!?
  
  
  
https://cgit.kde.org/knotifications.git/commit/?id=a56a379097d5159f1efa247a109c82e02872dfd2
  
  this should fix that.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: vkrause, nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns


D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread TrickyRicky
trickyricky26 marked 4 inline comments as done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns


D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-13 Thread TrickyRicky
trickyricky26 updated this revision to Diff 63652.
trickyricky26 added a comment.


  - Fix stylesheet ids

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23116?vs=63626=63652

BRANCH
  fix-depth-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23116

AFFECTED FILES
  icons-dark/actions/22/depth16to8.svg
  icons-dark/actions/22/depth8to16.svg
  icons/actions/22/depth16to8.svg
  icons/actions/22/depth8to16.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns


D23029: Fix the attica pkgconfig file.

2019-08-13 Thread Christophe Giboudeaux
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R235:134e0290cc2f: Fix the attica pkgconfig file. (authored by 
cgiboudeaux).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23029?vs=63354=63648

REVISION DETAIL
  https://phabricator.kde.org/D23029

AFFECTED FILES
  src/CMakeLists.txt
  src/cmake/libKF5Attica.pc.cmake
  src/cmake/libattica.pc.cmake

To: cgiboudeaux
Cc: leinir, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D23112: Add a event Spy for GtkFileChooser recent files

2019-08-13 Thread Méven Car
meven updated this revision to Diff 63647.
meven marked an inline comment as done.
meven added a comment.


  Remove unused include

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63641=63647

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D23112: Add a event Spy for GtkFileChooser recent files

2019-08-13 Thread Méven Car
meven updated this revision to Diff 63641.
meven added a comment.


  Use KServiceTypeTrader to look for apps being used

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63603=63641

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D23112: Add a event Spy for GtkFileChooser recent files

2019-08-13 Thread Méven Car
meven added a comment.


  In D23112#510798 , @broulik wrote:
  
  > Can you check out the `KBookmarks` framework which has classes for 
processing xbel files
  
  
  Thanks for pointing it out.
  I just did, and It does not seem to cover my use case here :
  It is quite heavily oriented towards its main use : application bookmark.
  For instance to get the attributes of the bookmarks elements I would need to 
use the internalElement() method to get a raw QDomElement which kind of defeat 
the purpose of using a library.
  I would also need to parse myself the  elements using 
internalElement as well.
  While user-places.xbel references 
https://www.freedesktop.org/wiki/Specifications/desktop-bookmark-spec/ as its 
specification, it does not abide by it.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart