KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

2019-08-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 15 Aug 2019 02:49:40 + Build duration: 3 min 15 sec and counting JUnit Tests

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 92 - Fixed!

2019-08-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/92/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 15 Aug 2019 02:50:40 + Build duration: 2 min 42 sec and counting BUILD ARTIFACTS

D23159: Prevent error() being emitted when purposefully reading 0 bytes

2019-08-14 Thread Alexander Saoutkin
feverfew added inline comments. INLINE COMMENTS > apol wrote in file.cpp:520 > this should be > > { > Q_EMIT data({});` > return; > } > > I'm not sure that we'd need an empty data emitted then. Are you trying to fix > a specific bug that triggers this? I('ve not seen any

D23163: Remove double check for DBus

2019-08-14 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R289:ffd4373116a8: Remove double check for DBus (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23163?vs=63772=63775 REVISION DETAIL

D23163: Remove double check for DBus

2019-08-14 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. it was just in case.. ;) REPOSITORY R289 KNotifications BRANCH doublecheck REVISION DETAIL https://phabricator.kde.org/D23163 To: nicolasfella, #frameworks, apol Cc: apol,

D23163: Remove double check for DBus

2019-08-14 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Once is enough TEST PLAN builds REPOSITORY R289

D23159: Prevent error() being emitted when purposefully reading 0 bytes

2019-08-14 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > file.cpp:520 > +// Nothing to do... > +return data(QByteArray()); > +} this should be { Q_EMIT data({});` return; } I'm not sure that we'd need an empty data emitted then. Are you trying to fix a specific bug

D23134: fix additionalDeliminator attribute

2019-08-14 Thread jonathan poelen
jpoelen updated this revision to Diff 63771. jpoelen added a comment. - add unit test REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23134?vs=63683=63771 BRANCH fix_wordDelimiters (branched from master) REVISION DETAIL

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

2019-08-14 Thread Aleix Pol Gonzalez
apol added a comment. There's several unrealated changes I'd discourage but the patch looks good overall. +1 INLINE COMMENTS > icoutils_wrestool.cpp:78 > > -if ( name.at(0) == '\'' ) > -name = name.mid(1, name.size()-2); > +if (name.at(0) == QLatin1Char('\''))

D23131: Define install location for JAR/AAR files for Android

2019-08-14 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D23131 To: vkrause, #build_system, #android, apol Cc: apol, kde-frameworks-devel,

D23119: Fix dates being on the wrong locale when setting an application language individually

2019-08-14 Thread Aleix Pol Gonzalez
apol added a comment. LGTM +1 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23119 To: aacid Cc: apol, kde-frameworks-devel, asemke, LeGast00n, michaelh, ngraham, bruns

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Björn Feber
GB_2 added a comment. F7247689: photo5775267645204048231.jpg This would fix the unbalanced icon style in file operation notifications. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23161 To: guoyunhe, #vdg, ndavis,

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Fixed!

2019-08-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 14 Aug 2019 20:18:46 + Build duration: 28 min and counting JUnit Tests Name: projectroot

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Yunhe Guo
guoyunhe added a comment. Yes, I did a search on the internet and almost all popular music app use solid play/pause/stop icon. The outline icon will look like this in JuK: F7247683: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Yunhe Guo
guoyunhe updated this revision to Diff 63763. guoyunhe added a comment. 22px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23161?vs=63762=63763 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23161 AFFECTED FILES

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 91 - Unstable!

2019-08-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/91/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 14 Aug 2019 20:18:46 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 25 - Fixed!

2019-08-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/25/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 14 Aug 2019 20:18:46 + Build duration: 3 min 9 sec and counting BUILD ARTIFACTS

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. We don't strictly adhere to outline or filled style (for better or worse), sometimes making use of both styles in the same icon (e.g., `view-list-icons`). I think the general

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Yunhe Guo
guoyunhe updated this revision to Diff 63762. guoyunhe added a comment. Correct SVG format REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23161?vs=63760=63762 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23161 AFFECTED FILES

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, not sure how I feel about this. I kind of like the filled-in versions. Regardless, please re-add `id="current-color-scheme"` to the CSS, or else the icons will no

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Nathaniel Graham
ngraham added reviewers: VDG, ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23161 To: guoyunhe, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Yunhe Guo
guoyunhe edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23161 To: guoyunhe Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23161: Make media control icons outline style instead of solid style

2019-08-14 Thread Yunhe Guo
guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY In progress. If others think this is the correct way to do it, I can continue with other media control icons and all

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 24 - Failure!

2019-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/24/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 14 Aug 2019 19:07:39 + Build duration: 6 min 56 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 2 - Fixed!

2019-08-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/2/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 14 Aug 2019 19:07:09 + Build duration: 5 min 38 sec and counting JUnit Tests

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Failure!

2019-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 14 Aug 2019 19:07:39 + Build duration: 3 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 90 - Failure!

2019-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/90/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 14 Aug 2019 19:07:39 + Build duration: 5 min 46 sec and counting CONSOLE OUTPUT [...truncated

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

2019-08-14 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R266:c8ebfc2530dd: Fix missing digit and pixel-perfect alignment of depth action icons (authored by Rafael Brandmaier rafael.brandma...@kdemail.net). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST

D23159: Prevent error() being emitted when purposefully reading 0 bytes

2019-08-14 Thread Alexander Saoutkin
feverfew created this revision. feverfew added reviewers: dfaure, fvogt, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY Currently when 0 is passed as a parameter, if the file to be read

D23157: Add technology property to battery interface

2019-08-14 Thread Méven Car
meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D23157 AFFECTED

D22061: Add a logging category for logs warnings

2019-08-14 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R237:403c617eea56: Add a logging category for logs warnings (authored by meven). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=63729=63735 REVISION DETAIL

D22061: Add a logging category for logs warnings

2019-08-14 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R237 KConfig BRANCH arcpatch-D22061 REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks, apol, cgiboudeaux Cc: cgiboudeaux,

D22805: set autorcc and autouic by default

2019-08-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. Patch as is fine with me. But no expert on both flags itself, no idea if there could be sideeffects of having those two now injected as ON to all projects. Possibly best to do global rebuilds of all projects on CI once this lands. REPOSITORY R240 Extra CMake

D23149: Only build tests when DBus is available

2019-08-14 Thread Nicolas Fella
nicolasfella updated this revision to Diff 63732. nicolasfella added a comment. - Fix case REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23149?vs=63712=63732 BRANCH dbustest REVISION DETAIL https://phabricator.kde.org/D23149 AFFECTED FILES

D23149: Only build tests when DBus is available

2019-08-14 Thread Nicolas Fella
nicolasfella marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik, bruns, #frameworks Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23149: Only build tests when DBus is available

2019-08-14 Thread Nicolas Fella
nicolasfella added a comment. Yes, QtDBus is available on Windows, so no change there REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik, bruns, #frameworks Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh,

D23149: Only build tests when DBus is available

2019-08-14 Thread Alexander Potashev
aspotashev added a comment. At least for now Window CI tries and tests something: https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.13/1/console REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik,

D23149: Only build tests when DBus is available

2019-08-14 Thread Alexander Potashev
aspotashev added a comment. Does this mean we cannot test Solid on Windows CI? https://api.kde.org/frameworks/solid/html/ says Solid is supported also on Windows. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik, bruns,

D22061: Add a logging category for logs warnings

2019-08-14 Thread Méven Car
meven added a comment. In D22061#511799 , @cgiboudeaux wrote: > ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should be fine. Should be good now. Thank you for your feedback. REPOSITORY R237 KConfig

D22061: Add a logging category for logs warnings

2019-08-14 Thread Méven Car
meven updated this revision to Diff 63729. meven added a comment. Renamed kconf to kconfig, KCONF to KCONFIG, re-add the mistakenly removed categories file REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=62903=63729 BRANCH arcpatch-D22061

D23103: Add decibel power units (dBW and multiples)

2019-08-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Since there are only two common units in the list right now, adding a third doesn't seem like a disaster. :) @broulik, what do you think? REPOSITORY R292 KUnitConversion BRANCH

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-14 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-14 Thread Méven Car
meven marked an inline comment as done. meven added a comment. In D23112#511779 , @ngraham wrote: > Cool stuff. Does it handle duplicates when a file is present in both GTKFileChooserRecent and KActivitiesStats? Yes, the file url is a

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-14 Thread Méven Car
meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in kactivitymanagerd-plugin-gtk-eventspy.json:41 > Not sure you need to add translations of your own name here This was done for Ivan so I guess the translation team fills this. REPOSITORY

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-14 Thread Méven Car
meven updated this revision to Diff 63724. meven added a comment. grammar REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63713=63724 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED FILES

D22805: set autorcc and autouic by default

2019-08-14 Thread Volker Krause
vkrause added a comment. I'm happy with this, +2 from my side. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham,

D22805: set autorcc and autouic by default

2019-08-14 Thread Christophe Giboudeaux
cgiboudeaux added a comment. @kossebau @vkrause @apol something else to change? INLINE COMMENTS > KDECMakeSettings.cmake:82 > +# - CMAKE_AUTORCC and CMAKE_AUTOUIC enabled by default when supported by > cmake > +# (>= 3.0) since 5.61.0 > # 5.62 now REPOSITORY R240 Extra CMake Modules

D22061: Add a logging category for logs warnings

2019-08-14 Thread Christophe Giboudeaux
cgiboudeaux added a comment. ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should be fine. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks, apol Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n,

D23149: Only build tests when DBus is available

2019-08-14 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > CMakeLists.txt:127 > add_subdirectory(src) > -if (BUILD_TESTING) > +if (TARGET QT5::DBus AND BUILD_TESTING) > add_subdirectory(autotests) Qt5::DBus, not sure if this is case-sensitive, if it is this would disable the tests for everyone I

D23103: Add decibel power units (dBW and multiples)

2019-08-14 Thread Ismael Asensio
iasensio marked an inline comment as done. iasensio added a comment. Well, in my field of work (telephony, radar and radio signal transmission) it makes totally sense (altought Terawatts would be major words ). It is a non trivial conversion that we make quite frequently. If the

D22699: Support passing target to ecm_qt_declare_logging_category

2019-08-14 Thread Christophe Giboudeaux
cgiboudeaux set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22699 To: daandemeyer, alexmerry Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh,

D22709: Support passing target to ecm_add_app_icon.

2019-08-14 Thread Christophe Giboudeaux
cgiboudeaux added a comment. -1. This shall be compliant with the minimum ECM version set in the project. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22709 To: daandemeyer, alexmerry, dschmidt Cc: cgiboudeaux, kde-frameworks-devel,

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-14 Thread Nathaniel Graham
ngraham added a comment. Cool stuff. Does it handle duplicates when a file is present in both GTKFileChooserRecent and KActivitiesStats? INLINE COMMENTS > kactivitymanagerd-plugin-gtk-eventspy.json:41 > +"Name[zh_CN]": "Méven Car", > +"Name[zh_TW]": "Méven

D23103: Add decibel power units (dBW and multiples)

2019-08-14 Thread Nathaniel Graham
ngraham added a comment. Works just fine, but by adding dBm as a common unit, it's now the first t hing that shows up when I convert watts: F7247005: Screenshot_20190814_070401.png Seems a little odd to me, not being an audio professional.

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-14 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-14 Thread Méven Car
meven marked 5 inline comments as done. meven added inline comments. INLINE COMMENTS > ivan wrote in GtkEventSpy.cpp:143 > Let's hope commands will never have spaces in them :) It is to just extract the executable name, we don't want to have an exploding number of initiatingAgent for every

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-14 Thread Méven Car
meven updated this revision to Diff 63713. meven added a comment. Add const where need be, simplify KTrader query REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63669=63713 BRANCH master REVISION DETAIL

D23149: Only build tests when DBus is available

2019-08-14 Thread Nicolas Fella
nicolasfella added reviewers: bcooksley, broulik, bruns, Frameworks. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik, bruns, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23149: Only build tests when DBus is available

2019-08-14 Thread Nicolas Fella
nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The tests require DBus REPOSITORY R245 Solid BRANCH dbustest REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

2019-08-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 14 Aug 2019 10:03:47 + Build duration: 16 min and counting JUnit Tests Name: projectroot

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-14 Thread Méven Car
meven added a comment. In D23112#511354 , @ivan wrote: > Thanks for geting involved this much! :D REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc:

D23147: KRun: fix runtime warning when widget is null

2019-08-14 Thread David Faure
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23147 To: dfaure, nicolasfella, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23147: KRun: fix runtime warning when widget is null

2019-08-14 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23147 To: dfaure, nicolasfella, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23134: fix additionalDeliminator attribute

2019-08-14 Thread Dominik Haumann
dhaumann added a comment. Could you add a unit test for this? - add the dummy xml similar to the one in the bug report. This can be done by using the additional search folder in the Repository. - add a test highlighting like done with the others The so only when the unit tests

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

2019-08-14 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks. Removing hardcoded colors would also be nice :-) REPOSITORY R216 Syntax Highlighting BRANCH gettext (branched from master) REVISION DETAIL

D23147: KRun: fix runtime warning when widget is null

2019-08-14 Thread David Faure
dfaure created this revision. dfaure added reviewers: nicolasfella, vkrause. Herald added a project: Frameworks. dfaure requested review of this revision. REVISION SUMMARY I wanted the connection to be broken if the widget was deleted early, but if there's no widget then Qt warns about a null

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-14 Thread Kai Uwe Broulik
broulik added a comment. Then please investigate what's going on there. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14632: keyword rule: Spport for keywords inclusion from another language/file

2019-08-14 Thread Dominik Haumann
dhaumann added a comment. What just came to my mind is that this patch also has an issue: If you include a keyword list of a.xml in b.xml, and a.xml uses different word delimiters for the keyword list, then the keywords in b.xml will not be highlighted/detected correctly. Did we think

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-14 Thread Piyush Aggarwal
brute4s99 added a comment. the duplicate notification always has id= -1, so I think it's more an issue of KNotifications, I think REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n,

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

2019-08-14 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: vonreth, pali, antlarr, bruns. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY 16 bit executables don't have `--language` in

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

2019-08-14 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > klistopenfiles.cpp:26 > + > +void listProcessesWithOpenFiles(QDir path, Callback callback) > +{ Can you allow passing an optional context object, so when the caller gets deleted, you don't crash when the reply comes in? REPOSITORY R244

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-14 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > GtkEventSpy.cpp:135 > +// See > https://techbase.kde.org/Development/Tutorials/Services/Traders#The_KTrader_Query_Language > +QString query = QString("exist Exec and ((Exec ~~ '%1') or (exist > GenericName and '%1' ~~

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-14 Thread Kai Uwe Broulik
broulik added a comment. I think this is a bug in KDE Connect? I've seen numerous people complain about that in the new notification system that didn't filter them out originally. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99,