D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

sredman added a comment. In D22727#513842 , @dfaure wrote: > The truth is stronger than "I would not recommend". > put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the

D23249: Change radio to device icon, add more sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R266:5637b119d95d: Change radio to device icon, add more sizes (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23249?vs=64004=64006 REVISION

D23249: Change radio to device icon, add more sizes

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH radio (branched from master) REVISION DETAIL https://phabricator.kde.org/D23249 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23249 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23249 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23249 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Used by D21525 (Elisa). The previous version of this

D23188: Fix supported OS attributes for api.kde.org

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D23188 To: vkrause, #frameworks, apol Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, mart, hein

D23245: New syntax: SASS. Some fixes for CSS and SCSS

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY CSS, SCSS (CSS4): - number in scientific notation: `12.3e3` - hexadecimal

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 63984. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63981=63984 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES src/notifybysnore.cpp To: brute4s99,

D23196: have the app icon as fallback icon in Snore

brute4s99 marked 2 inline comments as done. REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 63981. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63888=63981 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES src/CMakeLists.txt

clang-format file for KDE Frameworks coding style?

Hi, is there some pre-defined clang-format file for our coding rules? I would like to use that for ktexteditor & kate but only found astyle/uncrustify stuff. Qt seems to have some "semi-official" file for their style https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format Greetings Christoph

D23200: Fixes a crash in Peruse triggered by baloo

poboiko added a comment. AFAIK `canonicalFilePath()` cannot return path without slash. The result is either empty (if path does not exist; this is covered by first `if`), or a proper path. The second check is redundant. REPOSITORY R293 Baloo BRANCH fixCrashWithEmptyFolder REVISION

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/26/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 18 Aug 2019 10:23:05 + Build duration: 27 min and counting BUILD ARTIFACTS

D23224: Fix capitalization of Nextcloud

z3ntu added a comment. No, I don't have any rights here. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D23224 To: z3ntu, nicolasfella, apol Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 150 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/150/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 18 Aug 2019 10:23:05 + Build duration: 8 min 34 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 18 Aug 2019 10:23:05 + Build duration: 7 min 38 sec and counting JUnit Tests Name:

D23225: Allow 0 in line ranges in vim mode.

This revision was automatically updated to reflect the committed changes. Closed by commit R39:066004396d57: fix vi mode unit test (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23225?vs=63944=63973#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23188: Fix supported OS attributes for api.kde.org

vkrause added inline comments. INLINE COMMENTS > apol wrote in metainfo.yaml:12 > Isn't it called macOS nowadays? Or is it a keyword we have that we'd need to > change elsewhere? See commit message, yes. We'd need to change it everywhere in order to show up as a single "macOS" entry on

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/32/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 18 Aug 2019 03:02:11 + Build duration: 6 hr 3 min and counting JUnit Tests Name: projectroot

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

dfaure added a comment. The truth is stronger than "I would not recommend". put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.