D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Simon Redman]

sredman added a comment.


  In D22727#513842 , @dfaure wrote:
  
  > The truth is stronger than "I would not recommend".
  >  put() in SlaveBase-derived classes is called by the KIO library 
(TransferJob), so you CANNOT change the meaning of the arguments. It's part of 
the API/ABI for all slaves, and this cannot change until KF6.
  
  
  +1
  
  But it is worth making a note of this as something to change (or discuss 
changing) for KF6 since it seems like using the Qt constants would be a better 
design

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D23249: Change radio to device icon, add more sizes

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:5637b119d95d: Change radio to device icon, add more sizes 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23249?vs=64004&id=64006

REVISION DETAIL
  https://phabricator.kde.org/D23249

AFFECTED FILES
  icons-dark/devices/16/audio-radio.svg
  icons-dark/devices/16/radio.svg
  icons-dark/devices/22/audio-radio.svg
  icons-dark/devices/22/radio.svg
  icons-dark/devices/symbolic/audio-radio-symbolic.svg
  icons-dark/mimetypes/16/radio.svg
  icons/devices/16/audio-radio.svg
  icons/devices/16/radio.svg
  icons/devices/22/audio-radio.svg
  icons/devices/22/radio.svg
  icons/devices/symbolic/audio-radio-symbolic.svg
  icons/mimetypes/16/radio.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  radio (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23249

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23249

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23249

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23249

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Used by D21525  (Elisa). The previous 
version of this icon was a blue 16px only mimetype icon. As far as I know, it 
was only used by Banshee, which is abandoned.

REPOSITORY
  R266 Breeze Icons

BRANCH
  radio (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23249

AFFECTED FILES
  icons-dark/devices/16/audio-radio.svg
  icons-dark/devices/16/radio.svg
  icons-dark/devices/22/audio-radio.svg
  icons-dark/devices/22/radio.svg
  icons-dark/devices/symbolic/audio-radio-symbolic.svg
  icons-dark/mimetypes/16/radio.svg
  icons/devices/16/audio-radio.svg
  icons/devices/16/radio.svg
  icons/devices/22/audio-radio.svg
  icons/devices/22/radio.svg
  icons/devices/symbolic/audio-radio-symbolic.svg
  icons/mimetypes/16/radio.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23188: Fix supported OS attributes for api.kde.org

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23188

To: vkrause, #frameworks, apol
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein

D23245: New syntax: SASS. Some fixes for CSS and SCSS

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  CSS, SCSS (CSS4):
  
  - number in scientific notation: `12.3e3`
  - hexadecimal rgba: `#fffa` and `#ffaa`
  - new units: cap,ic,lh,rlh,vi,vb,vmin,vmax,Q,in,dpi,dpcm,dppx,x
  - remove unknown unit: vm
  - new pseudo selector: matches
  
  SCSS:
  
  - fix nested function
  - fix `...` as operator
  - fix interpolation as property
  
  SASS:
  
  - new syntax
  
  BUG: 149313

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23245

AFFECTED FILES
  autotests/folding/highlight.sass.fold
  autotests/folding/highlight.scss.fold
  autotests/html/highlight.css.html
  autotests/html/highlight.sass.html
  autotests/html/highlight.scss.html
  autotests/html/review128925-1.scss.html
  autotests/input/highlight.sass
  autotests/input/highlight.scss
  autotests/reference/highlight.css.ref
  autotests/reference/highlight.sass.ref
  autotests/reference/highlight.scss.ref
  autotests/reference/review128925-1.scss.ref
  data/syntax/css.xml
  data/syntax/sass.xml
  data/syntax/scss.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63984.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=63981&id=63984

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 marked 2 inline comments as done.

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 63981.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=63888&id=63981

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/CMakeLists.txt
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

clang-format file for KDE Frameworks coding style?

[Christoph Cullmann]

Hi,

is there some pre-defined clang-format file for our coding rules?

I would like to use that for ktexteditor & kate but only found 
astyle/uncrustify stuff.


Qt seems to have some "semi-official" file for their style

https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format

Greetings
Christoph

--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org

D23200: Fixes a crash in Peruse triggered by baloo

[Igor Poboiko]

poboiko added a comment.


  AFAIK `canonicalFilePath()` cannot return path without slash. The result is 
either empty (if path does not exist; this is covered by first `if`), or a 
proper path. The second check is redundant.

REPOSITORY
  R293 Baloo

BRANCH
  fixCrashWithEmptyFolder

REVISION DETAIL
  https://phabricator.kde.org/D23200

To: tcanabrava, #baloo, astippich, bruns, poboiko, ngraham
Cc: ngraham, kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 26 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/26/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 18 Aug 2019 10:23:05 +
 Build duration:
27 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.62.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33306/48959)51%
(15802/31229)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4769/5064)49%
(1808/3662)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5475/5516)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1210/1598)src.completion100%
(11/11)100%
(11/11)57%
(1783/3125)43%
(1166/2733)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(75/346)src.dialogs0%
(0/4)0%
(0/4)0%
(0/848)0%
(0/220)src.document100%
(4/4)100%
(4/4)61%
(1941/3185)50%
(1598/3215)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode88%
(7/8)88%
(7/8)37%
(306/837)21%
(150/729)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/860)0%
(0/296)src.render100%
(7/7)100%
(7/7)77%
(949/1238)66%
(603/910)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%

D23224: Fix capitalization of Nextcloud

[Luca Weiss]

z3ntu added a comment.


  No, I don't have any rights here.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu, nicolasfella, apol
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 150 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/150/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 18 Aug 2019 10:23:05 +
 Build duration:
8 min 34 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.62.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33304/48959)51%
(15801/31229)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4769/5064)49%
(1808/3662)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5475/5516)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1210/1598)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2733)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(75/346)src.dialogs0%
(0/4)0%
(0/4)0%
(0/848)0%
(0/220)src.document100%
(4/4)100%
(4/4)61%
(1941/3185)50%
(1598/3215)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode88%
(7/8)88%
(7/8)37%
(306/837)21%
(150/729)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/860)0%
(0/296)src.render100%
(7/7)100%
(7/7)77%
(949/1238)66%
(603/910)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%
 

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/22/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 18 Aug 2019 10:23:05 +
 Build duration:
7 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D23225: Allow 0 in line ranges in vim mode.

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:066004396d57: fix vi mode unit test (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23225?vs=63944&id=63973#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23225?vs=63944&id=63973

REVISION DETAIL
  https://phabricator.kde.org/D23225

AFFECTED FILES
  autotests/src/vimode/emulatedcommandbar.cpp

To: verner, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23188: Fix supported OS attributes for api.kde.org

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> apol wrote in metainfo.yaml:12
> Isn't it called macOS nowadays? Or is it a keyword we have that we'd need to 
> change elsewhere?

See commit message, yes. We'd need to change it everywhere in order to show up 
as a single "macOS" entry on api.kde.org. Alternatively we implement some form 
of OS normalization/mapping in kapidox.

IOW, this change improves the api.kde.org OS list from the current "Android | 
FreeBSD | Linux | MacOSX | Windows | iOS (maintainer needed) | macOS 
(maintainer needed)" to "Android | FreeBSD | Linux | MacOSX | Windows | iOS". 
Getting it to the ultimately correct "Android | FreeBSD | Linux | macOS | 
Windows | iOS" is a further change.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23188

To: vkrause, #frameworks
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/32/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 18 Aug 2019 03:02:11 +
 Build duration:
6 hr 3 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[David Faure]

dfaure added a comment.


  The truth is stronger than "I would not recommend".
  put() in SlaveBase-derived classes is called by the KIO library 
(TransferJob), so you CANNOT change the meaning of the arguments. It's part of 
the API/ABI for all slaves, and this cannot change until KF6.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov