D23313: improve code in Snore backend

[Kai Uwe Broulik]

broulik added a comment.


  I don't really see the point in this cleanup as it only messes up git history 
and doesn't actually follow coding style better

INLINE COMMENTS

> notifybysnore.cpp:141
> +
> +void NotifyBySnore::notify(KNotification* notification, KNotifyConfig 
> *config)
> +{

The previous coding style was correct, asterisk goes with the name, not the 
type.

> notifybysnore.cpp:162
> +
> +const QString iconPath = m_iconDir.path() + QLatin1Char('/') +
> + QString::number(notification->id()) + 
> QStringLiteral(".png");

Plus goes on a new line so you can see without horizontally scroling what 
operator is being used:

  foo = bar
  + baz

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23313

To: brute4s99, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 96 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/96/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 21 Aug 2019 03:03:52 +
 Build duration:
2 min 58 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.62.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)21%
(461/2245)18%
(178/999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)60%
(60/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
  

D23313: improve code in Snore backend

[Piyush Aggarwal]

brute4s99 created this revision.
brute4s99 added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23313

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23312: JSP: support of

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  BUG: 345003

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  jsp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23312

AFFECTED FILES
  autotests/folding/highlight.jsp.fold
  autotests/html/highlight.jsp.html
  autotests/input/highlight.jsp
  autotests/reference/highlight.jsp.ref
  data/syntax/jsp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23278: LESS: import CSS keywords, new highlighting and some improvements

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:63719f49867b: LESS: import CSS keywords, new highlighting 
and some improvements (authored by jpoelen).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23278?vs=64078&id=64182#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23278?vs=64078&id=64182

REVISION DETAIL
  https://phabricator.kde.org/D23278

AFFECTED FILES
  autotests/html/highlight.less.html
  autotests/reference/highlight.less.ref
  data/syntax/less.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23278: LESS: import CSS keywords, new highlighting and some improvements

[jonathan poelen]

jpoelen added a comment.


  The other files that use the include statement are also in version 5.53.
  
  If highlightingindexer adds a version check, it is also necessary to check 
that the included files are of the same or lower version. Ideally, this should 
also be done for IncludeRules.
  
  I also note 2 additional changes that can be verified:
  
  - caseinsensitive WordDetect -> 5.44
  - '!' with context and fallthroughContext -> 5.40

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  less (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23278

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23119: Fix dates being on the wrong locale when setting an application language individually

[Albert Astals Cid]

aacid updated this revision to Diff 64176.
aacid edited the summary of this revision.
aacid removed a subscriber: ltoscano.
aacid added a comment.


  update commit log

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23119?vs=63633&id=64176

BRANCH
  arcpatch-D23119

REVISION DETAIL
  https://phabricator.kde.org/D23119

AFFECTED FILES
  autotests/kxmlgui_unittest.cpp
  src/kswitchlanguagedialog_p.cpp

To: aacid
Cc: apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, ngraham, 
bruns, ltoscano

D23119: Fix dates being on the wrong locale when setting an application language individually

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> asemke wrote in kxmlgui_unittest.cpp:1089
> does this test work? The name of the month is "январь" in russian, not 
> "января".

Declensions: 
https://en.wiktionary.org/wiki/%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8C#Declension

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: ltoscano, apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> asemke wrote in kxmlgui_unittest.cpp:1089
> does this test work? The name of the month is "январь" in russian, not 
> "января".

Yes, it may surprise you, but i did actually run the tests before submitting 
this code change.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23286: Prevent dragging SimpleKCM contents outside view

[Björn Feber]

GB_2 abandoned this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg, davidedmundson
Cc: ngraham, filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, 
LeGast00n, GB_2, michaelh, bruns

D23286: Prevent dragging SimpleKCM contents outside view

[Nathaniel Graham]

ngraham added a comment.


  Ah ok.

REPOSITORY
  R296 KDeclarative

BRANCH
  prevent-dragging-simplekcm-contents-outside-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg, davidedmundson
Cc: ngraham, filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, 
LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Interesting design! However having that triangular part jutting out of the 
side is pretty unusual, and not seen in any other MimeType icons. Maybe move 
that shape fully inside and copy the visual style of existing book-style icons, 
such as `application-pdf` `application-epub+zip` . Generally they have a sort 
of book-like appearance with a line on the left side for the book's spine.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> kwindowsystem.cpp:458
>  
> +static QWindow* setMainWindowHelper(QWindow *subWindow, WId mainWindowId)
> +{

Coding style: For pointers or references, use a single space before '*' or '&', 
but not after.

https://techbase.kde.org/Policies/Frameworks_Coding_Style#Whitespace

> kwindowsystem.cpp:490
> +{
> +(void) setMainWindowHelper(subWindow, mainWindowId);
>  }

Each time this method is called a new foreign QWindow object will be created. 
Can you please explain why leaking those objects is okay?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23108

To: dfaure, broulik, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor updated this revision to Diff 64152.
yurchor added a comment.


  Remove extra font dependencies

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64148&id=64152

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23300: Add FictionBook 2 icons

[Yuri Chornoivan]

yurchor created this revision.
yurchor added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  FictionBook 2 icons from Okular (design by Vladimir Prohorenkov, my 
implementation).

TEST PLAN
  See the image attached.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23286: Prevent dragging SimpleKCM contents outside view

[Björn Feber]

GB_2 added a comment.


  > This would disable it when using a touch swipe or a touchpad on the desktop 
too though, right? That doesn;t seem desirable. I think we on;y want scroll 
overshoot disabled when using a scroll wheel; for all other cases, IMO it 
should be on.
  
  That's how it is now, but click and drag lets you overshoot infinitely.

REPOSITORY
  R296 KDeclarative

BRANCH
  prevent-dragging-simplekcm-contents-outside-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg, davidedmundson
Cc: ngraham, filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, 
LeGast00n, GB_2, michaelh, bruns

D23286: Prevent dragging SimpleKCM contents outside view

[Nathaniel Graham]

ngraham added a comment.


  In D23286#515329 , @GB_2 wrote:
  
  > I will fix it there, but it won't disable click and drag to scroll the view 
if it's scrollable. It just disables click and drag scroll when there is no 
scrollbar
  
  
  Right, that's fine.
  
  > and disables the scroll overshoot on desktop.
  
  This would disable it when using a touch swipe or a touchpad on the desktop 
too though, right? That doesn;t seem desirable. I think we on;y want scroll 
overshoot disabled when using a scroll wheel; for all other cases, IMO it 
should be on.

REPOSITORY
  R296 KDeclarative

BRANCH
  prevent-dragging-simplekcm-contents-outside-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg, davidedmundson
Cc: ngraham, filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, 
LeGast00n, GB_2, michaelh, bruns

D23286: Prevent dragging SimpleKCM contents outside view

[Björn Feber]

GB_2 added a comment.


  In D23286#515322 , @ngraham wrote:
  
  > +1, but maybe this doesn't go far enough. How about doing it for 
`ScrollablePage` instead? That would fix 
https://bugs.kde.org/show_bug.cgi?id=403837 as well as this.
  
  
  I will fix it there, but it won't disable click and drag to scroll the view 
if it's scrollable. It just disables click and drag scroll when there is no 
scrollbar and disables the scroll overshoot on desktop.

REPOSITORY
  R296 KDeclarative

BRANCH
  prevent-dragging-simplekcm-contents-outside-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg, davidedmundson
Cc: ngraham, filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, 
LeGast00n, GB_2, michaelh, bruns

D23286: Prevent dragging SimpleKCM contents outside view

[Nathaniel Graham]

ngraham added a comment.


  +1, but maybe this doesn't go far enough. How about doing it for 
`ScrollablePage` instead? That would fix 
https://bugs.kde.org/show_bug.cgi?id=403837 as well as this.

REPOSITORY
  R296 KDeclarative

BRANCH
  prevent-dragging-simplekcm-contents-outside-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg, davidedmundson
Cc: ngraham, filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, 
LeGast00n, GB_2, michaelh, bruns

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> kfileplacesview.cpp:1089
>  // it after the remove only).
>  connect(model, SIGNAL(rowsRemoved(QModelIndex,int,int)),
>  this, SLOT(adaptItemSize()), Qt::QueuedConnection);

I think David F means you should connect here and expunge dead entries.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16311

To: broulik, #frameworks, dfaure, lbeltrame
Cc: davidedmundson, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

[Kai Uwe Broulik]

broulik added a comment.


  In D16311#353808 , @dfaure wrote:
  
  > This map will keep growing and growing...
  
  
  Are you sure? It didn't grow during my testing, even after moving places 
around and adding and removing items. It could always identify the same 
`QPersistentModelIndex`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16311

To: broulik, #frameworks, dfaure, lbeltrame
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

brute4s99 added a comment.


  landed it! F7262311: shufflefurtherparrot.gif 


REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks, broulik
Cc: nicolasfella, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:a9b61d5b0cb8: avoid duplicate notifications from showing 
up on Windows and remove whitespaces (authored by brute4s99).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23133?vs=63846&id=64122#toc

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23133?vs=63846&id=64122

REVISION DETAIL
  https://phabricator.kde.org/D23133

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, #frameworks, broulik
Cc: nicolasfella, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

brute4s99 added a subscriber: nicolasfella.
brute4s99 added a comment.


  In D23133#515156 , @ngraham wrote:
  
  > Just on Windows, or does this fix the problem on Linux too?
  
  
  that problem has been fixed by @nicolasfella on master of kdeconnect-kde .
  
  This bug was a backend specific issue of the windows build, unrelated to that 
bug. 🐛

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks, broulik
Cc: nicolasfella, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Nathaniel Graham]

ngraham added a comment.


  Just on Windows, or does this fix the problem on Linux too?

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks, broulik
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23196: have 1024x1024 app icon as fallback icon in Snore

[Piyush Aggarwal]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:e96bf17d8cac: have 1024x1024 app icon as fallback icon in 
Snore (authored by brute4s99).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=64119&id=64120

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have 1024x1024 app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64119.
brute4s99 added a comment.


  changed line endings to Unix style

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=64115&id=64119

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23291: have application's icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64118.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23291?vs=64116&id=64118

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23291

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23291: have application's icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23291

To: brute4s99
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23291: have application's icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23291

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23196: have 1024x1024 app icon as fallback icon in Snore

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have 1024x1024 app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 added a comment.


  landing it! F7262311: shufflefurtherparrot.gif 


REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have 1024x1024 app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64115.
brute4s99 retitled this revision from "have the app icon as fallback icon in 
Snore" to "have 1024x1024 app icon as fallback icon in Snore".
brute4s99 added a comment.


  removed `actualSize` in favour of always passing an icon of size 1024x1024 to 
SnoreToast

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=64114&id=64115

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64114.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=64113&id=64114

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64113.
brute4s99 added a comment.


  rebased

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23196?vs=63984&id=64113

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23196: have the app icon as fallback icon in Snore

[Piyush Aggarwal]

brute4s99 added a comment.


  landing it! F7262311: shufflefurtherparrot.gif 


REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:ee5c3d12f965: add `-pid` parameter to Snore backend calls 
(authored by brute4s99).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23282?vs=64111&id=64112

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64111.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23282?vs=64110&id=64111

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 64110.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23282?vs=64085&id=64110

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

AFFECTED FILES
  src/notifybysnore.cpp

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

brute4s99 added a comment.


  had some non-unix line endings, so updated the diff.

REPOSITORY
  R289 KNotifications

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23047: Properly turn real into integer

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23047

To: apol, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

[Piyush Aggarwal]

brute4s99 added a comment.


  landing it! F7262311: shufflefurtherparrot.gif 


REPOSITORY
  R289 KNotifications

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23286: Prevent dragging SimpleKCM contents outside view

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  prevent-dragging-simplekcm-contents-outside-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg, davidedmundson
Cc: filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, 
LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/11/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 20 Aug 2019 11:32:59 +
 Build duration:
3 min 16 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D23149: Only build tests when DBus is available

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:f7149af10e4b: Only build tests when DBus is available 
(authored by nicolasfella).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23149?vs=63732&id=64104

REVISION DETAIL
  https://phabricator.kde.org/D23149

AFFECTED FILES
  CMakeLists.txt

To: nicolasfella, bcooksley, broulik, bruns, #frameworks, apol
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23124: Remove unused DBus XML file

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:ee235f11c13a: Remove unused DBus XML file (authored by 
nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23124?vs=63655&id=64103

REVISION DETAIL
  https://phabricator.kde.org/D23124

AFFECTED FILES
  src/org.kde.KNotify.xml

To: nicolasfella, #frameworks, broulik, vkrause
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23149: Only build tests when DBus is available

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  dbustest

REVISION DETAIL
  https://phabricator.kde.org/D23149

To: nicolasfella, bcooksley, broulik, bruns, #frameworks, apol
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23272: JavaScript: remove unnecessary "Conditional Expression" context

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:4bc333ee2509: JavaScript: remove unnecessary 
"Conditional Expression" context (authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23272?vs=64068&id=64102

REVISION DETAIL
  https://phabricator.kde.org/D23272

AFFECTED FILES
  autotests/folding/test.htm.fold
  autotests/html/test.htm.html
  autotests/input/test.htm
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.qml.ref
  autotests/reference/test.htm.ref
  data/syntax/javascript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22946: Include API to generically implement --replace arguments

[Aleix Pol Gonzalez]

apol added a comment.


  ping

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23047: Properly turn real into integer

[Aleix Pol Gonzalez]

apol added a comment.


  ping

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D23047

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23285: Prevent dragging QQC2 ComboBox contents outside menu

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:ec1b5c60c19f: Prevent dragging QQC2 ComboBox contents 
outside menu (authored by GB_2).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23285?vs=64092&id=64099

REVISION DETAIL
  https://phabricator.kde.org/D23285

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: GB_2, #plasma, #frameworks, #vdg, filipf, apol
Cc: #vdg, #frameworks, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko added a comment.


  Mm, any changes?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23061

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, GB_2, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann

D23285: Prevent dragging QQC2 ComboBox contents outside menu

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  prevent-dragging-qqc2-combobox-contents-outside-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23285

To: GB_2, #plasma, #frameworks, #vdg, filipf, apol
Cc: #vdg, #frameworks, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23286: Prevent dragging SimpleKCM contents outside view

[Björn Feber]

GB_2 updated this revision to Diff 64096.
GB_2 added a comment.


  Only affect desktop

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23286?vs=64094&id=64096

BRANCH
  prevent-dragging-simplekcm-contents-outside-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23286

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: GB_2, #plasma, #frameworks, #vdg
Cc: filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D23262: disable autouic again - it breaks builds

[Harald Sitter]

sitter added a comment.


  https://gitlab.kitware.com/cmake/cmake/issues/19615

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23262

To: sitter, apol, nicolasfella, cullmann
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D23286: Prevent dragging SimpleKCM contents outside view

[Filip Fila]

filipf added a comment.


  +1 visually
  
  If the behavior is important on mobile let's keep it there of course, but on 
desktop it feel out of place.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg
Cc: filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D23286: Prevent dragging SimpleKCM contents outside view

[Kai Uwe Broulik]

broulik added a comment.


  Can we keep it on mobile?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg
Cc: broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D23286: Prevent dragging SimpleKCM contents outside view

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  You should not be able to drag the contents outside the view, it looks weird. 
This fixes it.

TEST PLAN
  Open the {Fonts} KCM and try dragging the contents outside the view. It 
should not be possible anymore.

REPOSITORY
  R296 KDeclarative

BRANCH
  prevent-dragging-simplekcm-contents-outside-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23286

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: GB_2, #plasma, #frameworks, #vdg
Cc: #vdg, #frameworks, kde-frameworks-devel, #plasma, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D23286: Prevent dragging SimpleKCM contents outside view

[Björn Feber]

GB_2 edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg
Cc: #vdg, #frameworks, kde-frameworks-devel, #plasma, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D23285: Prevent dragging QQC2 ComboBox contents outside menu

[Björn Feber]

GB_2 edited the test plan for this revision.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  prevent-dragging-qqc2-combobox-contents-outside-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23285

To: GB_2, #plasma, #frameworks, #vdg, filipf
Cc: #vdg, #frameworks, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23282: add `-pid` parameter to Snore backend calls

[Hannah von Reth]

vonreth accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23282

To: brute4s99, #kde_connect, #frameworks, vonreth
Cc: kde-frameworks-devel, vonreth, LeGast00n, GB_2, michaelh, ngraham, bruns

D23285: Prevent dragging QQC2 ComboBox contents outside menu

[Filip Fila]

filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  prevent-dragging-qqc2-combobox-contents-outside-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23285

To: GB_2, #plasma, #frameworks, #vdg, filipf
Cc: #vdg, #frameworks, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23285: Prevent dragging QQC2 ComboBox contents outside menu

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, Frameworks, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  You should not be able to drag the items outside the menu, it looks weird. 
This fixes it.

TEST PLAN
  Run the `testComboBox.qml` test and try dragging the items outside the menu. 
It should not work anymore.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  prevent-dragging-qqc2-combobox-contents-outside-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23285

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: GB_2, #plasma, #frameworks, #vdg
Cc: #vdg, #frameworks, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11554: Add warnings to why some actions might be invalid

[Méven Car]

meven added inline comments.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.

INLINE COMMENTS

> kauthaction.cpp:126
> +if (!d->valid)
> +qCWarning(KAUTH) << "Backend does not recognize action: " << 
> name;
>  } else {

Code style, use {} even for one liner.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D11554

To: carewolf, vkrause
Cc: kde-frameworks-devel, meven, LeGast00n, michaelh, ngraham, bruns, 
#frameworks

D11554: Add warnings to why some actions might be invalid

[Méven Car]

meven added a reviewer: Frameworks.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D11554

To: carewolf, vkrause, #frameworks
Cc: kde-frameworks-devel, meven, LeGast00n, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven added a comment.


  I'v added @dfaure as reviewer.
  
  David feel free to not review this if you think somebody else would be better 
suited.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven added a reviewer: dfaure.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan

[Méven Car]

meven added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  ping @dfaure
  
  Is it still valid ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5856

To: dfaure, aacid
Cc: kde-frameworks-devel, meven, LeGast00n, michaelh, ngraham, bruns, 
#frameworks

D13757: Move parsing .desktop file for folder Comment to file KIO

[Kai Uwe Broulik]

broulik added a comment.


  Theres's also the directory icon reading which potentially blocks, so doing 
both in the KIO slave improves the situation without having to introduce new 
API and rewrite everything and the kitchen sink.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13757

To: broulik, dfaure, lbeltrame
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23272: JavaScript: remove unnecessary "Conditional Expression" context

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks very reasonable to me, thanks.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  javascript

REVISION DETAIL
  https://phabricator.kde.org/D23272

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23278: LESS: import CSS keywords, new highlighting and some improvements

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Lgtm.
  
  Btw, do all highlighting files using the include statement in lists use 
kateversion="5.53"? If not, we should fix it. In fact, we should extend our 
highlightingindexer to check this...

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  less (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23278

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/12/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 20 Aug 2019 06:59:16 +
 Build duration:
1 min 2 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest