KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 21 - Unstable!

2019-08-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/21/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 27 Aug 2019 05:48:04 + Build duration: 6 min 43 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 68 - Unstable!

2019-08-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/68/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 27 Aug 2019 05:48:04 + Build duration: 7 min 12 sec and counting BUILD ARTIFACTS

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

2019-08-26 Thread Christoph Cullmann
cullmann added a comment. Please only add the isAcceptableInputText with the event. We only need to check that for the keyboard input in KateViewInternal::keyPressEvent(QKeyEvent *e). And there we don't need to do this for the \t tab insertion, makes no sense, we want to add there a \t

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

2019-08-26 Thread Dominik Haumann
dhaumann added a comment. In D23472#519774 , @ahmadsamir wrote: > Digging around in git log I found: https://git.reviewboard.kde.org/r/127026/ > > But I think that's covered by the method in QInputControl, and ktexteditor has a unit test

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

2019-08-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 27 Aug 2019 02:57:21 + Build duration: 37 min and counting JUnit Tests Name:

D23457: Port regex search to QRegularExpression

2019-08-26 Thread Ahmad Samir
ahmadsamir added a comment. In D23457#519773 , @cullmann wrote: > In D23457#519217 , @ahmadsamir wrote: > > > Maybe they'll also see it as ktexteditor/kate using a regex engine that matches what

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

2019-08-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 64709. ahmadsamir added a comment. Improve comment in header file REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23472?vs=64708=64709 BRANCH ahmad/soft-hyphen (branched from master) REVISION DETAIL

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

2019-08-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 64708. ahmadsamir retitled this revision from "Enable typing soft-hyphen characters" to "Mimic QInputControl::isAcceptableInput() when filtering typed characters". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this

D23470: Offer an xdg-compatible mode for convertToQVariant

2019-08-26 Thread Aleix Pol Gonzalez
apol added a comment. In D23470#519726 , @kossebau wrote: > How exactly are you using ths from KService? If just by passing the flag set, won't this break any existing custom properties which are relying on "," as separator?

D23472: Enable typing soft-hyphen characters

2019-08-26 Thread Ahmad Samir
ahmadsamir added a comment. Digging around in git log I found: https://git.reviewboard.kde.org/r/127026/ But I think that's covered by the method in QInputControl, and ktexteditor has a unit test for that; I'll see how it goes. REPOSITORY R39 KTextEditor REVISION DETAIL

D23457: Port regex search to QRegularExpression

2019-08-26 Thread Christoph Cullmann
cullmann added a comment. In D23457#519217 , @ahmadsamir wrote: > Maybe they'll also see it as ktexteditor/kate using a regex engine that matches what the abundance of online pcre docs say, and how other editors that use pcre behave? > >

D23400: reST: handle some more corner cases, add an actual test file

2019-08-26 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0ad8e84e4d1c: reST: handle some more corner cases, add an actual test file (authored by mosra, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23472: Enable typing soft-hyphen characters

2019-08-26 Thread Christoph Cullmann
cullmann added a comment. That would fix btw. https://bugs.kde.org/show_bug.cgi?id=366424, too. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23472 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson,

D23400: reST: handle some more corner cases, add an actual test file

2019-08-26 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. Looks better, right. thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23400 To: mosra, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, turbov, LeGast00n, GB_2, domson,

D23472: Enable typing soft-hyphen characters

2019-08-26 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think the proper fix is: 1. remove any filtering in typeChars(). 2. implement a Qt like handling in the void KateViewInternal::keyPressEvent(QKeyEvent *e) member.

D23472: Enable typing soft-hyphen characters

2019-08-26 Thread Christoph Cullmann
cullmann added a comment. I checked a bit what Qt does: bool QInputControl::isAcceptableInput(const QKeyEvent *event) const { const QString text = event->text(); if (text.isEmpty()) return false; const QChar c = text.at(0); // Formatting characters

D23472: Enable typing soft-hyphen characters

2019-08-26 Thread Christoph Cullmann
cullmann added a comment. This is a good idea. But actually, is there any reason we filter out stuff at all? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23472 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel,

D23400: reST: handle some more corner cases, add an actual test file

2019-08-26 Thread Vladimír Vondruš
mosra updated this revision to Diff 64694. mosra added a comment. Hmm, actually during use I discovered that the newly added "default role" was marking everything after the backticks as a role... and the test file was crafted in a way that didn't make that visible. Sorry for submitting too

D23472: Enable typing soft-hyphen characters

2019-08-26 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The typeChars() functions filters out non-printable characters, except for: \t, \n, \r; add

D23470: Offer an xdg-compatible mode for convertToQVariant

2019-08-26 Thread Friedrich W. H. Kossebau
kossebau added a comment. How exactly are you using ths from KService? If just by passing the flag set, won't this break any existing custom properties which are relying on "," as separator? `grep "Type=QStringList" /usr/share/kservicetypes5/ -r` hints there are quite some properties

D23444: Remove applets/22/computer

2019-08-26 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:fff83c41653a: Remove applets/22/computer (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23444?vs=64584=64692 REVISION DETAIL

D23470: Offer an xdg-compatible mode for convertToQVariant

2019-08-26 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > apol wrote in kconfiggroup.h:653 > Thought about it, it's private API, are you sure it makes sense to have an > enum just for this? Still helps readers of codes which calls this method. IMHO one should not make a difference in API style for

D23470: Offer an xdg-compatible mode for convertToQVariant

2019-08-26 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > kconfiggroup.h:655 > + > +KCONFIGCORE_DEPRECATED_EXPORT static QVariant convertToQVariant(const > char *pKey, const QByteArray , const QVariant ) { return > convertToQVariant(pKey, value, aDefault, false); } > friend class KServicePrivate;

D23470: Offer an xdg-compatible mode for convertToQVariant

2019-08-26 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kossebau wrote in kconfiggroup.h:653 > No `bool` flags, please :) > https://community.kde.org/Policies/Library_Code_Policy#Flags Thought about it, it's private API, are you sure it makes sense to have an enum just for this? REPOSITORY R237

D23470: Offer an xdg-compatible mode for convertToQVariant

2019-08-26 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kconfiggroup.h:653 > */ > -static QVariant convertToQVariant(const char *pKey, const QByteArray > , const QVariant ); > +static QVariant convertToQVariant(const char *pKey, const QByteArray > , const QVariant , bool

KDE CI: Frameworks » knotifications » kf5-qt5 SUSEQt5.12 - Build # 64 - Fixed!

2019-08-26 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20SUSEQt5.12/64/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 26 Aug 2019 17:34:06 + Build duration: 3 min 20 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knotifications » kf5-qt5 SUSEQt5.13 - Build # 26 - Fixed!

2019-08-26 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20SUSEQt5.13/26/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 26 Aug 2019 17:34:05 + Build duration: 3 min 16 sec and counting BUILD ARTIFACTS

D23381: Allow splitting lists using ;

2019-08-26 Thread Aleix Pol Gonzalez
apol abandoned this revision. apol added a comment. Doing https://phabricator.kde.org/D23470 instead, which is less radical. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D23381 To: apol, #frameworks Cc: dfaure, kossebau, sitter, kde-frameworks-devel, LeGast00n,

D23470: Offer an xdg-compatible mode for convertToQVariant

2019-08-26 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's used from KService, which works with desktop files, add support to parse xdg lists.

D23119: Fix dates being on the wrong locale when setting an application language individually

2019-08-26 Thread Alexander Semke
asemke added a comment. The original problem in LabPlot was reported by a windows user. The proposed fix won't fix the problem on windows. I think the only way to get the proper strings on Windows is to get the current language of the application, to create a QLocale with the proper

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-26 Thread Alexander Saoutkin
feverfew added reviewers: sitter, dfaure. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23207 To: feverfew, chinmoyr, fvogt, sitter, dfaure Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

KDE CI: Frameworks » knotifications » kf5-qt5 SUSEQt5.13 - Build # 25 - Failure!

2019-08-26 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20SUSEQt5.13/25/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 26 Aug 2019 16:47:00 + Build duration: 2 min 40 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 11 - Failure!

2019-08-26 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/11/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 26 Aug 2019 16:47:00 + Build duration: 1 min 58 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knotifications » kf5-qt5 SUSEQt5.12 - Build # 63 - Failure!

2019-08-26 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20SUSEQt5.12/63/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 26 Aug 2019 16:47:00 + Build duration: 1 min 9 sec and counting CONSOLE OUTPUT

D23468: Resolve whether there's dbus before processing src/

2019-08-26 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R289:2db6ead89036: Resolve whether theres dbus before processing src/ (authored by apol). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23468?vs=64677=64681

D22922: Implement writing of images

2019-08-26 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:4a90e8f348c2: Implement writing of images (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22922?vs=63053=64679 REVISION DETAIL

D23468: Resolve whether there's dbus before processing src/

2019-08-26 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D23468 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23468: Resolve whether there's dbus before processing src/

2019-08-26 Thread Aleix Pol Gonzalez
apol edited the summary of this revision. apol edited the test plan for this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23468 To: apol, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23381: Allow splitting lists using ;

2019-08-26 Thread Friedrich W. H. Kossebau
kossebau added a subscriber: dfaure. kossebau added a comment. Looking at KServiceTypePrivate::init() (from KService) pr parseServiceTypesFile() (in desktopfileparser from KCoreAddons) seems currently the only supported property types are bool, int, double, string, stringlist (reusing

D23468: Resolve whether there's dbus before processing src/

2019-08-26 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise \#if HAVE_DBUSMENUQT will be always false. REPOSITORY R289 KNotifications

D23465: Add new non standard mime type for ROOT cern files

2019-08-26 Thread Alex Debus
alexde added a comment. In D23465#519586 , @yurchor wrote: > Yes. The maintainers of shared-mime-info will tell you if the type is right (I think, that it would be better to use , similar to PDF, but I might be wrong). Alright, I have

D23381: Allow splitting lists using ;

2019-08-26 Thread Friedrich W. H. Kossebau
kossebau added a comment. Without having looked further, my gut reaction is that changing the syntax for all existing config files due to code reuse to help an issue with desktop files might not be the backward-compatible way forward here. For what I can tell, the issue comes from the

D23381: Allow splitting lists using ;

2019-08-26 Thread Harald Sitter
sitter added a comment. Shouldn't you be using KConfigGroup::readXdgListEntry? KConfig is strangely conflicted with it's default assumption being that you want the legacy comma lists so if you want xdg-style lists you need to call different functions altogether. That said I think Kai and I

D23444: Remove applets/22/computer

2019-08-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, I see now. Confirmed that this fixes the issue. Nice catch! REPOSITORY R266 Breeze Icons BRANCH remove-applet-computer (branched from master) REVISION DETAIL

D23465: Add new non standard mime type for ROOT cern files

2019-08-26 Thread Yuri Chornoivan
yurchor added a comment. In D23465#519576 , @alexde wrote: > In D23465#519544 , @ltoscano wrote: > > > The idea is good, but it should be proposed to shared-mime-info repository instead. As far as

D23465: Add new non standard mime type for ROOT cern files

2019-08-26 Thread Alex Debus
alexde added a subscriber: yurchor. alexde added a comment. In D23465#519544 , @ltoscano wrote: > The idea is good, but it should be proposed to shared-mime-info repository instead. As far as I remember from the previous discussions, this file

We can't properly parse standard Desktop files

2019-08-26 Thread Aleix Pol
Hey, Last week I was debugging an issue where I realised that we were not splitting properly a StringList field in a desktop file coming from Flatpak. I notice then that we are using a coma to split desktop files instead of a ; as the standard requests. The multiple values should be separated by

Aw: BluezQt GATT client API

2019-08-26 Thread Manuel Weichselbaumer
Hi,   the GATT client API is not fully implemented (nor tested). Unfortunately, i do not plan to implement this soon.   However, Qt also provides a BluettothLE API which should work just fine (in client mode).   Best regards, Manuel Weichselbaumer   Gesendet: Freitag, 23. August 2019 um

Re: Aw: BluezQt GATT client API

2019-08-26 Thread Иван Подкурков
Hi, Thanks a lot for response, However, Qt also provides a BluettothLE API which should work just fine (in client mode). That is very true, but it looks that they don't have any control over pairing process - there are no API to provide "custom Agent" to it (there are in BluezQt though). It

D23194: Making FileJob behave consistently.

2019-08-26 Thread Alexander Saoutkin
feverfew marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23194 To: feverfew, dfaure, fvogt, chinmoyr, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23450: Icons for ROOT cern files.

2019-08-26 Thread Alex Debus
alexde added a comment. Sorry, for some reason it was easier for me to abandon this revision and to reopen another one here: https://phabricator.kde.org/D23464 > Personally, I like these icons Thanks :) > they can be easily used on the system (shared-mime-info) or KDE level

D23194: Making FileJob behave consistently.

2019-08-26 Thread Alexander Saoutkin
feverfew updated this revision to Diff 64673. feverfew added a comment. - Removing flush on write REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23194?vs=64672=64673 BRANCH ConsistentRead (branched from master) REVISION DETAIL

D23464: Add breeze icons for ROOT cern files

2019-08-26 Thread Alex Debus
alexde edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23194: Making FileJob behave consistently.

2019-08-26 Thread Alexander Saoutkin
feverfew marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23194 To: feverfew, dfaure, fvogt, chinmoyr, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23194: Making FileJob behave consistently.

2019-08-26 Thread Alexander Saoutkin
feverfew updated this revision to Diff 64672. feverfew added a comment. - Fixing typos - Adding test for reading of 0 bytes and asserting that the close signal is actually emitted. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23194?vs=64051=64672

D23464: Add breeze icons for ROOT cern files

2019-08-26 Thread Alex Debus
alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23465: Add new non standard mime type for ROOT cern files

2019-08-26 Thread Luigi Toscano
ltoscano added a comment. The idea is good, but it should be proposed to shared-mime-info repository instead. As far as I remember from the previous discussions, this file is meant to contain a limited number of entities and possibiy disappear over time. REPOSITORY R244 KCoreAddons

D23465: Add new non standard mime type for ROOT cern files

2019-08-26 Thread Alex Debus
alexde added a comment. Here's a testfile for the defined mime type: F7282186: testfile.root REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23465 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23465: Add new non standard mime type for ROOT cern files

2019-08-26 Thread Alex Debus
alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH ROOT (branched from master) REVISION DETAIL

D23450: Icons for ROOT cern files.

2019-08-26 Thread Yuri Chornoivan
yurchor added a comment. Just a side note. Personally, I like these icons and they can be easily used on the system (shared-mime-info) or KDE level (kcoreaddons) level with very minor patching, imho. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23450

D23464: Add breeze icons for ROOT cern files

2019-08-26 Thread Alex Debus
alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL

D23450: Icons for ROOT cern files.

2019-08-26 Thread Alex Debus
alexde abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23450 To: alexde, #vdg, ngraham, ndavis Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

2019-08-26 Thread Nathaniel Graham
ngraham retitled this revision from "Use solid to check if a a KFileItem is located on a network mount" to "Use solid to check if a KFileItem is located on a network mount". REPOSITORY R241 KIO BRANCH solid-network-fs-check REVISION DETAIL https://phabricator.kde.org/D23420 To: meven,

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

2019-08-26 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D23229 To: asturmlechner, #frameworks, ltoscano Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D21795: [KAuth] Add support for action details in Polkit1 backend.

2019-08-26 Thread Harald Sitter
sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. Unfortunately I've noticed a huge blocker... polkit-qt-1 with the `checkAuthorizationWithDetails` change is not actually released. That needs fixing :|

D23420: Use solid to check if a a KFileItem is located on a network mount

2019-08-26 Thread Kai Uwe Broulik
broulik added a comment. What about symlink resolution, though? Maybe this needs to check `linkDest()`, too. This might block but for our usecase in local files you have `UDS_LINK_DEST` populated on the kioslave side already. INLINE COMMENTS > kfileitem.cpp:766 > +const

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

2019-08-26 Thread Luigi Toscano
ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. (sorry, time off) thanks! REPOSITORY R238 KDocTools BRANCH kdeinstalldirs REVISION DETAIL https://phabricator.kde.org/D23229 To: asturmlechner, #frameworks, ltoscano Cc:

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-08-26 Thread Dominik Haumann
dhaumann added a comment. Unconditionally removing this is not a good idea, since the feature significantly helps to discover API via code completion. In any case, feedback from @kfunk, @molff is needed here imho REPOSITORY R39 KTextEditor REVISION DETAIL

D23454: Fixing bug where MTP slave does not return error in stat()/mimetype()

2019-08-26 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R320:8c42ec63200f: Fixing bug where MTP slave does not return error in stat()/mimetype() (authored by feverfew, committed by fvogt). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D23061: Possiblity to change Definition data after loading

2019-08-26 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > sirgienko wrote in definition.h:339 > Is it enough? I mean, I can add explanation, that rehiglighting whole > document (after keyword list modification) works via > `QSyntaxHighlighter::rehighlight()`, but i think, it is pretty obivously for >

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

2019-08-26 Thread Volker Krause
vkrause added a comment. In D23323#519093 , @dhaumann wrote: > In D23323#516317 , @apol wrote: > > > Makes sense, but I feel some explanation is missing ^^' > > > > Put it in the commit message?

D23420: Use solid to check if a a KFileItem is located on a network mount

2019-08-26 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH solid-network-fs-check REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23420: Use solid to check if a a KFileItem is located on a network mount

2019-08-26 Thread Méven Car
meven updated this revision to Diff 64645. meven marked an inline comment as done. meven added a comment. Add a const REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23420?vs=64538=64645 BRANCH solid-network-fs-check REVISION DETAIL

D23420: Use solid to check if a a KFileItem is located on a network mount

2019-08-26 Thread Kai Uwe Broulik
broulik added a comment. I'm always hesitant to use Solid but since `KFilePlacesModel` already queries Solid for everything, it has already loaded all its backends and queried everything, so the overhead of this during normal Dolphin use, is surprisingly negligible. +1 good call! :)

D23454: Fixing bug where MTP slave does not return error in stat()/mimetype()

2019-08-26 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH mtpFixStat (branched from master) REVISION DETAIL https://phabricator.kde.org/D23454 To: feverfew, chinmoyr, akrutzler, elvisangelaccio, dfaure Cc: kde-frameworks-devel,

D23420: Use solid to check if a a KFileItem is located on a network mount

2019-08-26 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > meven wrote in kfileitem.cpp:764 > Can't because of > > Solid::StorageAccess *storageAccess = device.as(); Get it as `const Solid::StorageAccess`, you can use `auto storageAccess = ...` REPOSITORY R241 KIO BRANCH