D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven marked 3 inline comments as done. meven added inline comments. INLINE COMMENTS > broulik wrote in slavebase.cpp:281 > This is initialized automatically like this That's on purpose, the first use of mapConfig is in rebuildConfig and is a clear() call. REPOSITORY R241 KIO REVISION DETAI

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 65200. meven marked an inline comment as done. meven added a comment. Review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=65006&id=65200 BRANCH arcpatch-D23523_1 REVISION DETAIL https://phabricator.k

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65199. meven added a comment. arc amend REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65198&id=65199 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES autotests/kfileplac

D7446: [Places panel] Revamp the Recently Saved section

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni,

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65198. meven added a comment. Better variable naming REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65197&id=65198 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES autote

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65197. meven added a comment. Add recentlyused:/ entry to Recent group to existing users REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65191&id=65197 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kd

D23657: Markdown, TypeScript & Logcat: some fixes

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23657 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, s

D22069: Localize long number strings

aacid added a comment. Other tests are telling you "French test files not usable." You don't have the setup correct for the test to work. You need to fix your setup for the test to pass, but first since you already have a "wrong" setup, please add the qskip like the other tests have.

D23627: Make notification icons use outline style

ndavis added a dependent revision: D23658: Make notification icons use outline style. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23658: Make notification icons use outline style

ndavis added a dependency: D23627: Make notification icons use outline style. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23658 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23658: Make notification icons use outline style

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23658 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23658: Make notification icons use outline style

ndavis updated this revision to Diff 65195. ndavis added a comment. Add breeze dark icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23658?vs=65194&id=65195 BRANCH notifications-outline (branched from master) REVISION DETAIL https://phabricat

D23658: Make notification icons use outline style

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY They didn't quite fit in with the filled style REPOSITORY R266 Breeze Icons BRANCH not

D23657: Markdown, TypeScript & Logcat: some fixes

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH update-syntax REVISION DETAIL https://phabricator.kde.org/D23657 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-dev

D23645: Do not generate string list at runtime

dhaumann added a subscriber: mwolff. dhaumann added inline comments. INLINE COMMENTS > kossebau wrote in katemodemanager.cpp:214 > I saw you mentioned this elsewhere, but thought it was a typo. Never seen > this before, so curious to leatn what advantage using an initializer list > brings here.

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65191. meven added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=64927&id=65191 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES autotests/kfileplacesm

D23657: Markdown, TypeScript & Logcat: some fixes

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY **Markdown:** - Fix Mar

D23627: Make notification icons use outline style

ndavis added a comment. I could use a modified version of the KAlarm systray icon F7307137: Screenshot_20190901_212547.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: n

D23627: Make notification icons use outline style

ngraham added a comment. Maybe leave the clapper alone for now then? +1 on making it outline style at least. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2

D23627: Make notification icons use outline style

ndavis added a comment. In D23627#523987 , @ngraham wrote: > I kinda like the off-center clapper, but I understand how it might drive OCD people mildly insane. :) However the full-color icon theme notification preferences icon has an off-center

D23627: Make notification icons use outline style

ngraham added a comment. I kinda like the off-center clapper, but I understand how it might drive OCD people mildly insane. :) However the full-color icon theme notification preferences icon has an off-center clapper, so I think if we're going to make that change here, we need to do it there

D23650: Add an icon for the trash root and a proper label

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice fix. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2,

D22069: Localize long number strings

ngraham added a comment. In D22069#523824 , @aacid wrote: > If what you're saying is that that you run ./bin/ki18n-klocalizedstringtest without those lines and the test fails for you, well you'll have to give me access to your machine since i ca

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. I think so. It's a very big upgrade, and we're going to be mentioning it in a lot of promo materials. People may get confused and annoyed if they don't see it after reading about it in the release announcement or a U&P blog post. REPOSITORY R241 KIO REVISION DETAI

D23626: Use QChar overload for single char strings where possible

cullmann added a comment. :=) If you have time to spare and some fun for tedious work: D19367 Finalizing a chunk wise regex search as drafted in https://cgit.kde.org/ktexteditor.git/commit/?id=dbebf059575f83608c94ac3a6d374667b5a6 is highly apprec

D23626: Use QChar overload for single char strings where possible

kossebau added a comment. In D23626#523884 , @dhaumann wrote: > Do you have a clang-tidy plugin for such changes, or do you use a manual regexp for detection? Very unprofessionally I use the grep dialog of KDevelop, to collect hits of me

D23645: Do not generate string list at runtime

kossebau added inline comments. INLINE COMMENTS > dhaumann wrote in katemodemanager.cpp:214 > I would even prefer: > > static const auto commonSuffixes = { ... }; > > This way it's an initializer_list and a pattern we use at other places in > KTextEditor as well. But of course, your patch is

D19367: SearchBar: Don't block GUI when enter incremental pattern

cullmann added a comment. I thought a bit about the problem with multi-line regex. I think we can solve this in a consistent way by allowing to incremental do matches that span more than one line. See the first example code in this commit: https://cgit.kde.org/ktexteditor.git/c

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

This revision was automatically updated to reflect the committed changes. Closed by commit R39:00721e80b5b4: Fix for all themes: allow turn off attributes in XML highlighting files (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phab

D23645: Do not generate string list at runtime

dhaumann added inline comments. INLINE COMMENTS > katemodemanager.cpp:214 > if (! fileName.isEmpty()) { > -static const QStringList commonSuffixes = > QStringLiteral(".orig;.new;~;.bak;.BAK").split(QLatin1Char(';')); > +static const QLatin1String commonSuffixes[] = { > +

D23515: Format class: add functions to know if XML files set style attributes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:b7555d6a475a: Format class: add functions to know if XML files set style attributes (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https

D23626: Use QChar overload for single char strings where possible

dhaumann added a comment. Do you have a clang-tidy plugin for such changes, or do you use a manual regexp for detection? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23626 To: kossebau, #kate, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

dhaumann accepted this revision. REPOSITORY R39 KTextEditor BRANCH turnoff-attr REVISION DETAIL https://phabricator.kde.org/D23516 To: nibags, #ktexteditor, cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cu

D23515: Format class: add functions to know if XML files set style attributes

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks!! REPOSITORY R216 Syntax Highlighting BRANCH format-new-functions REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting, dhaumann,

D23645: Do not generate string list at runtime

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a7212d561de1: Do not generate string list at runtime (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23645?vs=65164&id=65170 REVISION DETA

D22069: Localize long number strings

aacid added a comment. In D22069#523253 , @ngraham wrote: > I'm not sure I understand about about localization to figure that out. Would you be able to help me out? Figure *what* out? Just remove this diff --git a/autotests/kl

D23645: Do not generate string list at runtime

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think that is nicer, yes! REPOSITORY R39 KTextEditor BRANCH preparelistatbuildtie REVISION DETAIL https://phabricator.kde.org/D23645 To: kossebau, #kate, cullmann Cc: cullmann

D23645: Do not generate string list at runtime

kossebau updated this revision to Diff 65164. kossebau added a comment. now as plain array REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23645?vs=65124&id=65164 BRANCH preparelistatbuildtie REVISION DETAIL https://phabricator.kde.org/D23645 AFFEC

D23645: Do not generate string list at runtime

kossebau added a comment. (And thanks for all the quick review :) ) In D23645#523622 , @cullmann wrote: > Hmm, could we here now avoid the QStringList completely and just use a normal array with a range based for below? Okay, looks l

D23646: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ede4725394e9: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0) (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23646?vs=65125&id=65161#toc REPOSITORY R39 KTextEd

D23641: Use s.mid(n) instead of s.right(s.size() - n)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a11e13d30378: Use s.mid(n) instead of s.right(s.size() - n) (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23641?vs=65117&id=65158 REVISI

D23633: Use s.chop(n) instead of s = s.left(s.length() - n)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:35537b5e1efd: Use s.chop(n) instead of s = s.left(s.length() - n) (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23633?vs=65108&id=65156

D23634: Use more QString::leftRef where possible

This revision was automatically updated to reflect the committed changes. Closed by commit R39:6e26fc41f7b1: Use more QString::leftRef where possible (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23634?vs=65109&id=65159#toc REPOSITORY R39 KTextEditor CHANGES S

D23630: Use QString(int, QChar) instead of QStringLiteral(" ").repeated(int)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:842486d3d10d: Use QString(int, QChar) instead of QStringLiteral(" ").repeated(int) (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23630?vs

D23644: Use more QString::splitRef

This revision was automatically updated to reflect the committed changes. Closed by commit R39:6532ee50669e: Use more QString::splitRef (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23644?vs=65123&id=65162#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDA

D23632: Use s.truncate(n) instead of s = s.left(n)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8f76508792cc: Use s.truncate(n) instead of s = s.left(n) (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23632?vs=65107&id=65155 REVISION

D23626: Use QChar overload for single char strings where possible

This revision was automatically updated to reflect the committed changes. Closed by commit R39:3f993a2b9c05: Use QChar overload for single char strings where possible (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23626?vs=65101&id=65152#toc REPOSITORY R39 KText

D23637: Use more QString::midRef where possible

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d77ce06e8e9d: Use more QString::midRef where possible (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23637?vs=65114&id=65160#toc REPOSITORY R39 KTextEditor CHANGES SI

D23642: Use QStringLiteral instead of runtime conversion to QString

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e3cb6a131764: Use QStringLiteral instead of runtime conversion to QString (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23642?vs=65120&id

D23629: Use QLatin1String over QStringLiteral in string concatenation

This revision was automatically updated to reflect the committed changes. Closed by commit R39:67ed8cbdf954: Use QLatin1String over QStringLiteral in string concatenation (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23629?vs=65121&id=65154#toc REPOSITORY R39 K

D22069: Localize long number strings

huftis added a comment. In D22069#523253 , @ngraham wrote: > I'm not sure I understand about about localization to figure that out. Would you be able to help me out? Perhaps https://phabricator.kde.org/D10757 could offer a clue? REPOSITO

D23625: Use QString::count(QChar) over QString::split().length() - 1

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a5783ba11943: Use QString::count(QChar) over QString::split().length() - 1 (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23625?vs=65100&i

D23650: Add an icon for the trash root and a proper label

meven added a comment. I need a fix in dolphin so that the icon in dolphin information panel is updated after the trash is emptied. Will come soon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks Cc: broulik, kde-frameworks-devel,

D23650: Add an icon for the trash root and a proper label

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23650: Add an icon for the trash root and a proper label

meven updated this revision to Diff 65144. meven added a comment. Notify that trash:/ has changed when emptied, add Display Name REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23650?vs=65140&id=65144 BRANCH master REVISION DETAIL https://phabricator.kde.o

D23644: Use more QString::splitRef

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. looks ok REPOSITORY R39 KTextEditor BRANCH moresplitref REVISION DETAIL https://phabricator.kde.org/D23644 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel, kde-framewor

D23646: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ok INLINE COMMENTS > kossebau wrote in kateviewhelpers.cpp:1191 > Refactoring to one static object will be separate commit. I would have no issue with this to be in this commit ;=) Tha

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

broulik added inline comments. INLINE COMMENTS > slavebase.cpp:189 > +} > +if (config != nullptr) { > +delete config; `delete nullptr` is fine, no need to check first > slavebase.cpp:281 > d->needSendCanResume = false; > -d->config = new KConfig(QString(), K

D23637: Use more QString::midRef where possible

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. looks ok REPOSITORY R39 KTextEditor BRANCH usemidref REVISION DETAIL https://phabricator.kde.org/D23637 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-

D23650: Add an icon for the trash root and a proper label

broulik added inline comments. INLINE COMMENTS > kio_trash.cpp:280 > entry.clear(); > -entry.fastInsert(KIO::UDSEntry::UDS_NAME, QStringLiteral(".")); > entry.fastInsert(KIO::UDSEntry::UDS_FILE_TYPE, S_IFDIR); `UDS_NAME` has to be "." to denote it's the root entry. You want to be a

D23634: Use more QString::leftRef where possible

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok REPOSITORY R39 KTextEditor BRANCH moreleftref REVISION DETAIL https://phabricator.kde.org/D23634 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-deve

D23641: Use s.mid(n) instead of s.right(s.size() - n)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems ok, too. REPOSITORY R39 KTextEditor BRANCH midnotrightlengthminus REVISION DETAIL https://phabricator.kde.org/D23641 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-dev

D23650: Add an icon for the trash root and a proper label

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23650: Add an icon for the trash root and a proper label

meven created this revision. meven added reviewers: ngraham, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 392882 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://p

D23630: Use QString(int, QChar) instead of QStringLiteral(" ").repeated(int)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) REPOSITORY R39 KTextEditor BRANCH repeatedtoconstructor REVISION DETAIL https://phabricator.kde.org/D23630 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel, kde-f

Re: Coding style: white space around asterisks

On 8/6/19 5:44 PM, Roman Gilg wrote: Hi, Hi, I am not sure whether you started this discussion in Qt/Development mailing list, so I'll just leave my 2 cents here. Let's start with very obvious thing first: If you align pointers and references to right, then you're doing something fishy. [1

D23633: Use s.chop(n) instead of s = s.left(s.length() - n)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok REPOSITORY R39 KTextEditor BRANCH chopnotleft REVISION DETAIL https://phabricator.kde.org/D23633 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-deve

D23632: Use s.truncate(n) instead of s = s.left(n)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) REPOSITORY R39 KTextEditor BRANCH truncatenotleft REVISION DETAIL https://phabricator.kde.org/D23632 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel, kde-framewo

D23629: Use QLatin1String over QStringLiteral in string concatenation

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok ;=) REPOSITORY R39 KTextEditor BRANCH usemoreqlatin1string REVISION DETAIL https://phabricator.kde.org/D23629 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel,

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this is fine, as soon as the other patch is in, feel free to commit! REPOSITORY R39 KTextEditor BRANCH turnoff-attr REVISION DETAIL https://phabricator.kde.org/D23516 To

D23642: Use QStringLiteral instead of runtime conversion to QString

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks fine. REPOSITORY R39 KTextEditor BRANCH noruntimetoqstringconversion REVISION DETAIL https://phabricator.kde.org/D23642 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-

D23645: Do not generate string list at runtime

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hmm, could we here now avoid the QStringList completely and just use a normal array with a range based for below? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabr

D23626: Use QChar overload for single char strings where possible

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok, too. Thanks! REPOSITORY R39 KTextEditor BRANCH useqcharoverload REVISION DETAIL https://phabricator.kde.org/D23626 To: kossebau, #kate, cullmann Cc: cullmann, kwrite

D23515: Format class: add functions to know if XML files set style attributes

cullmann added a comment. Dominik, ok with this now, too? Or did I miss some name issues in the API? (tried to read all lines for spelling mistakes :=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting, dhau

D23625: Use QString::count(QChar) over QString::split().length() - 1

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable, thanks. REPOSITORY R39 KTextEditor BRANCH usecount REVISION DETAIL https://phabricator.kde.org/D23625 To: kossebau, #kate, cullmann Cc: cullmann, kwrite-devel,

D23646: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)

kossebau added inline comments. INLINE COMMENTS > kateviewhelpers.cpp:1191 > { > +static const QRegularExpression > focusChangingCommands(QStringLiteral("^(buffer|b|new|vnew|bp|bprev|bn|bnext|bf|bfirst|bl|blast|edit|e)$")); > + Refactoring to one static object will be separate commit. REP

D23646: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH leftrefnotsplit

D23645: Do not generate string list at runtime

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH preparelistatbui

D23644: Use more QString::splitRef

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH moresplitref RE

D23629: Use QLatin1String over QStringLiteral in string concatenation

kossebau updated this revision to Diff 65121. kossebau added a comment. two more case found REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23629?vs=65104&id=65121 BRANCH usemoreqlatin1string REVISION DETAIL https://phabricator.kde.org/D23629 AFFEC

D23642: Use QStringLiteral instead of runtime conversion to QString

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY Detected by clazy GIT_SILENT REPOSITORY R39 KTextEditor BRANC

D23619: Introduce cloning and replication of output devices

romangg updated this revision to Diff 65118. romangg added a comment. - Add trigger reason and direction enums - Disable replication on output device going away I decided to go with the enums to make it explicit. Also I plan on using these in the future with events to signal the curren

D23641: Use s.mid(n) instead of s.right(s.size() - n)

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH midnotrightlengt

D23637: Use more QString::midRef where possible

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH usemidref REVIS

D23634: Use more QString::leftRef where possible

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH moreleftref REV

D23633: Use s.chop(n) instead of s = s.left(s.length() - n)

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH chopnotleft REV

D23632: Use s.truncate(n) instead of s = s.left(n)

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH truncatenotleft

D23627: Make notification icons use outline style

filipf added a comment. +1, looks good, thanks for centering the clapper as well REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23627: Make notification icons use outline style

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23630: Use QString(int, QChar) instead of QStringLiteral(" ").repeated(int)

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH repeatedtoconstr

D23627: Make notification icons use outline style

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23627: Make notification icons use outline style

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23629: Use QLatin1String over QStringLiteral in string concatenation

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH usemoreqlatin1st

D23627: Make notification icons use outline style

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY They didn't quite fit in with the filled style REPOSITORY R242 Plasma Framework (L

D23626: Use QChar overload for single char strings where possible

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH useqcharoverload

D23625: Use QString::count(QChar) over QString::split().length() - 1

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REPOSITORY R39 KTextEditor BRANCH usecount REVISION DETAIL https://phabricator

D23597: Bulk port away from foreach

kossebau added a comment. Thanks. In any case, would wait for after 5.62 tagging/branching, as by experience there still might be one or the other regression slipped in with porting from foreach, so having some weeks of testing from more people running git master makes me feel better, before

D23597: Bulk port away from foreach

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I think this patch is good to go in. REPOSITORY R236 KWidgetsAddons BRANCH portmostfporeach REVISION DETAIL https://phabricator.kde.org/D23597 To: kossebau, #frameworks, cfeck,