D23778: Remove superfluous 32px recent documents icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:fbbc49bf219b: Remove superfluous 32px recent documents icons (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23778?vs=65708=65717

D23813: Port away from foreach loops over arguments without calls to owner class

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which still call the

D23812: Port away from foreach loops over members without calls to owner class

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which still call the

D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5

cfeck created this revision. cfeck added a reviewer: Frameworks. cfeck added a project: Gwenview. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cfeck requested review of this revision. TEST PLAN Tested with HDR images from hdrihaven.com - Loading in

D23713: strongswan support for custom proposals

rrichmond marked 5 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D23713 To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23713: strongswan support for custom proposals

rrichmond updated this revision to Diff 65711. rrichmond added a comment. Moved custom cipher proposals into its own group box, with the checked property, encompassing the IKE/ESP proposal QLineEdit boxes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23713?vs=65357=65711

D23810: Port away from Qt's foreach all loops over rvalue container objects

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The other simple part of foreach porting, as those containers objects are not

D23801: Port kpac from QtScript

knauss added a task: T11530: Investigate removal of KIO's KPAC in favor of QNetworkProxy. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23801 To: carewolf, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

This revision was automatically updated to reflect the committed changes. Closed by commit R320:f9f2ef104fa7: Remove the man KPart, and thus the last KHtml user in kio-extras (authored by vkrause). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D23664: Port away from Qt's foreach all loops over method-local containers

This revision was automatically updated to reflect the committed changes. Closed by commit R263:867351258d1f: Port away from Qts foreach all loops over method-local containers (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D23797: [KWidgetAddons] port to non-deprecated Qt API

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Merci! REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D23797 To: dfaure, cfeck Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2,

D23778: Remove superfluous >22px recent documents icons

ngraham updated this revision to Diff 65708. ngraham added a comment. Restore 24px versions (they will be deleted later) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23778?vs=65596=65708 BRANCH remove-superfluous-recent-docs-icons (branched from

D23778: Remove superfluous 32px recent documents icons

ngraham retitled this revision from "Remove superfluous >22px recent documents icons" to "Remove superfluous 32px recent documents icons". ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23778 To: ngraham, #vdg, ndavis

D23664: Port away from Qt's foreach all loops over method-local containers

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH plainporttorangeloop REVISION DETAIL https://phabricator.kde.org/D23664 To: kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

broulik accepted this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D23809 To: vkrause, dfaure, broulik Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D23809 To: vkrause, dfaure Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe,

D23782: Add "edit-none-border" icon

ngraham added a comment. I kinda liked the originally proposed icon IMO. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis Cc: trickyricky26, ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

ngraham added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23809 To: vkrause, dfaure Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun,

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The man KPart was originally added to open troff files directly

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65705. meven added a comment. Remove unneeded friend function declarations REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65608=65705 BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667

D23797: [KWidgetAddons] port to non-deprecated Qt API

dfaure updated this revision to Diff 65703. dfaure added a comment. constify, sort includes REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23797?vs=65673=65703 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23797 AFFECTED FILES

D23664: Port away from Qt's foreach all loops over method-local containers

kossebau added a comment. Ping :) REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23664 To: kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 6 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65696. leinir marked 2 inline comments as done. leinir added a comment. - Add a simple cache for CommentsModel instances REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=65689=65696 BRANCH

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/65/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Sep 2019 16:53:19 + Build duration: 27 min and counting JUnit Tests Name: projectroot

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau retitled this revision from "WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API" to "RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To:

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23800 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23797: [KWidgetAddons] port to non-deprecated Qt API

dhaumann added a comment. Lgtm. INLINE COMMENTS > dhaumann wrote in ktitlewidget.cpp:137 > Is that not needed anymore? Sorry, the next line gives the answer ;) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23797 To: dfaure, cfeck Cc: dhaumann, aacid,

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Sep 2019 16:51:11 + Build duration: 2 min 47 sec and counting JUnit Tests Name:

D23797: [KWidgetAddons] port to non-deprecated Qt API

dhaumann added inline comments. INLINE COMMENTS > ktitlewidget.cpp:137 > d->headerLayout->setColumnStretch(0, 1); > -d->headerLayout->setMargin(6); > d->headerLayout->setContentsMargins(0, 0, 0, 0); Is that not needed anymore? REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a dependent revision: D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2,

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a dependency: D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau edited the test plan for this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KService to hide deprecated API up to a given version or silence deprecation

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 3 inline comments as done. leinir added inline comments. INLINE COMMENTS > broulik wrote in author.h:111 > `ProfilePage`? In principle yes, except we can't change homepage to homePage, until KF6... and then we'd end up with mixed spelling styles, and that just makes me sad ;) >

D23801: Port kpac from QtScript

carewolf created this revision. carewolf added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. carewolf requested review of this revision. REVISION SUMMARY Migrate the QtScript code to QJS classes. Warning: untested REPOSITORY

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65689. leinir marked 3 inline comments as done. leinir added a comment. Address comments by Kai Uwe and David - Use QQmlParserStatus to ensure we don't do unnecessary work - Get rid of all the extraneous data entries (also a couple of other bits)

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a dependent revision: D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2,

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a dependency: D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23800 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KCoreAddons to hide deprecated API up to a given version or silence deprecation

D10362: Change reveal password button logic

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb18347e4dea: Change reveal password button logic (authored by GB_2). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65592=65681

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 65678. kossebau added a comment. - change BEFORE to BEFORE_AND_AT, to match actual Qt behaviour (though do not copy confusing name, but be more precise using AND_AT - add NO_DEFINITION_EXPORT_TO_BUILD_INTERFACE option REPOSITORY R240 Extra CMake

D23797: [KWidgetAddons] port to non-deprecated Qt API

cfeck added inline comments. INLINE COMMENTS > kpopupframe.cpp:24 > > -#include > +#include > #include Please keep this sorted. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23797 To: dfaure, cfeck Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2,

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/25/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Sep 2019 15:12:13 + Build duration: 4 min 25 sec and counting JUnit Tests

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/64/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Sep 2019 14:16:26 + Build duration: 6 min 54 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Sep 2019 14:05:50 + Build duration: 2 min 53 sec and counting JUnit Tests Name:

D23797: [KWidgetAddons] port to non-deprecated Qt API

aacid added a comment. +1 looks sane but i have **not** tried this INLINE COMMENTS > kcollapsiblegroupbox.cpp:288 > { > -int top, left, right, bottom; > -getContentsMargins(, , , ); > +QMargins margins = contentsMargins(); > if you get bored, add const? >

D23797: [KWidgetAddons] port to non-deprecated Qt API

dfaure created this revision. dfaure added a reviewer: cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN Added "cxxflags -DQT_DISABLE_DEPRECATED_BEFORE=0x06" to kdesrc-build's

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/25/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Sep 2019 12:30:35 + Build duration: 1 min 50 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Sep 2019 12:10:50 + Build duration: 8 min 2 sec and counting JUnit Tests Name:

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. In D23789#527769 , @cgiboudeaux wrote: > Tests needed :) Sure :) Will be done, once I know investment makes sense. For now interested in feedback whether the principle approach makes sense and is

Re: Proposing Quick Charts as a new framework

Hi, On Sat, Sep 7, 2019 at 3:59 PM Arjen Hiemstra wrote: > On 06-09-2019 02:49, Aleix Pol wrote: > > On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra > > wrote: > >> > >> On 02-09-2019 19:26, Luigi Toscano wrote: > >> > Arjen Hiemstra ha scritto: > [...] > >> That's actually a good point,