D23791: ECMAddQch: add INCLUDE_DIRS argument

2019-09-14 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R240:ee4c3fd91eea: ECMAddQch: add INCLUDE_DIRS argument (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23791?vs=65657=66099

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

2019-09-14 Thread Nathaniel Graham
ngraham added a comment. Two things with this patch series: 1. Now there's no way to lock widgets without entering panel edit mode. Feels like we might as well just get rid of unlocked mode entirely. Or are more patches coming? Did we ever come to a conclusion in T10190

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 23:13:16 + Build duration: 2 min 35 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 87 - Fixed!

2019-09-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/87/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 14 Sep 2019 22:35:16 + Build duration: 25 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 220 - Fixed!

2019-09-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/220/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Sep 2019 22:35:16 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/76/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 22:35:17 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

2019-09-14 Thread Nicolas Fella
nicolasfella added a comment. This fixed it for me, thanks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23944 To: dfaure, vkrause, nicolasfella, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

2019-09-14 Thread David Faure
dfaure added a comment. It built for me; but I pushed a missing include. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23944 To: dfaure, vkrause, nicolasfella, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh,

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-09-14 Thread Emirald Mateli
emateli added a comment. I spent some time with modifying CopyJob but didn't make much progress and it's too deep into KIO internals - a lot one has to familiarize himself with. Maybe it's best someone who already did work on KIO to add the batch stuff. Once that is done and merged we can

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

2019-09-14 Thread Björn Feber
GB_2 edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

2019-09-14 Thread Björn Feber
GB_2 added a dependency: D23950: Only show "Add Widgets..." and "Lock Widgets" panel context menu options in panel edit mode. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma,

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

2019-09-14 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

2019-09-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY See M144 and T10047

D23586: Improve code that detects useful elements in an Svg file

2019-09-14 Thread Frederik Gladhorn
gladhorn added inline comments. INLINE COMMENTS > svg.cpp:103 > while (!reader.atEnd()) { > -if (reader.readNext() == QXmlStreamReader::StartElement && > +const auto t = reader.readNext(); > +if (t == QXmlStreamReader::StartElement) { Maybe use

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

2019-09-14 Thread Nibaldo González
nibags marked an inline comment as done. nibags added inline comments. INLINE COMMENTS > dhaumann wrote in katemodemenulist.cpp:175 > QStringLiteral("") us discouraged and should simply be QString(). Fixed in 3aa9c13f5a8b

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

2019-09-14 Thread Kai Uwe Broulik
broulik added a comment. This breaks the build: https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/219/ /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/krun_p.h:97:10: error: ���unique_ptr��� in namespace ���std��� does not name a template

D23667: Add == and != operators to KIO::UDSEntry

2019-09-14 Thread Méven Car
meven added a comment. @pino if this is fine for you... REPOSITORY R241 KIO BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks, ngraham Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

2019-09-14 Thread Méven Car
meven updated this revision to Diff 66086. meven added a comment. Update @since references REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65705=66086 BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Nathaniel Graham
ngraham added a dependent revision: D23868: [kfontinst] Port to use icons from the icon theme. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/75/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 19:27:00 + Build duration: 7 min 5 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 219 - Failure!

2019-09-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/219/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Sep 2019 19:27:00 + Build duration: 5 min 52 sec and counting CONSOLE OUTPUT [...truncated 1196

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Nathaniel Graham
ngraham added a comment. I still feel like I'd prefer the checkmark to be green. I also feel like I understand the argument that red isn't the best color to use for disabling something since it isn't destructive. Maybe we should use the orange color for that? Definitely need

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 86 - Failure!

2019-09-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/86/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 14 Sep 2019 19:27:00 + Build duration: 3 min 5 sec and counting CONSOLE OUTPUT [...truncated 1203

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

2019-09-14 Thread David Faure
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23944 To: dfaure, vkrause, nicolasfella, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe added a comment. @ndavis can you give review? thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. Now it's good! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe added a comment. Changed to `currentColor` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe updated this revision to Diff 66083. guoyunhe added a comment. Remove hardcoded colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66080=66083 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942 AFFECTED FILES

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Björn Feber
GB_2 added a comment. In D23942#531364 , @guoyunhe wrote: > @GB_2 is it correct now? There's still a hardcoded `style="fill:#da4453"` in the `disable` icons. REPOSITORY R266 Breeze Icons REVISION DETAIL

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe added a comment. @GB_2 is it correct now? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe updated this revision to Diff 66080. guoyunhe added a comment. Add inline styles REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66077=66080 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942 AFFECTED FILES

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Björn Feber
GB_2 added a comment. In D23942#531349 , @guoyunhe wrote: > I was asked to remove the hard code color like: `fill="currentColor"` and `fill="#da4453"`. But I see other icons have something like `style="fill:currentColor"`. Can anyone tell me

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe added a comment. I was asked to remove the hard code color like: `fill="currentColor"` and `fill="#da4453"`. But I see other icons have something like `style="fill:currentColor"`. Can anyone tell me correct way of applying colors? REPOSITORY R266 Breeze Icons REVISION DETAIL

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Björn Feber
GB_2 added a comment. In D23942#531347 , @guoyunhe wrote: > @ndavis it looks strange when I removed the inline style > > {F7351830} The inline style needs to be included, how it is now. REPOSITORY R266 Breeze Icons REVISION

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe added a comment. @ndavis it looks strange when I removed the inline style F7351830: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis,

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. Then it's fine. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe added a comment. I just followed the email icons' color: check mark is black/white, disable mark is red. F7351796: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze,

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Noah Davis
ndavis added a comment. In D23942#531337 , @GB_2 wrote: > In D23942#531330 , @ngraham wrote: > > > Shouldn't the checkmark be green? > > > FWIW, both should be black/white. Disabling is not a

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Björn Feber
GB_2 added a comment. In D23942#531330 , @ngraham wrote: > Shouldn't the checkmark be green? FWIW, both should be black/white. Disabling is not a destructive action like removing. REPOSITORY R266 Breeze Icons REVISION DETAIL

D23915: Improve documentation

2019-09-14 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 66078. gladhorn retitled this revision from "Improve documentation Some of the documentation did not say what the purpose of the respective class was, but rather gave a tautology. For people new to the code base it helps to mention that DPMS is power

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Nathaniel Graham
ngraham added a comment. Shouldn't the checkmark be green? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe updated this revision to Diff 66077. guoyunhe added a comment. Remove hardcoded colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66071=66077 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942 AFFECTED FILES

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Noah Davis
ndavis added a comment. In D23942#531279 , @guoyunhe wrote: > @ndavis, @broulik, @ngraham, I made some change. Can you have another look? I just noticed that the "No" symbol is backwards. Once you fix that and the hardcoded colors, this

D23946: Remove dependency on kdesignerplugin

2019-09-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. The current macro does not check for the existence, so the dep is hard IMHO. One could change that, but myself no energy left to work on/review such patch, all my energy would be spent to get of kdelibs4support completely in general :) REPOSITORY R239

D23902: [KCoreDirLister] replace deprecated foreach with range-for

2019-09-14 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kcoredirlister.cpp:1044 > It's generally considered bad practice to return a const value, because the > caller makes a copy anyway, so this doesn't guarantee anything. And it > removes the benefits of rvalues that can be

D23902: [KCoreDirLister] replace deprecated foreach with range-for

2019-09-14 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 66073. ahmadsamir marked 7 inline comments as done. ahmadsamir retitled this revision from "[KCoreDirLister] replace foreach with range-for" to "[KCoreDirLister] replace deprecated foreach with range-for". ahmadsamir added a comment. Fix stuff

D23946: Remove dependency on kdesignerplugin

2019-09-14 Thread Antonio Rojas
arojas added a comment. Does that really justify a hard dependency? It would make more sense for the dependency to be moved to the projects that do use the macro. extra-cmake-modules ships macros that call sip or doxygen and it doesn't hard depend on them. REPOSITORY R239 KDELibs4Support

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe added a comment. @ndavis, @broulik, @ngraham, I made some change. Can you have another look? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis Cc: ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe updated this revision to Diff 66071. guoyunhe added a comment. Add 16px icons for font-enable and font-disable REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66067=66071 BRANCH master REVISION DETAIL

D23946: Remove dependency on kdesignerplugin

2019-09-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. PS: That''s also the reason why I gave up on porting kdelibs4support away from it, given the tool is leaked in the public interface by this macro (cmp. comment D22776#503175 ) REPOSITORY R239 KDELibs4Support REVISION

D23946: Remove dependency on kdesignerplugin

2019-09-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. It's there because one of the cmake macros kdelibs4support installs depends on its existance, see https://phabricator.kde.org/source/kdelibs4support/browse/master/src/KDEUIMacros.cmake$166 REPOSITORY R239 KDELibs4Support REVISION DETAIL

D23946: Remove dependency on kdesignerplugin

2019-09-14 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Not sure what the reason was to have it here in the first place, but it doesn't seem

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

2019-09-14 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH 1_kprocesrunner REVISION DETAIL https://phabricator.kde.org/D23944 To: dfaure, vkrause, nicolasfella, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe updated this revision to Diff 66067. guoyunhe added a comment. Reduce space between A and marks REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66050=66067 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

2019-09-14 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > katemodemenulist.cpp:175 > +// which will remain hidden and will only be shown when necessary. > +createSectionList(QStringLiteral(""), false); > +m_list->setRowHidden(0, true); QStringLiteral("") us discouraged and should simply be

D14707: autotests: skip '/' fstab check with zfs

2019-09-14 Thread David Faure
dfaure added a reviewer: adridg. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14707 To: dfaure, adridg Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

2019-09-14 Thread David Faure
dfaure created this revision. dfaure added reviewers: vkrause, nicolasfella, broulik. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY - Make that functionality

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 14:21:37 + Build duration: 1 min 34 sec and counting JUnit Tests Name:

D23939: [KService] add workingDirectory(), deprecate path().

2019-09-14 Thread David Faure
dfaure closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D23939 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe updated this revision to Diff 66050. guoyunhe edited the summary of this revision. guoyunhe added a comment. Rename enablefont and disablefont icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23942?vs=66043=66050 BRANCH master

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Noah Davis
ndavis added a comment. Oof, all of the font icons that contain an 'A' need to be cleaned up someday. The 'A's aren't even 16px tall and the line thickness and alignment is all over the place. I guess that's something for another patch. For now, we should maintain consistency with the

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe added a comment. In D23942#531086 , @broulik wrote: > Please use a more hierarchical name, e.g. "font-enable" and "font-disable", to match the other font icons we have such as "font-size-up" and "font-face" OK. Then need to

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. There's a bit too much space around the checkmark. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis Cc: ndavis,

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Kai Uwe Broulik
broulik added a comment. Please use a more hierarchical name, e.g. "font-enable" and "font-disable", to match the other font icons we have such as "font-size-up" and "font-face" REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze Cc:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/74/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 14:03:31 + Build duration: 8 min 26 sec and counting JUnit Tests Name:

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Nathaniel Graham
ngraham added a comment. Thanks! Please create a 16px version as well. Monochrome icons need both sizes. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23943: HiDPI support

2019-09-14 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R311:1147829e8ea8: HiDPI support (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23943?vs=66047=66048 REVISION DETAIL

D23943: HiDPI support

2019-09-14 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D23943 To: guoyunhe, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23943: HiDPI support

2019-09-14 Thread Yunhe Guo
guoyunhe added a reviewer: Frameworks. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D23943 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23943: HiDPI support

2019-09-14 Thread Yunhe Guo
guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY Make the change password pop up sharp in HiDPI display, which is a part of kwalletd. REPOSITORY R311 KWallet

KDE CI: Frameworks » kunitconversion » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Fixed!

2019-09-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20WindowsMSVCQt5.13/5/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Sep 2019 11:41:57 + Build duration: 2 hr 6 min and counting JUnit Tests

D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5

2019-09-14 Thread Christoph Feck
cfeck added a comment. I somehow knew autotest would fail on FreeBSD ... I cannot investigate why it fails, maybe too old MIME database? REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D23811 To: cfeck, #frameworks, aacid Cc: aacid, kde-frameworks-devel,

D23939: [KService] add workingDirectory(), deprecate path().

2019-09-14 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D23939 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 12:09:48 + Build duration: 39 min and counting JUnit Tests Name:

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe edited the summary of this revision. guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23902: [KCoreDirLister] replace foreach with range-for

2019-09-14 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoredirlister.cpp:285 > { > -Q_FOREACH (CachedItemsJob *job, m_cachedItemsJobs) { > +for (CachedItemsJob *job : qAsConst(m_cachedItemsJobs)) { >

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 11:43:30 + Build duration: 1 hr 2 min and counting JUnit Tests Name:

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Yunhe Guo
guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942 AFFECTED FILES

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 61 - Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/61/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Sep 2019 11:42:09 + Build duration: 52 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 11:42:09 + Build duration: 49 min and counting JUnit Tests Name:

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

2019-09-14 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH fix_unittest_if_lsof_is_not_installed REVISION DETAIL https://phabricator.kde.org/D23884 To: hallas, dfaure Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

2019-09-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik,

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 11:41:38 + Build duration: 35 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 11:41:19 + Build duration: 33 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/15/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 11:40:54 + Build duration: 31 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 73 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/73/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 11:39:46 + Build duration: 30 min and counting JUnit Tests Name: projectroot

D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5

2019-09-14 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R287:68bb1a0ee7f9: Port HDR (Radiance RGBE) image loader to Qt5 (authored by cfeck). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23811?vs=65784=66041 REVISION

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 80 - Fixed!

2019-09-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/80/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Sep 2019 11:37:33 + Build duration: 24 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 6 - Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/6/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Sep 2019 11:36:57 + Build duration: 23 min and counting JUnit Tests Name:

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-09-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. Quick update: Currently still busy trying to get unit tests done, half-way through that. ETA begin of upcoming week. Next plan: see how only having the 3-arg-`FOO_DEPRECATED_VERSION(major. minor, message)` would work by using that in the experimental patches

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 11:38:04 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 11:38:15 + Build duration: 15 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 11:37:33 + Build duration: 13 min and counting JUnit Tests Name:

D23939: [KService] add workingDirectory(), deprecate path().

2019-09-14 Thread David Faure
dfaure created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Reading code like service->path() is confusing, because it looks like the path to the .desktop file (which is in fact

D23791: ECMAddQch: add INCLUDE_DIRS argument

2019-09-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I don't know doxygen very well, but the cmake change seems sensible. REPOSITORY R240 Extra CMake Modules BRANCH supoortincludedirsinaddqch REVISION DETAIL

D23937: [KDeclarative] Port away from deprecated QWheelEvent methods

2019-09-14 Thread David Faure
dfaure created this revision. dfaure added reviewers: davidedmundson, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This finishes the work to make kdeclarative compile with Qt 5.14, when

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/72/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 10:10:44 + Build duration: 7 min 12 sec and counting JUnit Tests Name:

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

2019-09-14 Thread David Faure
dfaure closed this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23894 To: dfaure, mart, davidedmundson Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Unstable!

2019-09-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/71/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Sep 2019 10:00:40 + Build duration: 9 min 58 sec and counting JUnit Tests Name:

  1   2   >