D22569: [Dialog] Apply window type after changing flags

2019-09-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:67811e152a67: [Dialog] Apply window type after changing flags (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22569?vs=6208

D23968: Use app specific location for DB on Android

2019-09-15 Thread Nicolas Fella
nicolasfella added a comment. I thought the same thing, but I'm not sure if changing that could break some apps REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23968 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23970: Port away from deprecated methods in Qt 5.14

2019-09-15 Thread David Faure
dfaure closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23970 To: dfaure, davidedmundson, broulik, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 80 - Still unstable!

2019-09-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/80/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 01:12:26 + Build duration: 29 min and counting JUnit Tests Name: projectroot Fail

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

2019-09-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 00:40:10 + Build duration: 50 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 19 - Unstable!

2019-09-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/19/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 16 Sep 2019 00:40:11 + Build duration: 49 min and counting BUILD ARTIFACTS abi-compatibility-r

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

2019-09-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 00:27:31 + Build duration: 55 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 81 - Unstable!

2019-09-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/81/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Sep 2019 00:00:09 + Build duration: 15 min and counting BUILD ARTIFACTS abi-compatibilit

D23970: Port away from deprecated methods in Qt 5.14

2019-09-15 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23970 To: dfaure, davidedmundson, broulik, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23968: Use app specific location for DB on Android

2019-09-15 Thread Aleix Pol Gonzalez
apol added a comment. Then maybe Qt shouldn't offer it? It's supposed to be writtable after all... REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23968 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23879: Add Qt Designer icon symlink

2019-09-15 Thread Björn Feber
GB_2 updated this revision to Diff 66167. GB_2 added a comment. Also for Qt 4 REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23879?vs=66166&id=66167 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23879 AFFECTED FILES icons-dark/app

D23879: Add Qt Designer icon symlink

2019-09-15 Thread Björn Feber
GB_2 updated this revision to Diff 66166. GB_2 added a comment. Rename to `designer-qt5` to avoid overriding unrelated icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23879?vs=65857&id=66166 BRANCH master REVISION DETAIL https://phabricator.

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber
GB_2 updated this revision to Diff 66162. GB_2 added a comment. Really add back "Show Alternatives..." item REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=66160&id=66162 BRANCH move-panel-options-contextmenu-items-out-of-subm

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber
GB_2 updated this revision to Diff 66160. GB_2 added a comment. Add back "Show Alternatives..." item REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=66103&id=66160 BRANCH move-panel-options-contextmenu-items-out-of-submenu-and

D21197: [KCoreDirLister] Remove assert in reinsert method

2019-09-15 Thread David Faure
dfaure added a comment. @chinmoyr D23875 fixes the crash, I suggest to abandon this change request. We can discuss it again if someone manages to hit the assert again, in a different scenario :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricato

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread Dominik Haumann
dhaumann added a comment. @dfaure: D21197 can be closed / abandoned? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: dfaure, #frameworks, ahmadsamir Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, br

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread David Faure
dfaure added a comment. Yeah I didn't change the git commit's author. It's partly your code, partly me deleting someone else's code :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: dfaure, #frameworks, ahmadsamir Cc: dhaumann, kde-frameworks-devel, LeGast00

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread Ahmad Samir
ahmadsamir added a comment. Here, in the web-UI, it says authored by dfaure, as it should, but the commit still says authored by me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: dfaure, #frameworks, ahmadsamir Cc: dhaumann, kde-frameworks-devel, LeGast00n,

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Nathaniel Graham
ngraham added a comment. OK cool, let's move the general UX discussion back into T10190 and use these just for implementation discussion. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread David Faure
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:f539b17ceec2: KCoreDirLister: fix crash when creating new folders from kfilewidget (authored by ahmadsamir, committed b

D23963: [KTextEditor] Port away from deprecated qBinaryFind

2019-09-15 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R39:532e9dc7bac8: [KTextEditor] Port away from deprecated qBinaryFind (authored by dfaure). Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. REPOSITORY

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Nathaniel Graham
ngraham added a task: T10190: (Re)define modes when editing panels and widgets. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 62 - Fixed!

2019-09-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/62/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Sep 2019 19:00:13 + Build duration: 7 min 54 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

2019-09-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Sep 2019 19:00:12 + Build duration: 6 min 8 sec and counting JUnit Tests Name: projec

D23915: Improve documentation

2019-09-15 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes. Closed by commit R127:6388d550e3a2: Improve documentation (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23915?vs=66078&id=66150 REVISION DETAIL https://phabr

D23915: Improve documentation

2019-09-15 Thread Roman Gilg
romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH arcpatch-D23915_1 REVISION DETAIL https://phabricator.kde.org/D23915 To: gladhorn, #kwin, romangg Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23961: Add apidox to most of KFilePlacesModel

2019-09-15 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R241:bcf51ae68193: Add apidox to most of KFilePlacesModel (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23961?vs=66124&id=66149 REVISION DET

D23955: KBookmark: improve addBookmark apidox

2019-09-15 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R294:797763d4b4d2: KBookmark: improve addBookmark apidox (authored by elvisangelaccio). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23955?vs=66108&id=66148 REVISI

D23969: [kpropertiesdialog] add icons for the size section

2019-09-15 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R241:764616b91b21: [kpropertiesdialog] add icons for the size section (authored by tienisto, committed by GB_2). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23969?vs=6613

D23969: [kpropertiesdialog] add icons for the size section

2019-09-15 Thread Björn Feber
GB_2 accepted this revision. REPOSITORY R241 KIO BRANCH kpropertiesdialog-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23969 To: tienisto, #vdg, ngraham, GB_2 Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, G

D23969: [kpropertiesdialog] add icons for the size section

2019-09-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R241 KIO BRANCH kpropertiesdialog-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23969 To: tienisto, #vdg, ngraham Cc: kde-frameworks-d

D23972: Add icons for "Open With" and "Actions" menus

2019-09-15 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e574f67a319e: Add icons for "Open With" and "Actions" menus (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23972?vs=66139&id=66140 REVISION DETA

D23972: Add icons for "Open With" and "Actions" menus

2019-09-15 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Excellent! REPOSITORY R241 KIO BRANCH icons-in-context-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D23972 To: ngraham, #vdg, GB_2 Cc: kde-frameworks-devel, L

D23972: Add icons for "Open With" and "Actions" menus

2019-09-15 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, GB_2. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY As requested in D23757 TEST PLAN F7356406: a

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread Ahmad Samir
ahmadsamir added a comment. Thanks for the explanation; it filled all the, various, gaps in my reasoning. Looks good to me. (I don't have a dev account, so probably phab.kde.org doesn't show the "accept revision" or similar in its web UI for me). INLINE COMMENTS > dfaure wrote in kfilew

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

2019-09-15 Thread Kai Uwe Broulik
broulik added a comment. Ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23145 To: broulik, vonreth, pali, antlarr, bruns Cc: apol, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, m

D23970: Port away from deprecated methods in Qt 5.14

2019-09-15 Thread David Faure
dfaure created this revision. dfaure added reviewers: davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN Builds with -DQT_DISABLE_DEPRECATED_BEFORE=0x06 (as of today) REPOSITORY

D23969: [kpropertiesdialog] add icons for the size section

2019-09-15 Thread Tien Do Nam
tienisto retitled this revision from "add icons for kpropertiesdialog" to "[kpropertiesdialog] add icons for the size section". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23969 To: tienisto, #vdg, ngraham Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, k

D23969: add icons for kpropertiesdialog

2019-09-15 Thread Tien Do Nam
tienisto edited the summary of this revision. tienisto added a reviewer: ngraham. tienisto added projects: Dolphin, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23969 To: tienisto, #vdg, ngraham Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinart

D23968: Use app specific location for DB on Android

2019-09-15 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY GenericDataLocation is typically not trivially writable on Android. Since

D23969: add icons for kpropertiesdialog

2019-09-15 Thread Tien Do Nam
tienisto created this revision. tienisto added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tienisto requested review of this revision. REVISION SUMMARY add icons for two buttons in the "size" section TEST PLAN Open properties of a fold

D23961: Add apidox to most of KFilePlacesModel

2019-09-15 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Nice work! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23961 To: elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra

D23960: [KTextEditor] Port away from deprecated QModelIndex::child()

2019-09-15 Thread David Faure
dfaure closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23960 To: dfaure, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23960: [KTextEditor] Port away from deprecated QModelIndex::child()

2019-09-15 Thread David Faure
dfaure added a comment. -DQT_DISABLE_DEPRECATED_BEFORE=0x06 leaves me no choice ;-) REPOSITORY R39 KTextEditor BRANCH port_child REVISION DETAIL https://phabricator.kde.org/D23960 To: dfaure, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, micha

D23960: [KTextEditor] Port away from deprecated QModelIndex::child()

2019-09-15 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for taking care, I was always to lazy too tackle that :/ REPOSITORY R39 KTextEditor BRANCH port_child REVISION DETAIL https://phabricator.kde.org/D23960 To: dfaure, cullm

D23961: Add apidox to most of KFilePlacesModel

2019-09-15 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 66124. elvisangelaccio added a comment. Mention that URLs will be stored in the QUrl::FullyEncoded string format. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23961?vs=66121&id=66124 BRANCH master REVISION DET

D23961: Add apidox to most of KFilePlacesModel

2019-09-15 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 66121. elvisangelaccio added a comment. - Fixed typo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23961?vs=66118&id=66121 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23961 AFFECTED FILES sr

D23961: Add apidox to most of KFilePlacesModel

2019-09-15 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde

D23960: [KTextEditor] Port away from deprecated QModelIndex::child()

2019-09-15 Thread David Faure
dfaure created this revision. dfaure added reviewers: cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dfaure requested review of this revision. REVISION SUMMARY A bit more verbose in some places, but actually simpler in c

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Still Unstable!

2019-09-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/78/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Sep 2019 12:26:25 + Build duration: 7 min 17 sec and counting JUnit Tests Name: projectroo

D23954: KRun: port to KService::Ptr

2019-09-15 Thread David Faure
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23954 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread David Faure
dfaure commandeered this revision. dfaure edited reviewers, added: ahmadsamir; removed: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: dfaure, #frameworks, ahmadsamir Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread David Faure
dfaure resigned from this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: ahmadsamir, #frameworks Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread David Faure
dfaure updated this revision to Diff 66116. dfaure added a comment. Simplify autotest; suggest a different fix which removes unnecessary updates and preserves the assert. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23875?vs=66104&id=66116 BRANCH arcpatch

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Sorry it took me a long time to review this. The commit didn't fully satisfy my need to understand the underlying problem, so I had to find the time to debug the issue (thanks for

KF6 Sprint

2019-09-15 Thread Volker Krause
Hi, as you might have seen in David's summary of the KF6 BoF at Akademy (https:// mail.kde.org/pipermail/kde-frameworks-devel/2019-September/093298.html), there's the idea to have a KF6 sprint, along the lines of the KF5 sprint we had in Randa a few years back, to determine what we actually want

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Still Unstable!

2019-09-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/77/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Sep 2019 10:53:06 + Build duration: 7 min 26 sec and counting JUnit Tests Name: projectroo

D23956: KFilePlacesModel: fix @since tags

2019-09-15 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R241:90c5872c08de: KFilePlacesModel: fix @since tags (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23956?vs=66109&id=66111 REVISION DETAIL

D23956: KFilePlacesModel: fix @since tags

2019-09-15 Thread Elvis Angelaccio
elvisangelaccio added a comment. Yeah, that's my next patch ;) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23956 To: elvisangelaccio, dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23956: KFilePlacesModel: fix @since tags

2019-09-15 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I'll trust you on the numbers. While you're at it, did you notice how much missing method documentation there is in in this class? :-) REPOSITORY R241 KIO BRANCH master REVISION

D23956: KFilePlacesModel: fix @since tags

2019-09-15 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added reviewers: dfaure, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY A bunch of @since tags were missing or wrong. While at

D23954: KRun: port to KService::Ptr

2019-09-15 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH 2019_krun_rewrite REVISION DETAIL https://phabricator.kde.org/D23954 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Heads-up: KContacts and KCalendarCore about to move to Frameworks

2019-09-15 Thread Volker Krause
Hi, as previously discussed here and finally approved during Akademy we will move KContacts and KCalendarCore from Applications to Frameworks. This should hopefully cause minimal disruptions as the versions then released with KF 5.63 are drop-in replacements for the previously releases with App

D23955: KBookmark: improve addBookmark apidox

2019-09-15 Thread Elvis Angelaccio
elvisangelaccio added a comment. In D23955#531647 , @dfaure wrote: > OK (why does this matter to the user of the class, though?) See D23706 , dolphin is going to need regex-based matches on the placesmo

D23955: KBookmark: improve addBookmark apidox

2019-09-15 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK (why does this matter to the user of the class, though?) REPOSITORY R294 KBookmarks BRANCH master REVISION DETAIL https://phabricator.kde.org/D23955 To: elvisangelaccio, dfaure C

D23955: KBookmark: improve addBookmark apidox

2019-09-15 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY Clarify that the URL will be stored in its toString(QUrl::Full

D23954: KRun: port to KService::Ptr

2019-09-15 Thread David Faure
dfaure created this revision. dfaure added a reviewer: vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY One more step towards KJob TEST PLAN krununittest; kruntest REPOSITORY R241 KIO B

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber
GB_2 added a dependent revision: D23952: Remove panel toolbox clean up editing options. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 66104. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir removed a reviewer: chinmoyr. ahmadsamir added a comment. Refer to one bug report, the others are dupes REPOSITORY R241 KIO CHANGES S

D23951: Improve desktop layout and panel editing UX

2019-09-15 Thread Björn Feber
GB_2 retitled this revision from "Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option" to "Improve desktop layout and panel editing UX". GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://pha

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

2019-09-15 Thread Björn Feber
GB_2 updated this revision to Diff 66103. GB_2 added a comment. Only show "Unlock Widgets" in the UI and only show "Show Alternatives..." in panel edit mode REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=66095&id=66103 BRANCH