D21235: Add handling of fuseiso filesystem type

2019-09-21 Thread David Hallas 
hallas added a comment.


  I have been resurrecting this patch again :) and have run into an issue I 
need some guidance on. To be able to parse the `~/.mtab.fuseiso` file I would 
like to use the `KMountPoint` class, but this class currently resides in KIO 
which Solid doesn't depend on. But, KIO actually depends on Solid so would it 
be an option to move this class from KIO to Solid?

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24020: Support NetworkManager 1.20 and do actually compile the NM backend

2019-09-21 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D24020

To: arojas, #frameworks, dfaure
Cc: lbeltrame, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

2019-09-21 Thread David Faure 
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  LOL I had no idea that one could do SmallIcon("foo", KIconLoader::SizeLarge) 
;-)
  
  I think 95% of the uses of these functions only specifies one argument.
  
  Then again, I just grepped for usage of SmallIcons in KF5, and one of the 
only two hits in non-deprecated modules is
  
kio/src/filewidgets/kimagefilepreview.cpp
200:
imageLabel->setPixmap(SmallIcon(QStringLiteral("image-missing"), 
KIconLoader::SizeLarge,
  
  Can you port KIO?
  
  Also I think you're missing #ifndef KICONTHEMES_NO_DEPRECATED around the 
newly deprecated methods
  (which helps to do a local experimental build with this being set, to catch 
all users and port them).

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

2019-09-21 Thread David Faure 
dfaure added a comment.


  kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon.
  (and that's all I can find in all of KF5)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread Phabricator 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:faff4ff246af: Add app icon for the Kirogi Drone control 
app (authored by Rafael Brandmaier ).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21169?vs=66594&id=66595

REVISION DETAIL
  https://phabricator.kde.org/D21169

AFFECTED FILES
  icons-dark/apps/48/kirogi.svg
  icons/apps/48/kirogi.svg

To: trickyricky26, hein, #vdg, ngraham
Cc: ognarb, ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, 
michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 66594.
trickyricky26 added a comment.


  - A tiny bit more optimized

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21169?vs=57954&id=66594

BRANCH
  kirogi-app-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21169

AFFECTED FILES
  icons-dark/apps/48/kirogi.svg
  icons/apps/48/kirogi.svg

To: trickyricky26, hein, #vdg, ngraham
Cc: ognarb, ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, 
michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

2019-09-21 Thread Nathaniel Graham 
ngraham added a comment.


  +1

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24136

To: vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit!

REPOSITORY
  R266 Breeze Icons

BRANCH
  kirogi-app-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg, ngraham
Cc: ognarb, ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, 
michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread Carl Schwan 
ognarb added a comment.


  kde.org/applications use the icons from breeze-icons. So I think it's worth 
adding to breeze-icons or improving how the icon are fetched in 
kde.org/applications.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ognarb, ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, 
michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread TrickyRicky 
trickyricky26 added a comment.


  Should I land this or abandon it?
  It doesn't really make a difference if the icon is in Breeze in addition to 
being shipped with the app, but IMO it would also be strange to not have this 
Breeze-style icon for a KDE app in Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, michaelh, bruns

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

2019-09-21 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  They are not namespaced and promote the use of pixmaps rather than
  icons. Additionally their API allowing to specify a size that differs
  from the size suggested by their name leads to bizarre usage like
  'SmallIcon("foo", KIconLoader::SizeLarge)'.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24136

AFFECTED FILES
  src/kiconloader.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one in okular

2019-09-21 Thread Carl Schwan 
ognarb abandoned this revision.
ognarb added a comment.


  I completly forgot about this patch and since KHTML is dead and is getting 
removed from most of our apps, it doesn't makes sence to land this patch.

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D19620: Use a searchbar similar to the one in okular

2019-09-21 Thread Nathaniel Graham 
ngraham added a comment.


  Isn't KHTML deprecated at this point? Does this actually need to happen?

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Unstable!

2019-09-21 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/4/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Sep 2019 13:25:10 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: projectroot.autotests.Rec

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 4 - Fixed!

2019-09-21 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/4/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Sep 2019 13:25:10 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.63.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 492 test(s), Skipped: 0 test(s), Total: 492 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9041/13173)48%
(4093/8574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2657/2779)52%
(743/1438)src94%
(44/47)94%
(44/47)61%
(6384/10394)47%
(3350/7136)

D21897: Address some issues reported by Krazy analysis

2019-09-21 Thread Elvis Angelaccio 
elvisangelaccio added inline comments.

INLINE COMMENTS

> pajamapants3000 wrote in ktextedit.cpp:373
> Thank you broulik! Could we use a `QScopedPointer` here? I see them 
> throughout the KDE source, but not often for dialogs. The krazy analysis 
> looked for `QPointer`, referencing blog https://blogs.kde.org/node/3919, 
> which appears to have predated the existence of `QScopedPointer`.

While we are at it, the best way to fix this would be to not use `exec()` at 
all, but use `open()` instead: 
https://wiki.qt.io/New_Signal_Slot_Syntax#Asynchronous_made_easier

REPOSITORY
  R310 KTextWidgets

BRANCH
  krazy-50b2564 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21897

To: pajamapants3000, elvisangelaccio
Cc: broulik, vkrause, elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 4 - Fixed!

2019-09-21 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Sep 2019 13:25:10 +
 Build duration:
5 min 12 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.63.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 492 test(s), Skipped: 0 test(s), Total: 492 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9041/13173)48%
(4093/8574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2657/2779)52%
(743/1438)src94%
(44/47)94%
(44/47)61%
(6384/10394)47%
(3350/7136)

D23902: [KCoreDirLister] replace deprecated foreach with range-for

2019-09-21 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kcoredirlister.cpp:1044
> Noted.

Actually, I was wrong.
I talked to the head of the LLVM/clang development team at Apple and he told me 
that returning a const value has zero effect whatsoever. I.e. in the version of 
your patch where you were returning a const value, the range for would *still* 
call the non-const begin() and end(). Good thing I made you change that :-)

His plan is to make a future version of the C++ standard deprecate const 
arguments and const return values in function declarations. (toplevel const 
only, const-ref is fine of course).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23902

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one in okular

2019-09-21 Thread Björn Feber 
GB_2 added a comment.


  Ping.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D24020: Support NetworkManager 1.20 and do actually compile the NM backend

2019-09-21 Thread Antonio Rojas 
arojas added a reviewer: Frameworks.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D24020

To: arojas, #frameworks
Cc: lbeltrame, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24060: Make KColorScheme compatible with QVariant

2019-09-21 Thread Volker Krause 
vkrause added a task: T8837: QColor support for Grantlee.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24060

To: vkrause, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns