KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 52 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/52/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 30 Sep 2019 03:07:25 + Build duration: 10 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.63.

D24261: Modernize code: use range-based for loop in more places

kossebau updated this revision to Diff 67047. kossebau added a comment. - move &/* to variable name ' use explicit const REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24261?vs=66989&id=67047 BRANCH morerangebasedforloops REVISION DETAIL https://

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in browseropenorsavequestion.cpp:270 > auto or not auto isn't the question when it comes to const :-) > > Would you have written `foreach(QString &app, apps)` if `apps` was a > qstringlist (to simplify)? > Or `for (QString &app : ap

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau updated this revision to Diff 67046. kossebau marked 3 inline comments as done. kossebau added a comment. - move &/* to varname - explicit const with auto types REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24262?vs=66996&id=67046 BRANCH morer

D24262: Modernize code: use range-based loops & algorithms in more places

dfaure added inline comments. INLINE COMMENTS > kossebau wrote in browseropenorsavequestion.cpp:270 > In most projects I have seen people omitting the const, and only adding > explicitly any &/* to help the human reader a bit more. > If you prefer explicit const, fine with me, personally undecid

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added a comment. In D24262#539348 , @ahmadsamir wrote: > @kossebau: did you try the C++ Standard (working draft): https://isocpp.org/blog/2013/10/n3797-working-draft-standard-for-programming-language-c-stefanus-du-toit > > This ^ on

D24262: Modernize code: use range-based loops & algorithms in more places

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in browseropenorsavequestion.cpp:270 > Why not *const* auto &app? In most projects I have seen people omitting the const, and only adding explicitly any &/* to help the human reader a bit more. If you prefer explicit const, fine wit

D24262: Modernize code: use range-based loops & algorithms in more places

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please make the loop variable const-ref whenever possible. INLINE COMMENTS > browseropenorsavequestion.cpp:270 > QObject::connect(menu, &QMenu::triggered, d, > &

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/109/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 29 Sep 2019 21:04:42 + Build duration: 7 min 12 sec and counting JUnit Tests Name: projectro

D24220: [src/ioslaves/*] replace deprecated foreach with range for

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24220 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/108/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 29 Sep 2019 20:33:40 + Build duration: 7 min 14 sec and counting JUnit Tests Name: projectro

D24220: [src/ioslaves/*] replace deprecated foreach with range for

ahmadsamir added a comment. (Please commit this one too). REPOSITORY R241 KIO BRANCH ahmad/foreach-ioslaves2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24220 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, brun

D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24171 To: ahmadsamir, kde-frameworks-devel, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure added a comment. In D24171#539612 , @ahmadsamir wrote: > (Reminder: I don't have a dev account so you'll have to commit the patches :)). If you keep this up, you should ask for one :-) REPOSITORY R241 KIO BRANCH ahmad/foreac

D24171: [src/filewidgets/*] replace deprecated foreach with range for

ahmadsamir added a comment. (Reminder: I don't have a dev account so you'll have to commit the patches :)). REPOSITORY R241 KIO BRANCH ahmad/foreach-filewidgets (branched from master) REVISION DETAIL https://phabricator.kde.org/D24171 To: ahmadsamir, kde-frameworks-devel, dfaure Cc:

D24171: [src/filewidgets/*] replace deprecated foreach with range for

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH ahmad/foreach-filewidgets (branched from master) REVISION DETAIL https://phabricator.kde.org/D24171 To: ahmadsamir, kde-frameworks-devel, dfaure C

D23920: Deprecate the KSslError::Error ctor of KSslError

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23920 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

This revision was automatically updated to reflect the committed changes. Closed by commit R216:72683653db72: Add syntax highlighting for SubRip Text (SRT) Subtitles (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator

D24210: KadeModeMenuList: fix memory leaks and others

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f1d9f086da6f: KadeModeMenuList: fix memory leaks and others (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24210?vs=6

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/ --- (Updated Sept. 29, 2019, 5:41 p.m.) Status -- This change has been d

D24245: Add support for passing Unix file descriptors

volkov added a comment. Without UnixFileDescriptor you could try to write int fd = ... Action action(...); action.addArgument(QStringLiteral("fd"), fd); but then KAuth won't be able to detect that it'a file descriptor and will pass it to a helper as int. REPOSITORY R283

D24245: Add support for passing Unix file descriptors

volkov added a comment. Yes, UnixFileDescriptor allows to use existing methods Action::setArguments() and ActionReply::setData(). REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: aacid, kde-framew

D24210: KadeModeMenuList: fix memory leaks and others

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Like that better, thanks! REPOSITORY R39 KTextEditor BRANCH fix-mode-menu REVISION DETAIL https://phabricator.kde.org/D24210 To: nibags, #ktexteditor, dhaumann, cullmann Cc: kwr

D24210: KadeModeMenuList: fix memory leaks and others

nibags updated this revision to Diff 67026. nibags added a comment. - Fix allocation in search names REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24210?vs=66864&id=67026 BRANCH fix-mode-menu REVISION DETAIL https://phabricator.kde.org/D24210 AFF

D24245: Add support for passing Unix file descriptors

aacid added a comment. Applications are supposed to do that? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24293: Make QSslError::SslError <-> KSslError::Error conversion reusable

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24293 To: vkrause, dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY An easy one admittedly. Uses have not been adapted yet, as this needs at least KSslC

D24293: Make QSslError::SslError <-> KSslError::Error conversion reusable

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This will allow a step by step migration of the certificate manager and kssld code t

D23920: Deprecate the KSslError::Error ctor of KSslError

vkrause added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23920 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns