D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[David Faure]

dfaure added a comment.


  In D23789#541134 , @kossebau wrote:
  
  > In D23789#540033 , @dfaure wrote:
  >
  > > I found confirmation in cmake's 
Tests/RunCMake/GenerateExportHeader/reference/
  >
  >
  > Not sure what you exactly mean, can you please specify confirmation for 
what? And what this recommends us to do? :)
  
  
  It confirms that only MSVC uses a different way to express this, which is why 
nobody handles the mix-and-match case where you'd generate the header for one 
compiler and then consume it with another.
  (unless I'm wrong and mix-and-match between mingw and MSVC is actually 
possible - AFAIK it's not)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau, #frameworks, #build_system
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24372: Compile without deprecated foreach

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> job.cpp:181
>  // kill all subjobs, without triggering their result slot
> -Q_FOREACH (KJob *it, subjobs()) {
> -it->kill(KJob::Quietly);
> +for (KJob *job : subjobs()) {
> +job->kill(KJob::Quietly);

You need a local const var to hold the result of the subjobs() method call.

(repeats)

> ksslcertificatemanager.cpp:380
>  
> -foreach (const QSslCertificate , 
> QSslCertificate::fromPath(userCertDir + QLatin1Char('*'),
> - QSsl::Pem, QRegExp::Wildcard)) {
> +const QList list2 = 
> QSslCertificate::fromPath(userCertDir + QLatin1Char('*'), QSsl::Pem,
> +   
> QRegExp::Wildcard);

`userList` would be a better variable name

> ktcpsocket.cpp:729
>  cl.reserve(d->ciphers.size());
> -foreach (const KSslCipher , d->ciphers) {
> +for (const KSslCipher  : qAsConst(d->ciphers)) {
>  cl.append(d->ccc.converted(c));

or just iterate over `ciphers`, which is already const

> scheduler.cpp:214
>  ret.reserve(m_runningJobs.size());
> -Q_FOREACH (SimpleJob *job, m_runningJobs) {
> +for (SimpleJob *job : qAsConst(m_runningJobs)) {
>  Slave *slave = jobSlave(job);

qAsConst not needed, this method is const

> scheduler.cpp:299
>  PerSlaveQueue  = it.value();
> -Q_FOREACH (SimpleJob *job, jobs.waitingList) {
> +for (SimpleJob *job : qAsConst(jobs.waitingList)) {
>  // ### for compatibility with the old scheduler we don't touch the 
> running job, if any.

I'm afraid that kill() ends up removing the job from waitingList. I would 
iterate over a copy to be safe.

> scheduler.cpp:377
>  Q_UNUSED(runningJobsCount);
>  #ifdef SCHEDULER_DEBUG
>  int realRunningJobsCount = 0;

Did you try enabling this to make sure your ported code compiles?

> dropjob.cpp:270
>  bool containsTrashRoot = false;
> -foreach (const QUrl , m_urls) {
> +for (const QUrl  : m_urls) {
>  const bool local = url.isLocalFile();

qAsConst

> dropjob.cpp:329
>  fileItems.reserve(m_urls.size());
> -foreach (const QUrl , m_urls) {
> +for (const QUrl  : m_urls) {
>  fileItems.append(KFileItem(url));

qAsConst

> dropjob.cpp:361
>  bool equalDestination = true;
> -foreach (const QUrl , m_urls) {
> +for (const QUrl  : m_urls) {
>  if (!m_destUrl.matches(src.adjusted(QUrl::RemoveFilename), 
> QUrl::StripTrailingSlash)) {

qAsConst

> kdirmodel.cpp:151
>  urls.reserve(urls.size() + m_childNodes.size());
> -Q_FOREACH (KDirModelNode *node, m_childNodes) {
> +for (KDirModelNode *node : qAsConst(m_childNodes)) {
>  const KFileItem  = node->item();

qAsConst not needed, method is const

> kfileitemdelegate.cpp:233
>  
> -foreach (KFileItemDelegate::Information info, informationList) {
> +for (KFileItemDelegate::Information info : qAsConst(informationList)) {
>  if (info == KFileItemDelegate::NoInformation) {

not needed, method is const and informationList is a member

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24372

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24477: [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

[Mason McParlane]

masonm added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24477

To: masonm, #vdg
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

[Albert Astals Cid]

aacid added a comment.


  ok, fair enough.
  
  Am i correct in understanding this breaks the wire-protocol for the dbus 
messages?
  
  Are we sure that's fine?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24395: Add some std::move in setter functions

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:1c8d9beb720f: Add some std::move in setter functions 
(authored by aacid).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24395?vs=67272=67469#toc

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24395?vs=67272=67469

REVISION DETAIL
  https://phabricator.kde.org/D24395

AFFECTED FILES
  src/comment.cpp
  src/content.cpp
  src/forum.cpp
  src/knowledgebaseentry.cpp

To: aacid, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe retitled this revision from "WIP: Treat 
"application/x-ms-dos-executable" as executable on all platforms" to "Treat 
"application/x-ms-dos-executable" as executable on all platforms".
guoyunhe edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24442: ensure winId() not called on non-native widgets

[David Faure]

dfaure added a comment.


  Done, this is in the v5.63.0-rc3 tag now.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D24442

To: cullmann, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24294

To: vkrause, dfaure, aacid
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe added a comment.


  It is now working. The condition is so complex. Please help test this patch!
  
  F7541884: image.png 

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe updated this revision to Diff 67458.
guoyunhe added a comment.


  Fix *.exe execution condition

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67444=67458

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24476: [KPropertiesDialog] Only show volume-related info for volumes

[Nathaniel Graham]

ngraham added a comment.


  In D24476#543297 , @broulik wrote:
  
  > Perhaps, but right clicking on my HOME will then give me no information as 
it's not a separate mount.
  
  
  Don't you already have the free space information in the status bar though?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24476

To: ngraham, #vdg, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24476: [KPropertiesDialog] Only show volume-related info for volumes

[Kai Uwe Broulik]

broulik added a comment.


  Perhaps, but right clicking on my HOME will then give me no information as 
it's not a separate mount.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24476

To: ngraham, #vdg, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24476: [KPropertiesDialog] Only show volume-related info for volumes

[Nathaniel Graham]

ngraham added a comment.


  It's not very accurate though. The free space is a property of the underlying 
volume, not the folder you happen to be looking at.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24476

To: ngraham, #vdg, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24477: [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

[Mason McParlane]

masonm created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
masonm requested review of this revision.

REVISION SUMMARY
  Build fails to generate binary resource (breeze-icons.rcc) by default. The 
proposed patch fixes this by adding the QtCore directory to the qrcAlias 
command invocation.

TEST PLAN
  1. In root of breeze-icons project generate the project using CMake with 
install prefix set
  2. The resultant makefiles or .vcxproj files should have PATH= (on Windows) and LD_LIBRARY_PATH= (on Unix)
  3. Build the install target
  4. Verify that breeze-icons.rcc was successfully copied to /bin/data/icons/breeze
  5. Same as 3 but for breeze-icons-dark.rcc
  
  Note: it must be tested when Qt is //not// already in the PATH or 
LD_LIBRARY_PATH

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24477

AFFECTED FILES
  CMakeLists.txt

To: masonm
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24476: [KPropertiesDialog] Only show volume-related info for volumes

[Kai Uwe Broulik]

broulik added a comment.


  Having the free space info bar on folders was always very useful imho

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24476

To: ngraham, #vdg, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24476: [KPropertiesDialog] Only show volume-related info for volumes

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now volume-related information is shown on the General page for all 
folders that
  are inside a volume. This is confusing because everything else on that page is
  contextually-relevant to the actual item whose properties you're looking at.
  
  With this patch, volume-related properties will only be shown when looking at 
the
  properties of the root level of a mounted volume.
  
  BUG: 412671
  FIXED-IN: 5.64

TEST PLAN
  F7541631: demo-2019-10-07_13.54.23.webm 

REPOSITORY
  R241 KIO

BRANCH
  only-show-volume-info-for-volumes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24476

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: ngraham, #vdg, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe retitled this revision from "Treat "application/x-ms-dos-executable" 
as executable on all platforms" to "WIP: Treat 
"application/x-ms-dos-executable" as executable on all platforms".
guoyunhe edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24439: Fix test kfileplacesmodeltest after D7446

[Méven Car]

meven added a comment.


  Fixed as of 
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/250/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24439

To: meven, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe updated this revision to Diff 67444.
guoyunhe added a comment.


  "openAsExecute" parameter for ExecutableFileOpenDialog

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67424=67444

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:494b068af264: Fix crash in writer collection and cleanup 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23411?vs=67376=67443

REVISION DETAIL
  https://phabricator.kde.org/D23411

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/writercollectiontest.cpp
  src/writer.cpp
  src/writer.h
  src/writer_p.h
  src/writercollection.cpp
  src/writercollection.h
  src/writers/CMakeLists.txt

To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D24442: ensure winId() not called on non-native widgets

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:93c19fbfa125: ensure winId() not called on non-native 
widgets (authored by cullmann).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24442?vs=67379=67442

REVISION DETAIL
  https://phabricator.kde.org/D24442

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: cullmann, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Ahmad Samir]

ahmadsamir added a reviewer: dfaure.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24294: Port KSslCertificateManager to QSslError

[Volker Krause]

vkrause added a comment.


  In D24294#543158 , @apol wrote:
  
  > I may be missing some context but this doesn't seem to be porting anything 
only adding a nonIgnorableErrors function that ignores whatever it gets.
  
  
  The context is the (still growing) patch series in T11620 
. Very small steps as this is rather 
sensitive code.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24294

To: vkrause, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24419

To: vkrause, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

[Aleix Pol Gonzalez]

apol added a comment.


  I may be missing some context but this doesn't seem to be porting anything 
only adding a nonIgnorableErrors function that ignores whatever it gets.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24294

To: vkrause, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

[Volker Krause]

vkrause added a comment.


  Ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24294

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

[Volker Krause]

vkrause added subscribers: dvratil, vkrause.
vkrause added a comment.


  Thanks for working on this! Some general thoughts:
  
  - Is KDeclarative is the right place for this? It's a module on the way out 
in KF6, it is hard to build for Android due to its dependency chain (which 
isn't even needed for this), while at the same time forcing ABI stability on 
this basically immediately without much chance for battle testing this.
  - This currently represents a flat list of calendars, which matches Android 
IIRC, but not Akonadi (which treats calendars as folders and thus 
hierarchical). That might not be a problem as long as we treat Akonadi as a 
single calendar and don't expose the different backends on this level at all, 
but IIUC @dvratil was argueing to move away from that approach.

INLINE COMMENTS

> calendarentry.cpp:26
> +CalendarEntry::CalendarEntry(const QString , const QString , 
> const QString , CalendarType type, KCalendarCore::Calendar::Ptr calendar)
> +: d(new CalendarEntryPrivate)
> +{

this is leaked it seems, maybe make d a unique_ptr?

> calendarentry.h:27
> +class CalendarEntryPrivate;
> +
> +class Q_DECL_EXPORT CalendarEntry : public QObject

add at least very minimal class-level API docs so this shows up on api.kde.org

> calendarentry.h:34
> +Q_PROPERTY(QString icon READ icon CONSTANT)
> +Q_PROPERTY(CalendarType type READ type CONSTANT)
> +Q_PROPERTY(KCalendarCore::Calendar::Ptr calendar READ calendar CONSTANT)

"type" is quite generic, maybe rather something like "permission"?

> davidedmundson wrote in calendarentry.h:57
> I don't understand what this is for.
> 
> Is it like Calendar::save ?

synchronize() maybe? ie. avoid abbreviations in API

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma
Cc: vkrause, dvratil, davidedmundson, dhaumann

Re: Call for action: applying version-based deprecation macros for KDE Frameworks API

[Volker Krause]

On Sunday, 6 October 2019 13:14:50 CEST Friedrich W. H. Kossebau wrote:
> PROTOTYPE BECOMING PRODUCTION VERSION
> 
> So far feedback has been positive (thanks especially David, but also
> Christian & Albert for comments). Could have been more feedback, but I
> project the silence onto "seems fine with me, nothing to object" :) If this
> does not represent you, now is your time to break your silence, please.

Thanks for working on this! While this will be quite some work to retrofit on 
to the existing KF5 codebase it will help us a lot with long term maintenance 
and with a smooth transition to KF6 and beyond :)

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.

D24442: ensure winId() not called on non-native widgets

[Christoph Cullmann]

cullmann added a comment.


  It would be great to have that in 5.63, or I am too late?

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24442

To: cullmann, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Looks good, quite similar to https://phabricator.kde.org/D23808

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24442

To: cullmann, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

[Christoph Cullmann]

cullmann added a comment.


  If nobody objects will push that later, without any window on secondary 
screen is garbage after palette change.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D24442

To: cullmann, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe added a comment.


  I just realized that this patch might be unfinished. In the pop up, you 
usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually 
to be executed by Wine? "Execute" will do nothing because it isn't a native 
executable for Linux/BSD.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24431: Restore cursor thumbnailer

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D24431

To: broulik, #plasma, fredrik, ngraham
Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a subscriber: dfaure.
ngraham added a comment.
This revision is now accepted and ready to land.


  I suppose that's true. Would be nice to also do that as a follow-up patch.
  
  Shipit!
  
  @dfaure given the security implications here, maybe we should get this into 
5.63. What do you think?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham
Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe added a comment.


  In D24463#543070 , @ngraham wrote:
  
  > Maybe can we check to see if WINE is installed or if there's a handler for 
`application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, 
won't you see a dialog that gives you the option to execute it when that 
doesn't work?
  
  
  It is another feature. We also need to check if PHP/Python/Perl/Ruby/Node.js 
is installed for other script types. It is not Wine specific problem but a 
general issue for all executable that requires an interpreter.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24464: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay)

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:39b92febeec5: i18n: Add ellipsis to action items 
(X-Purpose-ActionDisplay) (authored by aspotashev).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24464?vs=67426=67436

REVISION DETAIL
  https://phabricator.kde.org/D24464

AFFECTED FILES
  src/plugins/imgur/imgurplugin.json
  src/plugins/pastebin/pastebinplugin.json

To: aspotashev, apol, nicolasfella, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Nathaniel Graham]

ngraham added a comment.


  In D24453#543069 , @davidre wrote:
  
  > I could set `categorySpacing` in `KCategorizedView::Private::Private` to 0. 
F7538956: Screenshot_20191007_163458.png 
  >  But the difference is that in widgets the scrollbar doesn't overlap the 
contents.
  
  
  That's fine.
  
  Frankly I would really like a vertical line separating the scrollbar from the 
content for just this reason. IIRC Breeze used to have that but it lost it for 
some reason. When the scrollbar isn't an overlay, we should try to make it look 
like one IMO.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Nathaniel Graham]

ngraham added a comment.


  Maybe can we check to see if WINE is installed or if there's a handler for 
`application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, 
won't you see a dialog that gives you the option to execute it when that 
doesn't work?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[David Redondo]

davidre added a comment.


  I could set `categorySpacing` in `KCategorizedView::Private::Private` to 0. 
F7538956: Screenshot_20191007_163458.png 
  But the difference is that in widgets the scrollbar doesn't overlap the 
contents.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24464: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay)

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24464

To: aspotashev, apol, nicolasfella, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Nathaniel Graham]

ngraham added a comment.


  Might also be nice to add a comment somewhere in here reminding people to 
adjust the Kirigami BasicListHeader accordingly when this is changed (and vice 
versa).

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Nathaniel Graham]

ngraham added a task: T10384: Unify styles for lists and their buttons.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Nathaniel Graham]

ngraham added a comment.


  Nice. Is there any way to make it touch the edges of its parent view rather 
than having those small margins?

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24402: [PlasmaComponents3] Fix checkable toolbutton background

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:949a26d3fa0c: [PlasmaComponents3] Fix checkable 
toolbutton background (authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24402?vs=67287=67432

REVISION DETAIL
  https://phabricator.kde.org/D24402

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24468: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KWidgetsAddons to hide deprecated API up to a given 
version or silence deprecation warnings after a given version, using
- -DKWIDGETSADDONS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKWIDGETSADDONS_NO_DEPRECATED
- -DKWIDGETSADDONS_DEPRECATED_WARNINGS_SINCE
- -DKWIDGETSADDONS_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KWidgetsAddons optionally with deprecated API excluded from the 
build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, 5.13.0,
  CURRENT.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24468

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kactionmenu.cpp
  src/kactionmenu.h
  src/kmessagebox.h
  src/kmultitabbar.cpp
  src/kmultitabbar.h
  src/kratingwidget.cpp
  src/kratingwidget.h
  src/kruler.cpp
  src/kruler.h
  src/ktoolbarpopupaction.cpp
  src/ktoolbarpopupaction.h

To: kossebau, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24467: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KParts to hide deprecated API up to a given version or 
silence deprecation warnings after a given version, using
- -DKPARTS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKPARTS_NO_DEPRECATED
- -DKPARTS_DEPRECATED_WARNINGS_SINCE
- -DKPARTS_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KParts optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT.

REPOSITORY
  R306 KParts

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24467

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/browserextension.h
  src/browserrun.cpp
  src/browserrun.h
  src/readonlypart.cpp
  src/readonlypart.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KXmlGui to hide deprecated API up to a given version or 
silence deprecation warnings after a given version, using
- -DKXMLGUI_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKXMLGUI_NO_DEPRECATED
- -DKXMLGUI_DEPRECATED_WARNINGS_SINCE
- -DKXMLGUI_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KXmlGui optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.1.0, 5.0.0,
  CURRENT.

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kactioncollection.cpp
  src/kactioncollection.h
  src/kkeysequencewidget.cpp
  src/kkeysequencewidget.h
  src/kmainwindow.cpp
  src/kmainwindow.h
  src/kshortcutseditor.cpp
  src/kshortcutseditor.h
  src/kshortcutwidget.cpp
  src/kshortcutwidget.h
  src/ktoolbar.cpp
  src/ktoolbar.h
  src/kxmlguibuilder.cpp
  src/kxmlguibuilder.h
  tests/kmainwindowrestoretest.cpp

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24402: [PlasmaComponents3] Fix checkable toolbutton background

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-checkable-pc3-toolbutton-background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24402

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, KWin, dfaure, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KWindowSystem to hide deprecated API up to a given 
version or silence deprecation warnings after a given version, using
- -DKWINDOWSYSTEM_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKWINDOWSYSTEM_NO_DEPRECATED
- -DKWINDOWSYSTEM_DEPRECATED_WARNINGS_SINCE
- -DKWINDOWSYSTEM_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KWindowSystem optionally with deprecated API excluded from the 
build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.
  
  Setting KWINDOWSYSTEM_NO_WIDGETS ensures EXCLUDE_DEPRECATED_BEFORE_AND_AT
  is at least at the version where QWidgets API was deprecated.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, 5.18.0,
  5.38.0, 5.62.0, CURRENT as well as KWINDOWSYSTEM_NO_WIDGETS ON/OFF

REPOSITORY
  R278 KWindowSystem

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24465

AFFECTED FILES
  CMakeLists.txt
  autotests/kstartupinfo_unittest.cpp
  autotests/kwindowinfox11test.cpp
  autotests/kwindowsystemx11test.cpp
  autotests/kxmessages_unittest.cpp
  autotests/netwininfotestclient.cpp
  src/CMakeLists.txt
  src/kstartupinfo.cpp
  src/kstartupinfo.h
  src/kwindoweffects.cpp
  src/kwindoweffects.h
  src/kwindowsystem.cpp
  src/kwindowsystem.h
  src/kwindowsystem_dummy_p.h
  src/kwindowsystem_p.h
  src/netwm_def.h
  src/platforms/osx/kwindowsystem.cpp
  src/platforms/wayland/kwindowsystem.cpp
  src/platforms/wayland/kwindowsystem_p_wayland.h
  src/platforms/windows/kwindowsystem.cpp
  src/platforms/xcb/kkeyserver.cpp
  src/platforms/xcb/kkeyserver_x11.h
  src/platforms/xcb/kwindowsystem.cpp
  src/platforms/xcb/kwindowsystem_p_x11.h
  src/platforms/xcb/kxmessages.cpp
  src/platforms/xcb/kxmessages.h
  src/platforms/xcb/netwm.cpp
  src/platforms/xcb/netwm.h

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24464: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay)

[Alexander Potashev]

aspotashev created this revision.
aspotashev added reviewers: apol, nicolasfella.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

TEST PLAN
  none

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24464

AFFECTED FILES
  src/plugins/imgur/imgurplugin.json
  src/plugins/pastebin/pastebinplugin.json

To: aspotashev, apol, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Because of Wine, *.exe can be executed in almost all desktop platforms. BUG: 
412694

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/krun.cpp

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

[David Edmundson]

davidedmundson added a comment.


  Plan makes sense.

INLINE COMMENTS

> calendarentry.h:35
> +Q_PROPERTY(CalendarType type READ type CONSTANT)
> +Q_PROPERTY(KCalendarCore::Calendar::Ptr calendar READ calendar CONSTANT)
> +public:

If the intention is for QML to be able to get and access the 
CalendarCore::Calendar object this won't work. You'll need to return the raw 
pointer.

> calendarentry.h:57
> +public Q_SLOTS:
> +void sync();
> +

I don't understand what this is for.

Is it like Calendar::save ?

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma
Cc: davidedmundson, dhaumann

D24436: Add applications-network icon for renaming Internet category to Network

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:87d712c7a0e2: Add applications-network icon for renaming 
Internet category to Network (authored by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24436?vs=67364=67414

REVISION DETAIL
  https://phabricator.kde.org/D24436

AFFECTED FILES
  icons-dark/categories/32/applications-network.svg
  icons/categories/32/applications-network.svg

To: guoyunhe, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[David Redondo]

davidre edited the summary of this revision.
davidre edited the test plan for this revision.
davidre added reviewers: Frameworks, VDG.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

[Kai Uwe Broulik]

broulik added a comment.


  > Is the text in the window mouse-selectable?
  
  I don't think so (didn't test, just read the code) but should be trivial to 
add.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24429

To: broulik, #plasma
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[David Redondo]

davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REPOSITORY
  R276 KItemViews

BRANCH
  newcategorystyle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24453

AFFECTED FILES
  src/kcategorydrawer.cpp

To: davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Aleix Pol Gonzalez]

apol added a comment.


  ping?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23682

To: apol, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

[Dominik Haumann]

dhaumann added a comment.


  I'd go for a QVector for now. Arguing with Qt6 doesn't sound convincing to 
me, since Qt6 will take another>=1 year(s). So why try this experiment in 
public API now? :)

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma
Cc: dhaumann