D24621: [RFC] New Konsole and Yakuake icons

ndavis added a comment. The Yakuake icon is a major improvement. The little angled rectangle making the prompt arrow look like a Y is a little distracting, but also kind of charming and helps to distinguish it from Konsole. I kind of still prefer the plainer ">_" version though. I

D24537: Icons for windy weather

ndavis added a comment. In D24537#546733 , @cblack wrote: > I think cyan is an appropriate choice considering that people tend to associate air with shades of blue, even if air is transparent and that's just the colour of the sky. The shade

D24537: Icons for windy weather

cblack updated this revision to Diff 67874. cblack added a comment. Shift wind emblem to the right, clean scratch work, and rename night icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24537?vs=67625=67874 BRANCH windy-weather-icons (branched

D24537: Icons for windy weather

cblack added a comment. In D24537#545187 , @ndavis wrote: > That cyan looks odd. It sticks out way too much and AFAIK, it isn't commonly used to represent wind. Gray on more gray is going to be tricky as well though, especially when you've got

D24593: Modified breeze shadows

Luwx added a comment. Making good looking pure svg box shadows is a bit tricky. A while back I tried to create one: F7590931: shadow.png The right one uses blur (like breeze decoration does) and the left uses gradients with quite a few

D24621: [RFC] New Konsole and Yakuake icons

cblack added a comment. They look nice, but I'm not sure how well they fit in with other Breeze icons. Comparison montages: F7590391: image.png F7590397: image.png REPOSITORY R266 Breeze Icons REVISION

D24621: [RFC] New Konsole and Yakuake icons

mglb created this revision. mglb added reviewers: VDG, Konsole, Yakuake. mglb added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mglb requested review of this revision. REVISION SUMMARY Variants: F7589725: konsole-yakuake-icons.png

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added a reviewer: dfaure. cullmann added a comment. Perhaps David could give feedback if the file actually captures the intend to do proper KDE Frameworks/libs like formatting. I had a mistake with the indented case statements, that should be fixed. REPOSITORY R240 Extra CMake

D24620: Windows MSVC compile fix

cullmann updated this revision to Diff 67869. cullmann added a comment. Missed to add file with proper compiler guard :/ REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24620?vs=67867=67869 REVISION DETAIL

D24620: Windows MSVC compile fix

cullmann created this revision. cullmann added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY This patch is since "long" in craft blueprints, can we merge that? TEST PLAN

D24598: Update elisa icon

trickyricky26 requested changes to this revision. trickyricky26 added a comment. This revision now requires changes to proceed. Please optimize the SVG files using one of these methods: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization In D24598#546420

D24568: Provide clang-format target with a KDE Frameworks style file

mwolff added a comment. In D24568#545942 , @cullmann wrote: > In D24568#545736 , @apol wrote: > > > I'm not sure how this works, but would it be possible to have a target that only works on a patch?

D24555: Add draw-arrow icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b55f299b1733: Add draw-arrow icons (authored by Rafael Brandmaier rafael.brandma...@kdemail.net). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.13 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.13/12/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 13 Oct 2019 18:24:46 + Build duration: 2 min 44 sec and counting JUnit Tests

D24617: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, aacid. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to Baloo to hide deprecated

D24608: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me REPOSITORY R302 KIconThemes BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24608 To: kossebau, #frameworks, cfeck, mlaurent Cc:

D24593: Modified breeze shadows

filipf added a comment. > b) radial gradients instead of linear on the four sides to make the center darker than the angles. Other than this, they look great to me. I think they should be uniformly dispersed. One of the things with shadows is that the user shouldn't really notice

D24593: Modified breeze shadows

niccolove added a comment. In D24593#546309 , @ngraham wrote: > In D24593#546042 , @niccolove wrote: > > > I'm sorry, when I use scour on svg files, it looks like git does not recognize that the

D24593: Modified breeze shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24593: Modified breeze shadows

niccolove updated this revision to Diff 67853. niccolove added a comment. Re-done the widgets/panel-background.svg REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67852=67853 BRANCH breeze-shadows (branched from master)

D24593: Modified breeze shadows

niccolove updated this revision to Diff 67852. niccolove added a comment. Re-done the dialogs/background.svg REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67790=67852 BRANCH breeze-shadows (branched from master) REVISION

D24612: Use the text rather than highlight color for rating/star emblem

ngraham added a dependent revision: D24613: Use a lighter star color for non-default devices. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24612 To: ngraham, ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24612: Use the text rather than highlight color for rating/star emblem

ngraham created this revision. ngraham added reviewers: ndavis, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The problem with using the highlight color is that the emblem becomes invisible

D24590: Port KSslErrorUiData to QSslError

aacid accepted this revision. aacid added a comment. Do we have tests for the thing you discovered breaks? Do we need them? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24590 To: vkrause, dfaure, aacid Cc: aacid, kde-frameworks-devel, LeGast00n,

D24611: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KFileMetaData to hide

D24610: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KItemViews to hide deprecated

D24608: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KIconThemes to hide deprecated API up

D24598: Update elisa icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely! REPOSITORY R266 Breeze Icons BRANCH elisa_updated (branched from master) REVISION DETAIL https://phabricator.kde.org/D24598 To: astippich, #vdg, ngraham, mgallien Cc:

D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket

mlaurent added reviewers: dvratil, vkrause. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D24597 To: ahmadsamir, #konversation, dvratil, vkrause Cc: kde-frameworks-devel, #konversation

D24568: Provide clang-format target with a KDE Frameworks style file

ochurlaud added a comment. In D24568#546289 , @kossebau wrote: > There is also https://techbase.kde.org/Policies/Frameworks_Coding_Style which though missed the move from techbase to community, other than the other policies. > > I suspect

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.13 - Build # 11 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.13/11/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 13 Oct 2019 12:09:04 + Build duration: 2 min 58 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.13 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.13/10/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 13 Oct 2019 11:41:13 + Build duration: 14 min and counting CONSOLE OUTPUT

D24595: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R310:5cd5d6a412d1: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE

D24598: Update elisa icon

astippich added a comment. F7585764: elisaSmallNew.png F7585766: elisaBigNew.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24598 To: astippich, #vdg, ngraham, mgallien Cc:

D24598: Update elisa icon

astippich updated this revision to Diff 67836. astippich added a comment. - update REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24598?vs=67799=67836 BRANCH elisa_updated (branched from master) REVISION DETAIL https://phabricator.kde.org/D24598

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann retitled this revision from "Provide clang-format target with a common KDE style file" to "Provide clang-format target with a KDE Frameworks style file". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks Cc:

D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket

ahmadsamir updated this revision to Diff 67835. ahmadsamir retitled this revision from "Port from deprecated KTcpSocket to QSslSocket" to "[Konversation] Port from deprecated KTcpSocket to QSslSocket". ahmadsamir added a comment. Better commit message REPOSITORY R7 Konversation CHANGES

D24588: [SslUi] Add api docs for askIgnoreSslErrors()

ahmadsamir updated this revision to Diff 67834. ahmadsamir retitled this revision from "[SslUi] Overload askIgnoreSslErrors() to take a QSslSocket" to "[SslUi] Add api docs for askIgnoreSslErrors()". ahmadsamir added a comment. Since I wrote the docs bit anyway REPOSITORY R241 KIO CHANGES

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir removed a task: T11577: Port Konversation away from KTcpSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24588 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24597: Port from deprecated KTcpSocket to QSslSocket

ahmadsamir updated this revision to Diff 67833. ahmadsamir edited the summary of this revision. ahmadsamir removed reviewers: hein, mlaurent. ahmadsamir added a comment. Use KSslErrorUiData directly when calling askIgnoreSslErrors REPOSITORY R7 Konversation CHANGES SINCE LAST UPDATE

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir added a comment. In D24588#546367 , @vkrause wrote: > In D24588#546229 , @dfaure wrote: > > > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or even just

D24603: Port away from deprecated KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R103:e3b8910670e3: Port away from deprecated KDELibs4Support (authored by ahmadsamir). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24603?vs=67820=67831

D24603: Port away from deprecated KDELibs4Support

vkrause accepted this revision. vkrause added a comment. Thanks! REPOSITORY R103 KMenu Editor BRANCH master REVISION DETAIL https://phabricator.kde.org/D24603 To: ahmadsamir, mlaurent, vkrause Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

vkrause added a comment. In D24588#546229 , @dfaure wrote: > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`. > Don't know, just wondering (not

D24590: Port KSslErrorUiData to QSslError

vkrause updated this revision to Diff 67828. vkrause added a comment. This revision is now accepted and ready to land. Deal with errors with full QSslError level of detail until kssld is ported, make variables const. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24590: Port KSslErrorUiData to QSslError

vkrause planned changes to this revision. vkrause added a comment. This actually breaks things when the error comes from a Qt source rather than a KIO one, as we now carry the QSslError level of detail forward far enough and compare it to the stored KSslError. This is a temporary problem

D24603: Port away from deprecated KDELibs4Support

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R103 KMenu Editor BRANCH master REVISION DETAIL https://phabricator.kde.org/D24603 To: ahmadsamir, mlaurent Cc: plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24595: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24595 To: kossebau, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24598: Update elisa icon

mgallien added a comment. In D24598#546135 , @astippich wrote: > I have no intention on taking over D12992 as I would like rather like to code for Elisa. I am no designer. > I was unsatisfied with the