D24671: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent added a comment. Seems ok for me +1 REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D24671 To: kossebau, #frameworks, #plasma, mart, apol Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

hallas added inline comments. INLINE COMMENTS > bruns wrote in fstabdevice.cpp:56 > fuseiso itself uses setmntent/addmntent/endmntent, so I see no reason > getmntent should not work. > Most importantly, the same implementation should be used for writing and > reading. > >

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 67 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/67/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 19 Oct 2019 03:21:03 + Build duration: 2 min 23 sec and counting BUILD ARTIFACTS

D24753: Add edit-opacity icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D24753 REVISION DETAIL https://phabricator.kde.org/D24753 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24700: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R249:d6c413a0b779: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24700?vs=68059=68275

D24261: Modernize code: use range-based for loop in more places

kossebau added a comment. Ping? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24261 To: kossebau, dfaure Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24678: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R242:df7f98189060: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24678?vs=68001=68273#toc REPOSITORY R242

D24671: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. @apol Hi. Any chance you can give this a review soon, given this is almost the last one remaining before the complete of all (affected) KF modules to ECMGenerateExportHeader is done, and we can enable the respective KF_* macros? REPOSITORY R290 KPackage REVISION

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kstatusnotifieritemprivate_p.h:158 > It should be QPointer, no other changes are needed. Sure, but this is not my code and this is not related. What I want to do here is more like hack/workaround, so it is better to keep

D24753: Add edit-opacity icons

ngraham accepted this revision as: ngraham. ngraham added a subscriber: ndavis. ngraham added a comment. This revision is now accepted and ready to land. @ndavis, you good with this? REPOSITORY R266 Breeze Icons BRANCH arcpatch-D24753 REVISION DETAIL https://phabricator.kde.org/D24753

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks, GB_2 Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n,

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto added a comment. In D24746#549960 , @ngraham wrote: > [...] > If we improve the properties dialog for disks in general, that will also improve the display for other kinds of disks and mounted volumes. > What do you think?

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto edited the summary of this revision. REPOSITORY R241 KIO BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks, GB_2 Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n,

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto updated this revision to Diff 68263. tienisto added a comment. show 'Mounted on' again REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24746?vs=68228=68263 BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL

D24753: Add edit-opacity icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24753 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24753: Add edit-opacity icons

trickyricky26 updated this revision to Diff 68262. trickyricky26 added a comment. - Remove top stripe, reduce the opacity of the remaining stripes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24753?vs=68223=68262 BRANCH arcpatch-D24753 REVISION

D24496: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R237:fb37084b3e7c: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24496?vs=67735=68261#toc REPOSITORY R237

D24746: [kpropertiesdialog] adjust ui for root directory

ngraham added a comment. In principle I like the idea of customizing the display to be more appropriate. However I feel like the best way to do this might be to go in a different direction: instead of adding overrides for `/`, maybe we should take advantage of the fact that `/` is always a

D21235: Add handling of fuseiso filesystem type

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > hallas wrote in fstabdevice.cpp:56 > This implements a crude parser of the fuseiso mtab file. I can't use the > regular getmnt suite of functions to retrieve

T11627: Improve KIO asynchronicity

ngraham added projects: Frameworks, Dolphin. ngraham added subscribers: Frameworks, Dolphin. TASK DETAIL https://phabricator.kde.org/T11627 To: meven, ngraham Cc: #dolphin, #frameworks, meven, dfaure, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 146 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/146/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 18 Oct 2019 17:16:36 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D24753: Add edit-opacity icons

ngraham added a comment. Nice. I think the filled in areas might benefit from being a little bit more transparent to make it more obvious, particularly for the Breeze Dark version. Just a smidge. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24753 To:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 145 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/145/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 18 Oct 2019 16:50:39 + Build duration: 15 min and counting JUnit Tests Name: projectroot

D24684: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R241:aa5b0d89b2ed: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24684?vs=68210=68257#toc REPOSITORY R241 KIO

D24762: Remove two unused member variables using KSslError

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24762 To: vkrause, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24764: Deprecate KIconTheme::assignIconsToContextMenu

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D24764 To: vkrause, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24681: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R304:0d0b688643d8: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24681?vs=68006=68254#toc REPOSITORY R304

D24762: Remove two unused member variables using KSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24762 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24764: Deprecate KIconTheme::assignIconsToContextMenu

vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24764 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24764: Deprecate KIconTheme::assignIconsToContextMenu

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY It's no longer necessary as Qt sets icons on context menu actions itself by now. REPOSITORY R302 KIconThemes

D24762: Remove two unused member variables using KSslError

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24762 AFFECTED FILES

D24742: Make non-ignorable SSL errors explicit

vkrause updated this revision to Diff 68248. vkrause added a comment. Fix return value. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24742?vs=68168=68248 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 AFFECTED FILES

D24673: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R296:00bc9b132e66: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D24684: Use ECMGenerateExportHeader to manage deprecated API better

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK it's very likely that KIOCORE_NO_DEPRECATED didn't work anyway, as I found out in other frameworks where I tried enabling this kind of thing. REPOSITORY R241 KIO BRANCH

D24650: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R235:f79367c1aff3: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in global.h:105 > LOL 3.4 was long ago ;) > > good find :) Thankfully phabricator and its locate-file, go-to-version-before-commit & tags listing for commit was helpful here to good degrees, so that usually tool < 1 min to find

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. In D24684#549785 , @dfaure wrote: > The commit log says KIOKIOFILEWIDGETS with KIO duplicated, that's a typo in the commit log, but only there, right? Typo indeed, fixed. INLINE COMMENTS > dfaure wrote in

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24754: Fix KNSCore::Cache fetching when initialising Engine

rikmills accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix-knscore-cache (branched from master) REVISION DETAIL https://phabricator.kde.org/D24754 To: leinir, rikmills, #frameworks, #knewstuff Cc: kde-frameworks-devel,

D24754: Fix KNSCore::Cache fetching when initialising Engine

rikmills added a comment. Patched knewstuff build with this and tested. Switching between KCMs in systemsettings now seems to pull the correct KNS results. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D24754 To: leinir, rikmills, #frameworks, #knewstuff Cc:

D24684: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added inline comments. INLINE COMMENTS > global.cpp:99 > > -#ifndef KIOCORE_NO_DEPRECATED > KIOCORE_EXPORT QTime KIO::calculateRemaining(KIO::filesize_t totalSize, > KIO::filesize_t processedSize, KIO::filesize_t speed) Isn't some ifdef still needed for this deprecated method? >

D24684: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added a comment. The commit log says KIOKIOFILEWIDGETS with KIO duplicated, that's a typo in the commit log, but only there, right? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. Ping... would be happy if this one could get reviewed ASAP, so we have the patches for all of KF modules in and can enable the group KF_* macros, so people can conveniently use -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0Xxx in their projects :) REPOSITORY R241

D24663: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. @zzag Hi. Any chance you can have time to review this today/the WE? One of the last ECMGenerateExportHeader patches. I would be happy if we could have all in ASAP so we can enable the KF_* macros and test them in git master for two weeks before 5.64 gets tagged

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

anthonyfieroni added inline comments. INLINE COMMENTS > kstatusnotifieritemprivate_p.h:158 > > QMenu *menu; > QHash actionCollection; It should be QPointer, no other changes are needed. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24755 To:

D24673: Use ECMGenerateExportHeader to manage deprecated API better

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24673 To: kossebau, #plasma, mart, broulik Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2,

D24678: Use ECMGenerateExportHeader to manage deprecated API better

mart accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24678 To: kossebau, #plasma, mart, davidedmundson, apol, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

hallas added a comment. Currently you have the 'unmount' action if you right click on the device in dolphin, but it cannot unmount, so should we hide it? Or should we fix it so that it can actually unmount? INLINE COMMENTS > fstabdevice.cpp:56 > + > +QString

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka added a comment. Continuation of D24667 . I know this solution sucks, but I have no idea how this can be done better. I have another idea, probably even crazier: set "DO_NOT_DELETE" flag as a QObject property. Then in destructor check it:

D21235: Add handling of fuseiso filesystem type

hallas updated this revision to Diff 68230. hallas added a comment. Implemented parsing of the fuseiso mtab file REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21235?vs=58147=68230 BRANCH add_handling_of_fuseiso (branched from master) REVISION DETAIL

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto added a comment. In D24746#549637 , @meven wrote: > I would suggest keeping "Location" and "Mounted on" fields to actually display '/' to the user. To me users should know that / is the root folder and has the highest level in

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka created this revision. kmaterka added reviewers: Frameworks, davidedmundson, broulik, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kmaterka requested review of this revision. REVISION SUMMARY It is not possible to handle ownership

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

broulik added a comment. However, `setDummyHistoryEntry` has some logic for icon being `null` and "reuse previous pixmap if null" which would be moot if I change it to always fall back to `application-octet-stream`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15451

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

broulik planned changes to this revision. broulik added a comment. Yes. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15451 To: broulik, #frameworks, dfaure, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto marked an inline comment as done. REPOSITORY R241 KIO BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks, GB_2 Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n,

D24746: [kpropertiesdialog] adjust ui for root directory

tienisto updated this revision to Diff 68228. tienisto added a comment. use 'Unknown' instead of 'unknown' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24746?vs=68206=68228 BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL

D24754: Fix KNSCore::Cache fetching when initialising Engine

leinir added reviewers: rikmills, Frameworks, KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D24754 To: leinir, rikmills, #frameworks, #knewstuff Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24754: Fix KNSCore::Cache fetching when initialising Engine

leinir updated this revision to Diff 68227. leinir added a comment. - Revert unrelated change REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24754?vs=68226=68227 BRANCH fix-knscore-cache (branched from master) REVISION DETAIL

D24754: Fix KNSCore::Cache fetching when initialising Engine

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY During the moving-around of the config files, the Cache was left behind unfixed, and we ended up with all caches being

D24263: edit mode action

davidedmundson accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editModeActionwq! REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma, #vdg, ngraham, davidedmundson Cc: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n,

D24263: edit mode action

mart updated this revision to Diff 68224. mart added a comment. - text is always Customize Layout... REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24263?vs=67896=68224 BRANCH phab/editModeActionwq! REVISION DETAIL

D24746: [kpropertiesdialog] adjust ui for root directory

meven added a comment. I would suggest keeping "Location" and "Mounted on" fields to actually display '/' to the user. Especially for newbies users who might not know what "Root Directory" means. But for more advanced user it would make sense too as / is currently visible only in the

D24263: edit mode action

davidedmundson added a comment. GB_2's comment needs fixing, two strings are out of sync. Other than that, ship it. INLINE COMMENTS > GB_2 wrote in corona.cpp:502 > Missing ellipsis (...) Given how easy it is to get these out of sync, can I suggest removing all the code to update

D24753: Add edit-opacity icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24753 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24753 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REVISION SUMMARY This patch adds edit-opacity icons requested by Okular for D15580 .

D24752: WIP: Use a separate worker thread to run the actual deletion of files

meven updated this revision to Diff 68222. meven added a comment. Clean debug code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24752?vs=68221=68222 BRANCH threadedDelete REVISION DETAIL https://phabricator.kde.org/D24752 AFFECTED FILES

D24752: WIP: Use a separate worker thread to run the actual deletion of files

meven created this revision. meven added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Part of T11627 REPOSITORY R241 KIO BRANCH

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 144 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/144/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 18 Oct 2019 08:31:23 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D24263: edit mode action

GB_2 added inline comments. INLINE COMMENTS > corona.cpp:502 > +}); > +editAction->setText(i18n("Customize Layout")); > +editAction->setAutoRepeat(true); Missing ellipsis (...) REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editModeActionwq! REVISION DETAIL

D24650: Use ECMGenerateExportHeader to manage deprecated API better

leinir accepted this revision. leinir added a comment. Very nicely, go for it :) REPOSITORY R235 Attica BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24650 To: kossebau, #frameworks, gladhorn, leinir, mlaurent Cc: mlaurent, kde-frameworks-devel,

D24681: Use ECMGenerateExportHeader to manage deprecated API better

leinir accepted this revision. leinir added a comment. In D24681#547798 , @kossebau wrote: > No support for EXCLUDE_DEPRECATED_BEFORE_AND_AT, as some deprecated API is still used internally, so this needs more clean-up by someone(tm) first.

D24746: [kpropertiesdialog] adjust ui for root directory

GB_2 accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kpropertiesdialog-root-directory (branched from master) REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks, GB_2 Cc: ahmadsamir, GB_2,

D24746: [kpropertiesdialog] adjust ui for root directory

GB_2 added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24746 To: tienisto, #vdg, ngraham, #frameworks Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/143/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 18 Oct 2019 07:07:03 + Build duration: 20 min and counting JUnit Tests Name: projectroot

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d576ec8ae0e5: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

meven updated this revision to Diff 68214. meven added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23851?vs=66028=68214 BRANCH arcpatch-D23851_1 REVISION DETAIL https://phabricator.kde.org/D23851 AFFECTED FILES

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas added a comment. @davidedmundson ping :) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 18 Oct 2019 06:10:59 + Build duration: 26 min and counting JUnit Tests Name:

D24678: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24678 To: kossebau, #plasma, mart, davidedmundson, apol, mlaurent Cc:

D24700: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24700 To: kossebau, #frameworks, ilic, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24673: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent added a comment. +1 for me REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24673 To: kossebau, #plasma, mart, broulik Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24496: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. seems ok for me REPOSITORY R237 KConfig BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24496 To: kossebau, #frameworks, mlaurent Cc: mlaurent,

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 18 Oct 2019 05:52:22 + Build duration: 18 min and counting JUnit Tests Name: