D24871: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:dc13d172fdc8: Use a more correct and appropriate visual metaphor for get hot new stuff icon (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D24871: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH more-appropriate-ghns-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24871 To: ngraham, #vdg, leinir, ndavis Cc: kde-frameworks-devel, ndavis,

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. `Depth: 1` is duplicated too. I tried adding a contentType.isEmpty() check, but it is actually empty. Needs more debugging REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n,

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. This commit completely breaks the davgroupware resource for me (to access kolab calendars via CALDAV). REPORT requests get a 400 Bad Request error from the server. 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery:

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

aacid added inline comments. INLINE COMMENTS > ksslinfodialog.h:81 > + */ > +KIOWIDGETS_DEPRECATED void setSslInfo(const QList > , > +const QString , const QString , Does this need to use the new deprecated since markers? REPOSITORY R241 KIO REVISION DETAIL

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

vkrause added a comment. This will compile, but it will only work correctly once TCPSlaveBase has been ported to QSslSocket too. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24873 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH ahmad/kio_http-ktcpsocket (branched from master) REVISION DETAIL

D24871: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon

ngraham created this revision. ngraham added reviewers: VDG, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now it's a duplicate (not even a symlink) of the `favorite` icon, which is

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 17 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/17/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 18:04:06 + Build duration: 55 min and counting JUnit Tests Name:

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.13 - Build # 15 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.13/15/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 18:04:08 + Build duration: 44 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 39 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/39/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 18:03:56 + Build duration: 43 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 17:42:19 + Build duration: 25 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/37/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 22 Oct 2019 17:40:38 + Build duration: 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/18/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 17:26:54 + Build duration: 29 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 17:39:20 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 74 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/74/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 17:39:21 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 38 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/38/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 17:21:28 + Build duration: 26 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kdeclarative » kf5-qt5 WindowsMSVCQt5.13 - Build # 21 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20WindowsMSVCQt5.13/21/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 17:21:59 + Build duration: 25 min and counting JUnit Tests

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/43/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 17:38:20 + Build duration: 6 min 11 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 154 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/154/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 17:33:32 + Build duration: 10 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/23/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 17:37:15 + Build duration: 3 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/16/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 17:17:13 + Build duration: 17 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 53 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/53/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 22 Oct 2019 17:21:28 + Build duration: 10 min and counting BUILD ARTIFACTS

D24764: Deprecate KIconTheme::assignIconsToContextMenu

kossebau added a comment. As KIconThems supports EXCLUDE_DEPRECATED_BEFORE_AND_AT., you want to also wrap the implementation of assignIconsToContextMenu, with #if KICONTHEMES_BUILD_DEPRECATED_SINCE(5, 64) (look out for _BUILD_). Seems you are a candidate to answer the email

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 100 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/100/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 17:21:28 + Build duration: 4 min 20 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 17:22:35 + Build duration: 2 min 4 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/49/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 17:21:28 + Build duration: 2 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.13 - Build # 14 - Failure!

9-10-22T17:18:38.352Z]Build name: Win32-jom[2019-10-22T17:18:38.352Z] Create new tag: 20191022-1718 - Experimental[2019-10-22T17:18:38.352Z] Test project C:/CI/workspace/Frameworks/attica/kf5-qt5 WindowsMSVCQt5.13/build[2019-10-22T17:18:38.352Z] Start 1: configtest[2019-10-22T17:18:39.484Z

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 17:17:53 + Build duration: 1 min 36 sec and counting JUnit Tests Name:

D24841: Use modern way to set the C/CXX standard

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6e3c794e7c63: Use modern way to set the C/CXX standad (authored by vonreth). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24841?vs=68488=68560#toc REPOSITORY R240 Extra CMake Modules

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/17/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 16:21:03 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 153 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/153/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 16:16:07 + Build duration: 17 min and counting JUnit Tests Name: projectroot

D24764: Deprecate KIconTheme::assignIconsToContextMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R302:ccf27d634cbf: Deprecate KIconTheme::assignIconsToContextMenu (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24764?vs=68252=68555#toc REPOSITORY R302 KIconThemes

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:12b68224e084: Port the KSSLD D-Bus interface from KSslError to QSslError (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24676?vs=67999=68552#toc REPOSITORY R241 KIO

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24703 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Quick Charts in KDE Review

Jonathan Riddell ha scritto: > There's a file called LICENSE which contains a copy of the LGPL 2.1 > > But all the files with an explicit licence seem to be GPL 2+3+KDEeV > > Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove > LICENSE and put a copy of the GPL 2

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

meven added a comment. In D24858#552279 , @davidedmundson wrote: > The check comes from when the application requests a list of all available extensions, not when they actually request a specific one. > The warning is a bit premature. >

Re: Quick Charts in KDE Review

There's a file called LICENSE which contains a copy of the LGPL 2.1 But all the files with an explicit licence seem to be GPL 2+3+KDEeV Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove LICENSE and put a copy of the GPL 2 called COPYING which is our normal practice.

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

davidedmundson added a comment. The check comes from when the application requests a list of all available extensions, not when they actually request a specific one. The warning is a bit premature. kwallet most definitely shouldn't be getting the fake input extension! REPOSITORY

D24841: Use modern way to set the C/CXX standard

cgiboudeaux retitled this revision from "Use modern way to set the C/CXX standad" to "Use modern way to set the C/CXX standard". cgiboudeaux edited the summary of this revision. REPOSITORY R240 Extra CMake Modules BRANCH cmake_c_standard REVISION DETAIL https://phabricator.kde.org/D24841

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

meven abandoned this revision. meven added a comment. In D24858#552090 , @apol wrote: > These are not necessary for kwallet as far as I know. To fix this warning we'd have to look into where applications are requesting these and have these

D24859: Add a .desktop file for kdeinit

meven abandoned this revision. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D24859 To: meven, apol, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 WindowsMSVCQt5.13 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20WindowsMSVCQt5.13/20/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 13:51:14 + Build duration: 21 min and counting CONSOLE OUTPUT

D24821: Add ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R296:c8b95b07c53b: Add ManagedConfigModule (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24821?vs=68530=68545 REVISION DETAIL

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 68546. apol added a comment. Unrelated change REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=68544=68546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 AFFECTED FILES

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 68544. apol added a comment. Adopt new deprecation macros REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=65328=68544 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682

D24821: Add ManagedConfigModule

davidedmundson accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24821 To: ervin, #plasma, #frameworks, mart, bport, davidedmundson Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24821: Add ManagedConfigModule

ervin updated this revision to Diff 68530. ervin added a comment. Address David's comments REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24821?vs=68411=68530 REVISION DETAIL https://phabricator.kde.org/D24821 AFFECTED FILES

D24821: Add ManagedConfigModule

ervin marked an inline comment as done. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24821 To: ervin, #plasma, #frameworks, mart, bport, davidedmundson Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24821: Add ManagedConfigModule

ervin marked 4 inline comments as done. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24821 To: ervin, #plasma, #frameworks, mart, bport, davidedmundson Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 11:24:56 + Build duration: 34 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/73/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 11:24:59 + Build duration: 23 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 165 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/165/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 22 Oct 2019 10:53:52 + Build duration: 42 min and counting BUILD ARTIFACTS

D24859: Add a .desktop file for kdeinit

apol added a comment. Same as D24858 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D24859 To: meven, apol, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

apol added a comment. These are not necessary for kwallet as far as I know. To fix this warning we'd have to look into where applications are requesting these and have these interfaces only requested when they're necessary. REPOSITORY R311 KWallet REVISION DETAIL

D23766: FakeInput: add support for keyboard key press and release

jgrulich closed this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. No, just rambling. Ship it. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol,

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.13 - Build # 24 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.13/24/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 10:59:49 + Build duration: 7 min 0 sec and counting JUnit Tests

D24859: Add a .desktop file for kdeinit

meven created this revision. meven added reviewers: apol, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prevents logs such as : kwin_core: Did not grant the interface

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 164 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/164/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 21 Oct 2019 10:48:14 + Build duration: 1 day 0 hr and counting BUILD ARTIFACTS

Re: Quick Charts in KDE Review

On 21-10-2019 16:45, Alexander Potashev wrote: Hi Arjen, 1. I don't see any checks in the autotests. Would it be easy to compare the displayed chart against a reference screenshot image, in each of the tests? The same screenshots could also help developers understand what kind of charts

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

sitter updated this revision to Diff 68526. sitter added a comment. remove warning REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24827?vs=68428=68526 BRANCH assert-for-git REVISION DETAIL https://phabricator.kde.org/D24827 AFFECTED FILES

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

sitter marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24827 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

sitter edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24827 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

meven created this revision. meven added reviewers: apol, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY To Prevent logs such as : kwin_core: Did not grant the interface

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

dfaure added inline comments. INLINE COMMENTS > sitter wrote in CMakeLists.txt:49 > Well, at that point you can choose to: > > - explicitly -DASSERT_SLAVE_STATES_DEFAULT=OFF which will not trigger the > warning as the option will not default to the auto detection if you set it > manually > -

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

sitter added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:49 > It does, but people can still pass -DCMAKE_BUILD_TYPE=Release, or > RelWithDebInfo (as I do for profiling). > > Won't this give them the warning below then, even if they don't set the > KIO_ASSERT_SLAVE_STATES

D24841: Use modern way to set the C/CXX standad

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH cmake_c_standard REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem,

D23766: FakeInput: add support for keyboard key press and release

jgrulich added a comment. In D23766#533644 , @apol wrote: > The patch looks good to me, is there a reason why it wasn't accepted? I'm not sure from the comment whether David requested some changes to be made now or whether this is good

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

kmaterka added reviewers: Frameworks, broulik, nicolasfella. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D24843 To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella Cc: plasma-devel, LeGast00n,