D25025: decodeBCJ2: Fix assert with broken files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D25025 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25023: Make kconfig_compiler generate code with const

apol added a comment. I don't know if we can do that. There's been some changes we've pulled back assuming people could be installing + exporting classes generated from kconfig_compiler. :/ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25023 To: aacid Cc: apol,

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 68931. feverfew added a comment. - Switch from KDED module to DBus service REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=64440=68931 BRANCH KDEDModule (branched from master) REVISION DETAIL

D25025: decodeBCJ2: Fix assert with broken files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Make sure we're not reading past the bytearray data REPOSITORY R243 KArchive BRANCH master REVISION DETAIL

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

aacid added a comment. You don't want to accept there's a potential problem with typos and that either using KLocalizedString or forcing you to store the context is the solution? Fine then just undeprecate Noop2, but adding strip that does the same is stupid REPOSITORY R249 KI18n

D25023: Make kconfig_compiler generate code with const

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY KSharedConfig::Ptr is not very expensive to copy but const & is cheaper REPOSITORY R237 KConfig BRANCH master

D25015: Update breeze theme shadows

ngraham added a comment. If anything I wonder if we should make them bigger too, to better match the default Breeze shadows. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: ngraham, filipf, kde-frameworks-devel,

D24982: Small improvements in some XML files

dhaumann added a comment. Hm right... too bad. I was hoping to find an automated way to detect this. Since relying on the user to optimize the RegExps will always be suboptimal. @cullmann Do you have any ideas? REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D24982: Small improvements in some XML files

nibags added a comment. No, the dynamic flag is used to insert the captures already stored in `%N` (the captures are stored in the RegExpr rules and then "inserted" in the rules with the dynamic flag) REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D25015: Update breeze theme shadows

filipf added a comment. Testing it. Usability wise the strength is perfectly fine; the shadows still do their job. Visually it's a definitive improvement for me. Only thing I'm not sure of is the weaker strength in the corners, but I'm going to keep testing to see if it's just a

D25014: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

niccolove abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25014 To: niccolove Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

niccolove retitled this revision from "I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more sparse and a bit lighter especially on the angles while..." to

D24593: Modified breeze shadows

niccolove abandoned this revision. niccolove added a comment. Let's try again https://phabricator.kde.org/D25015 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson,

D25015: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY ...trying to keep it distinguishable when on white background. I received some positive feedback on these shadows

D25014: I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more s

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY ...trying to keep it distinguishable when on white background. I received some positive feedback on these shadows

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Can't wait to get clang-format fully automated into the review workflow INLINE COMMENTS > deletejob.cpp:76 > + */ > +void rmfile(const QUrl& url, bool isLink){ > +

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

dfaure added a comment. I agree with Friederich. In kio/filewidgets/kfileplacesmodel.cpp (for which you accepted the change in D24970 ) I'm passing the context to the method because I18NC_NOOP forces me to, but then I'm *discarding* this context because:

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

kossebau added a comment. As said, I do not think this would be "better" code. And it's violating a bit the goal of zero cost abstractions, given this adds runtime need which could be avoided compared to the old code. When using the I18N_NOOP, one has to know what you do and when you later

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

aacid added a comment. That's the problem with deprecation warnings, they force you to write better code. You don't like the fact that you have to do it, but at least please acknowledge that having "data type" in one place and then "data type" again in a totally different place just

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R302:3ff850df6b48: Fix usage of the new deprecation macros for assignIconsToContextMenu (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE

D24989: support multiple rcc files with icons themes

cullmann added a reviewer: dfaure. cullmann added a comment. Will alter the initializer before pushing, if it is clarified if the approach is ok. Given the lack of mmap for resource files on Windows, I actually would prefer to hide the resources in dummy plugins, but I guess it would make

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

apol added a comment. Hi Meven, I guess I didn't make myself clear, sorry about that. This is not what I meant. What I meant was here D24956 you can query the desktop entry directly, we don't need to expose access to it. REPOSITORY R237 KConfig

D24736: Grab the keyboard when KeySequenceItem is recording

apol accepted this revision. REPOSITORY R296 KDeclarative BRANCH grabkeyboard (branched from master) REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks, davidedmundson, apol Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

apol added a comment. +1 Makes sense to me. REPOSITORY R296 KDeclarative BRANCH grabkeyboard (branched from master) REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks, davidedmundson Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24736: Grab the keyboard when KeySequenceItem is recording

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH grabkeyboard (branched from master) REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks, davidedmundson Cc: broulik, kde-frameworks-devel,

D24993: Add integrated inline spelling menu to KTextEdit

pajamapants3000 added inline comments. INLINE COMMENTS > spellingmenu.h:44 > + * are handled internally, without any extra effort required from the parent. > + * Slots are available to facilitate these actions on-demand if needed. > + * Reviewing, I noticed that these slots are actually

D24983: KateModeMenuList: improve word wrap

dhaumann added a comment. Good, fine with me. Related: Maybe the translation should also be shorter, but the general possible problem persists. Please go ahead. REPOSITORY R39 KTextEditor BRANCH improve-word-wrap REVISION DETAIL https://phabricator.kde.org/D24983 To: nibags,

D24982: Small improvements in some XML files

dhaumann added a comment. > [...] > One option would be to add a **capture** or **dontCapture** attribute to enable or disable captures for RegExpr rules. Also, captures could be enabled or disabled in all RegExpr rules using the group, adding an element for that. But don't we

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven updated this revision to Diff 68893. meven added a comment. Fix wrong comparison REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68892=68893 BRANCH stat-qflags REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED FILES

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven retitled this revision from "Use A QFlag to specify the details returned by statJob" to "[StatJob] Use A QFlag to specify the details returned by statJob". meven added reviewers: Frameworks, dfaure, kossebau. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To:

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven updated this revision to Diff 68892. meven added a comment. Amend commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68890=68892 BRANCH stat-qflags REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED FILES

D25010: Use A QFlag to specify the details returned by statJob

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED FILES src/core/statjob.cpp

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

kossebau added a comment. Looking at deprecated API usage in Okteta, I came over the use of some use of I18N_NOOP2 as well. The use-case there though seems pretty fine to me, porting to I18NC_NOOP will complicate the logic without further need, as the context is the same for all strings in

D24736: Grab the keyboard when KeySequenceItem is recording

davidre added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

kossebau added a comment. It's actually an approach to be preferred in such cases, as it moves some of the work to be done at creating KF6 and porting to its new API for users of KF to now and the time span until KF6, keeping the unavoidable hurdle at the actual KF5->KF6 change as small as

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

meven added a comment. In D24999#555191 , @kossebau wrote: > Instead of the TODO one could already add an overload of the method now, and deprecate the current one. So that in KF6 times the deprecated could be dumped, and there would just be

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Needed to be able to use `propertyKde("NoGlobalShortcut", false)` instead of

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

meven added a reviewer: apol. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25003 To: meven, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

kossebau added a comment. Instead of the TODO one could already add an overload of the method now, and deprecate the current one. So that in KF6 times the deprecated could be dumped, and there would just be the preferred variant. REPOSITORY R241 KIO REVISION DETAIL

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

Am Sonntag, 27. Oktober 2019, 11:26:51 CET schrieb David Faure: > On dimanche 27 octobre 2019 03:07:01 CET Friedrich W. H. Kossebau wrote: > > Am Freitag, 25. Oktober 2019, 00:35:46 CET schrieb David Faure: > > > On jeudi 24 octobre 2019 22:24:55 CEST Friedrich W. H. Kossebau wrote: > > > > BTW,

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

apol added a comment. you may want to explain a bit more what you mean there. it could make sense to keep the TODO in the .cpp file, no need to get it on every user REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24999 To: meven, #frameworks, dfaure Cc: apol,

D24978: Add KService::noGlobalShortcut corresponding to X-KDE-NoGlobalShortcut

meven abandoned this revision. meven added a comment. In D24978#555165 , @apol wrote: > This doesn't look like some API we'd be using very often. Would it make sense to just have kglobalsettings access it through KService::property? I

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH enableallqtkfdeprecationwarningsforframeworks REVISION DETAIL https://phabricator.kde.org/D24990 To: kossebau, #frameworks, #build_system, apol Cc:

D24978: Add KService::noGlobalShortcut corresponding to X-KDE-NoGlobalShortcut

apol added a comment. This doesn't look like some API we'd be using very often. Would it make sense to just have kglobalsettings access it through KService::property? INLINE COMMENTS > kservice.cpp:739 > +{ > +if > (qvariant_cast(property(QStringLiteral("X-KDE-NoGlobalShortcut"), >

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

kmaterka added a comment. This is a proper solution to BUG 365105. Can someone review it? Is everything OK with this? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D24843 To: kmaterka, apol, davidedmundson, #plasma, #frameworks,

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24999 AFFECTED

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

meven added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24999 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven added a comment. In D24962#554961 , @dfaure wrote: > Any reason why you didn't implement my suggestion of > >DeleteJobIOWorker *ioworker() { >if (!m_ioworker) { > ... >} >return

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven updated this revision to Diff 68872. meven added a comment. Refactor initWorkerThread() to *worker() accessor REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68854=68872 BRANCH arcpatch-D24962 REVISION DETAIL

D24981: Modelines: fix end of comment

This revision was automatically updated to reflect the committed changes. Closed by commit R216:73489a79f9fd: Modelines: fix end of comment (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24981?vs=68820=68870 REVISION DETAIL

D24983: KateModeMenuList: improve word wrap

nibags added a comment. `QFontMetrics::boundingRect(text).width()` doesn't deliver an exact value of the text width, since I detected that in some translations and some desktop themes the text goes below the scroll bar. This problem doesn't exist with

D24982: Small improvements in some XML files

nibags added a comment. I had also thought about using `QRegularExpression::DontCaptureOption`, which is equivalent to using `(?:...)`, but I wasn't sure how much the real improvement in performance is. However, disabling captures avoids allocating unnecessary QString for each capture.

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

mlaurent abandoned this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24884 To: mlaurent, dfaure, ilic Cc: aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns