D25059: KPluginSelector: use new KAboutPluginDialog

2019-10-29 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > kpluginselector.cpp:799-803 > +PluginEntry *pluginEntry = model->data(index, > PluginEntryRole).value(); > +KPluginMetaData pluginMetaData = pluginEntry->pluginInfo.toMetaData(); > + > +KAboutPluginDialog

D24983: KateModeMenuList: improve word wrap

2019-10-29 Thread Nibaldo González
nibags updated this revision to Diff 69022. nibags added a comment. - Increase margin of list - search bar in Windows REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24983?vs=69005=69022 BRANCH improve-word-wrap REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-10-29 Thread Méven Car
meven planned changes to this revision. meven added a comment. In D25010#556237 , @dfaure wrote: > If you change the actual values being sent to kioslaves, then this breaks the "wire protocol". I.e. after upgrading KF5 on a live system,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-10-29 Thread Méven Car
meven updated this revision to Diff 69021. meven marked 3 inline comments as done. meven added a comment. Avoid using short and testFlag REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68975=69021 BRANCH arcpatch-D25010 REVISION DETAIL

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-10-29 Thread Méven Car
meven added inline comments. INLINE COMMENTS > dfaure wrote in deletejob.cpp:67 > "const bool" doesn't do anything in a signal, I suggest removing the const. I am hesitant to remove `const QUrl& url` from this signal, it could save some space in message passing. REPOSITORY R241 KIO BRANCH

D24965: KConfigWidgets: port away from KF5 deprecated API

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Tired given the time, but let's see if I get things straight this time: Given KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00, in the API of KConfig we just see

D24966: KXmlGui: port away from KF5 deprecated API

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. To leave KAboutData::programIconData as a deprecated property and instead turn to use KPluginMetaData where the iconName property is undisputed in its usefullnes, I have now uploaded 3 patches for view; - D25063 : Add

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Depends on D25058

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added a dependent revision: D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25058 To: kossebau, #frameworks, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

2019-10-29 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY The generated classes of kconfig_compiler take a KSharedConfig::Ptr by value, one possibility would be to make them const

D25023: Make kconfig_compiler generate code with const

2019-10-29 Thread Albert Astals Cid
aacid abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25023 To: aacid Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks! REPOSITORY R216 Syntax Highlighting BRANCH ps-escape (branched from master) REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax, dhaumann,

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:3d28d32776c9: Add string escape characters to PowerShell syntax. (authored by zrax, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D25025: decodeBCJ2: Fix assert with broken files

2019-10-29 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D25025 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Michael Hansen
zrax updated this revision to Diff 69011. zrax added a comment. - Add test case for new escape sequences to powershell autotest REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25054?vs=69010=69011 BRANCH ps-escape (branched from master)

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Dominik Haumann
dhaumann added a comment. Looks good to me. Btw, you posted several patches over the last two years. You could also apply for a KDE contributor account and push yourself, if you want. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax,

D24959: Add new preferences search icons

2019-10-29 Thread TrickyRicky
trickyricky26 added a comment. In D24959#556058 , @ngraham wrote: > Better now @trickyricky26? I do think the new version looks better, more because of the nicer proportions of the magnifying glass than the shadow. I think it's not

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Michael Hansen
zrax updated this revision to Diff 69010. zrax added a comment. - Add test case for new escape sequences to powershell autotest REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25054?vs=68996=69010 BRANCH ps-escape (branched from master)

D24983: KateModeMenuList: improve word wrap

2019-10-29 Thread Nibaldo González
nibags updated this revision to Diff 69005. nibags added a comment. - Restore scroll bar margins REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24983?vs=68974=69005 BRANCH improve-word-wrap REVISION DETAIL https://phabricator.kde.org/D24983

D25059: KPluginSelector: use new KAboutPluginDialog

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Depends on D25058

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added a dependent revision: D25059: KPluginSelector: use new KAboutPluginDialog. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25058 To: kossebau, #frameworks, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I can push it for you. But I think it would be a good idea to have an unit test extended with the new supported syntax parts. Could you add that? REPOSITORY R216 Syntax

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY When showing an About dialog for a plugin, so far a

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Michael Hansen
zrax added a comment. I do not have a KDE developer account, so I cannot land the change myself presently. REPOSITORY R216 Syntax Highlighting BRANCH ps-escape (branched from master) REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax, dhaumann Cc: dhaumann, kwrite-devel,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-10-29 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. If you change the actual values being sent to kioslaves, then this breaks the "wire protocol". I.e. after upgrading KF5 on a live system, kioslaves (started by kdeinit5 forking

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please commit. REPOSITORY R216 Syntax Highlighting BRANCH ps-escape (branched from master) REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax, dhaumann Cc: dhaumann,

D24966: KXmlGui: port away from KF5 deprecated API

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. Playing with reviving my programIconName undeprecation patch (by adding a new property iconName w/ setter/getter), and looking through the rest of the API, I though now think that we should keep KAboutData untouched and leave it for metadata about programs, while

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-10-29 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, let's get this in :-) REPOSITORY R241 KIO BRANCH arcpatch-D24962 REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Michael Hansen
zrax edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Michael Hansen
zrax edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Michael Hansen
zrax edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Michael Hansen
zrax created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. zrax requested review of this revision. REVISION SUMMARY Powershell uses the syntax ` or `u{hex} as escape sequences within double-quoted strings. This adds

D24957: Add new baloo icons

2019-10-29 Thread Alexander Stippich
astippich added a comment. F7686927: test32.png F7686929: test48.png REPOSITORY R266 Breeze Icons BRANCH newBalooIcon REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham,

D25015: Update breeze theme shadows

2019-10-29 Thread Niccolò Venerandi
niccolove added a comment. In D25015#48 , @ngraham wrote: > If anything I wonder if we should make them bigger too, to better match the default Breeze shadows. I'd prefer to avoid them making more sparse because a) they look worse to

D24742: Make non-ignorable SSL errors explicit

2019-10-29 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause, #frameworks, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

2019-10-29 Thread Björn Feber
GB_2 added a comment. +1 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25049 To: ngraham, #vdg, #plasma, mart Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.12 - Build # 84 - Fixed!

2019-10-29 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 17:18:18 + Build duration: 24 min and counting BUILD ARTIFACTS

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

2019-10-29 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This makes the navigeability of multi-page KCMs completely obvious. The

D24742: Make non-ignorable SSL errors explicit

2019-10-29 Thread Volker Krause
vkrause added a comment. Anyone? This blocks the subsequent SSL error patches. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

2019-10-29 Thread Volker Krause
vkrause added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 80 - Unstable!

2019-10-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/80/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 29 Oct 2019 11:27:43 + Build duration: 5 hr 11 min and counting JUnit Tests Name: (root)

D25041: Ensure that the changedEntries property is correctly propagated

2019-10-29 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH ensure-changedentries-is-forwarded (branched from master) REVISION DETAIL https://phabricator.kde.org/D25041 To: leinir, #frameworks, #knewstuff, apol, ngraham Cc:

D24959: Add new preferences search icons

2019-10-29 Thread Nathaniel Graham
ngraham added a comment. Better now @trickyricky26? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D12283: Allow to load dictionaries form a rcc

2019-10-29 Thread Ahmad Samir
ahmadsamir added a comment. IINM, in the commit message s/form a rcc/from an rcc/. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D12283 To: vonreth, mlaurent Cc: ahmadsamir, kde-frameworks-devel, habacker, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

2019-10-29 Thread Alexander Stippich
astippich updated this revision to Diff 68979. astippich added a comment. - modified icon with shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24959?vs=68779=68979 BRANCH newSearchIcon REVISION DETAIL https://phabricator.kde.org/D24959

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 205 - Fixed!

2019-10-29 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/205/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 11:30:56 + Build duration: 2 hr 57 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 189 - Unstable!

2019-10-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/189/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 11:27:45 + Build duration: 2 hr 52 min and counting JUnit Tests Name: (root)

D24958: Delete nepomuk icon

2019-10-29 Thread Alexander Stippich
astippich added a comment. Thanks @broulik for the hint and @ngraham for being faster than me :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

2019-10-29 Thread Nathaniel Graham
ngraham added a comment. All of our other icons that consist of a white symbol in a blur circle have the shadow, so it's probably best to at least be consistent. If we decided we don't like the shadow, we should remove them from all of these icons at once. REPOSITORY R266 Breeze Icons

D25041: Ensure that the changedEntries property is correctly propagated

2019-10-29 Thread Nathaniel Graham
ngraham added a dependent revision: D24942: Require and use the new NewStuffQuick Button component. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25041 To: leinir, #frameworks, #knewstuff, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24958: Delete nepomuk icon

2019-10-29 Thread Nathaniel Graham
ngraham added a comment. Actually I guess it needs to. I'll fix the icon in Dolphin. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

2019-10-29 Thread Nathaniel Graham
ngraham added a comment. Gross, it even uses a pixmap rather than just using the icon directly. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

2019-10-29 Thread Kai Uwe Broulik
broulik added a comment. https://cgit.kde.org/dolphin.git/tree/src/panels/information/informationpanelcontent.cpp#n231 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2,

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-29 Thread Méven Car
meven abandoned this revision. meven added a comment. See D25010 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24999 To: meven, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2019-10-29 Thread Méven Car
meven retitled this revision from "[StatJob] Use A QFlag to specify the details returned by statJob" to "[StatJob] Use A QFlag to specify the details returned by StatJob". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc:

D24958: Delete nepomuk icon

2019-10-29 Thread Alexander Stippich
astippich added a comment. Can you give me a hint exactly where? I searched for usages and found none, and still cannot find it now REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel,

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Méven Car
meven marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Méven Car
meven updated this revision to Diff 68975. meven added a comment. Move KIO::StatDefaultDetails to KIO::StatJob::StatDefaultDetails REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68973=68975 BRANCH arcpatch-D25010 REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Méven Car
meven added a comment. In D25010#555890 , @kossebau wrote: > Now that is a quick turn-around, +1 for doing the work :) > > No time myself to look at this closely the next days, also not that much into KIO, but here some quick feedback with

D24958: Delete nepomuk icon

2019-10-29 Thread Kai Uwe Broulik
broulik added a comment. Note that Dolphin still uses that icon for its information panel when in search mode. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24983: KateModeMenuList: improve word wrap

2019-10-29 Thread Nibaldo González
nibags updated this revision to Diff 68974. nibags added a comment. - Fix font size/style REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24983?vs=68828=68974 BRANCH improve-word-wrap REVISION DETAIL https://phabricator.kde.org/D24983 AFFECTED

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kossebau wrote in statjob.h:181 > I wonder if this should not be rather a member of StatJob, instead of being > on generic KIO namespace level. > It feels unbalanced to have the enum being in the class, but a util flag set > not. Actually,

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Méven Car
meven updated this revision to Diff 68973. meven added a comment. Fix jobs details argument passing and fix setDetails(int) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68971=68973 BRANCH arcpatch-D25010 REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > jobremotetest.cpp:70 > { > -KIO::Job *job = KIO::stat(url, KIO::StatJob::DestinationSide, 0, > KIO::HideProgressInfo); > +KIO::Job *job = KIO::stat(url, KIO::StatJob::DestinationSide, > KIO::StatJob::Basic, KIO::HideProgressInfo); >

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Méven Car
meven updated this revision to Diff 68971. meven marked an inline comment as done. meven added a comment. Wrap setDetails with #if KIOCORE_ENABLE_DEPRECATED_SINCE, use the new API throughout the rest of KIO REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > statjob.h:96 > + > /** > * Selects the level of @p details we want. All deprecated API should be also wrapped in visibility controls., so same #if/#endif also here. Basic structure: if deprecated api should be visible to compiler

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Méven Car
meven updated this revision to Diff 68969. meven marked 8 inline comments as done. meven added a comment. Rename StatJob::Detail to StatJob::StatDetail, KIO::DefaultDetails to KIO::StatDefaultDetails, add deprecation doc and macro REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 54 - Unstable!

2019-10-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/54/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 29 Oct 2019 11:27:45 + Build duration: 28 min and counting JUnit Tests

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Unstable!

2019-10-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/75/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 29 Oct 2019 11:27:45 + Build duration: 27 min and counting JUnit Tests Name:

D24958: Delete nepomuk icon

2019-10-29 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R266:34fa249177e1: Delete nepomuk icon (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24958?vs=68778=68967 REVISION DETAIL

D24959: Add new preferences search icons

2019-10-29 Thread Alexander Stippich
astippich added a comment. New proposal F7684533: preferences-desktop-search2.png However, I am not a fan of the shadow. It is barely visbile anyways at such small sizes, and it looks weird with the handle REPOSITORY R266 Breeze Icons

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 204 - Failure!

2019-10-29 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/204/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 10:29:41 + Build duration: 31 min and counting CONSOLE OUTPUT Started by

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.12 - Build # 83 - Failure!

2019-10-29 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.12/83/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 10:07:17 + Build duration: 54 min and counting CONSOLE OUTPUT Started by an

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. Now that is a quick turn-around, +1 for doing the work :) No time myself to look at this closely the next days, also not that much into KIO, but here some quick feedback with an API police hat on. Would be also good to have some patches which make use of

D12283: Allow to load dictionaries form a rcc

2019-10-29 Thread Ralf Habacker
habacker added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. In D12283#249520 , @vonreth wrote: > While the disk use of the installation goes down the ram usage explodes as QResource doesn't use mmap

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-29 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R296:7ede04501eda: Grab the keyboard when KeySequenceItem is recording (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24736?vs=68144=68960

D25041: Ensure that the changedEntries property is correctly propagated

2019-10-29 Thread Dan Leinir Turthra Jensen
leinir added reviewers: Frameworks, KNewStuff, apol, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25041 To: leinir, #frameworks, #knewstuff, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25041: Ensure that the changedEntries property is correctly propagated

2019-10-29 Thread Dan Leinir Turthra Jensen
leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Without this change, for some reason unknown to me, the alias seems to fail quietly (that is, you can still read the

D25039: Fix Clazy performance issues, const &, noexcept

2019-10-29 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY - Fix a lot of missing const & or &, avoiding copying mostly QString. - Add

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

2019-10-29 Thread Ahmad Samir
ahmadsamir added a comment. In D24951#554516 , @dfaure wrote: > A sort model allows to define any sorting criteria you want (see QSortFilterProxyModel::lessThan), so this is technically possible: the criteria would say "if A is a match and B

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-10-29 Thread Méven Car
meven added a comment. In D24962#555443 , @dfaure wrote: > Can't wait to get clang-format fully automated into the review workflow Such a time saver it would be. REPOSITORY R241 KIO REVISION DETAIL

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

2019-10-29 Thread Méven Car
meven updated this revision to Diff 68946. meven marked 5 inline comments as done. meven added a comment. Mostly formatting, change style to init m_ioworker and check it in worker() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68872=68946 BRANCH

D24982: Small improvements in some XML files

2019-10-29 Thread Christoph Cullmann
cullmann added a comment. Could we perhaps just do some minimal checking like "no dynamic stuff at all" => turn off all captures? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24982 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: