D25015: Update breeze theme shadows

filipf added a comment. Before: F7746042: Screenshot_20191107_083508.png After: F7746044: Screenshot_20191107_083534.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25015: Update breeze theme shadows

filipf added a comment. There's definitely a difference, whereas the shadows are now rough and dark this is subtler. I'd suggest testing this patch with a light color scheme and then switching to the unpatched theme plus testing against light backgrounds to notice the changes.

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 172 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/172/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 07 Nov 2019 05:39:20 + Build duration: 9 min 14 sec and counting JUnit Tests Name:

D25168: Use the pointing hand cursor for the single-clickable delegates

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH use-finger-cursor-for-single-clickable-bits (branched from master) REVISION DETAIL https://phabricator.kde.org/D25168 To: leinir, #knewstuff, #frameworks, ngraham Cc:

D25165: Only show DownloadItemsSheet if there's more than one download item

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH dont-show-downloaditemssheet-if-only-one-download (branched from master) REVISION DETAIL https://phabricator.kde.org/D25165 To: leinir, #knewstuff, #frameworks, ngraham Cc:

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

zzag retitled this revision from "Add property definition for "X-Plasma-MainScript" for Plasma/Wallpaper" to "Define property X-Plasma-MainScript for Plasma/Wallpaper". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25184 To: zzag, #plasma Cc:

D25184: Add property definition for "X-Plasma-MainScript" for Plasma/Wallpaper

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY This commit fixes `Unknown property type for key "X-Plasma-MainScript"` warning that pops up

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

ngraham added a comment. Now you don't need those PassiveNotifications anymore, because otherwise you wind up with duplicate messages: F7745214: loading.png REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25173 To:

D25015: Update breeze theme shadows

ngraham added a comment. In D25015#559367 , @ndavis wrote: > I haven't said much about this idea because I just have a hard time seeing the difference from the screenshots. I must admit having the same problem. :) REPOSITORY R242

D25015: Update breeze theme shadows

ndavis added a comment. I haven't said much about this idea because I just have a hard time seeing the difference from the screenshots. It seems like a good amount of effort went into this, and I know from experience that adjusting shadows in Inkscape is a major PITA, but I can't approve

D25015: Update breeze theme shadows

filipf added a comment. I'd prefer the shadows to have equal strength all around, I couldn't get used to weaker shadows in the corners. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: manueljlin, ngraham, filipf,

D25015: Update breeze theme shadows

niccolove added a comment. Any update on this? I can also upload the shadow for the panel. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 171 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/171/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 06 Nov 2019 17:30:11 + Build duration: 9 min 35 sec and counting JUnit Tests Name:

Re: HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

Am Mittwoch, 6. November 2019, 16:13:28 CET schrieb David Edmundson: > >Any chance this is about KGamma and you ran clazy with a Qt 5.14 copy > >locally? > It was! Okay :) So no new holes to fix then discovered. > >So here repeating the recommendation done by a few, which project > >maintainers

Re: HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

>Any chance this is about KGamma and you ran clazy with a Qt 5.14 copy locally? It was! >so the compiler still sees the overload and throws up. Yeah, the whole situation makes total sense, it just wasn't something that I had thought about when blindly running clazy. >So here repeating the

Re: HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

Am Mittwoch, 6. November 2019, 14:14:41 CET schrieb David Edmundson: > I just found a slight issue when using _DEPRECATED_SINCE. > > If one of two overloaded Q_SIGNALS is deprecated, clazy will blindly > port the signal without an overload as to the compiler only one signal > exists. This then

D25164: MobileTextActionsToolBar check if controlRoot is undefined before using it

This revision was automatically updated to reflect the committed changes. Closed by commit R242:22b66892: MobileTextActionsToolBar check if controlRoot is undefined before using it (authored by meven). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

sitter added inline comments. INLINE COMMENTS > desktopexecparser.cpp:314 > +org::kde::KIOFuse kiofuse_iface(QStringLiteral("org.kde.KIOFuse"), > +QStringLiteral("/org/kde/KIOFuse"), > +QDBusConnection::sessionBus()); align

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir edited the summary of this revision. leinir edited the test plan for this revision. leinir added reviewers: KNewStuff, Frameworks, ngraham, VDG. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25173 To: leinir, #knewstuff, #frameworks, ngraham, #vdg Cc:

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This adds an isLoading property to KNSQuick::Engine, and that is used to show a busy indicator (with descriptive label)

Re: HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

Am Mittwoch, 6. November 2019, 14:14:41 CET schrieb David Edmundson: > I just found a slight issue when using _DEPRECATED_SINCE. > > If one of two overloaded Q_SIGNALS is deprecated, clazy will blindly > port the signal without an overload as to the compiler only one signal > exists. This then

D25164: MobileTextActionsToolBar check if controlRoot is undefined before using it

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25164 To: meven, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

I just found a slight issue when using _DEPRECATED_SINCE. If one of two overloaded Q_SIGNALS is deprecated, clazy will blindly port the signal without an overload as to the compiler only one signal exists. This then gives a compilation error at a distro/CI level. I don't think anything can be

D25159: Fix linking to libssh 0.9.1

sitter added a comment. D25170 for when that lands REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol, sitter, fvogt Cc: nisavid, fvogt, sitter, asn, apol, asturmlechner, kde-frameworks-devel, kfm-devel,

D25170: make the libssh finder ensure the new ssh target is set

sitter added a comment. NB: depends on https://gitlab.com/libssh/libssh-mirror/merge_requests/71 getting landed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25170 To: sitter Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/73/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 06 Nov 2019 12:51:27 + Build duration: 7 min 7 sec and counting JUnit Tests Name:

D25170: make the libssh finder ensure the new ssh target is set

sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY starting with 0.9.2 the libssh cmake config defines a new ssh imported target, use this as the new

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/39/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 06 Nov 2019 12:51:28 + Build duration: 7 min 7 sec and counting JUnit Tests Name:

Re: Notice of intention to remove tests from KCrash and KNotifications

On Wed, Nov 6, 2019 at 8:07 AM Ben Cooksley wrote: > > On Tue, Nov 5, 2019 at 11:50 PM Harald Sitter wrote: > > > > I get where you are coming from, but honestly, none of this makes > > pushing unreviewed commits that disable the entire test collection of > > an entire framework any more

D25165: Only show DownloadItemsSheet if there's more than one download item

leinir edited the summary of this revision. leinir added reviewers: KNewStuff, Frameworks, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25165 To: leinir, #knewstuff, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25168: Use the pointing hand cursor for the single-clickable delegates

leinir edited the summary of this revision. leinir added reviewers: KNewStuff, Frameworks, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25168 To: leinir, #knewstuff, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25168: Use the pointing hand cursor for the single-clickable delegates

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REPOSITORY R304 KNewStuff BRANCH use-finger-cursor-for-single-clickable-bits (branched from master) REVISION DETAIL

D25165: Only show DownloadItemsSheet if there's more than one download item

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY BUG:413437 TEST PLAN With patch: Shows "Install..." for all items (with other than one user download) Without

D25164: MobileTextActionsToolBar check if controlRoot is undefined before using it

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prevents warning such as

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven added inline comments. INLINE COMMENTS > deletejob.cpp:130 > +/// Callback of worker rmfile > +void rmFileResult(bool result, bool isLink); > +/// Callback of worker rmdir Now we are at it, isLink could become m_curentURLIsLink, but isLink being a bool, it is much cheaper to

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven updated this revision to Diff 69332. meven marked 4 inline comments as done. meven added a comment. Use m_current instead of passing const QUrl around REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68946=69332 BRANCH arcpatch-D24962

D25159: Fix linking to libssh 0.9.1

asn added a comment. I've created https://gitlab.com/libssh/libssh-mirror/merge_requests/71 This means the right code would be then. if (TARGET ssh) # libssh 0.9+ target_link_libraries(kio_sftp ssh) endif() REPOSITORY R320 KIO Extras REVISION DETAIL

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D24962 REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns