D25149: Add a new template for KCMs

[Tomaz Canabrava]

tcanabrava added inline comments.

INLINE COMMENTS

> ervin wrote in kcm.cpp:43
> Shouldn't be needed anymore (and likely wrong in most cases).

What's the correct form then? No need to connect the settings *at all*?

> ervin wrote in main.qml:39
> What about disabling it if the setting is immutable?

The default fake setting will not be immutable, or you mean that you want me to 
do one mutable and one immutable settings for the example?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava, #plasma, #frameworks, mart, ervin
Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, 
kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Frameworks » syndication » kf5-qt5 SUSEQt5.12 - Build # 49 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20SUSEQt5.12/49/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 Nov 2019 06:57:15 +
 Build duration:
7 min 9 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Syndication-5.65.0.xmlcompat_reports/KF5Syndication_compat_report.htmllogs/KF5Syndication/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)85%
(75/88)85%
(75/88)62%
(2418/3887)31%
(2731/8729)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(3/4)75%
(3/4)60%
(85/141)37%
(188/514)src83%
(19/23)83%
(19/23)70%
(466/663)42%
(572/1352)src.atom91%
(10/11)91%
(10/11)48%
(337/705)22%
(406/1883)src.mapper100%
(16/16)100%
(16/16)90%
(446/496)51%
(352/692)src.rdf87%
(20/23)87%
(20/23)67%
(843/1252)36%
(1012/2780)src.rss270%
(7/10)70%
(7/10)41%
(241/584)14%
(201/1418)tests0%
(0/1)0%
(0/1)0%
(0/46)0%
(0/90)

KDE CI: Frameworks » syndication » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20FreeBSDQt5.13/27/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 14 Nov 2019 06:57:15 +
 Build duration:
3 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » syndication » kf5-qt5 SUSEQt5.13 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20SUSEQt5.13/29/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 14 Nov 2019 06:57:15 +
 Build duration:
3 min 57 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Syndication-5.65.0.xmlcompat_reports/KF5Syndication_compat_report.htmllogs/KF5Syndication/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)85%
(75/88)85%
(75/88)62%
(2418/3887)31%
(2731/8729)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(3/4)75%
(3/4)60%
(85/141)37%
(188/514)src83%
(19/23)83%
(19/23)70%
(466/663)42%
(572/1352)src.atom91%
(10/11)91%
(10/11)48%
(337/705)22%
(406/1883)src.mapper100%
(16/16)100%
(16/16)90%
(446/496)51%
(352/692)src.rdf87%
(20/23)87%
(20/23)67%
(843/1252)36%
(1012/2780)src.rss270%
(7/10)70%
(7/10)41%
(241/584)14%
(201/1418)tests0%
(0/1)0%
(0/1)0%
(0/46)0%
(0/90)

KDE CI: Frameworks » syndication » kf5-qt5 WindowsMSVCQt5.13 - Build # 19 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20WindowsMSVCQt5.13/19/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 14 Nov 2019 06:57:15 +
 Build duration:
3 min 30 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » syndication » kf5-qt5 SUSEQt5.12 - Build # 48 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20SUSEQt5.12/48/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 Nov 2019 06:28:55 +
 Build duration:
7 min 23 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Syndication-5.65.0.xmlcompat_reports/KF5Syndication_compat_report.htmllogs/KF5Syndication/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.syndicationtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)85%
(75/88)85%
(75/88)62%
(2415/3882)31%
(2742/8735)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(3/4)75%
(3/4)60%
(82/136)38%
(199/520)src83%
(19/23)83%
(19/23)70%
(466/663)42%
(572/1352)src.atom91%
(10/11)91%
(10/11)48%
(337/705)22%
(406/1883)src.mapper100%
(16/16)100%
(16/16)90%
(446/496)51%
(352/692)src.rdf87%
(20/23)87%
(20/23)67%
(843/1252)36%
(1012/2780)src.rss270%
(7/10)70%
(7/10)41%
(241/584)14%
(201/1418)tests0%
(0/1)0%
(0/1)0%
(0/46)0%
(0/90)

KDE CI: Frameworks » syndication » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20WindowsMSVCQt5.13/18/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 14 Nov 2019 06:28:55 +
 Build duration:
6 min 42 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.syndicationtest

KDE CI: Frameworks » syndication » kf5-qt5 SUSEQt5.13 - Build # 28 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20SUSEQt5.13/28/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 14 Nov 2019 06:28:55 +
 Build duration:
2 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Syndication-5.65.0.xmlcompat_reports/KF5Syndication_compat_report.htmllogs/KF5Syndication/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.syndicationtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)85%
(75/88)85%
(75/88)62%
(2415/3882)31%
(2742/8735)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(3/4)75%
(3/4)60%
(82/136)38%
(199/520)src83%
(19/23)83%
(19/23)70%
(466/663)42%
(572/1352)src.atom91%
(10/11)91%
(10/11)48%
(337/705)22%
(406/1883)src.mapper100%
(16/16)100%
(16/16)90%
(446/496)51%
(352/692)src.rdf87%
(20/23)87%
(20/23)67%
(843/1252)36%
(1012/2780)src.rss270%
(7/10)70%
(7/10)41%
(241/584)14%
(201/1418)tests0%
(0/1)0%
(0/1)0%
(0/46)0%
(0/90)

KDE CI: Frameworks » syndication » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20FreeBSDQt5.13/26/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 14 Nov 2019 06:28:55 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.syndicationtest

D25296: [RFC] Fix Display Configuration icon margins

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, ndavis.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The icon's old margins were too large, causing it to stick out.
  
  However in the process of fixing this, I managed to break the stylesheet so 
it no longer
  changes its colors and make the icon blurry, despite the fact that it appears 
perfectly
  pixel-aligned to the Inkscape grid.
  
  #VDG  assistance would be appreciated 
to help me figure out what's wrong here.
  
  BUG: 400087
  FIXED-IN; 5.65

TEST PLAN
  F7762410: half-fixed.png 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-xrandr-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25296

AFFECTED FILES
  src/desktoptheme/breeze/icons/preferences.svg

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new template for KCMs

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> %{APPNAMELC}settings.kcfgc:5
> +DefaultValueGetters=true
> +GenerateProperties=true

You also want "ParentInConstructor=true" in here.

> kcm.cpp:32
> +: KQuickAddons::ConfigModule(parent, args)
> +, m_settings(new %{APPNAME}Settings())
> +{

Pass this as parent here (currently you're leaking it)

> kcm.cpp:43
> +
> +connect(m_settings, &%{APPNAME}Settings::configChanged, this, [this] { 
> setNeedsSave(true); });
> +

Shouldn't be needed anymore (and likely wrong in most cases).

> kcm.h:26
> +
> +class %{APPNAME} : public KQuickAddons::ConfigModule
> +{

This should inherit from ManagedConfigModule now.

> kcm.h:36
> +
> +public Q_SLOTS:
> +void load() override;

None of those slots are needed with a ManagedConfigModule (except if you need 
to do something outside the realm of the settings of course, which is not the 
case by default.

> main.qml:39
> +
> +QQC2.TextField {
> +text: kcm.settings.exampleSetting

What about disabling it if the setting is immutable?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava, #plasma, #frameworks, mart, ervin
Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, 
kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24957: Add new baloo icons

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  newBalooIcon

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25132: Use an eyedropper for color-picker icons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b9dd7fd5a672: Use an eyedropper for color-picker icons 
(authored by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25132?vs=69699&id=69708

REVISION DETAIL
  https://phabricator.kde.org/D25132

AFFECTED FILES
  icons-dark/actions/16/color-picker.svg
  icons-dark/actions/22/color-picker.svg
  icons-dark/actions/24/color-picker.svg
  icons-dark/actions/32/color-picker.svg
  icons/actions/16/color-picker.svg
  icons/actions/22/color-picker.svg
  icons/actions/24/color-picker.svg
  icons/actions/32/color-picker.svg

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[TrickyRicky]

trickyricky26 accepted this revision.
trickyricky26 added a comment.
This revision is now accepted and ready to land.


  Sorry, I kind of forgot about this revision.
  But looks all good now!

REPOSITORY
  R266 Breeze Icons

BRANCH
  newSearchIcon

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D25132: Use an eyedropper for color-picker icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM, but I noticed that there is a 32px monochrome icon. Should we keep 
using 32px monochrome icons for now? It seems like we can't make up our minds 
on this issue and the amount of work required to complete a move in either 
direction leads to us not wanting to commit to either direction.

REPOSITORY
  R266 Breeze Icons

BRANCH
  eyedropper-style-color-picker-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  LGTM, let's try not to torture this icon to death. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D25149: Add a new template for KCMs

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D25149

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava, #plasma, #frameworks, mart
Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, 
kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24959: Add new preferences search icons

[Alexander Stippich]

astippich added a comment.


  any more comments?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D25132: Use an eyedropper for color-picker icons

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25132

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

[Nathaniel Graham]

ngraham updated this revision to Diff 69699.
ngraham added a comment.


  Thicken side lines

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25132?vs=69471&id=69699

BRANCH
  eyedropper-style-color-picker-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25132

AFFECTED FILES
  icons-dark/actions/16/color-picker.svg
  icons-dark/actions/22/color-picker.svg
  icons-dark/actions/24/color-picker.svg
  icons-dark/actions/32/color-picker.svg
  icons/actions/16/color-picker.svg
  icons/actions/22/color-picker.svg
  icons/actions/24/color-picker.svg
  icons/actions/32/color-picker.svg

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25291: Add "all applications" category icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:f249a14c70b4: Add "all applications" category 
icon (authored by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25291?vs=69687&id=69695

REVISION DETAIL
  https://phabricator.kde.org/D25291

AFFECTED FILES
  icons-dark/categories/32/applications-all.svg
  icons/categories/32/applications-all.svg

To: ngraham, #vdg, broulik, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25291: Add "all applications" category icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  all-apps-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25291

To: ngraham, #vdg, broulik, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25291: Add "all applications" category icon

[Nathaniel Graham]

ngraham updated this revision to Diff 69687.
ngraham added a comment.


  Optimize icons with scour

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25291?vs=69686&id=69687

BRANCH
  all-apps-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25291

AFFECTED FILES
  icons-dark/categories/32/applications-all.svg
  icons/categories/32/applications-all.svg

To: ngraham, #vdg, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25291: Add "all applications" category icon

[Nathaniel Graham]

ngraham added a reviewer: broulik.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25291

To: ngraham, #vdg, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25291: Add "all applications" category icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We currently have no accepted "all apps" icon. This patch creates one, 
inspired by the
  old "homerun" icon which seems to have tacitly been used for this purpose 
(Kickoff uses
  a monochrome version of this icon, and it's been used for the "All about the 
apps"
  initiative).

TEST PLAN
  Not actually used anywhere yet, but it's available for future uses of "all 
apps" in
  list items/categories/buttons/etc.
  
  F7761271: applications-all.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  all-apps-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25291

AFFECTED FILES
  icons-dark/categories/32/applications-all.svg
  icons/categories/32/applications-all.svg

To: ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

[Nathaniel Graham]

ngraham added a comment.


  Last question: give the button text, or stick with the icon only? I ask 
because `go-jump` is kind of an odd icon IMO: F7761220: 
Screenshot_20191113_093303.png 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25226

To: ngraham, #vdg, #frameworks
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

[Nathaniel Graham]

ngraham updated this revision to Diff 69684.
ngraham marked an inline comment as done.
ngraham added a comment.


  Use more semantically correct icon

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25226?vs=69493&id=69684

BRANCH
  show-link-target-in-properties-dialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25226

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: ngraham, #vdg, #frameworks
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

[Nathaniel Graham]

ngraham added a comment.


  Actually I played with that and in retrospect I don't think it would work. If 
we give it a "link-like" appearance, that would suggest that clicking on it 
would actually open the destination file/folder (i.e. the typical link 
behavior), which is not what we want here. We want to show it in the file 
manager, not open it. I'll stay with the current approach and change the icon 
as @ndavis requested.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25226

To: ngraham, #vdg, #frameworks
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22801: [KIO] silence a QFileInfo warning

[René J . V . Bertin]

rjvbb added a comment.


  Are you not seeing these for instance when browsing an MSWin share in Dolphin 
(with the same or newer versions of kio-extras, Samba and MSWin)?
  
  I tried to figure out where they came from but failed because of the async 
nature of the chain of events. I presume the empty paths come from the smb KIO 
plugin and then somehow make it to where the warning is printed.
   I also considered that findByPath() already accepts non-existing paths and 
handles them appropriately, it could (and probably should) do the same with an 
empty path. Regardless of the fact that the smb plugin probaby shouldn't output 
empty paths; maybe the maintainer(s) of that software should be CC'ed here?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22801

To: rjvbb, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25286: Allow to disable autosave behavior in ConfigPropertyMap

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:40b94af6f0f4: Allow to disable autosave behavior in 
ConfigPropertyMap (authored by ervin).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25286?vs=69676&id=69677

REVISION DETAIL
  https://phabricator.kde.org/D25286

AFFECTED FILES
  src/kdeclarative/configpropertymap.cpp
  src/kdeclarative/configpropertymap.h

To: ervin, #plasma, #frameworks, mart, davidedmundson, bport
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25286: Allow to disable autosave behavior in ConfigPropertyMap

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25286

To: ervin, #plasma, #frameworks, mart, davidedmundson, bport
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25286: Allow to disable autosave behavior in ConfigPropertyMap

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, Frameworks, mart, davidedmundson, bport.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This is especially important when ConfigPropertyMap is used with KCMs,
  if it keeps saving on any change we never get the chance to know if the
  config was dirty or not.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25286

AFFECTED FILES
  src/kdeclarative/configpropertymap.cpp
  src/kdeclarative/configpropertymap.h

To: ervin, #plasma, #frameworks, mart, davidedmundson, bport
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:44cfa0631d25: Prepare KConfigSkeletonItem to allow 
inheriting its private class (authored by ervin).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25210?vs=69440&id=69673

REVISION DETAIL
  https://phabricator.kde.org/D25210

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi, vkrause
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25211: Add KPropertySkeletonItem

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:d63955cfe547: Add KPropertySkeletonItem (authored by 
ervin).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25211?vs=69628&id=69674

REVISION DETAIL
  https://phabricator.kde.org/D25211

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Igor Poboiko]

poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, hurikhan77, 
lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Igor Poboiko]

poboiko added a comment.


  @bruns: I've missed D16593: [ExtractorCollection] Use only best matching 
extractor plugin , and had in mind previous 
situation where we've matched all extractors based on inheritance. In that 
case, "Secondly" part indeed does not seem to apply anymore.
  (as for my previous answer: I misunderstood you, thought you were asking 
about the case where `PlainTextExtractor` did not match & matched afterwards)
  
  > Your script is wrong. E.g. SVG inherits from text/plain, but has its own 
extractor, thus is not fed to the PlaintextExtractor. Dito for anything 
inheriting from XML.
  
  I'm not claiming the list to be comprehensive, it's just a first 
approximation.
  I'm claiming just that there is plethora of plain-text-based types (and might 
be even more in the future), some of which **in principle** might cause an 
issue.
  
  There were plenty of situations in the past when users first encountered 
Baloo choking on some files (see git log of `fileexcludefilters.cpp` - SQL 
dumps, genome data, etc.), which made Baloo unusable for them.
  Luckily for us, they reported it, and we blacklisted it. But I think it's 
unlikely we will manage to cover all the problematic cases that way (not all 
users report issues, and we're not familiar with all possible mimetypes).
  This patch should serve as a preventive measure, reducing the probabilty of 
Baloo choking on it in the first place.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, hurikhan77, 
lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D22801: [KIO] silence a QFileInfo warning

[Méven Car]

meven added a comment.


  The issue could be as well located in previewjob.cpp.
  Could you debug why KMountPoint::List::findByPath is called with an empty 
string or non-existing file.
  We might want to prevent this to happen instead.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22801

To: rjvbb, #frameworks
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Stefan Brüns]

bruns added a comment.


  In D23787#541963 , @poboiko wrote:
  
  > In D23787#537891 , @bruns wrote:
  >
  > > Can you please provide an example which:
  > >
  > > - is currently indexed though it should be skipped due to size
  > > - is skipped after this change
  >
  >
  > Sure. Any mimetype inherited from "text/plain", but starting with "text/" 
counts. I've made an actual list:
  >  F7515259: list.txt 
  >  (using simple python script, which iterates over 
`QMimeDatabase().allMimeTypes()`, checks if `type.inherits("text/plain")` and 
is not already excluded by default Baloo config from 
`file/fileexcludefilters.cpp`)
  
  
  Your script is wrong. E.g. SVG inherits from text/plain, but has its own 
extractor, thus is not fed to the PlaintextExtractor. Dito for anything 
inheriting from XML.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, hurikhan77, 
lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Stefan Brüns]

bruns added a comment.


  In D23787#541963 , @poboiko wrote:
  
  > > and another example which:
  > > 
  > > - is currently skipped though it should be indexed
  > > - is indexed after this change
  >
  > There shouldn't be any. I mean, "PlaintextExtractor" should be inside 
`exList` for anything that starts with `text/`...
  
  
  Then whats the "Secondly ..." paragraph in the summary about?

INLINE COMMENTS

> davidedmundson wrote in app.cpp:173
> This original line seemed very very wrong.
> 
> Just because we won't want to index phase 2 isn't a reason to remove the 
> filename indexing - it'll just keep running phase 1 on itself again and again.
> 
> So +1 on that

Off by one error - phase one is content indexing already, phase zero is 
filename/filestat.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, hurikhan77, 
lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Igor Poboiko]

poboiko added a comment.


  Ping?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, hurikhan77, 
lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams