D25313: Add autotest for QML KConcatenateRowsProxyModel

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25313

To: davidedmundson, vkrause
Cc: kde-frameworks-devel, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D23205: [KProcessList] Optimize KProcessList::processInfo

[David Hallas]

hallas added a comment.


  @davidedmundson - ping ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23205

To: hallas, davidedmundson, broulik
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas added a comment.


  @bruns  - ping ;)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 183 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/183/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 15 Nov 2019 04:25:40 +
 Build duration:
48 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25315: KDirModel: implement showing "/" as a root node, optionally

[David Faure]

dfaure created this revision.
dfaure added reviewers: stefanocrocco, elvisangelaccio, meven, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  The API for this is to call openUrl(QUrl()), which is understood
  to be the parent of "file:///".
  
  KDirModel has always been lacking a openUrl method anyway, it's always
  been weird to create a KDirModel but then call
  dirModel->dirLister()->openUrl().
  
  This feature has been requested by Raphael Rosch who is reimplementing
  the konqueror sidebar tree on top of KDirModel. Having a visible item
  for "/" is necessary in order to be able to click on it and have it
  listed in the main file view.

TEST PLAN
  kdirmodeltest_gui and 2 new methods in kdirmodeltest (unittest)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25315

AFFECTED FILES
  autotests/kdirmodeltest.cpp
  autotests/kdirmodeltest.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kdirmodeltest_gui.cpp

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Alexander Saoutkin]

feverfew marked 8 inline comments as done.
feverfew added inline comments.

INLINE COMMENTS

> sitter wrote in desktopexecparser.cpp:317
> There's nothing wrong with this. But wouldn't using 
> `QHash, QUrl>` make for easier to read code all in 
> all since you don't have to mess with pairs?
> 
> Alternatively with a vector I'd still make a struct for the data
> 
>   struct MountRequest { QDBusPendingReply reply, QUrl url };
>   QVector requests;
>   ...
>   requests.push_back({ mountUrl(url), url });

Gone for the vector option.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Alexander Saoutkin]

feverfew updated this revision to Diff 69774.
feverfew added a comment.


  - Get rid of unnecessary copying of URLs
  - Switch to interface generated at compile time
  - Delete unused interfaces
  - Merge branch 'master' into arcpatch-D23384
  - remove kiofuseinterface from build

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23384?vs=69769=69774

BRANCH
  arcpatch-D23384

REVISION DETAIL
  https://phabricator.kde.org/D23384

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/desktopexecparser.cpp
  src/core/org.kde.KIOFuse.VFS.xml
  src/widgets/CMakeLists.txt
  src/widgets/krun.cpp
  src/widgets/org.kde.KIOFuse.VFS.xml

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D25311: Add KColumnHeadersProxyModel

[David Edmundson]

davidedmundson added a comment.


  We should probably have a unit test, even if it just covers the basic case.
  
  This currently assumes the source model's columns are static.  At a minimum 
that needs a comment.

INLINE COMMENTS

> kcolumnheadersproxymodel.h:30
> + *
> + * This model will expose the source model's headers as a simple list. This 
> is
> + * mostly useful as a helper for QML applications that want to display a 
> model's

Worth clarifying that the list isn't across columns.

i.e
"Each header section (column) column in the source model is presented as a row 
in this proxy. Roles map directly"

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25311

To: ahiemstra
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25313: Add autotest for QML KConcatenateRowsProxyModel

[David Edmundson]

davidedmundson updated this revision to Diff 69773.
davidedmundson added a comment.


  whitespace

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25313?vs=69772=69773

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25313

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/concatenaterowstest.qml
  autotests/kconcatenaterows_qml.cpp
  tests/qml/concatenaterows.qml

To: davidedmundson
Cc: kde-frameworks-devel, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D25313: Add autotest for QML KConcatenateRowsProxyModel

[David Edmundson]

davidedmundson added a comment.


  The unit test was requested on the original revision, I wrote it at the time, 
but I only realised I hadn't uploaded it just now :/

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25313

To: davidedmundson
Cc: kde-frameworks-devel, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D25313: Add autotest for QML KConcatenateRowsProxyModel

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Test passes

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25313

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/concatenaterowstest.qml
  autotests/kconcatenaterows_qml.cpp
  tests/qml/concatenaterows.qml

To: davidedmundson
Cc: kde-frameworks-devel, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

[Eon S. Jeon]

esjeon added a comment.


  Thanks all. I hope I can be of help.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D25307: kwriteconfig: add delete option

[Nathaniel Graham]

ngraham added a comment.


  Thanks very much for the nice patch. May it be the first of many! :)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D25307: kwriteconfig: add delete option

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:9b8ef694412c: kwriteconfig: add delete option (authored 
by esjeon, committed by ngraham).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25307?vs=69754=69770

REVISION DETAIL
  https://phabricator.kde.org/D25307

AFFECTED FILES
  src/kreadconfig/kwriteconfig.cpp

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D25307: kwriteconfig: add delete option

[Eon S. Jeon]

esjeon added a comment.


  > Can you provide your email address
  
  Eon S. Jeon 

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D25307: kwriteconfig: add delete option

[Nathaniel Graham]

ngraham added a comment.


  Can you provide your email address so we can land this patch with correct 
authorship information?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D25307: kwriteconfig: add delete option

[Eon S. Jeon]

esjeon added a comment.


  > Do you have commit access?
  
  I don't think so. I'm a first timer around here.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D25312: Document configuration file path on Android

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25312

To: jbbgameich, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

[Nathaniel Graham]

ngraham added a comment.


  In D25307#562652 , @esjeon wrote:
  
  > Also, I don't see anything wrong with adding this, since it merely exposes 
`deleteEntry` method already in the API. Some projects do rely on it, so why 
should it be kept away from actual human beings?
  
  
  FWIW, I don't disapprove; the above logic is reasonable IMO.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25307: kwriteconfig: add delete option

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Shortcuts aside, the patch makes sense.
  
  In general, I want to encourage people to wipe config entries rather than 
write in the current default as it makes several other things work better.
  
  Do you have commit access?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D25307: kwriteconfig: add delete option

[David Redondo]

davidre added a comment.


  In D25307#562652 , @esjeon wrote:
  
  > Also, I don't see anything wrong with adding this, since it merely exposes 
`deleteEntry` method already in the API. Some projects do rely on it, so why 
should it be kept away from actual human beings?
  
  
  I am in no way against this. I just wanted to know what the motivation behind 
this is :).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Alexander Saoutkin]

feverfew updated this revision to Diff 69769.
feverfew added a comment.


  - Align function arguments
  - Remove hack
  - Get rid of iterator

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23384?vs=69201=69769

BRANCH
  KDEDModule (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23384

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/desktopexecparser.cpp
  src/core/kiofuseinterface.cpp
  src/core/kiofuseinterface.h
  src/widgets/krun.cpp

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D25304: Fix the OpenEXR >= 2.4 detection

[Christophe Giboudeaux]

cgiboudeaux abandoned this revision.
cgiboudeaux added a comment.


  I applied the patch to our openexr package instead.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25304

To: cgiboudeaux
Cc: arojas, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25312: Document configuration file path on Android

[Jonah Brüchert]

jbbgameich added a reviewer: vkrause.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D25312

To: jbbgameich, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

[Eon S. Jeon]

esjeon added a comment.


  In D25307#562618 , @davidre wrote:
  
  > In D25307#562613 , @esjeon wrote:
  >
  > > > What shortcuts had you in mind to delete?
  > >
  > > My specific interest is deleting shortcuts of removed KWin scripts. ( 
e.g. https://github.com/esjeon/krohnkite/issues/31 ) Such shortcuts keep 
appearing on Global Shortcuts dialog unless manually deleted. Also, while 
developing the script, I leave garbage values behind, and having this around 
will be handy.
  >
  >
  > As noted in that issue for removing shortcuts modifying kglobalshortcutsrc 
is not enough as kglobaccel will write back. A reliable way to do that is via 
DBus.
  
  
  Yeah, that sounds like a better approach for the shortcut thing. But I want 
to make clear that I submitted this patch only after verifying that this works 
for my case, for whatever reason.
  
  Also, I don't see anything wrong with adding this, since it merely exposes 
`deleteEntry` method already in the API. Some projects do rely on it, so why 
should it be kept away from actual human beings?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25312: Document configuration file path on Android

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  It's pretty hard right now to find out the search path on android for new 
developers.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25312

AFFECTED FILES
  src/knotification.h

To: jbbgameich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 69765.
ahiemstra added a comment.


  - Add @since for the class

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25311?vs=69764=69765

BRANCH
  columnheadersmodel

REVISION DETAIL
  https://phabricator.kde.org/D25311

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kcolumnheadersproxymodel.cpp
  src/core/kcolumnheadersproxymodel.h
  src/qml/plugin.cpp
  tests/qml/columnheaders.qml

To: ahiemstra
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

[Arjen Hiemstra]

ahiemstra created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  It converts a model's column headers into a simple list model. It is
  mainly useful as a helper to create headers for QtQuick TableView but
  may also be useful for other things.

TEST PLAN
  The added test QML file shows a single 1 as described in the test.

REPOSITORY
  R275 KItemModels

BRANCH
  columnheadersmodel

REVISION DETAIL
  https://phabricator.kde.org/D25311

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kcolumnheadersproxymodel.cpp
  src/core/kcolumnheadersproxymodel.h
  src/qml/plugin.cpp
  tests/qml/columnheaders.qml

To: ahiemstra
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

[David Redondo]

davidre added a comment.


  In D25307#562613 , @esjeon wrote:
  
  > > What shortcuts had you in mind to delete?
  >
  > My specific interest is deleting shortcuts of removed KWin scripts. ( e.g. 
https://github.com/esjeon/krohnkite/issues/31 ) Such shortcuts keep appearing 
on Global Shortcuts dialog unless manually deleted. Also, while developing the 
script, I leave garbage values behind, and having this around will be handy.
  
  
  As noted in that issue for removing shortcuts modifying kglobalshortcutsrc is 
not enough as kglobaccel will write back. A reliable way to do that is via DBus.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

[Eon S. Jeon]

esjeon added a comment.


  > What shortcuts had you in mind to delete?
  
  My specific interest is deleting shortcuts of removed KWin scripts. ( e.g. 
https://github.com/esjeon/krohnkite/issues/31 ) Such shortcuts keep appearing 
on Global Shortcuts dialog unless manually deleted. Also, while developing the 
script, I leave garbage values behind, and having this around will be handy.
  
  > If you delete an entry you will get the default value on the next read.
  
  I believe some people will find such behaviour(?) useful. You can safely 
"reset" configs from CLI without worrying about putting wrong values.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25270: Correctly set i18n arguments in one pass

[David Edmundson]

davidedmundson added a reviewer: leinir.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25270

To: davidedmundson, leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D20766: Use appropriate background color for text previews

[Méven Car]

meven added a comment.


  I believe the issue currently is that for text files or files without 
associated definition we end up with an invalid definition that prevents 
SyntaxHighlighter::setDefinition to call rehighlight().
  QTextDocument uses then whatever it get from the theme I guess.
  Kate has an explicit special case in KateHighlighting::KateHighlighting to 
insert a default Format.
  
  I think either KSyntaxHighlighting should have a dummy default definition 
based on currrent theme or we should here create a dummy default definition 
when `m_highlightingRepository.definitionForFileName(path)` return an invalid 
definition.
  What do you think ?

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: dhaumann, cullmann, vkrause, cfeck, meven, broulik, kde-frameworks-devel, 
kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, 
alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D25236: Remove the last traces of KSslError from TCPSlaveBase

[Volker Krause]

vkrause added a comment.


  ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25236

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  on windows we install the binary to bin/ where software that uses kio
  can find it through applicationDirPath() ordinarily. at test-time however
  applicationDirPath() of the test != finalPath, so the only way a test
  can possibly find the helper is through $PATH.
  
  this should fix the drkonqi connection test on win32 on build.kde.org

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25308

AFFECTED FILES
  src/core/slave.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

[David Redondo]

davidre added a comment.


  I don't think deleting a entry from a config file makes sense. If you delete 
an entry you will get the default value on the next read.
  
  For shortcuts it's a bit more complicated. What shortcuts had you in mind to 
delete?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25304: Fix the OpenEXR >= 2.4 detection

[Antonio Rojas]

arojas added a comment.


  > The pkgconfig file disagrees:
  >  it contains `libsuffix=-2_4` and later `Libs: -L${libdir} 
-lIlmImf${libsuffix}`
  >  For me, that library name is correct
  
  I didn't say that the suffixed .so shouldn't exist. They are *both* supposed 
to be installed: the suffixed one and the unsuffixed one which is a symlink to 
the suffixed one. IOW, your patch is not wrong, it just wouldn't be necessary 
if it weren't for the openexr bug which is fixed in the linked commit

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25304

To: cgiboudeaux
Cc: arojas, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25304: Fix the OpenEXR >= 2.4 detection

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D25304#562561 , @arojas wrote:
  
  > > I don't see how that commit is related.
  > >  openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so
  > > 
  > > This is expected afaics.
  >
  > No, it's not. That line in openexr is supposed to link libXXX-2_4.so 
(${verlibname}) to libXXX.so (${baselibname}) but it does so in the wrong dir
  
  
  The pkgconfig file disagrees:
  it contains `libsuffix=-2_4` and later `Libs: -L${libdir} 
-lIlmImf${libsuffix}`
  
  To me, that library name is correct

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25304

To: cgiboudeaux
Cc: arojas, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25304: Fix the OpenEXR >= 2.4 detection

[Antonio Rojas]

arojas added a comment.


  > I don't see how that commit is related.
  >  openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so
  > 
  > This is expected afaics.
  
  No, it's not. That line in openexr is supposed to link libXXX-2_4.so 
(${verlibname}) to libXXX.so (${baselibname}) but it does so in the wrong dir

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25304

To: cgiboudeaux
Cc: arojas, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25304: Fix the OpenEXR >= 2.4 detection

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D25304#562553 , @arojas wrote:
  
  > This is a bug in openexr. It does actually try to install the unsuffixed 
symlinks, but it doesn't take DESTDIR into account, so it tries to install them 
to the root filesystem instead of doing so inside DESTDIR as it should. It is 
fixed in 
https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09
  
  
  I don't see how that commit is related.
  openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so
  
  This is expected afaics.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25304

To: cgiboudeaux
Cc: arojas, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

[Nathaniel Graham]

ngraham added reviewers: Frameworks, davidre, dfaure, meven, cfeck.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

To: esjeon, #frameworks, davidre, dfaure, meven, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19498: loadLibrary: Use enum values to define what type of plugin we load

[Alexander Potashev]

aspotashev added a comment.


  ping?

REPOSITORY
  R317 Kross

REVISION DETAIL
  https://phabricator.kde.org/D19498

To: aspotashev, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: New Framework Review: KDAV

[Alexander Potashev]

вс, 10 нояб. 2019 г. в 15:44, David Faure :
>
> On samedi 9 novembre 2019 21:14:46 CET Alexander Potashev wrote:
> > сб, 9 нояб. 2019 г. в 14:37, Volker Krause :
> > > during Akademy there was a request to promote KDAV from KDE PIM to
> > > Frameworks for use by Plasma Mobile. KDAV is a framework that implements
> > > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav support. It
> > > would be classified as a functional tier 3 framework.
> >
> > Hi Volker,
> >
> > The name "KDAV" suggests that it might implement WebDAV. Do you think
> > if it should be renamed to something like "DAVExtensions" or let's say
> > "AnyDAV"?
>
> The name seems fine to me. The substring "DAV" appears just as much in WebDAV
> as it does in CalDav/CardDav/GroupDav. So there's no reason to infer "WebDAV"
> from "KDAV".
>
> "Extensions" sounds very optional, and "AnyDAV" looks like yet-another WebDAV-
> based protocol in itself.
>
> The issue you see is that someone looking for WebDAV support might end up
> thinking KDAV is the right thing to use? Well, maybe it should be, i.e. this
> would probably be the right place for some proper future WebDAV API compared
> to using kio_http with metadata directly

OK. LGTM as well after your explanation.

-- 
Alexander Potashev

D25304: Fix the OpenEXR >= 2.4 detection

[Antonio Rojas]

arojas added a comment.


  This is a bug in openexr. It does actually try to install the unprefixed 
symlinks, but it doesn't take DESTDIR into account, so it tries to install them 
to the root filesystem instead of doing so inside DESTDIR as it should. It is 
fixed in 
https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25304

To: cgiboudeaux
Cc: arojas, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

[Eon S. Jeon]

esjeon created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
esjeon requested review of this revision.

REVISION SUMMARY
  Add a simple delete option to kwriteconfig. A possible usecase of this option 
is to delete unused shortcut bindings.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25307

AFFECTED FILES
  src/kreadconfig/kwriteconfig.cpp

To: esjeon
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[Stefan Brüns]

bruns accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  newSearchIcon

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26, bruns
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D25303: Expose KDescendantsProxyModel to QML

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R275:59dedec38d8a: Expose KDescendantsProxyModel to QML 
(authored by davidedmundson).

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25303?vs=69744=69751

REVISION DETAIL
  https://phabricator.kde.org/D25303

AFFECTED FILES
  src/qml/plugin.cpp

To: davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25303: Expose KDescendantsProxyModel to QML

[Arjen Hiemstra]

ahiemstra accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25303

To: davidedmundson, ahiemstra
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

[Nathaniel Graham]

ngraham added a comment.


  In D25015#562362 , @niccolove 
wrote:
  
  > Meanwhile, I tried to do a more sparse and equal-all-around shadow (to 
address Nate+Filip), but I'm not 100% okay with it. Opinions?
  >
  > F7762929: Screenshot_20191114_100519.png 

  
  
  Hmm, that shadow feels too "hard," somehow. It feels like it ends rather 
abruptly rather than fading out smoothly.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25304: Fix the OpenEXR >= 2.4 detection

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Note: openEXR >= 2.4 provides CMake configuration modules 
(OpenEXRConfig.cmake and IlmBaseConfig.cmake). We could also look for those and 
use the current code as a fallback if the modules can't be found

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25304

To: cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25304: Fix the OpenEXR >= 2.4 detection

[Christophe Giboudeaux]

cgiboudeaux created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
cgiboudeaux requested review of this revision.

REVISION SUMMARY
  Newer OpenEXR versions add a suffix to the libraries file names.
  ECM can now detect OpenEXR 2.3 and newer versions.

TEST PLAN
  kimageformats detects OpenEXR 2.3 and 2.4

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25304

AFFECTED FILES
  find-modules/FindOpenEXR.cmake

To: cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25303: Expose KDescendantsProxyModel to QML

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25303

AFFECTED FILES
  src/qml/plugin.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25302: Remove stale symlink

[Martin Tobias Holmedahl Sandsmark]

sandsmark created this revision.
sandsmark added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
sandsmark requested review of this revision.

REVISION SUMMARY
  When receiving a symlink, QFile::link will refuse in case the link already 
exist. This will cause updates to symlinks, or replacing files with a symlinked 
version to fail.
  
  Patch stolen from https://github.com/reMarkable/karchive/pull/1

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D25302

AFFECTED FILES
  src/karchive.cpp

To: sandsmark, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21328: Add qml import for KItemModels

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R275:adb9b0e9cd3a: Add qml import for KItemModels (authored by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21328?vs=64882=69738#toc

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21328?vs=64882=69738

REVISION DETAIL
  https://phabricator.kde.org/D21328

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/core/kconcatenaterowsproxymodel.cpp
  src/core/kconcatenaterowsproxymodel.h
  src/qml/CMakeLists.txt
  src/qml/kconcatenaterowsproxymodel_qml.cpp
  src/qml/kconcatenaterowsproxymodel_qml.h
  src/qml/plugin.cpp
  src/qml/plugin.h
  src/qml/qmldir
  tests/qml/concatenaterows.qml

To: davidedmundson, apol
Cc: kossebau, vkrause, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25223: Avoid side effects during menu initialization

[Konrad Materka]

kmaterka added a comment.


  In D25223#561638 , @nicolasfella 
wrote:
  
  > My long-term goal is to get rid of the application side KStatusNotifierItem 
and amend the QSystemTrayIcon API
  
  
  OK, I will think about this. This change is only to fix one regression.
  @broulik Is it OK now? Or should I use std::optional (and require C++17)?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D25223

To: kmaterka, #plasma, #frameworks, broulik
Cc: nicolasfella, davidedmundson, cgiboudeaux, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D22801: [KIO] silence a QFileInfo warning

[René J . V . Bertin]

rjvbb added a comment.


  >   I disagree since it will change the current precondition of the function 
for the need of one of its users.
  
  In that case the warning could be made to be a qDebug, and that user can 
configure his/her logging setting so the category used will always be printed.
  That user might also be served much better by an error return that his/her 
code could work with, rather than with a terminal warning (which will not be 
seen by anyone NOT using a terminal to launch applications.
  
  >   findPath is documented as :
  
  IOW, there is no documentation requirement that warnings be printed for empty 
path arguments.
  
  >   It makes no sense to check the mountpoint of an empty path that by 
essence cannot be a file.
  
  It makes no sense to do that check for any string that is not a valid path. 
Yet (from memory) there is a specific warning for this particular kind of 
invalid path.
  
  >   KIO is an old code-base and is maintained collectively mostly (with a 
single main maintainer @dfaure), we need to use our own wits.
  
  The smb plugin is part of kio-extras.
  
  >   Does it returns files with empty urls ?
  
  I have no idea how to check that (other than inserting trace output into 
smb.so), but I reckon the empty paths must indeed come from there.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22801

To: rjvbb, #frameworks
Cc: dfaure, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25170: make the libssh finder ensure the new ssh target is set

[Harald Sitter]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:24506c2af8d1: make the libssh finder ensure the new ssh 
target is set (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25170?vs=69342=69736

REVISION DETAIL
  https://phabricator.kde.org/D25170

AFFECTED FILES
  cmake/Findlibssh.cmake
  sftp/CMakeLists.txt

To: sitter
Cc: asn, heikobecker, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25237: Deprecated KTcpSocket and KSsl* classes

[Nicolas Fella]

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D25237

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  This was a unix only function in the shared file protocol cpp
  This has not been used at all in file_win.cpp for a while

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25301

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22801: [KIO] silence a QFileInfo warning

[Méven Car]

meven added a subscriber: dfaure.
meven added a comment.


  In D22801#561989 , @rjvbb wrote:
  
  > Are you not seeing these for instance when browsing an MSWin share in 
Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)?ç
  
  
  I don't have a samba (or MS) share available currently, unfortunately I can't 
test, but I might later.
  
  > I tried to figure out where they came from but failed because of the async 
nature of the chain of events. I presume the empty paths come from the smb KIO 
plugin and then somehow make it to where the warning is printed.
  
  I would suggest adding a dumb qDebug() appriopriately or panic whenever 
findByPath is called with an emtpy path.
  In `previewjob.cpp` What was `PreviewJobPrivate` `KFileItemList initialItems` 
when this happened ?
  
  >   I also considered that findByPath() already accepts non-existing 
ppathsaths and handles them appropriately, it could (and probably should) do 
the same with an empty path.
  
  I disagree since it will change the current precondition of the function for 
the need of one of its users.
  A warning is an explicit indication that assumption made writing the code are 
broken either because they are overstepped or were too limited when writing the 
code.
  
  findPath is documented as :
  
/**
 * Find the mountpoint on which resides @p path
 * For instance if /home is a separate partition, 
findByPath("/home/user/blah")
 * will return /home
 * @param path the path to check
 * @return the mount point of the given file
 */
Ptr findByPath(const QString ) const;
  
  It makes no sense to check the mountpoint of an empty path that by essence 
cannot be a file.
  This might hide others bugs elsewhere.
  
  > Regardless of the fact that the smb plugin probaby shouldn't output empty 
paths; maybe the maintainer(s) of that software should be CC'ed here?
  
  KIO is an old code-base and is maintained collectively mostly (with a single 
main maintainer @dfaure), we need to use our own wits.
  
  Btw do you use a samba mount(/etc/fstab defined or `mount -t smb`) or the 
`smb://` ioslave ? You must mean the `smb://` ioslave with `smb plugin`.
  In which case we might want to check the samba kio-extras code as well, in 
particular `SMBSlave::listDir` that returns the files contained in a folder.
  Does it returns files with empty urls ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22801

To: rjvbb, #frameworks
Cc: dfaure, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25149: Add a new template for KCMs

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> tcanabrava wrote in kcm.cpp:43
> What's the correct form then? No need to connect the settings *at all*?

No need indeed... it's *magic*! ;-)

> tcanabrava wrote in main.qml:39
> The default fake setting will not be immutable, or you mean that you want me 
> to do one mutable and one immutable settings for the example?

In fact you can't predict that, any setting can be made immutable (it's user 
and sysadmin controlled). No need to introduce another one.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava, #plasma, #frameworks, mart, ervin
Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, 
kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove added a comment.


  In D25015#560514 , @ndavis wrote:
  
  > > Remember that there are third party desktop themes with SVG that we 
probably want to support. Wouldn't using KWin for shadows break those?
  >
  > If we remove the code for using those SVG shadows, it won't break them in 
the sense that they will stop working. It'll just mean those parts of the 
desktop themes won't be used. I suppose that could be seen as a form of visual 
breakage.
  >
  > For complete theme sets, this shouldn't be such a problem since they also 
typically come with their own window decorations and recommend a specific 
widget style. For people who just want to get rid of the shadows we should 
probably provide an option somewhere to disable them rather than making them 
edit the plasma theme. I suppose we could wait until Plasma 6 to make that kind 
of change, but that's a ways away.
  
  
  I'm against this; there are many desktop themes that tweak their shadows 
without being a theme set, and it would be an important regression to ignore 
them.
  
  > Regardless of the method we use to achieve it (including continuing to use 
SVGs), I think it might be best to make Plasmashell's shadows match the shadows 
cast by menus (such as context menus) in applications. These are defined in the 
Breeze widget style and have different sizes to match the different window 
shadow sizes.
  
  This is interesting. I have to look more into it.
  
  Meanwhile, I tried to do a more sparse and equal-all-around shadow (to 
address Nate+Filip), but I'm not 100% okay with it. Opinions?
  
  F7762929: Screenshot_20191114_100519.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 182 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/182/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 14 Nov 2019 08:35:51 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven marked 5 inline comments as done.
meven added a comment.


  friendly ping
  
  Is https://phabricator.kde.org/D25010#inline-142132 satisfactory ?
  I think names are now explicit enough.
  I still wonder if the granularity level is enough.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

[Méven Car]

meven added a comment.


  Anyone to review this ? 30 lines change + test

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:80d5f52b0675: [DeleteJob] Use a separate worker thread to 
run actual IO operation (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24962?vs=69332=69728

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns