D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> bruns wrote in fstabhandling.cpp:301
> The API is totally awkward.
> 
> You end up with something significantly cleaner when you create a new class 
> for it:
> 
>   QStringMultiHash m_mtabCache;
>   QHash m_mtabFstypeCache;
>   bool m_mtabCacheValid;
> 
> and make the parser a member function.
> 
> Then instantiate the class for the fuseiso case and for the globalFstabCache.

Yeah, I agree - it isn't the prettiest of code :D My main reasoning for doing 
it like this was to make the change as small as possible. But, let me take a 
stab at refactoring it a bit and push a new commit.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  I wonder if the Light gray line on the inactive mode should be a little 
brighter (up to 35% opacity) or if the background for inactive and minimized 
should be a little darker (down to 15% opacity)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  Here's a cleaned up version of the file with the changes Nate and I 
requested: F7767647: tasks.svg 
  F7767649: Screenshot_20191117_005703.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  Unfortunately, InactiveText doesn't work and neither does DisabledText. I 
might need to change whatever library handles stylesheets for plasmashell.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21660: remove dbus for windows build and change audio dep logic

[Ben Cooksley]

bcooksley added a comment.


  Considering that D-Bus doesn't really belong on Windows, and has been known 
to cause security software (such as anti-malware packages) to generate false 
positives in the past, we really should avoid D-Bus completely if at all 
possible on Windows. For standalone applications there isn't really a reason to 
have it around.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: habacker, aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

[Ralf Habacker]

habacker added a comment.


  In D21660#563425 , @bcooksley 
wrote:
  
  > If tests launch D-Bus Daemon, then they will cause the CI system to jam as 
CTest will wait indefinitely for dbus-daemon to exit.
  
  
  There is a fix for this issue, see https://phabricator.kde.org/D25350

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: habacker, aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Also, according to the title, the line thickness changes are unrelated, so 
they shouldn't even be included here at all. Let's make this patch only about 
adding/changing background colors, and let's discuss the line thickness in 
another patch/task.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25328: Always rehiglhight() after definition was changed

[Méven Car]

meven added a comment.


  In D25328#563406 , @dhaumann wrote:
  
  > Can't you call `rehighlight()` yourself after calling `setDefinition()`?
  >
  > Btw, tanks for looking into this!
  
  
  I have done so in D25323 .
  But I meant to open this one as well to figure out which way to go, user side 
fix or lib fix ?
  I would favor the lib fix as it seems it might save some users the trouble of 
adding a workaround because no definition is found just to get highlight like 
D25323  does.
  Kate has such a workaround as well in KateSyntaxHighlight I believe.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25328

To: meven, kossebau, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D25340: Added background colors to active and inactive icon view

[Nathaniel Graham]

ngraham added a comment.


  I like the background changes here and I think it makes logical sense to have 
a progression of changing background colors to indicate the status. However I'm 
not a huge fan of reducing the active indicator to just 2px. It's now so small 
that it becomes kind of superfluous. I think it would look better at the 
current size, and this would be more consistent with the highlight effects that 
@ndavis is working on, IIRC.
  
  My view is that if we don't like the blue line being so visible, we should 
remove it entirely rather than making it so small that it feels like it wishes 
it didn't exist. :) Otherwise we should keep it where it is right now. I don't 
think there's anything wrong with its current size.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> ispellcheckerclient.cpp:33
> +// init com if needed
> +m_wasCOMInitialized = SUCCEEDED(CoInitializeEx(nullptr, 
> COINIT_MULTITHREADED));
> +

is that needed? It should be handled by the qt main loop?

> ispellcheckerclient.cpp:59
> +// de-init com if needed
> +if (m_wasCOMInitialized) {
> +CoUninitialize();

qt main loop again

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25244

To: cullmann, #frameworks, vonreth
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24957: Add new baloo icons

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:61331d6ce20a: Add new baloo icons (authored by astippich).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24957?vs=69857=69859

REVISION DETAIL
  https://phabricator.kde.org/D24957

AFFECTED FILES
  icons-dark/apps/48/baloo.svg
  icons-dark/preferences/32/baloo.svg
  icons-dark/preferences/32/preferences-desktop-baloo.svg
  icons/apps/48/baloo.svg
  icons/preferences/32/baloo.svg
  icons/preferences/32/preferences-desktop-baloo.svg

To: astippich, #vdg, ngraham, bruns
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24957: Add new baloo icons

[Alexander Stippich]

astippich updated this revision to Diff 69857.
astippich added a comment.


  - tweak icon and shadows
  - remove baloo symlink

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24957?vs=69501=69857

BRANCH
  newBalooIcon

REVISION DETAIL
  https://phabricator.kde.org/D24957

AFFECTED FILES
  icons-dark/apps/48/baloo.svg
  icons-dark/preferences/32/baloo.svg
  icons-dark/preferences/32/preferences-desktop-baloo.svg
  icons/apps/48/baloo.svg
  icons/preferences/32/baloo.svg
  icons/preferences/32/preferences-desktop-baloo.svg

To: astippich, #vdg, ngraham, bruns
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  In D25340#563388 , @niccolove 
wrote:
  
  > > @ndavis said:
  > >  Here's what I think:
  > > 
  > > - The line should indicate that the app is opened, the window is not 
minimized and the window is focused (opaque blue) or inactive (opaque gray)
  > > - The background should indicate whether an app is not opened (no BG), 
minimized or inactive (semi-transparent gray), or focused (semi-transparent 
blue)
  >
  > Please note that would require change in how desktop themes are handled, 
not in the desktop theme itself, as far as I understand it. I'm afraid I don't 
have the experience to implement what you are saying; this is the best I can 
offer. Of course, if there is anybody else, it could be a good idea.
  
  
  It looks like you already did it, but the opacity levels of the inactive bars 
need to be changed. I noticed that the SVG uses black in inkscape as the base 
color for the minimized and normal (inactive) modes, but actually uses the text 
color in Plasmashell. Keep that in mind when adjusting the opacity and the 
color class should be changed to InactiveText. I haven't actually tested if 
this value works, but it should. Right now I'm playing around with your patch a 
bit.
  
  Based on my experience, this should have broken stylesheet support, but 
apparently not...
  

  


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

[Ben Cooksley]

bcooksley added a comment.


  If tests launch D-Bus Daemon, then they will cause the CI system to jam as 
CTest will wait indefinitely for dbus-daemon to exit.
  
  D-Bus should not be used under any circumstances on Windows.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: habacker, aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

[Ralf Habacker]

habacker added a comment.


  In D21660#481421 , @bcooksley 
wrote:
  
  > With regards to Windows, please note that any unit test which depends on 
calls that involve D-Bus on the CI system will likely lead to that test hanging 
because dbus-daemon is not launched by the CI system.
  
  
  There is no need to start dbus-daemon by CI. dbus-daemon is started by the 
dbus client library by default, if not running for the given install path.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: habacker, aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove updated this revision to Diff 69851.
niccolove added a comment.


  Added background colors to active and inactive icon view

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69849=69851

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25328: Always rehiglhight() after definition was changed

[Dominik Haumann]

dhaumann added a comment.


  Can't you call `rehighlight()` yourself after calling `setDefinition()`?
  
  Btw, tanks for looking into this!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25328

To: meven, kossebau, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove added a comment.


  In D25340#563400 , @ndavis wrote:
  
  > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which 
isn't in git master. Do I actually need that commit for this patch to work?
  
  
  No. My bad. Let me fix.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which 
isn't in git master. Do I actually need that commit for this patch to work?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove added a subscriber: ndavis.
niccolove added a comment.


  > @ndavis said:
  >  Here's what I think:
  > 
  > - The line should indicate that the app is opened, the window is not 
minimized and the window is focused (opaque blue) or inactive (opaque gray)
  > - The background should indicate whether an app is not opened (no BG), 
minimized or inactive (semi-transparent gray), or focused (semi-transparent 
blue)
  
  Please note that would require change in how desktop themes are handled, not 
in the desktop theme itself, as far as I understand it. I'm afraid I don't have 
the experience to implement what you are saying; this is the best I can offer. 
Of course, if there is anybody else, it could be a good idea.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#563295 , @niccolove 
wrote:
  
  > In D25334#563285 , @ngraham 
wrote:
  >
  > > Perfect, all issues fixed, and thanks for pointing  me in the direction 
of the cache files. Deleting those fixed a bunch of other issues I was having 
with applying plasma theme SVG changes.
  >
  >
  > Did it fix the shadows? I can't apply my own shadows to the new distro I'm 
using.
  >
  > Regarding this task, I just realized a possible problem: 
  >  I originally copied this effect from the highlight effect that's used when 
you hover on applications, which uses a 3px blue line:
  >  F774: Screenshot_20191116_164209.png 

  >  But then, tweaking things around, I realized that a 2px line looks way 
better in my panel, imo:
  >  F776: Screenshot_20191116_164303.png 

  >  Therefore right now this effect and the application hover effect are 
inconsistent. I'm not a fan of bringing back that 3px line though. Do you think 
I should change the application top lines, or leave them as-is?
  
  
  If we use a 2px line here, then using a 2px outline for button focus in 
D24706  would be more acceptable. If a 2px 
line looks good in the task manager, it might be worth making the change.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove edited the test plan for this revision.
niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Added:
  
  - Light blue color for active window
  - Light gray color for inactive but not minimized window

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#563346 , @ngraham wrote:
  
  > Found the bug report tracking that requested change: 
https://bugs.kde.org/show_bug.cgi?id=370465
  >
  > Based on the comments there, it's likely that this proposal would receive 
pushback, and we should endeavor to understand why it was changed to the 
current state in the first place. That's not a reason to hold back on doing it, 
we just need to understand the history and make the change for legitimate 
usability-based reasons so it's not perceived as "flipping things back and 
forth over and over again".
  
  
  The relevant quote:
  
  > Kai Uwe Broulik 2018-04-03 07:51:10 UTC 
  >  We had exactly what you suggest for a while and then it was changed back 
to line art. Can we stop randomly changing theme whenever someone comes by and 
doesn't like something unless it actually comes enclosed with a 20 page 
empirical study made in a lab or something?
  
  Looks like he's referring to using only colored backgrounds, which is not 
what we're doing now. I do think the current way of showing window state is 
visually a bit confusing.
  
  Here's what I think:
  
  - The line should indicate that the app is opened, the window is not 
minimized and the window is focused (opaque blue) or inactive (opaque gray)
  - The background should indicate whether an app is not opened (no BG), 
minimized or inactive (semi-transparent gray), or focused (semi-transparent 
blue)
  
  This way it mostly doesn't change, but the visuals have more of a logical 
relation to each other.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

Re: Disabling of 'kdav-davitemfetchjob' test in KDav

[Ben Cooksley]

On Sat, Nov 16, 2019 at 11:49 PM Volker Krause  wrote:
>
> On Saturday, 16 November 2019 11:26:39 CET Volker Krause wrote:
> > On Saturday, 16 November 2019 07:04:57 CET Ben Cooksley wrote:
> > > Hi everyone,
> > >
> > > Currently we have an issue where the test 'kdav-davitemfetchjob' within
> > > kdav causes kdeinit5 to be relaunched, as can be seen in the CI
> > > run log below.
> > >
> > > https://build.kde.org/job/Applications/job/kdav/job/kf5-qt5%20SUSEQt5.12/3
> > > 8/ console
> > >
> > > This is behaviour which is not permitted within the CI system, as the
> > > newly spawned 'kdeinit5' processes are treated as being launched by
> > > that test by CTest, meaning it will wait for eternity for them to exit
> > > (which as resident daemon processes, they will not do without manual
> > > intervention).
> > >
> > > This in turn blocks the job from completing, and blocks CI resources
> > > in the process.
> > >
> > > I'd therefore like to propose disabling this test across all platforms
> > > as it's behaviour is incompatible with the CI system.
> >
> > uh, I wasn't even aware of that problem for KDAV...
>
> turns out there's a reason for this: the problem only started to occur after a
> build run on Nov 15 triggered without source code changes (yesterday), before
> this the entire tests for kdav finished in less than a minute.
>
> > The test doesn't do anything special regarding kdeinit, it does run a KIO
> > HTTP job against a local fake server though, which I guess triggers this.
> >
> > I've added the same workaround that KIO seems to use: https://cgit.kde.org/
> > kdav.git/commit/?id=c6fb178a38028281fea9bae48ca3c6a9e6d04059
>
> That alone wasn't enough, it needs:
>
> qputenv("KDE_FORK_SLAVES", "yes");
> qputenv("KIO_DISABLE_CACHE_CLEANER", "yes");
>
> With that kdav works fine again.
>
> > If that doesn't help, I'm wondering if there's a way to disable such
> > problematic tests only on the CI (also with regard to the Akonadi test
> > issue), as those tests work fine locally and are useful there. Is there
> > maybe a characteristic environment variable that we can use to easily check
> > for this in CMake?
>
> Probably not needed after all, the two other reported issue in akonadi and
> kdepim-runtime are the same problem, HTTP KIO operations that have been around
> since a long time now starting to get stuck. I'll look into applying the same
> fix there.
>
> As this all started at the same time, I guess there was some change to either
> KIO or the CI environment yesterday that started to trigger this?

The CI images themselves were last rebuilt 4 weeks ago, so they're
innocent in this regard.
Likewise, the CI Tooling itself hasn't changed in any meaningful way
here either.

I'd say this is a regression within KIO/Kdeinit.

>
> Regards,
> Volker

Cheers,
Ben

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Xuetian Weng]

xuetianweng added reviewers: cullmann, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Xuetian Weng]

xuetianweng added a comment.


  F7766842: Screenshot_20191116_092819.png 

  
  Add screenshot to demonstrate the problem.
  
  And what I'd like to point is, for CJK users, it is uncommon for them to 
select a single font to cover all the characters, because such fonts are really 
rare. People usually select one latin only font and just let system 
(fontconfig) select the fallback for them.
  So this could be a common problem for them to see the "half character".

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Xuetian Weng]

xuetianweng updated this revision to Diff 69848.
xuetianweng added a comment.


  Add comment about the actual characters.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25339?vs=69847=69848

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25339

AFFECTED FILES
  src/render/katerenderer.cpp

To: xuetianweng, #ktexteditor
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added a reviewer: KTextEditor.
xuetianweng added projects: Kate, Frameworks.
xuetianweng requested review of this revision.

REVISION SUMMARY
  When a font has fallback, the fontHeight is broken can may cut the string
  in the middle in the line. Try to use some representive character from 
multiple
  languages to estimate the actual fontHeight.
  
  BUG: 404907

TEST PLAN
  Manually tested.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25339

AFFECTED FILES
  src/render/katerenderer.cpp

To: xuetianweng, #ktexteditor
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  In D25334#563345 , @niccolove 
wrote:
  
  > In D25334#563334 , @ngraham 
wrote:
  >
  > > If you wanna do that, let's split it out into a different patch though.
  >
  >
  > Sure. Should this patch land first, or should I try to make two at the same 
time?
  
  
  You can do two patches at once. Just do each on a separate git branch, and 
then they won't interfere with one another. See 
https://community.kde.org/Infrastructure/Phabricator#Workflow

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  Found the bug report tracking that requested change: 
https://bugs.kde.org/show_bug.cgi?id=370465
  
  Based on the comments there, it's likely that this proposal would receive 
pushback, and we should endeavor to understand why it was changed to the 
current state in the first place. That's not a reason to hold back on doing it, 
we just need to understand the history and make the change for legitimate 
usability-based reasons so it's not perceived as "flipping things back and 
forth over and over again".

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#563334 , @ngraham wrote:
  
  > If you wanna do that, let's split it out into a different patch though.
  
  
  Sure. Should this patch land first, or should I try to make two at the same 
time?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  If you wanna do that, let's split it out into a different patch though.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  In D25334#563308 , @niccolove 
wrote:
  
  > F7766720: Screenshot_20191116_172052.png 

  >  I think that this last one looks much prettier and usable, but that's just 
an idea I only wanted to try, feel free to tell me that's not a good idea. 
Also, changing the background colors there could also be done regardless of the 
line thickness. I just felt like it was much prettier.
  
  
  I agree 100%, and in fact this is also something I have wanted for a long 
time. It would be a big improvement IMO. There's a bug report requesting this 
somewhere, I just need to find it...

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25328: Always rehiglhight() after definition was changed

[Christoph Cullmann]

cullmann added a comment.


  Hmm, I am not sure this doesn't regress cases that rely on setDefinition 
being "cheap" for the nop case.
  Is there no other way to trigger re-highlight for the wanted case?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25328

To: meven, kossebau, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#563301 , @ngraham wrote:
  
  > If anything, I think the tab bar line should increase to be 3px to match 
the open app task manager highlight. If we do the reverse, the highlight for 
open app swill be too subtle IMO.
  
  
  Uhm, what if we drew the blue background for the active app? That is what 
Windows does as well, and I think it makes sense. When you open a widget, the 
window will lose focus, so there will never be two elements with blue 
background in the panel. Hover is still clearly visible. See:
  Before:
  F7766706: Screenshot_20191116_170621.png 

  After:
  F7766713: Screenshot_20191116_171634.png 

  At this point open-but-inactive applications could be made more visible by 
adding a gray background as transparent as the blue on.
  F7766720: Screenshot_20191116_172052.png 

  I think that this last one looks much prettier and usable, but that's just an 
idea I only wanted to try, feel free to tell me that's not a good idea. Also, 
changing the background colors there could also be done regardless of the line 
thickness. I just felt like it was much prettier.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

[Christoph Cullmann]

cullmann added a comment.


  Then we can merge this, or?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25244

To: cullmann, #frameworks, vonreth
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25106: Also allow invoking session restoration logic when apps are manually launched

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25106

To: ngraham, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25219: Only create a session config when actually restoring a session

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  If anything, I think the tab bar line should increase to be 3px to match the 
open app task manager highlight. If we do the reverse, the highlight for open 
app swill be too subtle IMO.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove added a comment.


  This is a comparison: F7766697: Screenshot_20191116_165659.png 

  The problem is not that you don't see, it's that it doesn't show. I'll try to 
understand what's going on and get back to you.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

[Nathaniel Graham]

ngraham added a comment.


  Okay, after you taught me how to delete the cache files `rm 
~/.cache/plasma*`, I can see other changes to the plasma theme SVG files but I 
must admit I still don't see a difference between the old and new shadows in 
this patch. :/

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#563285 , @ngraham wrote:
  
  > Perfect, all issues fixed, and thanks for pointing  me in the direction of 
the cache files. Deleting those fixed a bunch of other issues I was having with 
applying plasma theme SVG changes.
  
  
  Did it fix the shadows? I can't apply my own shadows to the new distro I'm 
using.
  
  Regarding this task, I just realized a possible problem: 
  I originally copied this effect from the highlight effect that's used when 
you hover on applications, which uses a 3px blue line:
  F774: Screenshot_20191116_164209.png 

  But then, tweaking things around, I realized that a 2px line looks way better 
in my panel, imo:
  F776: Screenshot_20191116_164303.png 

  Therefore right now this effect and the application hover effect are 
inconsistent. I'm not a fan of bringing back that 3px line though. Do you think 
I should change the application top lines, or leave them as-is?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25296: [RFC] Fix Display Configuration icon margins

[Nathaniel Graham]

ngraham added a comment.


  Never mind, I wasn't deleting the cache files properly after rebuilding. When 
I do that, the monochrome icons don't get used at all and it reverts to the 
colorful one:
  F778: Screenshot_20191116_084222.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Perfect, all issues fixed, and thanks for pointing  me in the direction of 
the cache files. Deleting those fixed a bunch of other issues I was having with 
applying plasma theme SVG changes.
  
  This looks great to me.
  
  Other VDG or #plasma  folks, any 
comments?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 65 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/65/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 16 Nov 2019 15:24:58 +
 Build duration:
8 min 27 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.65.0.xmlcompat_reports/KF5ItemModels_compat_report.htmllogs/KF5ItemModels/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)57%
(43/76)57%
(43/76)72%
(6504/8985)57%
(2922/5098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)99%
(2416/2440)62%
(1051/1701)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1759/2545)54%
(651/1211)src.core81%
(17/21)81%
(17/21)80%
(2329/2916)65%
(1220/1886)src.qml0%
(0/2)0%
(0/2)0%
(0/26)0%
(0/2)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1058)0%
(0/298)

D24957: Add new baloo icons

[Nathaniel Graham]

ngraham added a comment.


  Yes, that's correct.

REPOSITORY
  R266 Breeze Icons

BRANCH
  newBalooIcon

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/42/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 16 Nov 2019 15:28:56 +
 Build duration:
2 min 27 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.65.0.xmlcompat_reports/KF5ItemModels_compat_report.htmllogs/KF5ItemModels/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)57%
(43/76)57%
(43/76)72%
(6504/8981)57%
(2922/5098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)99%
(2416/2440)62%
(1051/1701)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1759/2545)54%
(651/1211)src.core81%
(17/21)81%
(17/21)80%
(2329/2915)65%
(1220/1886)src.qml0%
(0/2)0%
(0/2)0%
(0/26)0%
(0/2)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1055)0%
(0/298)

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/41/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 16 Nov 2019 15:24:07 +
 Build duration:
4 min 46 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.65.0.xmlcompat_reports/KF5ItemModels_compat_report.htmllogs/KF5ItemModels/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)57%
(43/76)57%
(43/76)72%
(6504/8981)57%
(2922/5098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)99%
(2416/2440)62%
(1051/1701)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1759/2545)54%
(651/1211)src.core81%
(17/21)81%
(17/21)80%
(2329/2915)65%
(1220/1886)src.qml0%
(0/2)0%
(0/2)0%
(0/26)0%
(0/2)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1055)0%
(0/298)

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#563265 , @ngraham wrote:
  
  > Did you change the SVGs for vertical tab bars as well?
  
  
  Uh, yes I did. Try deleting the plasma theme + svg cache in .cache
  
  > I also noticed one visual papercut in the plasma-pa tab bar: the blue line 
highlight becomes thinner on the right edge: F7766617: 
Screenshot_20191116_081301.png 
  > 
  > Any idea what's up with that?
  
  Fixed, my bad. Or, better put, OOPSIE WOOPSIE!! Uwu I made a fucky wucky!! A 
wittle fucko boingo!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/39/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 16 Nov 2019 15:24:58 +
 Build duration:
2 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove updated this revision to Diff 69841.
niccolove added a comment.


  Fixed broken north bottom-left tabbar line

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25334?vs=69840=69841

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove, #vdg
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

Re: Bulk replacement of projects.kde.org on Frameworks modules

[Luigi Toscano]

Luigi Toscano ha scritto:
> Hi,
> basically all Frameworks components reference the ECM website
> using the old projects.kde.org URL, which is long gone and
> it is just a (partial) redirect.
> 
> See for example:
> 
> set_package_properties(ECM PROPERTIES TYPE REQUIRED
> DESCRIPTION "Extra CMake Modules."
> URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;)
> 
> Can I go around a bulk-replace all the URLs with
> https://commits.kde.org/extra-cmake-modules, so that it would look like:
> 
> set_package_properties(ECM PROPERTIES TYPE REQUIRED
> DESCRIPTION "Extra CMake Modules."
> URL "https://commits.kde.org/extra-cmake-modules;)
> 
> There are few additional URLs which use the old website and I would replace
> them as well using the same pattern.
> 
> I'm asking to avoid ~70 almost-identical review requests.

Apart from Elvis (here) and Volker (on IRC), any other ack? (looking
especially for dfaure :)

Ciao
-- 
Luigi

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/40/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 16 Nov 2019 15:17:23 +
 Build duration:
6 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.65.0.xmlcompat_reports/KF5ItemModels_compat_report.htmllogs/KF5ItemModels/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)57%
(43/76)57%
(43/76)72%
(6504/8981)57%
(2922/5098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)99%
(2416/2440)62%
(1051/1701)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1759/2545)54%
(651/1211)src.core81%
(17/21)81%
(17/21)80%
(2329/2915)65%
(1220/1886)src.qml0%
(0/2)0%
(0/2)0%
(0/26)0%
(0/2)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1055)0%
(0/298)

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/64/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 16 Nov 2019 15:20:53 +
 Build duration:
2 min 26 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.65.0.xmlcompat_reports/KF5ItemModels_compat_report.htmllogs/KF5ItemModels/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)57%
(43/76)57%
(43/76)72%
(6504/8985)57%
(2922/5098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)99%
(2416/2440)62%
(1051/1701)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1759/2545)54%
(651/1211)src.core81%
(17/21)81%
(17/21)80%
(2329/2916)65%
(1220/1886)src.qml0%
(0/2)0%
(0/2)0%
(0/26)0%
(0/2)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1058)0%
(0/298)

D25296: [RFC] Fix Display Configuration icon margins

[Nathaniel Graham]

ngraham added a comment.


  Hmm, if I change that, the icon disappears entirely when displayed at the 
22px size: F7766627: Screenshot_20191116_082035.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/38/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 16 Nov 2019 15:20:53 +
 Build duration:
1 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/63/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 16 Nov 2019 15:17:23 +
 Build duration:
2 min 30 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.65.0.xmlcompat_reports/KF5ItemModels_compat_report.htmllogs/KF5ItemModels/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)57%
(43/76)57%
(43/76)72%
(6504/8985)57%
(2922/5098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)99%
(2416/2440)62%
(1051/1701)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1759/2545)54%
(651/1211)src.core81%
(17/21)81%
(17/21)80%
(2329/2916)65%
(1220/1886)src.qml0%
(0/2)0%
(0/2)0%
(0/26)0%
(0/2)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1058)0%
(0/298)

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/37/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 16 Nov 2019 15:17:23 +
 Build duration:
1 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added subscribers: ndavis, ngraham.
ngraham added a comment.


  This is great, I've wanted Plasma tabs to look like this for ages. It gels 
very well with the in-progress highlight changes that @ndavis is working on. 
However for me it only seems to take effect for horizontal tab bars. Did you 
change the SVGs for vertical tab bars as well?
  
  I also noticed one visual papercut in the plasma-pa tab bar: the blue line 
highlight becomes thinner on the right edge: F7766617: 
Screenshot_20191116_081301.png 
  
  Any idea what's up with that?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#563254 , @KonqiDragon 
wrote:
  
  > Something like this looks better and clearer.
  >  F6924045: grafik.png 
  
  
  That's because no element was selected. If you select an element, only that 
one appears selected:
  F7766584: Screenshot_20191116_154652.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25334: Added transparent blue background to tabbars

[KonqiDragon]

KonqiDragon added a comment.


  Is it possible to make the  selection of system tray visually more cleary? 
  On this screenshot i see that opened the "Status and Notifications" tray 
popup,  but it looks like that selected all in the system tray
  F7766344: Screenshot_20191116_121454.png 

  Something like this looks better and clearer.
  F6924045: grafik.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 185 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/185/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 16 Nov 2019 14:29:28 +
 Build duration:
8 min 45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove updated this revision to Diff 69840.
niccolove edited the summary of this revision.
niccolove added a comment.


  Resized blue line of tabbars

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25334?vs=69833=69840

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove, #vdg
Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25237: Deprecated KTcpSocket and KSsl* classes

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ba8e9c7df86c: Deprecated KTcpSocket and KSsl* classes 
(authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25237?vs=69530=69839

REVISION DETAIL
  https://phabricator.kde.org/D25237

AFFECTED FILES
  src/core/ktcpsocket.h

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 184 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/184/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 16 Nov 2019 12:20:34 +
 Build duration:
9 min 53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio added inline comments.

INLINE COMMENTS

> bruns wrote in kio_search.cpp:88
> @broulik - why `endsWith()`?

should I just change the comparisons to `path == ...`, just like the 
`/documents` one?

REPOSITORY
  R293 Baloo

BRANCH
  extend_query_url

REVISION DETAIL
  https://phabricator.kde.org/D24433

To: iasensio, #baloo, meven, ngraham, astippich
Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D24433: Move URL parsing methods from kioslave to query object

[Ismael Asensio]

iasensio updated this revision to Diff 69836.
iasensio added a comment.


  Remove extra spaces

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24433?vs=69613=69836

BRANCH
  extend_query_url

REVISION DETAIL
  https://phabricator.kde.org/D24433

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp
  src/lib/query.cpp

To: iasensio, #baloo, meven, ngraham, astippich
Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D25236: Remove the last traces of KSslError from TCPSlaveBase

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e0eb9ebaa569: Remove the last traces of KSslError from 
TCPSlaveBase (authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25236?vs=69527=69835

REVISION DETAIL
  https://phabricator.kde.org/D25236

AFFECTED FILES
  src/core/tcpslavebase.cpp

To: vkrause, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

[Michel Ludwig]

mludwig added a comment.


  I've tried it out and works just fine! :)

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25244

To: cullmann, #frameworks, vonreth
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: kconfig-elektra

[kde5]

Dear David,

Am 16.11.19 um 03:20 schrieb David Faure:
> On mardi 12 novembre 2019 16:58:19 CET k...@markus-raab.org wrote:
>> Dear KDE developers,
>>
>> As discussed in Akademy 2018 [1] Felix Resch and Dardan Haxhimustafa are
>> working on a patch for KConfig so that KConfig uses Elektra [2] instead
>> of the KConfigINI backend.
>>
>> We forked the KConfig repository [3] and currently try to:
>> 1. successfully start KDE to use Elektra (Felix Resch)
>> 2. implement a new plugin for Elektra that supports the KConfig INI
>>files for a smooth transition to Elektra (Dardan Haxhimustafa)
>> 3. improve Elektra's qt-gui, which will provide a low-level GUI for the
>>whole (KDE) configuration (Dardan Haxhimustafa)
> 
> Cool.

:-)

>> Two questions came up until now:
>> 1. Is KConfigBackend supposed to be thread safe?
> 
> No, KSharedConfig::openConfig is thread safe and creates different KConfig 
> instances in each thread. This way, KConfig and KConfigBackend don't need to 
> be thread-safe.

Perfect, then we can directly have Elektra's KDB handle within our
implementation of KConfigBackend.

>> 2. If Elektra finds a merge conflict between the KConfig objects and the
>>configuration files on the disc, should we then do a 3-way merge
>>which prefers "ours" or should we ask the user with a KDialog how to
>>proceed?
> 
> I'm a bit out of context (2018 was a long time ago),

I am not even sure if we even discussed this at all.

> what's the scenario that might lead to this happening?

Someone presses "save" in a configuration dialog but this change would
overwrite another change in the configuration file done by another
process (e.g. another application (instance), some CM tool, manual
modification of the INI file, ...).

Steps to reproduce such an issue:
1. Start the application, let us assume this is the only point in time
   where the application reads the configuration.
2. Modify the INI file of the application externally.
3. Press save in the configuration dialog of the application.

> It sounds to me like a dialog would bother the 
> user with low-level technical things that they won't understand nor know how 
> to resolve.

In the case the person had manually edited the INI file (or used Elektra
to modify the configuration) him/herself, he/she would understand. If
some other tool changed the INI file, it would be exactly as you say.

> If you can describe how this can happen, then we can conclude what 
> should be happening automatically to fix the situation.

Unfortunately, we cannot know if the "other change" happened by the user
him/herself or by some script the user is not aware of.

The current situation is that *all* changes some other process did are
lost. In Elektra and automatic 3-way merging in favor of "ours", you
will only lose changes in which there are actually conflicts. So it will
already be an improvement -- even without a dialog. If you do not want
to lose *any* changes, an interaction is needed (like "git merge" has).

best regards,
Markus

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.
niccolove added a reviewer: VDG.
niccolove added a subscriber: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Used the T11124  highlight effect for 
breeze tabbars by editing the file widgets/tabbar.svg.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Disabling of 'kdav-davitemfetchjob' test in KDav

[Volker Krause]

On Saturday, 16 November 2019 11:26:39 CET Volker Krause wrote:
> On Saturday, 16 November 2019 07:04:57 CET Ben Cooksley wrote:
> > Hi everyone,
> > 
> > Currently we have an issue where the test 'kdav-davitemfetchjob' within
> > kdav causes kdeinit5 to be relaunched, as can be seen in the CI
> > run log below.
> > 
> > https://build.kde.org/job/Applications/job/kdav/job/kf5-qt5%20SUSEQt5.12/3
> > 8/ console
> > 
> > This is behaviour which is not permitted within the CI system, as the
> > newly spawned 'kdeinit5' processes are treated as being launched by
> > that test by CTest, meaning it will wait for eternity for them to exit
> > (which as resident daemon processes, they will not do without manual
> > intervention).
> > 
> > This in turn blocks the job from completing, and blocks CI resources
> > in the process.
> > 
> > I'd therefore like to propose disabling this test across all platforms
> > as it's behaviour is incompatible with the CI system.
> 
> uh, I wasn't even aware of that problem for KDAV...

turns out there's a reason for this: the problem only started to occur after a 
build run on Nov 15 triggered without source code changes (yesterday), before 
this the entire tests for kdav finished in less than a minute.

> The test doesn't do anything special regarding kdeinit, it does run a KIO
> HTTP job against a local fake server though, which I guess triggers this.
> 
> I've added the same workaround that KIO seems to use: https://cgit.kde.org/
> kdav.git/commit/?id=c6fb178a38028281fea9bae48ca3c6a9e6d04059

That alone wasn't enough, it needs:

qputenv("KDE_FORK_SLAVES", "yes");
qputenv("KIO_DISABLE_CACHE_CLEANER", "yes");

With that kdav works fine again.

> If that doesn't help, I'm wondering if there's a way to disable such
> problematic tests only on the CI (also with regard to the Akonadi test
> issue), as those tests work fine locally and are useful there. Is there
> maybe a characteristic environment variable that we can use to easily check
> for this in CMake?

Probably not needed after all, the two other reported issue in akonadi and 
kdepim-runtime are the same problem, HTTP KIO operations that have been around 
since a long time now starting to get stuck. I'll look into applying the same 
fix there.

As this all started at the same time, I guess there was some change to either 
KIO or the CI environment yesterday that started to trigger this?

Regards,
Volker


signature.asc
Description: This is a digitally signed message part.

Re: Disabling of 'kdav-davitemfetchjob' test in KDav

[Volker Krause]

On Saturday, 16 November 2019 07:04:57 CET Ben Cooksley wrote:
> Hi everyone,
> 
> Currently we have an issue where the test 'kdav-davitemfetchjob' within
> kdav causes kdeinit5 to be relaunched, as can be seen in the CI
> run log below.
> 
> https://build.kde.org/job/Applications/job/kdav/job/kf5-qt5%20SUSEQt5.12/38/
> console
> 
> This is behaviour which is not permitted within the CI system, as the
> newly spawned 'kdeinit5' processes are treated as being launched by
> that test by CTest, meaning it will wait for eternity for them to exit
> (which as resident daemon processes, they will not do without manual
> intervention).
> 
> This in turn blocks the job from completing, and blocks CI resources
> in the process.
> 
> I'd therefore like to propose disabling this test across all platforms
> as it's behaviour is incompatible with the CI system.

uh, I wasn't even aware of that problem for KDAV...

The test doesn't do anything special regarding kdeinit, it does run a KIO HTTP 
job against a local fake server though, which I guess triggers this.

I've added the same workaround that KIO seems to use: https://cgit.kde.org/
kdav.git/commit/?id=c6fb178a38028281fea9bae48ca3c6a9e6d04059

If that doesn't help, I'm wondering if there's a way to disable such 
problematic tests only on the CI (also with regard to the Akonadi test issue), 
as those tests work fine locally and are useful there. Is there maybe a 
characteristic environment variable that we can use to easily check for this 
in CMake?

Thanks,
Volker

signature.asc
Description: This is a digitally signed message part.

D24957: Add new baloo icons

[Alexander Stippich]

astippich added a comment.


  the scalable test fails with this one. Is the right solution to just delete 
the 32px symlink under .../preferences?

REPOSITORY
  R266 Breeze Icons

BRANCH
  newBalooIcon

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24959: Add new preferences search icons

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:40acd718572a: Add new preferences search icons (authored 
by astippich).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24959?vs=69500=69830

REVISION DETAIL
  https://phabricator.kde.org/D24959

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-search.svg
  icons/preferences/32/preferences-desktop-search.svg

To: astippich, #vdg, ngraham, trickyricky26, bruns
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D24568: Provide clang-format target with a KDE Frameworks style file

[Dominik Haumann]

dhaumann added a comment.


  You can force the current clang format to keep the multi-line if as follows:
  
if (roles.isEmpty() // comment
|| roles.contains(Notifications::UpdatedRole)
|| roles.contains(Notifications::ExpiredRole)
  
  The comment prevents clang to join the lines. I understand it's not what you 
want, though.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns