D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25390

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

[Nibaldo González]

nibags updated this revision to Diff 69971.
nibags added a comment.


  - Fix format

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25390?vs=69970&id=69971

BRANCH
  verify-katefiletypes

REVISION DETAIL
  https://phabricator.kde.org/D25390

AFFECTED FILES
  src/mode/katemodemanager.cpp
  src/mode/katemodemenu.cpp
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/syntax/katehighlightmenu.cpp

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  verify-katefiletypes

REVISION DETAIL
  https://phabricator.kde.org/D25390

AFFECTED FILES
  src/mode/katemodemanager.cpp
  src/mode/katemodemenu.cpp
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/syntax/katehighlightmenu.cpp

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25389: Verify modes of the session config file

[Nibaldo González]

nibags edited the summary of this revision.
nibags edited the test plan for this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25389

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25389: Verify modes of the session config file

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  verify-session-modes

REVISION DETAIL
  https://phabricator.kde.org/D25389

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 318 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/318/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 19 Nov 2019 04:29:49 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/404)67%
(271/404)56%
(34735/61702)40%
(17598/43568)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9659/10118)47%
(4508/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)60%
(8688/14578)51%
(4514/8817)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4665/8288)43%
(2022/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(679/1208)40%
(383/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(522/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1809/4292)36%
(1312/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 187 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/187/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 19 Nov 2019 04:29:49 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25388: Make constructor explicit and cleanup QWebPluginFactory #include.

[John Hayes]

jhayes created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jhayes requested review of this revision.

REPOSITORY
  R300 KDEWebKit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25388

AFFECTED FILES
  src/kwebpluginfactory.h

To: jhayes
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25371: Remove porting scaffolding, this is entirely on QSslError now

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25371

To: vkrause, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new template for KCMs

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 69942.
tcanabrava added a comment.


  - Handle immutability

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25149?vs=69941&id=69942

BRANCH
  arcpatch-D25149

REVISION DETAIL
  https://phabricator.kde.org/D25149

AFFECTED FILES
  templates/CMakeLists.txt
  templates/kcm-qml/%{APPNAMELC}settings.kcfg
  templates/kcm-qml/%{APPNAMELC}settings.kcfgc
  templates/kcm-qml/CMakeLists.txt
  templates/kcm-qml/Messages.sh
  templates/kcm-qml/README
  templates/kcm-qml/kcm-qml.kdevtemplate
  templates/kcm-qml/kcm.cpp
  templates/kcm-qml/kcm.h
  templates/kcm-qml/kcm_%{APPNAMELC}.desktop
  templates/kcm-qml/package/contents/ui/main.qml
  templates/kcm-qml/package/metadata.desktop

To: tcanabrava, #plasma, #frameworks, mart, ervin
Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, 
kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25149: Add a new template for KCMs

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 69941.
tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  - Adapt to ManagedConfigModule

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25149?vs=69649&id=69941

BRANCH
  arcpatch-D25149

REVISION DETAIL
  https://phabricator.kde.org/D25149

AFFECTED FILES
  templates/CMakeLists.txt
  templates/kcm-qml/%{APPNAMELC}settings.kcfg
  templates/kcm-qml/%{APPNAMELC}settings.kcfgc
  templates/kcm-qml/CMakeLists.txt
  templates/kcm-qml/Messages.sh
  templates/kcm-qml/README
  templates/kcm-qml/kcm-qml.kdevtemplate
  templates/kcm-qml/kcm.cpp
  templates/kcm-qml/kcm.h
  templates/kcm-qml/kcm_%{APPNAMELC}.desktop
  templates/kcm-qml/package/contents/ui/main.qml
  templates/kcm-qml/package/metadata.desktop

To: tcanabrava, #plasma, #frameworks, mart, ervin
Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, 
kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25371: Remove porting scaffolding, this is entirely on QSslError now

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25371

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25371: Remove porting scaffolding, this is entirely on QSslError now

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25371

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25328: Always rehiglhight() after definition was changed

[Méven Car]

meven added a comment.


  In D25328#563637 , @cullmann wrote:
  
  > Hmm, the use case is that it re-highlights if you set an invalid definition?
  
  
  Here it rehighlight if the definition has changed `definition() != def`.
  But since the current definition `m_definition` has initially the value 
`Definition()`, it is the same as the invalid default definition returned by 
`Repository::definitionForFileName` (set in `RepositoryPrivate::load` line 161) 
and does not call `rehighlight`.
  
  > Perhaps one should just trigger rehighlight here just for that case, too.
  
  So the fix does not really depend on the definition being valid or invalid.
  
  Perhaps there is a better way to fix this.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25328

To: meven, kossebau, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

[Nathaniel Graham]

ngraham updated this revision to Diff 69932.
ngraham marked an inline comment as done.
ngraham added a comment.


  Improve config file entry name

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25360?vs=69898&id=69932

BRANCH
  left-click-warps-scrollbar-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25360

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: ngraham, #frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/28/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 13:28:35 +
 Build duration:
1 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: projectroot.autote

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 186 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/186/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 13:10:10 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25223: Avoid side effects during menu initialization

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:3c78453b: Avoid side effects during menu 
initialization (authored by kmaterka).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25223?vs=69634&id=69924

REVISION DETAIL
  https://phabricator.kde.org/D25223

AFFECTED FILES
  src/platformtheme/kdeplatformsystemtrayicon.cpp
  src/platformtheme/kdeplatformsystemtrayicon.h

To: kmaterka, #plasma, #frameworks, broulik
Cc: nicolasfella, davidedmundson, cgiboudeaux, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25355: [Samba] Improve warning message about netbios name

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3874f9f8a4b7: [Samba] Improve warning message about 
netbios name (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25355?vs=69921&id=69923

REVISION DETAIL
  https://phabricator.kde.org/D25355

AFFECTED FILES
  src/core/ksambashare.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25223: Avoid side effects during menu initialization

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25223

To: kmaterka, #plasma, #frameworks, broulik
Cc: nicolasfella, davidedmundson, cgiboudeaux, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25355: [Samba] Improve warning message about netbios name

[Méven Car]

meven updated this revision to Diff 69921.
meven added a comment.


  Improve reliability

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25355?vs=69878&id=69921

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25355

AFFECTED FILES
  src/core/ksambashare.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in sortfiltermodel.h:78
> > presumably for some reason.
> 
> Either because someone was too lazy to use the respective property on the 
> `Repeater` or `ListView` or before `rowCount()` was `Q_INVOKABLE`. Not sure 
> it's upstreamable since it assumes it's a flast list. Maybe something for 
> QAbstract*List*Model rather than QAbstract*Item*Model

rowCount being invokable seems enough in the cases I've found in Plasma, will 
drop this.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Vlad Zahorodnii]

zzag added a comment.


  In D20261#443859 , @broulik wrote:
  
  > This is a bug in Quassel, a violation of the FDO spec, it should have ebeen 
`quassel-tray-inactive` or something
  
  
  See https://github.com/quassel/quassel/pull/515

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma, #vdg
Cc: zzag, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[David Edmundson]

davidedmundson marked an inline comment as done.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[David Edmundson]

davidedmundson updated this revision to Diff 69918.
davidedmundson marked 3 inline comments as done.
davidedmundson added a comment.


  asdf

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25326?vs=69917&id=69918

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25326

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ksortfilterproxymodel_qml.cpp
  autotests/ksortfilterproxymodeltest.qml
  src/qml/CMakeLists.txt
  src/qml/ksortfilterproxymodel.cpp
  src/qml/ksortfilterproxymodel.h
  src/qml/plugin.cpp

To: davidedmundson
Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in sortfiltermodel.h:43
> It's not listed in https://doc.qt.io/qt-5/qtqml-cppintegration-data.html
> 
> We need to test

Bummer. I tried, a JS `RegExp` (both `new RegExp()` and `/literal syntax/`) get 
turned into a `QRegExp`. It does *not* work with `QRegularExpression` :(

There's a `RegularExpressionValidator` which uses `QRegularExpression` but it's 
in Qt 5.14. Maybe they fixed that recently - doesn't really help us here, 
though.

> davidedmundson wrote in sortfiltermodel.h:63
> Did some investigation we have our handling just to emit a signal when the 
> property changes!
> 
> Another good thing to try to upstream.
> 
> Keeping the same name allows us to subtly drop the API in the future and keep 
> clients working.

> Another good thing to try to upstream.

+1 given they're all `QObject`s already anyway

> davidedmundson wrote in sortfiltermodel.h:78
> I think so. We've implemented it in a lot of plasma models, presumably for 
> some reason.
> 
> Would be a good thing to try and upstream though.

> presumably for some reason.

Either because someone was too lazy to use the respective property on the 
`Repeater` or `ListView` or before `rowCount()` was `Q_INVOKABLE`. Not sure 
it's upstreamable since it assumes it's a flast list. Maybe something for 
QAbstract*List*Model rather than QAbstract*Item*Model

> davidedmundson wrote in sortfiltermodel.h:138
> I don't see why we would need a d pointer. We may as well self an allocation.
> 
> > Perhaps rename the header to _p.h then?
> 
> We haven't done that universally in all frameworks, but sure I could.

Was just wondering but if it's only to be used from QML and not exported, 
doesn't need one I suppose.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[David Edmundson]

davidedmundson updated this revision to Diff 69917.
davidedmundson edited the summary of this revision.
davidedmundson added a comment.


  Only some changes done, not all
  Updating now to share added unit test

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25326?vs=69800&id=69917

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25326

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ksortfilterproxymodel_qml.cpp
  autotests/ksortfilterproxymodeltest.qml
  src/qml/CMakeLists.txt
  src/qml/ksortfilterproxymodel.cpp
  src/qml/ksortfilterproxymodel.h
  src/qml/plugin.cpp

To: davidedmundson
Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[David Edmundson]

davidedmundson marked 3 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in sortfiltermodel.cpp:84
> Can we also just have it send `source_row` and `source_parent` since we have 
> proper `QModelIndex` handling now?

We could.

Though means everyone doing a lookup immediately, handling columns and roles 
properly.

More powerful, but slightly more complex for the user

There's also the option of having two proxies with different behaviours?

@mart thoughts?

> broulik wrote in sortfiltermodel.h:43
> Can this be a `QRegularExpression`?
> I would assume a JS `RegExp` object (or regexp literal `/syntax/`) was 
> supported (didn't test)

It's not listed in https://doc.qt.io/qt-5/qtqml-cppintegration-data.html

We need to test

> davidedmundson wrote in sortfiltermodel.h:63
> Or potentially we could just kill our handling of it?

Did some investigation we have our handling just to emit a signal when the 
property changes!

Another good thing to try to upstream.

Keeping the same name allows us to subtly drop the API in the future and keep 
clients working.

> broulik wrote in sortfiltermodel.h:78
> Is this needed?

I think so. We've implemented it in a lot of plasma models, presumably for some 
reason.

Would be a good thing to try and upstream though.

> broulik wrote in sortfiltermodel.h:138
> Does this need a `d` pointer or is it just for use in QML? Perhaps rename the 
> header to `_p.h` then?

I don't see why we would need a d pointer. We may as well self an allocation.

> Perhaps rename the header to _p.h then?

We haven't done that universally in all frameworks, but sure I could.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25364: KNumberModel: gracefully handle a stepSize of 0

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R275:13a039441fdb: KNumberModel: gracefully handle a stepSize 
of 0 (authored by kossebau).

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25364?vs=69909&id=69916

REVISION DETAIL
  https://phabricator.kde.org/D25364

AFFECTED FILES
  src/core/knumbermodel.cpp

To: kossebau, #frameworks, davidedmundson, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> feverfew wrote in krun.cpp:598
> That's within the same loop though?
> 
> I explicitly want to change the QUrl in that list, so that I can simply 
> return the same list without having to do a copy of it all.
> 
> I can't get this to work. I need to change the definition of the struct to be:
> 
> `struct MountRequest {QDBusReply reply; QUrl &url;};`
> 
> This doesn't compile because "is implicitly deleted because the default 
> definition would be ill-formed"...

Can't reproduce with gcc.

  diff --git a/src/widgets/krun.cpp b/src/widgets/krun.cpp
  index c05875f7..2ea79257 100644
  --- a/src/widgets/krun.cpp
  +++ b/src/widgets/krun.cpp
  @@ -576,10 +576,9 @@ static QList resolveURLs(const QList &_urls, 
const KService &_servic
   org::kde::KIOFuse::VFS 
kiofuse_iface(QStringLiteral("org.kde.KIOFuse"),

QStringLiteral("/org/kde/KIOFuse"),
QDBusConnection::sessionBus());
  -struct MountRequest { QDBusPendingReply reply; int 
urlIndex; };
  +struct MountRequest { QDBusPendingReply reply; QUrl &url; };
   QVector requests;
  -for (int i = 0; i < urls.length(); ++i) {
  -const QUrl url = urls[i];
  +for (QUrl &url : urls) {
   if (KIO::DesktopExecParser::isProtocolInSupportedList(url, 
appSupportedProtocols))
   continue;
   if (KProtocolInfo::protocolClass(url.scheme()) == 
QLatin1String(":local")) {
  @@ -588,7 +587,7 @@ static QList resolveURLs(const QList &_urls, 
const KService &_servic
   if (job->exec()) { // ## nasty nested event loop!
   const QUrl localURL = job->mostLocalUrl();
   if (localURL != url) {
  -urls[i] = localURL;
  +url = localURL;
   //qDebug() << "Changed to" << localURL;
   // KIOFuse doesn't work too well with mtp/gdrive.
   // @see https://invent.kde.org/kde/kio-fuse/issues/1 
(GDrive)
  @@ -598,11 +597,11 @@ static QList resolveURLs(const QList 
&_urls, const KService &_servic
   && url.scheme() != QLatin1String("gdrive")) {
   // Can't convert...
   // Lets try a KIOFuse mount instead.
  -requests.push_back({ 
kiofuse_iface.mountUrl(url.toString()), i });
  +requests.push_back({ 
kiofuse_iface.mountUrl(url.toString()), url });
   }
   }
   } else {
  -requests.push_back({ kiofuse_iface.mountUrl(url.toString()), 
i });
  +requests.push_back({ kiofuse_iface.mountUrl(url.toString()), 
url });
   }
   }
   // Doesn't matter that we've blocked here to process the replies.
  @@ -610,7 +609,7 @@ static QList resolveURLs(const QList &_urls, 
const KService &_servic
   for (auto request : requests) {
   request.reply.waitForFinished();
   if (!request.reply.isError()) {
  -urls[request.urlIndex] = 
QUrl::fromLocalFile(request.reply.value());
  +request.url = QUrl::fromLocalFile(request.reply.value());
   }
   }
   }

That said, I forgot about the second loop and I am not too sure that carrying 
the reference across two loops is all that nice to read anyway. Perhaps best 
wait for dfaure on this matter.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.13 - Build # 31 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.13/31/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 18 Nov 2019 09:54:19 +
 Build duration:
6 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 67 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/67/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 18 Nov 2019 09:54:19 +
 Build duration:
2 min 20 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.65.0.xmlcompat_reports/KF5ItemModels_compat_report.htmllogs/KF5ItemModels/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)59%
(45/76)59%
(45/76)73%
(6531/8990)57%
(2928/5098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)99%
(2423/2440)62%
(1057/1701)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1759/2545)54%
(651/1211)src.core81%
(17/21)81%
(17/21)80%
(2329/2916)65%
(1220/1886)src.qml100%
(2/2)100%
(2/2)65%
(20/31)0%
(0/2)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1058)0%
(0/298)

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 44 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/44/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 18 Nov 2019 09:54:19 +
 Build duration:
2 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.65.0.xmlcompat_reports/KF5ItemModels_compat_report.htmllogs/KF5ItemModels/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)59%
(45/76)59%
(45/76)73%
(6531/8986)57%
(2928/5098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)99%
(2423/2440)62%
(1057/1701)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1759/2545)54%
(651/1211)src.core81%
(17/21)81%
(17/21)80%
(2329/2915)65%
(1220/1886)src.qml100%
(2/2)100%
(2/2)65%
(20/31)0%
(0/2)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1055)0%
(0/298)

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/41/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 09:54:19 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)

D25331: Duplicate QML installation for unit tests

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R275:6b05ca4afbda: Duplicate QML installation for unit tests 
(authored by davidedmundson).

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25331?vs=69896&id=69911

REVISION DETAIL
  https://phabricator.kde.org/D25331

AFFECTED FILES
  src/qml/CMakeLists.txt

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25364: KNumberModel: gracefully handle a stepSize of 0

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R275 KItemModels

BRANCH
  knumbermodelhandlestepsizezero

REVISION DETAIL
  https://phabricator.kde.org/D25364

To: kossebau, #frameworks, davidedmundson, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25364: KNumberModel: gracefully handle a stepSize of 0

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, davidedmundson, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  While setting a stepSize of 0 is undefined in the API docs, Qt widgets with
  similar step properties gracefully handle also a value of 0.
  The current Q_ASSERT only catches any 0 value in respective debug builds,
  but would result in crashing applications in normal builds at runtime due to
  the divide-by-zero.

REPOSITORY
  R275 KItemModels

BRANCH
  knumbermodelhandlestepsizezero

REVISION DETAIL
  https://phabricator.kde.org/D25364

AFFECTED FILES
  src/core/knumbermodel.cpp

To: kossebau, #frameworks, davidedmundson, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kstyle.cpp:504
> +KConfigGroup g(KSharedConfig::openConfig(), "KDE");
> +return !g.readEntry("LeftClickNavigatesByPage", true);
> +}

`ScrollBarLeftClick...`?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D25360

To: ngraham, #frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 66 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/66/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 18 Nov 2019 08:59:48 +
 Build duration:
4 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.65.0.xmlcompat_reports/KF5ItemModels_compat_report.htmllogs/KF5ItemModels/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)57%
(43/76)57%
(43/76)72%
(6504/8985)57%
(2922/5098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)99%
(2416/2440)62%
(1051/1701)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1759/2545)54%
(651/1211)src.core81%
(17/21)81%
(17/21)80%
(2329/2916)65%
(1220/1886)src.qml0%
(0/2)0%
(0/2)0%
(0/26)0%
(0/2)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1058)0%
(0/298)

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/43/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 18 Nov 2019 08:59:48 +
 Build duration:
3 min 21 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ItemModels-5.65.0.xmlcompat_reports/KF5ItemModels_compat_report.htmllogs/KF5ItemModels/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)57%
(43/76)57%
(43/76)72%
(6504/8981)57%
(2922/5098)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(14/14)100%
(14/14)99%
(2416/2440)62%
(1051/1701)autotests.proxymodeltestsuite67%
(12/18)67%
(12/18)69%
(1759/2545)54%
(651/1211)src.core81%
(17/21)81%
(17/21)80%
(2329/2915)65%
(1220/1886)src.qml0%
(0/2)0%
(0/2)0%
(0/26)0%
(0/2)tests.proxymodeltestapp0%
(0/21)0%
(0/21)0%
(0/1055)0%
(0/298)

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/40/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 08:59:48 +
 Build duration:
2 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.kconcatenaterows_qml