D25530: Sonnet: Add locales that are missing in QLocale

waqar added a comment. > With no respect for your lack of being subtle I meant no disrespect to anyone. If you felt offended I apologize > we need to maintain this for 20 years in the future, you making a quick hack here doesn't make this any better, the user will still see cv_RU in

D25561: Remove unused signal we can use directly "signal(const QUrl&)

mlaurent updated this revision to Diff 70477. mlaurent added a comment. Deprecated signal with argument REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25561?vs=70406=70477 BRANCH remove_overload_signal (branched from master) REVISION DETAIL

D25561: Remove unused signal we can use directly "signal(const QUrl&)

mlaurent added a comment. I don't prefer a signal with argument or not. Indeed I can adapt kmail for it. So I will change deprecated signal. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D25561 To: mlaurent, dfaure, kossebau Cc: cfeck,

D25545: Rename signal for avoiding overload signal

This revision was automatically updated to reflect the committed changes. Closed by commit R246:f6f6aa244b55: Rename signal for avoiding overload signal (authored by mlaurent). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25545?vs=70410=70476 REVISION

D24884: Undeprecate I18N_NOOP2

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH arcpatch-D24884 REVISION DETAIL https://phabricator.kde.org/D24884 To: dfaure, ilic, aacid, mlaurent Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2,

D25585: Fix i18n syntax to avoid runtime errors

ngraham created this revision. ngraham added reviewers: leinir, Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Using `.arg()` in `i18n()` calls can lead to runtime errors such

D25575: remove unused kgesturemap from kaction

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D25575 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

filipf added a comment. My impression is that the rounding is currently just faked by the shadow. So when the shadow gets lighter, it becomes more obvious that the object itself isn't really rounded. F7787609: image.png REPOSITORY R242 Plasma

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a reviewer: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Currently I have a broken DB, the worst part is that I'm in a 100% CPU loop.

D25015: Update breeze theme shadows

niccolove added a comment. In D25015#568331 , @ngraham wrote: > Actually it looks like that was due to some kind of caching issue. It's gone now. LGTM! > > Everyone else good with this? Actually, it seems to me that borders are not

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 27 Nov 2019 20:51:45 + Build duration: 5 min 52 sec and counting JUnit Tests Name:

D25576: [server] Do not own dmabuf implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R127:005a8ede4bb7: [server] Do not own dmabuf implementation (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25576?vs=70457=70463 REVISION

D25576: [server] Do not own dmabuf implementation

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH dmabuf-impl-ownership REVISION DETAIL https://phabricator.kde.org/D25576 To: romangg, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25576: [server] Do not own dmabuf implementation

romangg added a dependent revision: D25577: Destroy dmabuf implementation on EGL backend going down. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D25576 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25576: [server] Do not own dmabuf implementation

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The dmabuf implementation should be managed by the compositor and not by the

D25575: remove unused kgesturemap from kaction

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Compiles Checked kaction_p.h wasn't installed REPOSITORY R239 KDELibs4Support BRANCH master REVISION

D25552: Deprecate top-level UserIcon method, no longer used

This revision was automatically updated to reflect the committed changes. Closed by commit R302:312f27f31199: Deprecate top-level UserIcon method, no longer used (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25552?vs=70364=70450

D25530: Sonnet: Add locales that are missing in QLocale

aacid added a comment. > the end user doesn't give a crap whether it was a problem in QLocale, or whether it needed to be done in many places in KDE code and that nobody did it. The end user opens the menu, sees 'American English (United States)' and below that 'cv_RU' and he is just going

D25546: Deprecate KRecursiveFilterProxyModel

dfaure accepted this revision. REPOSITORY R275 KItemModels BRANCH deprecate (branched from master) REVISION DETAIL https://phabricator.kde.org/D25546 To: davidre, kossebau, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, davidre, GB_2, michaelh, ahmadsamir, ngraham, bruns,

D25561: Remove unused signal we can use directly "signal(const QUrl&)

dfaure added a comment. Yeah, but these days with lambdas, we can find out who emitted the signal, without the need for an identifier as signal argument... connect(urlLabel, qOverload<>(::leftClickedUrl), this, [this, urlLabel]() { selectFolder(urlLabel->url()); } ); should work

D25533: Deprecate KFileWidget::toolBar

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. 5.65 isn't released yet, you can use 5.65 as deprecation version here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25533 To: nicolasfella, #frameworks,

D25572: [KFileWidget] Allow double quotes in filenames

meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Use " " to detect if there is multiple files and split filenames allowing them

D25545: Rename signal for avoiding overload signal

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH deprecated_overload_signal (branched from master) REVISION DETAIL https://phabricator.kde.org/D25545 To: mlaurent, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25311: Add KColumnHeadersProxyModel

ahiemstra marked an inline comment as done. ahiemstra added inline comments. INLINE COMMENTS > kossebau wrote in kcolumnheadersmodel.h:57 > For consistency I would prefer having a full Q_SIGNALS section: > > Q_SIGNALS: > void sourceModelChanged(); > > That matches the usual pattern and

D25311: Add KColumnHeadersProxyModel

ahiemstra updated this revision to Diff 70437. ahiemstra added a comment. - Use separate Q_SIGNALS for consistency REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=70405=70437 BRANCH columnheadersmodel REVISION DETAIL

D25564: Fix conflicts of shortcuts

This revision was automatically updated to reflect the committed changes. Closed by commit R480:4db2d47acddb: Fix conflicts of shortcuts (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R480 Kipi Plugins CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25564?vs=70409=70435

D25564: Fix conflicts of shortcuts

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R480 Kipi Plugins BRANCH master REVISION DETAIL https://phabricator.kde.org/D25564 To: guoyunhe, #frameworks, apol

Re: KInit - Current state and benchmarks

On Tue, Nov 26, 2019 at 8:57 AM Milian Wolff wrote: > > On Montag, 25. November 2019 22:57:11 CET Albert Astals Cid wrote: > > El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va > escriure: > > > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote: > > > > El

D25562: Add some friendly "report bugs here" links

ngraham added a comment. Instead of using `.arg()`, just put the variable inline, inside the i18n call. This is less fragile and less likely to produce visible i18n errors in the UI. Also, screenshots in the Test Plan section are always appreciated for user-visible changes. :)

D25015: Update breeze theme shadows

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Actually it looks like that was due to some kind of caching issue. It's gone now. LGTM! Everyone else good with this? REPOSITORY R242 Plasma Framework (Library) BRANCH

D24657: Add support for _GTK_FRAME_EXTENTS

zzag closed this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24657 To: zzag, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25441: Send along the config name with requests

leinir updated this revision to Diff 70427. leinir added a comment. (just a little merge, for my own sanity... but also ping?) - Merge branch 'master' into send-config-name-with-requests REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 27 Nov 2019 12:55:38 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 207 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/207/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 27 Nov 2019 12:32:15 + Build duration: 33 min and counting JUnit Tests Name: projectroot

D25546: Deprecate KRecursiveFilterProxyModel

davidre updated this revision to Diff 70426. davidre marked 4 inline comments as done. davidre added a comment. address comments REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25546?vs=70348=70426 BRANCH deprecate (branched from master) REVISION

D23745: [server] Make double-buffered properties in xdg-shell double-buffered

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:d0b3eab864a2: [server] Make double-buffered properties in xdg-shell double-buffered (authored by zzag). CHANGED PRIOR

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

This revision was automatically updated to reflect the committed changes. ahmadsamir marked an inline comment as done. Closed by commit R241:54ccb1ac4883: More fixes to compile without implicit conversion from ASCII/ByteArray (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 27 Nov 2019 12:11:25 + Build duration: 9 min 29 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 27 Nov 2019 12:12:29 + Build duration: 8 min 50 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 72 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/72/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Nov 2019 12:10:49 + Build duration: 4 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 44 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/44/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 27 Nov 2019 12:10:49 + Build duration: 5 min 13 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/39/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 27 Nov 2019 12:10:50 + Build duration: 3 min 27 sec and counting JUnit Tests Name:

D25563: Remove -std=c++0x flag and duplicated -Wall flag

This revision was automatically updated to reflect the committed changes. Closed by commit R290:d6a6c210b0d1: Remove -std=c++0x flag and duplicated -Wall flag (authored by kossebau). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25563?vs=70408=70412

D25545: Rename signal for avoiding overload signal

mlaurent updated this revision to Diff 70410. mlaurent added a comment. Fix some errors REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25545?vs=70394=70410 BRANCH deprecated_overload_signal (branched from master) REVISION DETAIL

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D24349 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24349 To: ahmadsamir, dfaure, #frameworks Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2,

D25564: Fix conflicts of shortcuts

guoyunhe added a reviewer: Frameworks. REPOSITORY R480 Kipi Plugins REVISION DETAIL https://phabricator.kde.org/D25564 To: guoyunhe, #frameworks

D25563: Remove -std=c++0x flag and duplicated -Wall flag

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH removeoldstd REVISION DETAIL https://phabricator.kde.org/D25563 To: kossebau, #frameworks, apol, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25563: Remove -std=c++0x flag and duplicated -Wall flag

kossebau created this revision. kossebau added reviewers: Frameworks, apol, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY -Wall is set by KDECompilerSettings (via

D25311: Add KColumnHeadersProxyModel

kossebau added a comment. Two more nitpicks while this has my attention (sadly no time/idea to comment on the general usefulness) :) INLINE COMMENTS > kcolumnheadersmodel.h:57 > +void setSourceModel(QAbstractItemModel *newSourceModel); > +Q_SIGNAL void sourceModelChanged(); > + For

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir updated this revision to Diff 70407. ahmadsamir added a comment. Per dfaure's recommendation, change createSystemBookmark 2nd and 3rd params to take a const char * (since this is the translation context which will be dropped) and a QByteArray, respectively. REPOSITORY R241 KIO

D25561: Remove unused signal we can use directly "signal(const QUrl&)

mlaurent marked an inline comment as done. mlaurent added a comment. There is not autotests/test which use kurllabel. we have some apps as connect(urlLabel, qOverload(::leftClickedUrl), this, ::selectFolder); in kmail. REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D25561: Remove unused signal we can use directly "signal(const QUrl&)

mlaurent updated this revision to Diff 70406. mlaurent added a comment. Fix comment REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25561?vs=70395=70406 BRANCH remove_overload_signal (branched from master) REVISION DETAIL

D25311: Add KColumnHeadersProxyModel

ahiemstra updated this revision to Diff 70405. ahiemstra added a comment. - Do not use nested Private class REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=70359=70405 BRANCH columnheadersmodel REVISION DETAIL

D25552: Deprecate top-level UserIcon method, no longer used

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D25552 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25562: Add some friendly "report bugs here" links

leinir added reviewers: Frameworks, KNewStuff, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25562 To: leinir, #frameworks, #knewstuff, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25562: Add some friendly "report bugs here" links

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Add a link to the FeedbackOverlay's "report-a-bug-please" bit Also add the link to EntryDetails (and remove some

D25545: Rename signal for avoiding overload signal

kossebau added inline comments. INLINE COMMENTS > Doxyfile.local:4 > +# define so that deprecated API is not skipped > +PREDEFINED += \ > +"KCOREADDONS_ENABLE_DEPRECATED_SINCE(x, y)=1" \ The predefined macros we want to tell doxygen about in the case of kapidox (being run in a non-build

D25561: Remove unused signal we can use directly "signal(const QUrl&)

kossebau added a comment. Looks correct from deprecation-markup POV. Did you do a test build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.65.0, to check if any tests or examples still use the deprecated signals and need some additions of #if KWIDGETSADDONS_ENABLE_DEPRECATED_SINCE(5, 65) in

D25561: Remove unused signal we can use directly "signal(const QUrl&)

cfeck added inline comments. INLINE COMMENTS > kurllabel.h:281 > * Emitted when the mouse has passed over the label. > + * @deprecated Since 5.65, use leftUrl(const QString ); > */ Wrong comment? REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D24657: Add support for _GTK_FRAME_EXTENTS

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH gtk-frame-extents REVISION DETAIL https://phabricator.kde.org/D24657 To: zzag, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 70401. meven added a comment. Let windows code path not being changed, add a todo for windows support REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=70102=70401 BRANCH arcpatch-D25117 REVISION DETAIL

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

This revision was automatically updated to reflect the committed changes. Closed by commit R39:cee9d9642735: KateModeManager::updateFileType(): validate modes and reload menu of the status… (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 151 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/151/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 27 Nov 2019 08:58:59 + Build duration: 7 min 33 sec and counting JUnit Tests Name:

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think that is nicer, not yet-an-other global hash ;=) Thanks! REPOSITORY R39 KTextEditor BRANCH verify-katefiletypes REVISION DETAIL https://phabricator.kde.org/D25390

D25530: Sonnet: Add locales that are missing in QLocale

waqar updated this revision to Diff 70399. waqar added a comment. Add test for iso code to language names REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25530?vs=70310=70399 BRANCH add-missing-locales (branched from master) REVISION DETAIL

D25515: Only extract lyrics when the plain text flag is set

astippich added a comment. For baloo-widgets, the display of the lyrics tag is disabled anyways. Displaying a large chunk of text does not really look good in the information panel... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25515 To: astippich,

D25516: Remove unrequired private declarations for taglibextractor

astippich updated this revision to Diff 70398. astippich added a comment. - put all helper functions into anonymous namespace REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25516?vs=70283=70398 BRANCH cleanupTagLib REVISION DETAIL

D25516: Remove unrequired private declarations for taglibextractor

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:105 > This puts `readGenericProperties(...)` with external linkage in the global > namespace. > > Put the private helpers in an anonymous namespace (and also include > `extractAudioProperties(...)` in it).

D25517: Add an option to extract binary data and add front cover property

astippich added inline comments. INLINE COMMENTS > bruns wrote in extractionresult.h:61 > Binary is **how**, not **what**. Do you have a suggestion for a better name? I tried to be as generic as possible. It could be named more specifically ExtractImages, since this is what it will be