D25599: Fix plugin-metadata translations on windows

[Kåre Särs]

sars added reviewers: aacid, vonreth.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, 
cullmann, kfunk

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Nathaniel Graham]

ngraham added a comment.


  I just found that Totem has a "Show Containing Folder" feature. If I use it, 
it shows me that the video file is in fact being opened from the FUSE mount 
path! So that's good. But it still insists on downloading the whole thing 
locally before it starts to play it. When Totem opens a video file from a 
Nautilus/GVfs-created FUSE path, it doesn't do this and starts playing the file 
instantly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Nathaniel Graham]

ngraham added a comment.


  In D23384#569929 , @feverfew wrote:
  
  > This isn't reaching KIOFuse at all. I believe this is related to this bug 
and that you've also blogged about:
  >  https://bugs.kde.org/show_bug.cgi?id=330192
  >  https://pointieststick.com/2018/01/17/videos-on-samba-shares/
  >
  > This can be solved in this patch (and I did, although I removed it at 
Harald's request). I think I'll move it back in, and will leave it if it does 
solve this issue for you.
  
  
  Great! Once it's back in, I'll re-test that.
  
  > You must be doing something wrong. FUSE provides output of all calls that 
it receives (and how kio-fuse responds). Let me write the instructions more 
verbosely for CLI to make sure no steps are missed:
  >  `$ killall kio-fuse`
  >  `$ export QT_LOGGING_RULES="*.debug=true"`
  >  `$ kio-fuse $myFavLocation -d &> ~/kio-fuse-debug.txt` (I recommend 
`$myFabLocation` isn't empty if you haven't installed the 
`kio-fuse-tmpfiles.conf` exclusion file at the system level.)
  > 
  > Then open the file in the media player. Once your done simply attach 
`~/kio-fuse-debug.txt` here.
  >  It's really important for us to know what kind of read requests are being 
called to help us diagnose the issue.
  
  I think I found part of the problem. When I follow these instructions, the 
log file has only a single line:
  
kio-fuse: command not found
  
  This is because the path it is installed to (`~/kde/usr/lib64/libexec/`) is 
not in `$PATH`. When I add that location to `$PATH` and try again, the log file 
contains the following:
  
FUSE library version: 3.8.0
unique: 2, opcode: INIT (26), nodeid: 0, insize: 56, pid: 0
INIT: 7.31
flags=0x03fb
max_readahead=0x0002
   INIT: 7.31
   flags=0x00409021
   max_readahead=0x0002
   max_write=0x0010
   max_background=0
   congestion_threshold=0
   time_gran=10
   unique: 2, success, outsize: 80
unique: 4, opcode: ACCESS (34), nodeid: 1, insize: 48, pid: 7327
   unique: 4, error: -38 (Function not implemented), outsize: 16
unique: 6, opcode: LOOKUP (1), nodeid: 1, insize: 47, pid: 7327
   unique: 6, error: -2 (No such file or directory), outsize: 16
unique: 8, opcode: LOOKUP (1), nodeid: 1, insize: 52, pid: 7327
   unique: 8, error: -2 (No such file or directory), outsize: 16
unique: 10, opcode: LOOKUP (1), nodeid: 1, insize: 44, pid: 10077
   unique: 10, success, outsize: 144
unique: 12, opcode: LOOKUP (1), nodeid: 3, insize: 62, pid: 10077
   unique: 12, success, outsize: 144
unique: 14, opcode: LOOKUP (1), nodeid: 4, insize: 46, pid: 10077
   unique: 14, success, outsize: 144
unique: 16, opcode: LOOKUP (1), nodeid: 5, insize: 47, pid: 10077
   unique: 16, success, outsize: 144
unique: 18, opcode: LOOKUP (1), nodeid: 6, insize: 48, pid: 10077
   unique: 18, success, outsize: 144
unique: 20, opcode: LOOKUP (1), nodeid: 7, insize: 62, pid: 10077
   unique: 20, success, outsize: 144
unique: 22, opcode: OPEN (14), nodeid: 8, insize: 48, pid: 10077
   unique: 22, success, outsize: 32
unique: 24, opcode: FLUSH (25), nodeid: 8, insize: 64, pid: 10077
   unique: 24, success, outsize: 16
unique: 26, opcode: RELEASE (18), nodeid: 8, insize: 64, pid: 0
   unique: 26, success, outsize: 16
unique: 28, opcode: OPEN (14), nodeid: 8, insize: 48, pid: 10077
   unique: 28, success, outsize: 32
unique: 30, opcode: FLUSH (25), nodeid: 8, insize: 64, pid: 10077
   unique: 30, success, outsize: 16
unique: 32, opcode: RELEASE (18), nodeid: 8, insize: 64, pid: 0
   unique: 32, success, outsize: 16
unique: 34, opcode: OPEN (14), nodeid: 8, insize: 48, pid: 10077
   unique: 34, success, outsize: 32
unique: 36, opcode: GETATTR (3), nodeid: 1, insize: 56, pid: 10077
   unique: 36, success, outsize: 120
unique: 38, opcode: GETATTR (3), nodeid: 1, insize: 56, pid: 10084
   unique: 38, success, outsize: 120
unique: 40, opcode: READ (15), nodeid: 8, insize: 80, pid: 10088
   unique: 40, success, outsize: 16400
unique: 42, opcode: READ (15), nodeid: 8, insize: 80, pid: 10091
unique: 44, opcode: LOOKUP (1), nodeid: 1, insize: 44, pid: 31993
   unique: 44, success, outsize: 144
unique: 46, opcode: LOOKUP (1), nodeid: 3, insize: 62, pid: 31993
   unique: 46, success, outsize: 144
unique: 48, opcode: LOOKUP (1), nodeid: 4, insize: 46, pid: 31993
   unique: 48, success, outsize: 144
unique: 50, opcode: LOOKUP (1), nodeid: 5, insize: 47, pid: 31993
   unique: 50, success, outsize: 144
unique: 52, opcode: LOOKUP (1), nodeid: 6, insize: 48, pid: 31993
   unique: 52, success, outsize: 144
unique: 54, opcode: LOOKUP (1), nodeid: 7, insize: 62, pid: 31993
   unique: 54, success, outsize: 144
unique: 56, opcode: GETATTR (3), nodeid: 1, insize: 56, pid: 31993
   

D25533: Deprecate KFileWidget::toolBar

[David Faure]

dfaure added a comment.


  I started a kdesrc-build with the method removed, and found that 
KFileDialog::toolBar (in kdelibs4support) uses it, so it needs a matching #if 
in case EXCLUDE_DEPRECATED_BEFORE_AND_AT.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25533

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

[David Faure]

On samedi 30 novembre 2019 19:43:16 CET Ben Cooksley wrote:
> For Windows, CMake will need to find Perl itself and invoke that with the
> script in question as a parameter (which is a solution that will work on
> all three platforms)

This seems to be already done, in "if (WIN32)" specifically.

So I think all we need is: https://phabricator.kde.org/D25643

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Alexander Saoutkin]

feverfew added a comment.


  In D23384#569926 , @ngraham wrote:
  
  > In D23384#569645 , @fvogt wrote:
  >
  > > **Issue #1:**
  > >
  > > That happens because the .desktop file sets 
`X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb`:
  > >  
https://code.videolan.org/videolan/vlc/blob/master/share/vlc.desktop.in#L124
  >
  >
  > I'm not sure about that. If I remove that line from VLC's installed desktop 
file, the problem still happens. And SMPlayer exhibits the same problem yet its 
desktop file doesn't define `X-KDE-Protocols` at all: 
https://sourceforge.net/p/smplayer/code/HEAD/tree/smplayer/trunk/smplayer.desktop
  
  
  This isn't reaching KIOFuse at all. I believe this is related to this bug and 
that you've also blogged about:
  https://bugs.kde.org/show_bug.cgi?id=330192
  https://pointieststick.com/2018/01/17/videos-on-samba-shares/
  
  This can be solved in this patch (and I did, although I removed it at 
Harald's request). I think I'll move it back in, and will leave it if it does 
solve this issue for you.
  
  >> **Issue #2:**
  >> 
  >> The only explanation I have for that is that totem for some reason starts 
reading the file from the end.
  >>  If you start `kio-fuse -d` manually (kill the other kio-fuse process 
first) and then use totem again, what's the debug output
  > 
  > There is no debug output, and the whole file is downloaded locally as with 
the other apps. It seems like Totem is not getting the FUSE mount path; it gets 
an `smb://` URL and it or KIO downloads the file normally. Again, this happens 
even if I open the file from the FUSE mount path itself.
  > 
  > I can confirm that the FUSE path handoff is working properly. For example 
if I open `smb://gaston@living-room-pc/Users/Gaston/Desktop/Shep Face Code.txt` 
in Gedit, Gedit displays the file's path as follows: F7791491: 
Screenshot_20191130_133857.png 
  
  You must be doing something wrong. FUSE provides output of all calls that it 
receives (and how kio-fuse responds). Let me write the instructions more 
verbosely for CLI to make sure no steps are missed:
  `$ killall kio-fuse`
  `$ export QT_LOGGING_RULES="*.debug=true"
  `$ kio-fuse $myFavLocation -d &> ~/kio-fuse-debug.txt` (I recommend 
`$myFabLocation` isn't empty if you haven't installed the 
`kio-fuse-tmpfiles.conf` exclusion file at the system level.)
  
  Then open the file in the media player. Once your done simply attach 
`~/kio-fuse-debug.txt` here.
  It's really important for us to know what kind of read requests are being 
called to help us diagnose the issue.
  
  >> **Issue #3:**
  >> 
  >> Everything is in a separate process and async already. When/how does it 
happen?
  > 
  > When I open a large video file from the hidden mount path in any of the 
media player apps. KIO (or something) downloads the entire file, during which 
time Dolphin freezes. The moment the network activity ends because the file is 
finished downloading, Dolphin becomes responsive again. It's 100% reproducible 
for me.
  
  I'm a bit confused. Which one of the three are you doing:
  
  1. Opening a KIO Url via Dolphin.
  2. Opening a KIOFuse mount local URL via Dolphin.
  3. Opening a KIOFuse URL via the media players file picker.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Nathaniel Graham]

ngraham added a comment.


  In D23384#569645 , @fvogt wrote:
  
  > **Issue #1:**
  >
  > That happens because the .desktop file sets 
`X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb`:
  >  
https://code.videolan.org/videolan/vlc/blob/master/share/vlc.desktop.in#L124
  
  
  I'm not sure about that. If I remove that line from VLC's installed desktop 
file, the problem still happens. And SMPlayer exhibits the same problem yet its 
desktop file doesn't define `X-KDE-Protocols` at all: 
https://sourceforge.net/p/smplayer/code/HEAD/tree/smplayer/trunk/smplayer.desktop
  
  > **Issue #2:**
  > 
  > The only explanation I have for that is that totem for some reason starts 
reading the file from the end.
  >  If you start `kio-fuse -d` manually (kill the other kio-fuse process 
first) and then use totem again, what's the debug output
  
  There is no debug output, and the whole file is downloaded locally as with 
the other apps. It seems like Totem is not getting the FUSE mount path; it gets 
an `smb://` URL and it or KIO downloads the file normally. Again, this happens 
even if I open the file from the FUSE mount path itself.
  
  I can confirm that the FUSE path handoff is working properly. For example if 
I open `smb://gaston@living-room-pc/Users/Gaston/Desktop/Shep Face Code.txt` in 
Gedit, Gedit displays the file's path as follows: F7791491: 
Screenshot_20191130_133857.png 
  
  > **Issue #3:**
  > 
  > Everything is in a separate process and async already. When/how does it 
happen?
  
  When I open a large video file from the hidden mount path in any of the media 
player apps. KIO (or something) downloads the entire file, during which time 
Dolphin freezes. The moment the network activity ends because the file is 
finished downloading, Dolphin becomes responsive again. It's 100% reproducible 
for me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D17595: Upstream Dolphin's file rename dialog

[Lydia Pintscher]

lydia added a comment.


  For posterity's sake:
  
  I confirm that we have confirmation to the board list from (hope I didn't 
overlook anyone):
  
  - Emmanuel Pescosta
  - Roman Inflianskas
  - Alexander Richardson
  - David Faure
  - Matthias Fuchs
  - Artur Puzio
  - Kevin Funk
  - Aldo Mateli
  - Kevin Ottens
  - Chinmoy Ranjan
  - Elvis Angelaccio
  - Laurent Montel
  - Jeff Mitchell
  
  And that I have confirmation from Peter Penz' wife via Facebook that he is 
fine with it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, 
dhaumann, pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D25638: autotests: Find perl executable on all platforms

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:93
> -  set(_runner ${CMAKE_CURRENT_SOURCE_DIR}/runsingletestcase.pl)
> -  if(WIN32)
> -set(_runner ${PERL_EXECUTABLE} ${_runner})

maybe it would make sense to check for BSD instead?
I don't know much about BSD, but I'd expect the shebang to work there as well.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D25638

To: aspotashev, #frameworks
Cc: apol, #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, GB_2, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D25620: Register ActionType enum with metaobject system

[Jonah Brüchert]

jbbgameich added inline comments.

INLINE COMMENTS

> apol wrote in personactionsmodel_p.h:24
> Why do we need the include?

The enum ist defined in that header.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D25620

To: jbbgameich, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25638: autotests: Find perl executable on all platforms

[Alexander Potashev]

aspotashev added a reviewer: Frameworks.
aspotashev added a project: Frameworks.
aspotashev added a subscriber: Frameworks.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D25638

To: aspotashev, #frameworks
Cc: #frameworks, kde-pim, bcooksley, LeGast00n, fbampaloukas, GB_2, dcaliste, 
michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, 
knauss, dvratil

Re: KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

[Ben Cooksley]

On Sun, Dec 1, 2019 at 7:34 AM Alexander Potashev 
wrote:

> Hi Ben,
>

Hi Alexander,


>
> KCalendarCore's unit tests are failing all the time on FreeBSD CI. Could
> you please check if perl interpreter needs to be installed?
>

Perl is definitely installed, however FreeBSD is a bit different to Linux
and only installs essential software to /usr.
The rest, including Perl, all go to /usr/local/

This means the following shebang at the top of each of those scripts won't
work:
#!/usr/bin/perl

The easy fix for FreeBSD would be to change that to the below, however it
will still fail on Windows:
#!/usr/bin/env perl

For Windows, CMake will need to find Perl itself and invoke that with the
script in question as a parameter (which is a solution that will work on
all three platforms)

Cheers,
Ben


>
> ср, 20 нояб. 2019 г. в 20:58, CI System :
>
>> *BUILD UNSTABLE*
>> Build URL
>> https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/29/
>> Project: kf5-qt5 FreeBSDQt5.13
>> Date of build: Wed, 20 Nov 2019 17:11:49 +
>> Build duration: 46 min and counting
>> * JUnit Tests *
>> Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0
>> test(s), Total: 492 test(s)
>>
>>
>> * - Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.ics*
>>
>>
>> * - Failed:
>> projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.ics*
>>
>>
>> * - Failed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.ics*
>>
>>
>> * - Failed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.ics*
>>
>>
>> * - Failed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.ics*
>>
>>
>> * - Failed: projectroot.autotests.Compat_libical3_MSExchange.ics*
>>
>>
>> * - Failed: projectroot.autotests.Compat_libical3_Mozilla_1.0.ics*
>>
>>
>> * - Failed: projectroot.autotests.Compat_libical3_Todos.ics*
>>
>>
>> * - Failed: projectroot.autotests.Compat_libical3_eGroupware.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily1.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily10.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily11.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily1a.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily2.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily3.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily4.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily5.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily6.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily7.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily8.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_ConnectDaily9.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase01.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase02.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase03.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase04.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase05.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase06.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase07.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase08.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase09.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase10.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test01.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test02.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test03.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test04.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test05.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test06.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test07.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test08.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test09.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test10.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test11.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test12.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test13.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase01.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase02.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase03.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase04.ics*
>>
>>
>> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase05.ics*
>>
>>
>> * - Failed: 

Re: KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

[Alexander Potashev]

Hi Ben,

KCalendarCore's unit tests are failing all the time on FreeBSD CI. Could
you please check if perl interpreter needs to be installed?

ср, 20 нояб. 2019 г. в 20:58, CI System :

> *BUILD UNSTABLE*
> Build URL
> https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/29/
> Project: kf5-qt5 FreeBSDQt5.13
> Date of build: Wed, 20 Nov 2019 17:11:49 +
> Build duration: 46 min and counting
> * JUnit Tests *
> Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0
> test(s), Total: 492 test(s)
>
>
> * - Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.ics*
>
>
> * - Failed:
> projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.ics*
>
>
> * - Failed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.ics*
>
>
> * - Failed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.ics*
>
>
> * - Failed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.ics*
>
>
> * - Failed: projectroot.autotests.Compat_libical3_MSExchange.ics*
>
>
> * - Failed: projectroot.autotests.Compat_libical3_Mozilla_1.0.ics*
>
>
> * - Failed: projectroot.autotests.Compat_libical3_Todos.ics*
>
>
> * - Failed: projectroot.autotests.Compat_libical3_eGroupware.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily1.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily10.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily11.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily1a.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily2.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily3.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily4.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily5.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily6.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily7.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily8.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_ConnectDaily9.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase01.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase02.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase03.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase04.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase05.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase06.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase07.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase08.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase09.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KAlarm_TestCase10.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test01.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test02.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test03.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test04.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test05.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test06.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test07.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test08.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test09.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test10.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test11.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test12.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_KOrganizer_Test13.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase01.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase02.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase03.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase04.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase05.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase06.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase07.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase08.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase09.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase10.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase11.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase12.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase15.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase16.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase17.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase18.ics*
>
>
> * - Failed: projectroot.autotests.RecurNext_LibICal_TestCase19.ics*
>
>

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

[Ahmad Samir]

ahmadsamir added a comment.


  Thank you.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D25631

To: ahmadsamir, #ark, elvisangelaccio, apol
Cc: apol, kde-frameworks-devel, kde-utils-devel, fbampaloukas, tctara

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R36:aee422b0b2c4: Replace KRecursiveFilterProxyModel with 
QSortFilterProxyModel (authored by ahmadsamir).

REPOSITORY
  R36 Ark

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25631?vs=70624=70631

REVISION DETAIL
  https://phabricator.kde.org/D25631

AFFECTED FILES
  CMakeLists.txt
  part/archivesortfiltermodel.cpp
  part/archivesortfiltermodel.h

To: ahmadsamir, #ark, elvisangelaccio, apol
Cc: apol, kde-frameworks-devel, kde-utils-devel, fbampaloukas, tctara

D25511: Drop unused broken KGesture support

[David Edmundson]

davidedmundson added a comment.


  kdelibs4support usage has now been destroyed

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25511

To: davidedmundson
Cc: apol, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R36 Ark

BRANCH
  l-qsortproxy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25631

To: ahmadsamir, #ark, elvisangelaccio, apol
Cc: apol, kde-frameworks-devel, kde-utils-devel, fbampaloukas, tctara

D25629: Port away from KTextWidgets

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R263 KXmlGui

BRANCH
  tw

REVISION DETAIL
  https://phabricator.kde.org/D25629

To: nicolasfella, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

[Aleix Pol Gonzalez]

apol added a comment.


  the Q_ENUM looks good.

INLINE COMMENTS

> personactionsmodel_p.h:24
>  
> +#include "widgets/actions.h"
> +

Why do we need the include?

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D25620

To: jbbgameich, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25632: Fix module imports with Python3

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  The broken module import was covered by the missleading warning
  "WARNING Missing Graphviz dependency: diagrams will not be generated."

TEST PLAN
  Installed and run `kapidox_generate ../kunitconversion/`

REPOSITORY
  R264 KApiDox

BRANCH
  bugfix/graphvizImportPython3

REVISION DETAIL
  https://phabricator.kde.org/D25632

AFFECTED FILES
  src/kapidox/depdiagram/__init__.py
  src/kapidox/depdiagram/frameworkdb.py

To: cordlandwehr
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D25631: Replace KRecursiveFilterProxyModel with QSortFilterProxyModel

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Ark, elvisangelaccio.
Herald added a project: Ark.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  KRecursiveFilterProxyModel was only needed to have recursive filtering, which
  became available upstream since Qt 5.10.  Also increate min. required Qt 
version
  to 5.10.

TEST PLAN
  The code builds, and recursive filtering still works

REPOSITORY
  R36 Ark

BRANCH
  l-qsortproxy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25631

AFFECTED FILES
  CMakeLists.txt
  part/archivesortfiltermodel.cpp
  part/archivesortfiltermodel.h

To: ahmadsamir, #ark, elvisangelaccio
Cc: kde-frameworks-devel, kde-utils-devel, fbampaloukas, tctara

D25630: Port to json metadata

[Alexandr Akulich]

akulichalexandr added a comment.


  Hi!
  Thank you for taking this up.
  Would you mind to use the same approach as in plasma-workspace? In case of 
your changes we'll lose the translations, but with desktop_to_json we won't 
have such a problem.
  
  https://phabricator.kde.org/R871:498cd08a1956d557478b119aeed17fbfcfbd9b56

REPOSITORY
  R150 KDE Telepathy KDE Daemon Module

REVISION DETAIL
  https://phabricator.kde.org/D25630

To: nicolasfella, #frameworks, #kde_telepathy
Cc: akulichalexandr, ltoscano

D25630: Port to json metadata

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> ktp_integration_module.json:3
> +"KPlugin": {
> +"Description": "Module providing deeper integration of Instant 
> Messaging with KDE.",
> +"Name": "Telepathy Integration Module",

I can't comment on the rest of the reivew, but as you are changing this string, 
I think it would be worth to change the "with KDE" part (it comes from the old 
definition of KDE). Maybe the entire sentence needs to be re-though, I don't 
have a clear alternative right now.

REPOSITORY
  R150 KDE Telepathy KDE Daemon Module

REVISION DETAIL
  https://phabricator.kde.org/D25630

To: nicolasfella, #frameworks, #kde_telepathy
Cc: ltoscano

D25630: Port to json metadata

[Nicolas Fella]

nicolasfella added a task: T11919: Port KDED modules from .desktop files to 
JSON metadata.

REPOSITORY
  R150 KDE Telepathy KDE Daemon Module

REVISION DETAIL
  https://phabricator.kde.org/D25630

To: nicolasfella, #frameworks

D25630: Port to json metadata

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
nicolasfella requested review of this revision.

REPOSITORY
  R150 KDE Telepathy KDE Daemon Module

BRANCH
  json

REVISION DETAIL
  https://phabricator.kde.org/D25630

AFFECTED FILES
  CMakeLists.txt
  ktp_integration_module.desktop
  ktp_integration_module.json
  telepathy-module.cpp

To: nicolasfella, #frameworks

D25630: Port to json metadata

[Nicolas Fella]

nicolasfella added a reviewer: KDE Telepathy.

REPOSITORY
  R150 KDE Telepathy KDE Daemon Module

REVISION DETAIL
  https://phabricator.kde.org/D25630

To: nicolasfella, #frameworks, #kde_telepathy

D25533: Deprecate KFileWidget::toolBar

[Nicolas Fella]

nicolasfella updated this revision to Diff 70622.
nicolasfella added a comment.


  - Adjust version

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25533?vs=70317=70622

BRANCH
  ktoolbar

REVISION DETAIL
  https://phabricator.kde.org/D25533

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilewidget.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25629: Port away from KTextWidgets

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It is only used for the bugreport dialog for non-KDE apps. By replacing 
KTextEdit with QTextEdit we can get rid of a rather large dependency with 
minimal impact.
  
  The only complication is that the krichtexteditor test uses it. For more 
context see T12195 .
  
  To work around this we only look for KTextWidgets if actually building the 
tests and only include the relevant test if ktextwidgets is found

TEST PLAN
  builds

REPOSITORY
  R263 KXmlGui

BRANCH
  tw

REVISION DETAIL
  https://phabricator.kde.org/D25629

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kbugreport.cpp
  tests/CMakeLists.txt

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/76/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 30 Nov 2019 14:09:04 +
 Build duration:
3 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/42/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 30 Nov 2019 14:09:04 +
 Build duration:
3 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D25626: Fix EcmGenerateExportHeader tests on Windows

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:bfdcec82d926: Fix EcmGenerateExportHeader tests on 
Windows (authored by davidre).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25626?vs=70610=70615

REVISION DETAIL
  https://phabricator.kde.org/D25626

AFFECTED FILES
  
tests/ECMGenerateExportHeaderTest/consumer/testAPI_DISABLE_DEPRECATED_BEFORE_AND_AT.cmake
  tests/ECMGenerateExportHeaderTest/consumer/testAPI_NO_DEPRECATED.cmake

To: davidre, kossebau, #windows, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D16770#569723 , @dfaure wrote:
  
  > Hmmpf, indeed. I forgot about the objection I had here :)
  >
  > Are you interested in testing my suggested fix, since you seemed to have a 
testcase for this code?
  
  
  Been some time, and forgot details, also was using some ftp servers I have no 
longer access to.
  Yet I remember is that I preferred the current variant for some reason, but 
not which, and was collecting enough arguments for a convincing reply, that's 
why I had not instantly replied then. Perhaps it was something about not 
trusting QUrl to do the right thing in all cases, but really no more memories.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16770

To: kossebau, dfaure
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

[David Faure]

dfaure added a comment.


  Hmmpf, indeed. I forgot about the objection I had here :)
  
  Are you interested in testing my suggested fix, since you seemed to have a 
testcase for this code?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16770

To: kossebau, dfaure
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25626: Fix EcmGenerateExportHeader tests on Windows

[David Redondo]

davidre added a comment.


  In D25626#569714 , @kossebau wrote:
  
  > Yay, thanks for fixing this. Not sure if `if(MSVC)` is the proper 
condition, due to not being into the windows side of things, so that part 
better has someone check who enters the dark side now and then. :)
  >  Otherwise +1 for this.
  
  
  I used it because it is the same condition inside 
ECMGenerateExportHeader.cmake which enables `__declspec(deprecated(text))`.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  testswin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25626

To: davidre, kossebau, #windows, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25626: Fix EcmGenerateExportHeader tests on Windows

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Yay, thanks for fixing this. Not sure if `if(MSVC)` is the proper condition, 
due to not being into the windows side of things, so that part better has 
someone check who enters the dark side now and then. :)
  Otherwise +1 for this.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  testswin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25626

To: davidre, kossebau, #windows, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25626: Fix EcmGenerateExportHeader tests on Windows

[David Redondo]

davidre retitled this revision from "Fix EcmGenerateExportHeader tests on 
windows" to "Fix EcmGenerateExportHeader tests on Windows".

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25626

To: davidre, kossebau, #windows, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25626: Fix EcmGenerateExportHeader tests on windows

[David Redondo]

davidre added reviewers: kossebau, Windows, Frameworks.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25626

To: davidre, kossebau, #windows, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25626: Fix EcmGenerateExportHeader tests on windows

[David Redondo]

davidre created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  -we errors on warning . C4996 warns on deprecated declarations.

TEST PLAN
  Tests pass.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  testswin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25626

AFFECTED FILES
  
tests/ECMGenerateExportHeaderTest/consumer/testAPI_DISABLE_DEPRECATED_BEFORE_AND_AT.cmake
  tests/ECMGenerateExportHeaderTest/consumer/testAPI_NO_DEPRECATED.cmake

To: davidre
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25561: Remove unused signal we can use directly "signal(const QUrl&)

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:e50d2ffeedd5: Remove unused signal we can use directly 
signal(const QUrl) (authored by mlaurent).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25561?vs=70477=70609

REVISION DETAIL
  https://phabricator.kde.org/D25561

AFFECTED FILES
  src/CMakeLists.txt
  src/kurllabel.cpp
  src/kurllabel.h

To: mlaurent, dfaure, kossebau
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25561: Remove unused signal we can use directly "signal(const QUrl&)

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  remove_overload_signal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25561

To: mlaurent, dfaure, kossebau
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25561: Remove unused signal we can use directly "signal(const QUrl&)

[Laurent Montel]

mlaurent added a comment.


  ping ?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D25561

To: mlaurent, dfaure, kossebau
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Fabian Vogt]

fvogt added a comment.


  **Issue #1:**
  
  That happens because the .desktop file sets 
`X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb`:
  https://code.videolan.org/videolan/vlc/blob/master/share/vlc.desktop.in#L124
  
  **Issue #2:**
  
  The only explanation I have for that is that totem for some reason starts 
reading the file from the end for some reason.
  If you start `kio-fuse -d` manually (kill the other kio-fuse process first) 
and then use totem again, what's the debug output?
  
  If totem behaves like this, only `KIO::open` support might help a bit, with 
the cost of increased latency.
  That needs support for something like `KIO::truncate` though, so might take a 
while.
  
  **Issue #3:**
  
  Everything is in a separate process and async already. When/how does it 
happen?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D25530: Sonnet: Add locales that are missing in QLocale

[Waqar Ahmed]

waqar added a comment.


  > I honestly would prefer if you abandon this, but maybe let it open for a 
few days in case someone else disagrees.
  
  Alright.
  
  > Please shout if you need help with improving QLocale
  
  I sure do! :)

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25530

To: waqar
Cc: cullmann, aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D25530: Sonnet: Add locales that are missing in QLocale

[Albert Astals Cid]

aacid added a comment.


  I honestly would prefer if you abandon this, but maybe let it open for a few 
days in case someone else disagrees.
  
  Thanks for your understanding :)
  
  Please shout if you need help with improving QLocale

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25530

To: waqar
Cc: cullmann, aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D25622: partial solution to accept accentuated characters on windows

[Matthieu Gallien]

mgallien added a comment.


  I forgot to maybe give some explanations.
  
  The documentation of the constructor of TagLib::FileStream takes a char* and 
"file should be a be a C-string in the local file system encoding".
  
  This means that the proper fix would possibly involve doing changes in TagLib 
itself to better handle non ASCII characters on Windows.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25622

To: mgallien, bruns, #windows
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams