D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

nibags updated this revision to Diff 71333. nibags added a comment. - Improve number delimiters (use lookbehind) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25869?vs=71242=71333 BRANCH python-numbers REVISION DETAIL

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis added a comment. In D25897#575934 , @ngraham wrote: > Thanks. However I wonder if the stroke width ought to increase for the larger sizes? Having such skinny lines looks a tad odd to me IMO: > > F7813271:

D25877: [KColorschemeManager] Add option to reenable following global theme

ngraham added a comment. Lovely. Any chance you could actually add the name of the current system color scheme into the menu item? Like "System color scheme (Breeze)" REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks Cc: ngraham,

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson updated this revision to Diff 71329. davidedmundson added a comment. Implement new arguments for filterAcceptsRow passing source_row, source_parent. It makes for slightly heavier messier JS, but it also allows for super flexibility beyond just having the value retried

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson updated this revision to Diff 71327. davidedmundson added a comment. update REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25326?vs=71326=71327 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25326 AFFECTED FILES

D25897: Add 32, 48 and 64 px user-desktop icons

ngraham added a comment. Thanks. However I wonder if the stroke width ought to increase for the larger sizes? Having such skinny lines looks a tad odd to me IMO: F7813271: Screenshot_20191211_235533.png REPOSITORY R242 Plasma Framework (Library)

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson updated this revision to Diff 71326. davidedmundson added a comment. All changes except the parameters of filterRowCallback REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25326?vs=69918=71326 BRANCH master REVISION DETAIL

D25902: Fix decrement index and not iterator as discussed with David

mlaurent updated this revision to Diff 71322. mlaurent added a comment. Fix other code REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25902?vs=71312=71322 BRANCH fix_kioslave_notifier (branched from master) REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 218 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/218/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 11 Dec 2019 18:10:15 + Build duration: 2 hr 21 min and counting JUnit Tests Name:

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

kossebau added a comment. See D25891 (not tested by myself, only saw it) for another approach to this. So seems in general setTheme() always needs an explicit rehighlight() afterwards (but why only in some cases)? AbstractHighlighter::setTheme claims

D25891: fix preview of plain text files when using dark theme

This revision was automatically updated to reflect the committed changes. Closed by commit R320:4ec12a850e25: fix preview of plain text files when using dark theme (authored by iliakats). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25891?vs=71295=71317

D25902: Fix decrement index and not iterator as discussed with David

anthonyfieroni added inline comments. INLINE COMMENTS > kioslavenotifier.cpp:114 > else > *it++; > } Same here REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25902 To: mlaurent, dfaure Cc: anthonyfieroni, kde-frameworks-devel, kfm-devel, pberestov,

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 11 Dec 2019 17:58:00 + Build duration: 2 hr 9 min and counting JUnit Tests Name:

D25891: fix preview of plain text files when using dark theme

anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25891 To: iliakats, #dolphin, anthonyfieroni Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe,

D25902: Fix decrement index and not iterator as discussed with David

mlaurent created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Fix decrement index and not iterator REPOSITORY R320 KIO Extras BRANCH fix_kioslave_notifier

D25902: Fix decrement index and not iterator as discussed with David

mlaurent added a reviewer: dfaure. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25902 To: mlaurent, dfaure Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 233 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/233/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 11 Dec 2019 18:10:15 + Build duration: 11 min and counting BUILD ARTIFACTS

D25870: SELinux: add "glblub" keyword and update permissions list

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6f9022a66567: SELinux: add glblub keyword and update permissions list (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D25858: Use QStyle for determining icon sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R241:34aeee14693b: Use QStyle for determining icon sizes (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25858?vs=71214=71308 REVISION DETAIL

D25858: Use QStyle for determining icon sizes

vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25858 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/38/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 11 Dec 2019 17:58:00 + Build duration: 5 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 40 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/40/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 11 Dec 2019 17:58:00 + Build duration: 4 min 11 sec and counting BUILD ARTIFACTS

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25897 To: ndavis, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis created this revision. ndavis added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This prevents the icon from becoming blurry at fairly normal panel widths. TEST

D25891: fix preview of plain text files when using dark theme

iliakats updated this revision to Diff 71295. iliakats added a comment. performance improvement: only do one round of highlighting (skip the one run in the constructor of QSyntaxHighlighter) REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D25891: fix preview of plain text files when using dark theme

iliakats added a reviewer: Dolphin. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25891 To: iliakats, #dolphin Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,

D25891: fix preview of plain text files when using dark theme

iliakats created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. iliakats requested review of this revision. REVISION SUMMARY When using a dark theme, plain text files without an associated highlighting theme are rendered in

D25888: Support multiple children elements in comment elements

This revision was automatically updated to reflect the committed changes. Closed by commit R235:268195d2d5e2: Support multiple children elements in comment elements (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25888?vs=71283=71285

D25888: Support multiple children elements in comment elements

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Awesome! REPOSITORY R235 Attica BRANCH support-multiple-comment-children-elements (branched from master) REVISION DETAIL https://phabricator.kde.org/D25888 To: leinir,

D25888: Support multiple children elements in comment elements

leinir edited the test plan for this revision. leinir added reviewers: Frameworks, KNewStuff, ngraham. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D25888 To: leinir, #frameworks, #knewstuff, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25888: Support multiple children elements in comment elements

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This may seem strange, however we are dealing with a situation where we may receive multiple children subsections (the

D25887: [ColorScope] Work with plain QObjects again

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8f7b2c9ae099: [ColorScope] Work with plain QObjects again (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25887: [ColorScope] Work with plain QObjects again

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise `colorScope` doesn't attach to things like `Plasma.Svg`. Also remove

D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e44cab6ab55b: [Breeze Desktop Theme] Add monochrome user-desktop icon (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25887: [ColorScope] Work with plain QObjects again

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25887 To: broulik, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

ngraham edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25878 To: ngraham, davidedmundson, #vdg, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

ngraham edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25878 To: ngraham, davidedmundson, #vdg, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

ngraham updated this revision to Diff 71276. ngraham added a comment. Don't use relative dates farther than three days back REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25878?vs=71262=71276 BRANCH better-relative-dates (branched from master)

D23682: Make use of KPluginMetaData where we can

kossebau added a comment. Also some nitpicks on the style... remember that API dox tool and compiler both need all data duplicated sadly, both deprecated-at version and what-to-do-instead. Please also compare https://community.kde.org/Policies/Library_Code_Policy#Deprecation_of_API and

D23682: Make use of KPluginMetaData where we can

kossebau added a comment. Do not forget to bump 5.64 to 5.66 in all places :) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma, mart Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice work! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25885 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, kde-frameworks-devel,

D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This ensures the "show desktop" plasmoid remains monochrome in the panel at any

D23682: Make use of KPluginMetaData where we can

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma, mart Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25870: SELinux: add "glblub" keyword and update permissions list

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH update-selinux REVISION DETAIL https://phabricator.kde.org/D25870 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel,

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH python-numbers REVISION DETAIL https://phabricator.kde.org/D25869 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D25878: Use clearer relative dates

ngraham added a comment. So no "in two days"/"two days ago"? That's too confusing? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25878 To: ngraham, davidedmundson, #vdg, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

broulik added a comment. Yeah i think yesterday and tomorrow is fine but everything beyond that becomes more annoying than helpful REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25878 To: ngraham, davidedmundson, #vdg, #frameworks Cc: broulik,

D25878: Use clearer relative dates

ngraham added a comment. I was on the fence about that too. We could move to absolute dates after three days, maybe. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25878 To: ngraham, davidedmundson, #vdg, #frameworks Cc: broulik, kde-frameworks-devel,

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf added a comment. Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma, ngraham, davidedmundson Cc: mart, davidedmundson, fvogt,

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e4e1613b0fe7: [PC3 ToolButton] Have the label take into account complementary color schemes (authored by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the summary of this revision. filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH ok-text-colo (branched from master) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma, ngraham, davidedmundson Cc: mart,

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre added a dependency: D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

davidre added a dependent revision: D25877: [KColorschemeManager] Add option to reenable following global theme. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25875 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

broulik added a comment. Not a fan of Mathematics there. "Five days ago" I first have to open my calendar and count what day that was. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25878 To: ngraham, davidedmundson, #vdg, #frameworks Cc: broulik,

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

davidre edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25875 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

ngraham created this revision. ngraham added reviewers: davidedmundson, VDG, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now relative dated within +/- one week use "last/next "

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre created this revision. davidre added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Because the style will always follow the global scheme (see D25875

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

fvogt added a comment. In D25699#575278 , @davidedmundson wrote: > Please don't link external sites (GitHub) in the committed message. > > RE: Menu > There is nothing in QQC2::Button to add a menu > > If we want that it would have to

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

davidre added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25875 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Currently if an application has set a custom color scheme and the global one is changed, the new global color scheme

D25015: Update breeze theme shadows

mart added a comment. In D25015#568865 , @niccolove wrote: > Got it. The shape is actually rounded BUT the desktop contract effect is applied in the whole rectangle underneath, and it makes everything look like a rectangle. Here's the widget

D25865: kfilemetadata EBN transport protocol cleanup

vkrause added inline comments. INLINE COMMENTS > xmlextractor.cpp:33 > +inline QString rdfNS(){ return > QStringLiteral("https://www.w3.org/1999/02/22-rdf-syntax-ns#;); } > +inline QString ccNS() { return > QStringLiteral("https://creativecommons.org/ns#;); } > sure about those?

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

davidedmundson accepted this revision. davidedmundson added a comment. Please don't link external sites (GitHub) in the committed message. RE: Menu There is nothing in QQC2::Button to add a menu If we want that it would have to be a custom button subclass, rather than something we

D25685: [QImageItem/QPixmapItem] Don't lose precision during calculation

This revision was automatically updated to reflect the committed changes. Closed by commit R296:c3e6627e598b: [QImageItem/QPixmapItem] Dont lose precision during calculation (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D25829: kconfig EBN transport protocol cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R237:975aaeeff483: kconfig EBN transport protocol cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D25864: kdeclarative EBN spelling cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R296:ab35bc727cb7: kdeclarative EBN spelling cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D25866: kholidays EBN transport protocol cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R175:98e731d68581: kholidays EBN transport protocol cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D25864: kdeclarative EBN spelling cleanup

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH ebn-spelling-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25864 To: jhayes, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25866: kholidays EBN transport protocol cleanup

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25866 To: jhayes, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, GB_2,