D25328: Always rehiglhight() after definition was changed

meven abandoned this revision. meven added a comment. Fixed in thumnail creator in D25891 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25328 To: meven, kossebau, cullmann, vkrause Cc: dhaumann, kwrite-devel,

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

meven abandoned this revision. meven added a comment. In favor of D25891 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25323 To: meven, kossebau, cullmann, vkrause Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio,

D25891: fix preview of plain text files when using dark theme

meven added a comment. For reference I had a similar patch https://phabricator.kde.org/D25323 and a potential fix in KSyntaxHighlighting https://phabricator.kde.org/D25328 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25891 To: iliakats, #dolphin,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 60 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/60/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 06:12:53 + Build duration: 4 min 58 sec and counting JUnit Tests

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 121 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/121/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Dec 2019 06:12:54 + Build duration: 5 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/74/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 14 Dec 2019 06:12:53 + Build duration: 4 min 57 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/69/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 06:12:53 + Build duration: 2 min 53 sec and counting JUnit Tests Name:

D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl

dfaure created this revision. dfaure added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Unfortunately this doesn't cover all LGPLv2-only files. I cannot find a way to contact

D25974: Fix Invalid-enum-value assignment

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY It is undefined behaviour oss-fuzz/19481 REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL

Re: D24489: KAutosaveFile not respecting maximum filename length

Ouch sorry about that! Won't be able to work on it before tomorrow afternoon at best. Feel free to revert if you think it's best and I can work on an updated version... On Dec 13, 2019, 21:49, at 21:49, David Faure wrote: >dfaure added a comment. > > > It *also* broke Windows compilation: >

D25972: Support PyQt5 compiled with SIP 5

arojas created this revision. arojas added reviewers: bruns, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY When PyQt5 is compiled with SIP 5, the sip files are

D25434: [plasma-framework] port away from deprecated KF5 APIs

dfaure added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25434 To: dfaure, mart, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25433: KActionCollection: provide a changed() signal as a replacement for removed()

dfaure closed this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25433 To: dfaure, kossebau, mart, davidedmundson, vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25966: Ftp ioslave: fix 4 character time interpreted as year

ngraham added a comment. I learned recently that you can find out if someone has commit rights by doing a find on https://websvn.kde.org/trunk/kde-common/accounts?view=markup. Looks like no in this case. @linagkar, can we have your email address so we can land the patch with correct

D25966: Ftp ioslave: fix 4 character time interpreted as year

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks correct (given the if() further down, not visible in this context-less patch). Do you have commit access, or do you need someone to land this? [I wish this parsing code was

D24489: KAutosaveFile not respecting maximum filename length

dfaure added a comment. ahmadsamir: feel free to push a windows fix made from documentation, and check if CI builds. And fix it if not :) Won't be the first time we "hack blind" for Windows. When it's about compilation errors it's easy enough to use the CI to find out what's right.

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. For SMB shares I guess what can happen is that the URL doesn't have a username in it, but it still needs a password? IIRC there was no username in "old" samba (W95

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. According to [1], for windows, it's _MAX_FNAME defined in stdlib.h [1] https://docs.microsoft.com/en-us/cpp/c-runtime-library/path-field-limits?view=vs-2019 see also https://docs.microsoft.com/en-us/cpp/c-runtime-library/filename-max?view=vs-2019

D24489: KAutosaveFile not respecting maximum filename length

mardelle added a comment. Oh sorry about that. Won't be able to work on it before sunday.. feel free to revert if you think it's best - no computer access now... and I can work on an updated patch... REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To:

D15763: Set correct image attributes on directory thumbnail

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > thumbnail.cpp:730 > > +KFileItem item(fileUrl); > + For local files, QFileInfo would be more straightforward, no? You'd just use

D25682: [WIP] add initial wsdiscovery support

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > discovery.cpp:31 > +Discoverer::Discoverer() = default; > +Discoverer::~Discoverer() = default; Lines 30-31 duplicate lines 23-28, surely this can't link

D24489: KAutosaveFile not respecting maximum filename length

dfaure added a comment. It *also* broke Windows compilation: C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.13\src\lib\io\kautosavefile.cpp(79): error C2065: 'NAME_MAX': undeclared identifier

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 57 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/57/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Dec 2019 20:44:06 + Build duration: 2 min 14 sec and counting JUnit Tests Name:

D25966: Ftp ioslave: fix 4 character time interpreted as year

ngraham added reviewers: dfaure, Frameworks, sitter, feverfew. ngraham added a comment. Thanks for the patch! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25966 To: linagkar, dfaure, #frameworks, sitter, feverfew Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D25966: Ftp ioslave: fix 4 character time interpreted as year

linagkar created this revision. linagkar added a project: Frameworks. linagkar requested review of this revision. REVISION SUMMARY Previously, the code checked for years by checking for length 4. However this resulted in dates with single digit hours, e.g. 9:37, being interpreted as years.

D25965: [plasmashell] Add signal for panelTakesFocus changing

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Attached unit test REPOSITORY R127 KWayland BRANCH master REVISION DETAIL

D25897: Add 32, 48 and 64 px user-desktop icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bcc1ba205d60: Add 32, 48 and 64 px user-desktop icons (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25897?vs=71467=71469

D25897: Add 32, 48 and 64 px user-desktop icons

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH show-desktop-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D25897 To: ndavis, #plasma, #vdg, ngraham Cc: ngraham,

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25897 To: ndavis, #plasma, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis updated this revision to Diff 71467. ndavis added a comment. - increase line thickness for 48 and 64 px REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25897?vs=71303=71467 BRANCH show-desktop-icon (branched from master)

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis added a comment. In D25897#576015 , @ngraham wrote: > The straight lines in the system tray items from my screenshot are definitely 1px strokes. But all the curved lines look thicker by virtue of not being able to align to the pixel

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/56/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Dec 2019 18:50:36 + Build duration: 2 min 17 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/120/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 13 Dec 2019 18:31:05 + Build duration: 4 min 1 sec and counting BUILD ARTIFACTS

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. FWIW, this broke kautosavefiletest: 3: * Start testing of KAutoSaveFileTest * 3: Config: Using QtTest library 5.13.1, Qt 5.13.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.2.1 20190903 [gcc-9-branch revision

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/73/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 13 Dec 2019 18:31:05 + Build duration: 3 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/68/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Dec 2019 18:31:05 + Build duration: 1 min 53 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 59 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/59/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 13 Dec 2019 18:31:05 + Build duration: 55 sec and counting CONSOLE OUTPUT

D25767: KAutoSaveFile: add a unit test to check max. filename length

This revision was automatically updated to reflect the committed changes. Closed by commit R244:f9e62dc0239d: KAutoSaveFile: add a unit test to check max. filename length (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D25960: [calendar] Check out of bounds array access in QLocale lookup

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY If we have a broken locale setup we don't have any uiLanugages

D25953: Ignore parent scopes that are in the process of being removed

This revision was automatically updated to reflect the committed changes. Closed by commit R242:208b94365ce0: Ignore parent scopes that are in the process of being removed (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/39/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Dec 2019 15:31:55 + Build duration: 3 min 14 sec and counting JUnit Tests Name:

D25953: Ignore parent scopes that are in the process of being removed

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25953 To: apol, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25767: KAutoSaveFile: add a unit test to check max. filename length

mardelle added a comment. I have now committed https://phabricator.kde.org/D24489 REPOSITORY R244 KCoreAddons BRANCH l-kautosave-unittest (branched from master) REVISION DETAIL https://phabricator.kde.org/D25767 To: ahmadsamir, #frameworks, mpyne, dfaure Cc: mardelle, dhaumann,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/119/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 13 Dec 2019 15:06:35 + Build duration: 4 min 51 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 72 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/72/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 13 Dec 2019 15:06:35 + Build duration: 3 min 55 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/67/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Dec 2019 15:06:35 + Build duration: 2 min 30 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 58 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/58/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 13 Dec 2019 15:06:35 + Build duration: 1 min 28 sec and counting CONSOLE OUTPUT

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew marked 9 inline comments as done. feverfew added a comment. The current patch should be tested with latest kio-fuse master, as the blacklisting has been moved there to keep this patch clean. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew,

D25953: Ignore parent scopes that are in the process of being removed

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY When we destroy a colorscope, all children will try to reparent. This patch makes it so they

D25877: [KColorschemeManager] Add option to reenable following global theme

ngraham added a comment. I agree. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre added a comment. So KConfigWatcher didn't work because the KCM doesn't write with the notify flag. Even if we did we can't depend on a specific version of plasma. Thinking a bit more about this: This is in frameworks and getting the name probably works only on plasma byreading

D25918: Consistently define the tooltip delay

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c33fcaa8d747: Consistently define the tooltip delay (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25918?vs=71352=71443

D25859: Add Battery1 interface

This revision was automatically updated to reflect the committed changes. Closed by commit R269:5eabf3ac55c7: Add Battery1 interface (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25859?vs=71431=71441#toc REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE

D25859: Add Battery1 interface

drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > batterytest.cpp:40 > + > +//qRegisterMetaType("ReconnectMode"); > +} If it's not needed, then just remove it. REPOSITORY R269 BluezQt REVISION DETAIL

D25859: Add Battery1 interface

broulik updated this revision to Diff 71431. broulik added a comment. - Fix crash due to uninitialized q ptr REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25859?vs=71215=71431 REVISION DETAIL https://phabricator.kde.org/D25859 AFFECTED FILES

D25927: [PC3] Complete plasma progress bar animation

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c5a3d7cd5408: [PC3] Complete plasma progress bar animation (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25926: [PC3] Only show progress bar indicator when the ends won't overlap

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e91ba953eafb: [PC3] Only show progress bar indicator when the ends wont overlap (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. On further looking, it seems like git grep doesn't really tell the full picture. It seems like `resultingArguments` is called before `resolveURLs` is, so I've simplified the diff as requested. INLINE COMMENTS > feverfew wrote in desktopexecparser.cpp:331 > From

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 71423. feverfew added a comment. - Merge branch 'master' into arcpatch-D23384 - Address comments - Remove unnecessary mount requests in krun - Only use KIOFuse if password is empty REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25927: [PC3] Complete plasma progress bar animation

filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25927 To: davidedmundson, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25926: [PC3] Only show progress bar indicator when the ends won't overlap

filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25926 To: davidedmundson, #plasma, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson updated this revision to Diff 71421. davidedmundson edited the summary of this revision. davidedmundson added a comment. Huge cleanup Drop all the filter properties Implement other changes Extend unit tests REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf added a comment. In D25699#576444 , @fvogt wrote: > This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

dfaure added inline comments. INLINE COMMENTS > kdiroperator.h:688 > > -void keyPressEvent(QKeyEvent *event) override; > - For the record, removing a virtual method is BIC, I have added it again now (as a dummy forwarder). Oops, I failed to think about that earlier. REPOSITORY R241

D25939: TypeScript: add "bigint" primitive type

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25939 To: nibags, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, sars,