D26098: Display first / in mounted storage access description

meven created this revision. meven added reviewers: Frameworks, bruns, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Since f299edfeb8fd3893f9adf71a277f21a5ed50775u, for a mounted nfs drive

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

mlaurent updated this revision to Diff 71830. mlaurent added a comment. Move QRandomGenerator::global() outside loop REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26060?vs=71697=71830 BRANCH port_qrandomgenerator (branched from master) REVISION

D26062: Port to QRandomGenerator

mlaurent updated this revision to Diff 71829. mlaurent added a comment. Move QRandomGenerator::global() outside loop REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26062?vs=71699=71829 BRANCH remove_qrand (branched from master) REVISION DETAIL

D25388: Make constructor explicit and cleanup QWebPluginFactory #include.

jhayes added a comment. ping REPOSITORY R300 KDEWebKit REVISION DETAIL https://phabricator.kde.org/D25388 To: jhayes Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26096: kio filewidgets EBN constructor cleanup

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Make constructors explicit in kio/filewidgets REPOSITORY R241 KIO BRANCH ebn-constructor-cleanup-filewidgets

D26095: kio EBN constructor cleanup

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Make constructor explicit REPOSITORY R241 KIO BRANCH ebn-constructor-cleanup (branched from master) REVISION

D25550: Mark KInit as porting aid

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This seems too early to me. We are still using it in many places -- including in KIO to launch kioslaves. At the module level we need to follow the same rule than the one we

D25673: Deprecate KServiceTypeProfile

dfaure added a comment. Indeed missing "@deprecated since 5.66" --- and now the macros need s/65/66/ everywhere. As I'm the kservice maintainer (listed in the yaml file), please add me to kservice merge requests so I can react faster. REPOSITORY R309 KService REVISION DETAIL

D25789: Correctly report if baloo_file is unavailable

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Thx REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25789 To: davidedmundson, bruns Cc: bruns, ngraham, kde-frameworks-devel, #baloo, hurikhan77,

D26092: kidletime EBN constructor cleanup

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R274 KIdleTime BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D26092 To: jhayes, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26092: kidletime EBN constructor cleanup

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Make constructors explict REPOSITORY R274 KIdleTime BRANCH ebn-cleanup (branched from master) REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 80 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/80/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 18 Dec 2019 21:57:12 + Build duration: 5 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 129 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/129/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Dec 2019 21:57:12 + Build duration: 4 min 37 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/77/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Dec 2019 21:57:12 + Build duration: 2 min 17 sec and counting JUnit Tests Name:

D25980: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile()

ahmadsamir added a comment. In D25980#579978 , @dfaure wrote: > Yes. This matches the path() on line 77. Thanks for the pointer. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25980 To: ahmadsamir,

D25980: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile()

This revision was automatically updated to reflect the committed changes. Closed by commit R244:8e2768a69075: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile() (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#578285 , @niccolove wrote: > Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. If that's too light, we could darken it there, right? > Currently it's: F7819764:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 362 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/362/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Dec 2019 21:20:37 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 229 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/229/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Dec 2019 21:20:37 + Build duration: 14 min and counting JUnit Tests Name: projectroot

D25980: [KAutoSaveFile] Use QUrl::path() instead of toLocalFile()

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yes. This matches the path() on line 77. REPOSITORY R244 KCoreAddons BRANCH l-tolocalfile-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D25980 To:

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel,

D26043: Add edit mode menu item to desktop widget context menu

ngraham added a comment. +1, makes sense REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26043 To: GB_2, #plasma, #vdg, mart Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D26089: baloo EBN transport protocol cleanup

jhayes updated this revision to Diff 71817. jhayes added a comment. - Deleted addAuthor line as requested REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26089?vs=71807=71817 BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL

D26089: baloo EBN transport protocol cleanup

bruns added a comment. In D26089#579947 , @jhayes wrote: > Are you meaning the whole aboutData.addAuthor line or just the change > that's in the patch? The whole addAuthor line. REPOSITORY R293 Baloo REVISION DETAIL

D26089: baloo EBN transport protocol cleanup

jhayes added a comment. Are you meaning the whole aboutData.addAuthor line or just the change that's in the patch? John REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26089 To: jhayes, ngraham, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77,

D26089: baloo EBN transport protocol cleanup

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:44 > KAboutData aboutData(QStringLiteral("baloo"), i18n("Baloo File > Extractor"), QLatin1String(PROJECT_VERSION)); > -

D25495: Fix Sonnet autodetect failing on Indian langs

ognarb added a reviewer: cullmann. ognarb added a comment. Adding a potential reviewer :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

This revision was automatically updated to reflect the committed changes. Closed by commit R295:3f5a2879e99c: Port from KDE::icon to KIconUtils for getting icon overlays (authored by vkrause). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D26089: baloo EBN transport protocol cleanup

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D26089 To: jhayes, ngraham Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs,

D26089: baloo EBN transport protocol cleanup

jhayes created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change transport protocol from http to https REPOSITORY R293 Baloo BRANCH ebn-transport-cleanup

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

ngraham accepted this revision. ngraham added a comment. This was on my to-to list to fix, thanks! :) REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D26073 To: vkrause, apol, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26085: KCModuleQml: Ensure defaulted is emitted with the current configModule->representsDefaults on load

meven created this revision. meven added reviewers: crossi, mart, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY ConfigModule are instantiated before KCModuleQml in KCModuleLoader.

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi added inline comments. INLINE COMMENTS > broulik wrote in settings.h:343 > Not a fan of this becoming public API Maybe not the best approach. Any suggestion to access the KCoreConfigSkeleton encapsulated to register them in the KCM's ConfigModule ? REPOSITORY R120 Plasma Workspace

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

crossi created this revision. crossi added reviewers: Plasma, Frameworks, ervin, mart, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Allow the KCM Notifications to query the immutable

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

ngraham added a comment. Fantastic. UI-wise, I agree that adopting Dolphin's more narrow paddings between list elements makes the file dialog feel a bit crowded. This is also a (very) minor complaint I have about Dolphin. I wonder if it wouldn't make sense to keep the existing paddings

D25960: [calendar] Check out of bounds array access in QLocale lookup

This revision was automatically updated to reflect the committed changes. Closed by commit R242:6756d00fba11: [calendar] Check out of bounds array access in QLocale lookup (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26062: Port to QRandomGenerator

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > filemonitortest.cpp:197 > { > -int index = qrand() % possibleCharacters.length(); > +int index = >

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson requested review of this revision. davidedmundson marked 3 inline comments as done. davidedmundson added a comment. > Please allow some time for reviewing ... Marking as request review, so it hopefully reappears in your TODO queue. REPOSITORY R293 Baloo REVISION DETAIL

D25789: Correctly report if baloo_file is unavailable

davidedmundson marked an inline comment as done. davidedmundson added inline comments. INLINE COMMENTS > bruns wrote in monitor.cpp:67 > The watcher should be installed unconditionally, and first. > > Checking state first and the instaling the watcher is racy. Good catch. Done REPOSITORY

D26013: [KeySequenceHelper] Grab actual window when embedded

This revision was automatically updated to reflect the committed changes. Closed by commit R296:555a09198aef: [KeySequenceHelper] Grab actual window when embedded (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26013?vs=71586=71772

D25789: Correctly report if baloo_file is unavailable

davidedmundson updated this revision to Diff 71771. davidedmundson added a comment. swap order to fix potential race change i18n REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25789?vs=71024=71771 BRANCH master REVISION DETAIL

D25788: Initialise QML monitor values

broulik added inline comments. INLINE COMMENTS > monitor.h:82 > > org::kde::baloo::scheduler* m_scheduler; > org::kde::baloo::fileindexer* m_fileindexer; Might was well move the `nullptr` here, too REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25788 To:

D25788: Initialise QML monitor values

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a9dff763bf39: Initialise QML monitor values (authored by davidedmundson). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25788?vs=71023=71767 REVISION DETAIL

D25775: Check cursor_open return value

This revision was automatically updated to reflect the committed changes. Closed by commit R293:681bd3fcd65b: Check cursor_open return value (authored by davidedmundson). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25775?vs=70991=71768 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 361 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/361/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Dec 2019 09:37:57 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 228 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/228/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Dec 2019 09:37:56 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kossebau wrote in directorysizejob.cpp:137 > More correct would be KIOCORE_BUILD_DEPRECATED_SINCE(5, 65)., not ENABLE here > and in the other cpp files.

D25716: [KPropertiesDialog] Show extra fields

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6dcd50dd1ef2: [KPropertiesDialog] Show extra fields (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25716?vs=70831=71765 REVISION DETAIL

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfiltertest.cpp:102 > for (int i = 0; i < 8170; ++i) { > -data.append((char)(qrand() % 256)); > } Better move the

D25716: [KPropertiesDialog] Show extra fields

dfaure accepted this revision. dfaure added a comment. Yeah I introduced this mechanism for kio_trash. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25716 To: broulik, #frameworks, #vdg, dfaure, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25999: Add optional subtitle to grid delegate

broulik added inline comments. INLINE COMMENTS > GridDelegate.qml:81 > height: Kirigami.Settings.isMobile ? Math.round((delegate.width - > Kirigami.Units.gridUnit) / 1.6) > - : > Math.min(delegate.GridView.view.implicitCellHeight -

D26009: KCoreAddons: fix compilation with qtbase git dev branch

dfaure updated this revision to Diff 71764. dfaure added a comment. Use qcontainerfwd.h instead, as suggested by Giuseppe REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26009?vs=71562=71764 BRANCH arcpatch-D26009 REVISION DETAIL

D26062: Port to QRandomGenerator

mlaurent added a comment. Ping ?:) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26062 To: mlaurent, dfaure Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

mlaurent added a comment. Ping ?:) REVISION DETAIL https://phabricator.kde.org/D26060 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D20026: Go up in folder hierachy when in "edit mode"

meven added a comment. ping @krutovmikhail REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham, #dolphin Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns