D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

mlaurent added a comment. "Also QStringLiteral is missing on some strings." it can be fix in other patch. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26317 To: mlaurent, dfaure Cc: anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad,

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

mlaurent updated this revision to Diff 72444. mlaurent added a comment. use QLatin1Char('\n') REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26317?vs=72440=72444 BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

anthonyfieroni added a comment. Will be better if you use QLatin1Char('\n'), "\n" will call strlen on which is unneeded. Also QStringLiteral is missing on some strings. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26317 To: mlaurent, dfaure Cc: anthonyfieroni,

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

mlaurent added a reviewer: dfaure. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26320 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to \n REPOSITORY R269 BluezQt BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL

D26319: Port endl to \n (QFile flushs data when deleted)

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to \n (endl is Qt:: namespaced in qt5.15) REPOSITORY R289 KNotifications BRANCH port_endl_qt5.15

D26319: Port endl to \n (QFile flushs data when deleted)

mlaurent added a reviewer: dfaure. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26319 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26318: Port endl to "\n" flush at the end + use const'ref in loop

mlaurent added a reviewer: dfaure. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26318 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26318: Port endl to "\n" flush at the end + use const'ref in loop

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to \n REPOSITORY R266 Breeze Icons BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

mlaurent added a reviewer: dfaure. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26317 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

mlaurent created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to \n REPOSITORY R238 KDocTools BRANCH port_endl_qt5.15 (branched from

D26313: Add application/vnd.apple.pkpass icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Nice work! Looks like the 64px version got a part of it knocked out of position: F7851485: Screenshot_20191230_204235.PNG Once

D26313: Add application/vnd.apple.pkpass icon

broulik created this revision. broulik added reviewers: VDG, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 397987 TEST PLAN My boarding passes have nice icons now :) Since

D26308: Set output device's logical size

romangg added a dependent revision: D26311: Handle output logical size changes. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26308 To: romangg, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

romangg added a dependent revision: D26309: feat: replace replication source with logical size API. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26308 To: romangg, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

romangg added a comment. I thought about adding separate events/requests for an immutable`logical_size` just giving always back the current logical size of the output and `logical_size_override` always giving back the explicitly set logical size or an invalid size if none is set.

D26308: Set output device's logical size

romangg added a comment. This is an alternative to D23619 with more patches to come as discussed with David back then. INLINE COMMENTS > outputdevice.h:98 > }; > + > struct Mode { rm > outputdevice.xml:293 > + > + > +

D26308: Set output device's logical size

romangg created this revision. romangg added reviewers: KWin, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY This adds protocol methods and API to query and set explicitly the

D26306: Define more documentation search paths (also custom)

ltoscano added subscribers: asturmlechner, maximilianocuria, rikmills, arojas, rdieter, lbeltrame, cgiboudeaux. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26306 To: ltoscano Cc: cgiboudeaux, lbeltrame, rdieter, arojas, rikmills, maximilianocuria, asturmlechner,

D26306: Define more documentation search paths (also custom)

ltoscano created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ltoscano requested review of this revision. REVISION SUMMARY New search paths: - (GenericDataLocation)/help - a custom path (absolute path),

D26202: WIP: Refactor KConfigXT

tcanabrava added a subscriber: bport. tcanabrava added a comment. Not really as all the calls are the same, just split into classes and logical bits. I haven’t write a single line of logic. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava,

Re: D26202: WIP: Refactor KConfigXT

Not really as all the calls are the same, just split into classes and logical bits. I haven’t write a single line of logic. On Mon, 30 Dec 2019 at 19:00 Nathaniel Graham wrote: > ngraham added a comment. View Revision > > > At this point, it seems more like

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

mlaurent added a reviewer: dfaure. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26303 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl method for compiling against qt5.15 REPOSITORY R309 KService BRANCH port_endl (branched from master)

D26302: Port endl to "\n" + flush at the end

mlaurent added a reviewer: dfaure. REPOSITORY R298 KDesignerPlugin REVISION DETAIL https://phabricator.kde.org/D26302 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26302: Port endl to "\n" + flush at the end

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl for compiling against qt5.15 REPOSITORY R298 KDesignerPlugin BRANCH port_endl_qt5.15 (branched from

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl for compiling against qt5.15 REPOSITORY R294 KBookmarks BRANCH port_endl_qt5.15 (branched from

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

mlaurent added a reviewer: dfaure. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D26301 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26300: Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5.15

mlaurent added a reviewer: dfaure. REPOSITORY R301 KEmoticons REVISION DETAIL https://phabricator.kde.org/D26300 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26300: Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5.15

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to \n for compiling against qt5.15 REPOSITORY R301 KEmoticons BRANCH port_endl_qt5.15 (branched from

D26299: endl is namespaced in qt5.15

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to Qt::endl in qt5.15 REPOSITORY R280 Prison BRANCH compile_against_qt5.15 (branched from master)

D26299: endl is namespaced in qt5.15

mlaurent added a reviewer: dfaure. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D26299 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25702: Deprecate KUrlPixmapProvider

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25702 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26006: Deprecate KPixmapProvider

nicolasfella added a comment. Done in D25702 REPOSITORY R284 KCompletion BRANCH pmp REVISION DETAIL https://phabricator.kde.org/D26006 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25702: Deprecate KUrlPixmapProvider

nicolasfella updated this revision to Diff 72414. nicolasfella added a comment. - Update version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25702?vs=70795=72414 BRANCH arcpatch-D25702 REVISION DETAIL https://phabricator.kde.org/D25702 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 244 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/244/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 30 Dec 2019 19:19:23 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 72413. nicolasfella added a comment. - Fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=70804=72413 BRANCH arcpatch-D25705 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D25705: Deprecate KIO::pixmapForUrl

nicolasfella added a comment. In D25705#571458 , @apol wrote: > What do you mean by `Can easily be done otherwise.`? You can get an icon name for the icon with KIO::iconNameForUrl and then use QIcon API if you really need a pixmap

D25696: Remove dead code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:6281990dd4e9: Remove dead code (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26198: Deprecate KCModuleContainer

This revision was automatically updated to reflect the committed changes. Closed by commit R295:34686047d57c: Deprecate KCModuleContainer (authored by nicolasfella). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26198?vs=72121=72410 REVISION DETAIL

D26208: [KEmailAddress] Remove redundant bool var

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH l-ununsed-bool (branched from master) REVISION DETAIL https://phabricator.kde.org/D26208 To: ahmadsamir, dfaure, ngraham Cc: meven, kde-frameworks-devel, LeGast00n, GB_2,

D25743: Expose IndexerState enum to QML

ngraham added a comment. Now this patch no longer applies cleanly after those changes; needs a rebase. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n,

D26202: WIP: Refactor KConfigXT

ngraham added a comment. At this point, it seems more like a total rewrite than a refactor... REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26055: Enable wheel events on Slider {}

This revision was automatically updated to reflect the committed changes. Closed by commit R242:66122410a11d: Enable wheel events on Slider {} (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26055?vs=71744=72405 REVISION

D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr

pwojcik updated this revision to Diff 72404. pwojcik added a comment. Corrected logic, so it is is in line with GNUInstallDirs. Explained in comment. Added tests. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26245?vs=72258=72404 REVISION

D26175: [plasmashell] Update docs for panelTakesFocus to make it generic

This revision was automatically updated to reflect the committed changes. Closed by commit R127:935e54ce1aad: [plasmashell] Update docs for panelTakesFocus to make it generic (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D25965: [plasmashell] Add signal for panelTakesFocus changing

This revision was automatically updated to reflect the committed changes. Closed by commit R127:c25377a48183: [plasmashell] Add signal for panelTakesFocus changing (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/51/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 30 Dec 2019 16:35:17 + Build duration: 1 min 54 sec and counting JUnit Tests Name:

D26294: Allow to load widget based KCMs from kcms subdir

volkov added a dependent revision: D26244: Install all kcm plugins into kcms subdir. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26294 To: volkov, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

volkov updated this revision to Diff 72393. volkov added a comment. change branch REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26294?vs=72392=72393 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26294 AFFECTED FILES

D26294: Allow to load widget based KCMs from kcms subdir

volkov added a reviewer: Frameworks. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26294 To: volkov, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REPOSITORY R295 KCMUtils BRANCH xxx REVISION DETAIL https://phabricator.kde.org/D26294 AFFECTED FILES src/kcmoduleloader.cpp To:

D25743: Expose IndexerState enum to QML

davidedmundson added a comment. > Thanks, now it compiles! I'm not sure it's working perfectly though. I updated D25447 to use this, but it's claiming that my indexer is suspended, while balooctl status disagrees. There were several other problems

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/49/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 30 Dec 2019 15:45:25 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/44/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 30 Dec 2019 15:45:25 + Build duration: 7 min 13 sec and counting JUnit Tests Name:

D26292: [KSambaShare] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use QRegularExpression::anchoredPattern() to port QRegExp::exactMatch(). TEST PLAN make && ctest REPOSITORY

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 243 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/243/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 30 Dec 2019 15:04:19 + Build duration: 9 min 22 sec and counting JUnit Tests Name:

D26265: Fix crash on non-unix based systems

shubham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26265 To: shubham, ngraham, pino Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26208: [KEmailAddress] Remove redundant bool var

meven added a comment. Seems fine to me, indeed this bool was never changed REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26208 To: ahmadsamir, dfaure Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26208: [KEmailAddress] Remove redundant bool var

ahmadsamir added a comment. Ping. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26208 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

ahmadsamir added reviewers: dfaure, apol. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #frameworks, mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/44/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 30 Dec 2019 14:08:55 + Build duration: 2 min 35 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/32/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 30 Dec 2019 14:06:29 + Build duration: 1 min 3 sec and counting JUnit Tests Name:

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

meven added inline comments. INLINE COMMENTS > kfileplacesview.h:157 > Q_PRIVATE_SLOT(d, void adaptItemSize()) > -Q_PRIVATE_SLOT(d, void _k_placeClicked(const QModelIndex &)) > +Q_PRIVATE_SLOT(d, void _k_placeClicked(const QModelIndex &)) // TODO > remove > Q_PRIVATE_SLOT(d,

D26290: In qt5.15 endl is namespaced. But qCCritical already add a \n at the end so we can remove it

This revision was automatically updated to reflect the committed changes. Closed by commit R278:88e5a8c10c02: In qt5.15 endl is namespaced. But qCCritical already add a \n at the end so we… (authored by mlaurent). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D26290: In qt5.15 endl is namespaced. But qCCritical already add a \n at the end so we can remove it

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH remove_endl_qCCritical (branched from master) REVISION DETAIL https://phabricator.kde.org/D26290 To: mlaurent, dfaure, davidedmundson Cc: kde-frameworks-devel,

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72377. tcanabrava added a comment. - Reorganize code - Fix filename - Fix Static Methods - Fix name generation - Call forgotten function in the right place - Fix signal generation - remove stray bit of code REPOSITORY R237 KConfig CHANGES

D26290: In qt5.15 endl is namespaced. But qCCritical already add a \n at the end so we can remove it

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Remove not necessary endl REPOSITORY R278 KWindowSystem BRANCH remove_endl_qCCritical (branched from master)

D26290: In qt5.15 endl is namespaced. But qCCritical already add a \n at the end so we can remove it

mlaurent added a reviewer: dfaure. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D26290 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72371. tcanabrava added a comment. - Regression: Remove space from the autogen preamble - Whitespace regression - Fix hasNamespace: logic was inverted - Space issues and scope - Use whitespace() function to manage indentation level - Space

D25877: [KColorschemeManager] Add option to reenable following global theme

asemke added inline comments. INLINE COMMENTS > kcolorschememanager.cpp:220 > +{ > +return createSchemeSelectionMenu(QIcon(),QString(), QString(), parent); > +} why not to use reasonable default values here like QIcon::fromTheme(QStringLiteral("preferences-desktop-color") and i18n("Color

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port toVisualText() and finalizeVisualText() to use QRegularExpression. Replace

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

Hi, Stephen Kelly schrieb am So., 29. Dez. 2019, 15:03: > > On 28/12/2019 23:30, Friedrich W. H. Kossebau wrote: > > Why are you proposing to do a step back instead to the old state, which > > everyone including you considered not that satisfying? > > Because it's a temporary situation. We

D26117: [solid] Clarify referencing of DeviceInterface

anthonyfieroni added a comment. I've using the patch till now with no issues. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26117 To: anthonyfieroni, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#584220 , @dhaumann wrote: > @hoffmannrobert: by the way, looking at your phabricator activity, you should get a KDE contributor account, if you don't have one already. I applied for one and added

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#584218 , @dhaumann wrote: > @hoffmannrobert: Are you maybe also interested in looking into https://bugs.kde.org/show_bug.cgi?id=415570 ? It's again about printing, this time about the very last line