D26331: Removed reading description from desktop files

count added a comment. In D26331#586565 , @broulik wrote: > What about the directory Comment "feature" a few lines below? It is equally as questionable and causes significant slowdowns when browsing folders on nfs mounts, cf. D13757

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

mlaurent added a comment. Ping ?:) REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26303 To: mlaurent, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/48/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 05:57:19 + Build duration: 1 min 16 sec and counting JUnit Tests Name:

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

This revision was automatically updated to reflect the committed changes. Closed by commit R286:a5f8bfc9bf14: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash (authored by mlaurent). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D26373: Port endl to \n

This revision was automatically updated to reflect the committed changes. Closed by commit R290:011c329fa4f3: Port endl to \n (authored by mlaurent). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26373?vs=72639=72663 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 387 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/387/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 03 Jan 2020 04:55:25 + Build duration: 24 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 254 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/254/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 04:55:25 + Build duration: 17 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 216 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/216/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 03 Jan 2020 04:07:19 + Build duration: 2 min 51 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 108 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/108/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 03 Jan 2020 04:07:19 + Build duration: 2 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 102 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/102/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 03 Jan 2020 04:07:19 + Build duration: 2 min 20 sec and counting JUnit Tests Name:

D26326: Add application/x-audacity-project icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:4bba41c56947: Add application/x-audacity-project icon (authored by cblack). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26326?vs=72635=72662 REVISION

D26326: Add application/x-audacity-project icon

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D26326 REVISION DETAIL https://phabricator.kde.org/D26326 To: cblack, #vdg, ndavis, ngraham, broulik Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26376: [Kuit] Use const and QList::at() as need be

This revision was automatically updated to reflect the committed changes. Closed by commit R249:54170b448924: [Kuit] Use const and QList::at() as need be (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26376?vs=72649=72660 REVISION

D26376: [Kuit] Use const and QList::at() as need be

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH l-toKeyCombo-micro-opti (branched from master) REVISION DETAIL https://phabricator.kde.org/D26376 To: ahmadsamir, apol, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26376: [Kuit] Use const and QList::at() as need be

ahmadsamir created this revision. ahmadsamir added a reviewer: apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY toInterfacePath(), toKeyCombo(): use const and QList::at() where possible. TEST PLAN make && ctest REPOSITORY R249 KI18n

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

This revision was automatically updated to reflect the committed changes. Closed by commit R249:52cb9a5c2aaa: [Kuit] Port QRegExp to QRegularExpression, second pass (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26360?vs=72647=72648

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

ahmadsamir updated this revision to Diff 72647. ahmadsamir added a comment. Make the diff less noisy, split unrelated optimisations in a separate commit REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26360?vs=72601=72647 BRANCH l-toKeyCombo (branched from

D26374: [Attica] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R235:094968d5648f: [Attica] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26374?vs=72643=72645 REVISION

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 253 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/253/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 02 Jan 2020 19:28:54 + Build duration: 8 min 43 sec and counting JUnit Tests Name:

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in kuitmarkup.cpp:412 > According to the QList docs, at() should be used for read-only access, it > could be faster than [] and it never causes a detach.

D26374: [Attica] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26374 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH use_qmultihash (branched from master) REVISION DETAIL https://phabricator.kde.org/D26372 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs,

D26373: Port endl to \n

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26373 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26374: [Attica] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R235 Attica BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26365: Embed protocol data also for Windows version of trash ioslave.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:cb33e9478e58: Embed protocol data also for Windows version of trash ioslave. (authored by tfry). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26365?vs=72614=72644

D26277: KFilePlaceEditDialog: move logic into isIconEditable()

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH isIconEditable (branched from master) REVISION DETAIL https://phabricator.kde.org/D26277 To: elvisangelaccio, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2,

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham updated this revision to Diff 72641. ngraham added a comment. Update @since REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17596?vs=47624=72641 BRANCH arcpatch-D17596 REVISION DETAIL https://phabricator.kde.org/D17596 AFFECTED FILES

D17595: Upstream Dolphin's file rename dialog

ngraham accepted this revision. ngraham added a comment. The @since values need to be 5.66 now. Works great though, and the code looks sane to me now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure Cc:

D26373: Port endl to \n

mlaurent added reviewers: dfaure, apol. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D26373 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26373: Port endl to \n

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to \n + flush when necessary REPOSITORY R290 KPackage BRANCH port_endl (branched from master)

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

mlaurent added a reviewer: dfaure. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D26372 To: mlaurent, dfaure Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

mlaurent created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QMultiHash REPOSITORY R286 KFileMetaData BRANCH use_qmultihash (branched from master)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 252 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/252/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 02 Jan 2020 18:30:03 + Build duration: 9 min 48 sec and counting JUnit Tests Name:

D26331: Removed reading description from desktop files

broulik added a comment. What about the directory Comment "feature" a few lines below? It is equally as questionable and causes significant slowdowns when browsing folders on nfs mounts, cf. D13757 REPOSITORY R241 KIO REVISION DETAIL

D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fcf4529f62e1: Adding support for mounting KIOFuse URLs for applications that dont use KIO (authored by feverfew). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26331: Removed reading description from desktop files

ngraham accepted this revision. ngraham added a comment. Can you please provide your name and email address so we can land this patch with the correct authorship information? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26331 To: count, broulik, #frameworks,

D26326: Add application/x-audacity-project icon

cblack updated this revision to Diff 72635. cblack added a comment. Optimise with Scour REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26326?vs=72632=72635 BRANCH arcpatch-D26326 REVISION DETAIL https://phabricator.kde.org/D26326 AFFECTED FILES

D26326: Add application/x-audacity-project icon

cblack added a comment. F7855956: image.png F7855958: image.png REPOSITORY R266 Breeze Icons BRANCH arcpatch-D26326 REVISION DETAIL https://phabricator.kde.org/D26326 To: cblack, #vdg, ndavis, ngraham,

D26326: Add application/x-audacity-project icon

cblack updated this revision to Diff 72632. cblack added a comment. Refine colour palette of icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26326?vs=72526=72632 BRANCH arcpatch-D26326 REVISION DETAIL https://phabricator.kde.org/D26326

D26326: Add application/x-audacity-project icon

cblack commandeered this revision. cblack added a reviewer: broulik. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: cblack, #vdg, ndavis, ngraham, broulik Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kuitmarkup.cpp:1597 > I thought it was the resolved version, without entities (if they were > successfully resolved). If the entity is unknown it'll be left as is, I don't know how often that actually happens though.

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre added inline comments. INLINE COMMENTS > kcolorschememanager.cpp:220 > +{ > +return createSchemeSelectionMenu(QIcon(),QString(), QString(), parent); > +} Should we also do this for the other overloads? Or would that behavior change be a blocker? ALso an application would want to

D25877: [KColorschemeManager] Add option to reenable following global theme

davidre updated this revision to Diff 72623. davidre marked an inline comment as done. davidre added a comment. Default values REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25877?vs=72337=72623 BRANCH systemthem (branched from master) REVISION

D26365: Embed protocol data also for Windows version of trash ioslave.

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Makes sense for me, thanks for taking care of this. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26365 To: tfry, cullmann, vonreth Cc:

D26368: Add an isImmutable to know if a property is immutable

meven edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

meven created this revision. meven added reviewers: ervin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Add a utility function isImmutable to access immutability quickly. Generated

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

kossebau added a comment. Thanks. Okay, so the old symbol is still there, and with that info I looked some more, and indeed the ::endl symbol is not declared in the header qtextstream.h, but only defined (and exported) in the source file qtextstream.cpp. Having 3 variants now not make sense

D26171: Implement wp_viewporter

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH viewporter REVISION DETAIL https://phabricator.kde.org/D26171 To: romangg, #kwin, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port parseUiMarker() and determineIsStructured(). TEST PLAN make && ctest REPOSITORY

D26308: Set output device's logical size

romangg updated this revision to Diff 72615. romangg marked 4 inline comments as done. romangg added a comment. - Add autotest - Cleanup REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26308?vs=72427=72615 BRANCH replicaSize REVISION DETAIL

D26365: Embed protocol data also for Windows version of trash ioslave.

tfry added reviewers: cullmann, vonreth. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26365 To: tfry, cullmann, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26365: Embed protocol data also for Windows version of trash ioslave.

tfry created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tfry requested review of this revision. REVISION SUMMARY trash:/-protocol is currently broken on Windows: https://bugs.kde.org/show_bug.cgi?id=414430 The cause seems to be that

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

meven planned changes to this revision. meven added a comment. In D26361#586350 , @ervin wrote: > Indeed will have to wait KF6 branching AFAICT. Could you add a task for it in the KF6 board in the waiting for branching column? Just to make sure

D25673: Deprecate KServiceTypeProfile

This revision was automatically updated to reflect the committed changes. Closed by commit R309:486af98fe900: Deprecate KServiceTypeProfile (authored by nicolasfella). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25673?vs=72590=72612 REVISION DETAIL

D26208: [KEmailAddress] Remove redundant bool var

This revision was automatically updated to reflect the committed changes. Closed by commit R270:9e8f0306b549: [KEmailAddress] Remove redundant bool var (authored by ahmadsamir). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26208?vs=72142=72611 REVISION

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

kfunk added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26364 To: kfunk, chinmoyr, davidedmundson, dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

kfunk added reviewers: chinmoyr, davidedmundson, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26364 To: kfunk, chinmoyr, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

kfunk created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kfunk requested review of this revision. REVISION SUMMARY Old version of the code: ms = qMax(d->nextTimeout.elapsed() - d->nextTimeoutMsecs, 1); ... will mean the sleep

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

ervin added a comment. Indeed will have to wait KF6 branching AFAICT. Could you add a task for it in the KF6 board in the waiting for branching column? Just to make sure we don't forget it. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26361 To: meven,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 251 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/251/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 02 Jan 2020 12:48:48 + Build duration: 10 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/45/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 02 Jan 2020 12:49:58 + Build duration: 3 min 43 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 88 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/88/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 02 Jan 2020 12:42:38 + Build duration: 3 min 27 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/85/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 02 Jan 2020 12:42:38 + Build duration: 2 min 33 sec and counting JUnit Tests Name:

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

meven added a comment. The methods are straight copy-paste compared to KCoreConfigSkeleton. The binary compatiblity might be affected though so we might want to do it for KF6 only. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26361 To: meven, ervin,

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

This revision was automatically updated to reflect the committed changes. Closed by commit R294:2d40d4f5f0f1: Remove endl in qDebug its already add \n at the end + port endl + flush when… (authored by mlaurent). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE

D26302: Port endl to "\n" + flush at the end

This revision was automatically updated to reflect the committed changes. Closed by commit R298:f9e10975740d: Port endl to \n + flush at the end (authored by mlaurent). REPOSITORY R298 KDesignerPlugin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26302?vs=72593=72604 REVISION

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

meven created this revision. meven added reviewers: ervin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/47/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 02 Jan 2020 12:33:08 + Build duration: 56 sec and counting JUnit Tests Name:

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in kuitmarkup.cpp:412 > Why did you change [i] to at(i)? According to the QList docs, at() should be used for read-only access, it could be faster than [] and it never causes a detach. REPOSITORY R249 KI18n REVISION DETAIL

D26359: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R290:ab6743ffc5f3: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26359?vs=72598=72603 REVISION DETAIL

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

apol added inline comments. INLINE COMMENTS > kuitmarkup.cpp:412 > // Normalize key, trim and all lower-case. > -QString nkey = keys[i].trimmed().toLower(); > +const QString nkey = keys.at(i).trimmed().toLower(); > keys[i] = keyNames.contains(nkey) ? >

D26359: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26359 To: ahmadsamir, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26358: KIO/SMB convert kio protocol declaration to json format

apol added inline comments. INLINE COMMENTS > kio_smb.cpp:42 > +Q_OBJECT > +Q_PLUGIN_METADATA(IID "org.kde.kio.slave.smb" FILE "smb.json") > +}; Shouldn't this go in the SMBSlave class? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven,

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26301 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26302: Port endl to "\n" + flush at the end

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R298 KDesignerPlugin BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26302 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26277: KFilePlaceEditDialog: move logic into isIconEditable()

elvisangelaccio added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26277 To: elvisangelaccio, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port KuitStaticData::toKeyCombo() and KuitStaticData::toInterfacePath() to

D17595: Upstream Dolphin's file rename dialog

meven added a comment. In D17595#580655 , @ngraham wrote: > Awesome. Does this need a rebase? It should not, the API has not changed and this is new code. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To:

D26191: Add support for FileJob->truncate() in smb/sftp slaves

dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > kio_sftp.cpp:1478 > +void sftpProtocol::truncate(KIO::filesize_t length) { > +qCDebug(KIO_SFTP_LOG) << "truncate, length = " << length; > + [minor: qDebug already appends spaces between arguments, so you get two

D25673: Deprecate KServiceTypeProfile

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R309 KService BRANCH arcpatch-D25673 REVISION DETAIL https://phabricator.kde.org/D25673 To: nicolasfella, #frameworks, dfaure Cc: dfaure, apol,

D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D23384_1 REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson,

D26331: Removed reading description from desktop files

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I looked into the git/svn history and this actually is from before my time (lol), and a remnant of the fact that in the initial design by Torben, desktop files were a kmimetype-subclass

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

dfaure renamed this task from "KService: Look application that still use KService for plugins" to "KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts". dfaure updated the task description. TASK DETAIL

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

mlaurent added a comment. nm -gDC libQt5Core.so.5.15.0 | grep endl 00336680 T endl(QTextStream&) 00336500 T QTextStreamFunctions::endl(QTextStream&) 003361e0 T Qt::endl(QTextStream&) REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26320