D26331: Removed reading description from desktop files

[count negative]

count added a comment.


  In D26331#586565 , @broulik wrote:
  
  > What about the directory Comment "feature" a few lines below? It is equally 
as questionable and causes significant slowdowns when browsing folders on nfs 
mounts, cf. D13757 
  
  
  I thought, the !d->isSlow() would skip that part for (fsType == 
KFileSystemType::Nfs || fsType == KFileSystemType::Smb) as seen in 
kfileitem.cpp:763. So I would leave that here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

[Laurent Montel]

mlaurent added a comment.


  Ping ?:)

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26303

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/48/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 05:57:19 +
 Build duration:
1 min 16 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:a5f8bfc9bf14: In qt5.15 QHash::insertMulti is deprecated 
now we need to use QMultiHash (authored by mlaurent).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26372?vs=72638=72664

REVISION DETAIL
  https://phabricator.kde.org/D26372

AFFECTED FILES
  src/extractorcollection.cpp
  src/writercollection.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26373: Port endl to \n

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:011c329fa4f3: Port endl to \n (authored by mlaurent).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26373?vs=72639=72663

REVISION DETAIL
  https://phabricator.kde.org/D26373

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 387 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/387/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 03 Jan 2020 04:55:25 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34745/61858)40%
(17633/43692)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9687/10144)47%
(4509/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8698/14613)51%
(4522/8855)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4665/8295)43%
(2045/4766)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(683/1260)40%
(391/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 254 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/254/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 04:55:25 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 216 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/216/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 03 Jan 2020 04:07:19 +
 Build duration:
2 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/300)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(212/245)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 108 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/108/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 03 Jan 2020 04:07:19 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/300)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(212/245)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 102 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/102/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 04:07:19 +
 Build duration:
2 min 20 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

D26326: Add application/x-audacity-project icon

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:4bba41c56947: Add application/x-audacity-project icon 
(authored by cblack).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26326?vs=72635=72662

REVISION DETAIL
  https://phabricator.kde.org/D26326

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-audacity-project.svg
  icons-dark/mimetypes/22/application-x-audacity-project.svg
  icons-dark/mimetypes/32/application-x-audacity-project.svg
  icons-dark/mimetypes/64/application-x-audacity-project.svg
  icons/mimetypes/16/application-x-audacity-project.svg
  icons/mimetypes/22/application-x-audacity-project.svg
  icons/mimetypes/32/application-x-audacity-project.svg
  icons/mimetypes/64/application-x-audacity-project.svg

To: cblack, #vdg, ndavis, ngraham, broulik
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26326: Add application/x-audacity-project icon

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D26326

REVISION DETAIL
  https://phabricator.kde.org/D26326

To: cblack, #vdg, ndavis, ngraham, broulik
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26376: [Kuit] Use const and QList::at() as need be

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:54170b448924: [Kuit] Use const and QList::at() as need be 
(authored by ahmadsamir).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26376?vs=72649=72660

REVISION DETAIL
  https://phabricator.kde.org/D26376

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26376: [Kuit] Use const and QList::at() as need be

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  l-toKeyCombo-micro-opti (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26376

To: ahmadsamir, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26376: [Kuit] Use const and QList::at() as need be

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  toInterfacePath(), toKeyCombo(): use const and QList::at() where possible.

TEST PLAN
  make && ctest

REPOSITORY
  R249 KI18n

BRANCH
  l-toKeyCombo-micro-opti (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26376

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:52cb9a5c2aaa: [Kuit] Port QRegExp to QRegularExpression, 
second pass (authored by ahmadsamir).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26360?vs=72647=72648

REVISION DETAIL
  https://phabricator.kde.org/D26360

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid, apol
Cc: apol, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

[Ahmad Samir]

ahmadsamir updated this revision to Diff 72647.
ahmadsamir added a comment.


  Make the diff less noisy, split unrelated optimisations in a separate commit

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26360?vs=72601=72647

BRANCH
  l-toKeyCombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26360

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid, apol
Cc: apol, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26374: [Attica] Port QRegExp to QRegularExpression

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:094968d5648f: [Attica] Port QRegExp to QRegularExpression 
(authored by ahmadsamir).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26374?vs=72643=72645

REVISION DETAIL
  https://phabricator.kde.org/D26374

AFFECTED FILES
  src/activityparser.cpp
  src/eventparser.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 253 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/253/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 02 Jan 2020 19:28:54 +
 Build duration:
8 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ahmadsamir wrote in kuitmarkup.cpp:412
> According to the QList docs, at() should be used for read-only access, it 
> could be faster than [] and it never causes a detach.

I'd do these changes in a separate commit. Also adding consts to unrelated 
variables.

REPOSITORY
  R249 KI18n

BRANCH
  l-toKeyCombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26360

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid, apol
Cc: apol, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26374: [Attica] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R235 Attica

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26374

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  use_qmultihash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26372

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26373: Port endl to \n

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26373

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26374: [Attica] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R235 Attica

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26374

AFFECTED FILES
  src/activityparser.cpp
  src/eventparser.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26365: Embed protocol data also for Windows version of trash ioslave.

[Thomas Friedrichsmeier]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:cb33e9478e58: Embed protocol data also for Windows 
version of trash ioslave. (authored by tfry).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26365?vs=72614=72644

REVISION DETAIL
  https://phabricator.kde.org/D26365

AFFECTED FILES
  src/ioslaves/trash/kio_trash_win.cpp

To: tfry, cullmann, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26277: KFilePlaceEditDialog: move logic into isIconEditable()

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  isIconEditable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26277

To: elvisangelaccio, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17596: [KDirOperator] Allow renaming files from the context menu

[Nathaniel Graham]

ngraham updated this revision to Diff 72641.
ngraham added a comment.


  Update @since

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17596?vs=47624=72641

BRANCH
  arcpatch-D17596

REVISION DETAIL
  https://phabricator.kde.org/D17596

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h

To: ngraham, #frameworks, #dolphin
Cc: cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  The @since values need to be 5.66 now. Works great though, and the code looks 
sane to me now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, 
dhaumann, pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26373: Port endl to \n

[Laurent Montel]

mlaurent added reviewers: dfaure, apol.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D26373

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26373: Port endl to \n

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to \n + flush when necessary

REPOSITORY
  R290 KPackage

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26373

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D26372

To: mlaurent, dfaure
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

[Laurent Montel]

mlaurent created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to QMultiHash

REPOSITORY
  R286 KFileMetaData

BRANCH
  use_qmultihash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26372

AFFECTED FILES
  src/extractorcollection.cpp
  src/writercollection.cpp

To: mlaurent
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 252 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/252/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 02 Jan 2020 18:30:03 +
 Build duration:
9 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26331: Removed reading description from desktop files

[Kai Uwe Broulik]

broulik added a comment.


  What about the directory Comment "feature" a few lines below? It is equally 
as questionable and causes significant slowdowns when browsing folders on nfs 
mounts, cf. D13757 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Alexander Saoutkin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fcf4529f62e1: Adding support for mounting KIOFuse URLs 
for applications that dont use KIO (authored by feverfew).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23384?vs=71666=72637

REVISION DETAIL
  https://phabricator.kde.org/D23384

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/desktopexecparser.cpp
  src/core/org.kde.KIOFuse.VFS.xml

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, 
LeGast00n, GB_2, michaelh, bruns

D26331: Removed reading description from desktop files

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Can you please provide your name and email address so we can land this patch 
with the correct authorship information?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26326: Add application/x-audacity-project icon

[Carson Black]

cblack updated this revision to Diff 72635.
cblack added a comment.


  Optimise with Scour

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26326?vs=72632=72635

BRANCH
  arcpatch-D26326

REVISION DETAIL
  https://phabricator.kde.org/D26326

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-audacity-project.svg
  icons-dark/mimetypes/22/application-x-audacity-project.svg
  icons-dark/mimetypes/32/application-x-audacity-project.svg
  icons-dark/mimetypes/64/application-x-audacity-project.svg
  icons/mimetypes/16/application-x-audacity-project.svg
  icons/mimetypes/22/application-x-audacity-project.svg
  icons/mimetypes/32/application-x-audacity-project.svg
  icons/mimetypes/64/application-x-audacity-project.svg

To: cblack, #vdg, ndavis, ngraham, broulik
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26326: Add application/x-audacity-project icon

[Carson Black]

cblack added a comment.


  F7855956: image.png  F7855958: 
image.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D26326

REVISION DETAIL
  https://phabricator.kde.org/D26326

To: cblack, #vdg, ndavis, ngraham, broulik
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26326: Add application/x-audacity-project icon

[Carson Black]

cblack updated this revision to Diff 72632.
cblack added a comment.


  Refine colour palette of icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26326?vs=72526=72632

BRANCH
  arcpatch-D26326

REVISION DETAIL
  https://phabricator.kde.org/D26326

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-audacity-project.svg
  icons-dark/mimetypes/22/application-x-audacity-project.svg
  icons-dark/mimetypes/32/application-x-audacity-project.svg
  icons-dark/mimetypes/64/application-x-audacity-project.svg
  icons/mimetypes/16/application-x-audacity-project.svg
  icons/mimetypes/22/application-x-audacity-project.svg
  icons/mimetypes/32/application-x-audacity-project.svg
  icons/mimetypes/64/application-x-audacity-project.svg

To: cblack, #vdg, ndavis, ngraham, broulik
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26326: Add application/x-audacity-project icon

[Carson Black]

cblack commandeered this revision.
cblack added a reviewer: broulik.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26326

To: cblack, #vdg, ndavis, ngraham, broulik
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kuitmarkup.cpp:1597
> I thought it was the resolved version, without entities (if they were 
> successfully resolved).

If the entity is unknown it'll be left as is, I don't know how often that 
actually happens though.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26285

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, ltoscano, LeGast00n, GB_2, michaelh, ngraham, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> kcolorschememanager.cpp:220
> +{
> +return createSchemeSelectionMenu(QIcon(),QString(), QString(), parent);
> +}

Should we also do this for the other overloads? Or would that behavior change 
be a blocker? ALso an application would want to call 
`KColorSchemeManager::createSchemeSelectionMenu(const QString 
, QObject *parent)` probably if the custom scheme is saved 
between launches.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

[David Redondo]

davidre updated this revision to Diff 72623.
davidre marked an inline comment as done.
davidre added a comment.


  Default values

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25877?vs=72337=72623

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

AFFECTED FILES
  autotests/kcolorschemetest.cpp
  src/kcolorschememanager.cpp
  src/kcolorschememanager.h

To: davidre, #frameworks, ngraham
Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D26365: Embed protocol data also for Windows version of trash ioslave.

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Makes sense for me, thanks for taking care of this.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26365

To: tfry, cullmann, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26368

To: meven, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

[Méven Car]

meven created this revision.
meven added reviewers: ervin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Add a utility function isImmutable to access immutability quickly.
  Generated classes uses them internally to avoid code redundance.
  
  Sample:
  
/**
  Set blocked-by-default
*/
void setBlockedByDefault( bool v )
{
  if (v != mBlockedByDefault && !isBlockedByDefaultImmutable() )  {
mBlockedByDefault = v;
Q_EMIT blockedByDefaultChanged();
  }
}

/**
  Is blocked-by-default Immutable
*/
bool isBlockedByDefaultImmutable()
{
  return isImmutable( QStringLiteral( "blockedByDefault" ) );
}
  
  
  
/**
  Set org.kde.ActivityManager.ResourceScoringEnabled
*/
void setResourceScoringEnabled( bool v )
{
  if (!isResourceScoringEnabledImmutable() ) 
mResourceScoringEnabled = v;
}

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26368

AFFECTED FILES
  src/kconfig_compiler/kconfig_compiler.cpp

To: meven, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks. Okay, so the old symbol is still there, and with that info I looked 
some more, and indeed the ::endl symbol is not declared in the header 
qtextstream.h, but only defined (and exported) in the source file 
qtextstream.cpp. Having 3 variants now not make sense to me on first look, but 
perhaps a result of some incomplete approach in Qt 5.14... oh well...
  
  For Okteta I now went for this approach, which I find more elegant:
  
using TextStreamFunction = QTextStream& (*)(QTextStream&);
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
constexpr TextStreamFunction endl = Qt::endl;
#else
constexpr TextStreamFunction endl = ::endl;
#endif
  
  No extra namespace here, as all code is already in some Okteta namespace, so 
the lines with the `endl` do not even have to be touched :)
  
  Whether `endl` is a proper call in such places is left for another 
investigation on its own.
  
  In D26320#585916 , @dfaure wrote:
  
  > I don't think a code generator needs to flush() many times along the way 
anyway. \n actually sounds more efficient.
  
  
  Do Qt experts have some numbers on the sizes before which flush() makes sense 
in general? I guess it varies on the actual QIODevice, and then with QFile 
perhaps on the actual filesystem/kernel/whatever?
  
  Also surprised to see the implementation do a 
¸writeBuffer.replace(QLatin1Char('\n'), QLatin1String("\r\n"));¸for windows 
where I expected `endl` itself to care for it...

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26171: Implement wp_viewporter

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  viewporter

REVISION DETAIL
  https://phabricator.kde.org/D26171

To: romangg, #kwin, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Port parseUiMarker() and determineIsStructured().

TEST PLAN
  make && ctest

REPOSITORY
  R249 KI18n

BRANCH
  l-parseUiM (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26366

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

[Roman Gilg]

romangg updated this revision to Diff 72615.
romangg marked 4 inline comments as done.
romangg added a comment.


  - Add autotest
  - Cleanup

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26308?vs=72427=72615

BRANCH
  replicaSize

REVISION DETAIL
  https://phabricator.kde.org/D26308

AFFECTED FILES
  autotests/client/test_wayland_outputdevice.cpp
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/registry.cpp
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h
  src/server/outputmanagement_interface.cpp

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26365: Embed protocol data also for Windows version of trash ioslave.

[Thomas Friedrichsmeier]

tfry added reviewers: cullmann, vonreth.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26365

To: tfry, cullmann, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26365: Embed protocol data also for Windows version of trash ioslave.

[Thomas Friedrichsmeier]

tfry created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tfry requested review of this revision.

REVISION SUMMARY
  trash:/-protocol is currently broken on Windows: 
https://bugs.kde.org/show_bug.cgi?id=414430
  
  The cause seems to be that the trash-protocol meta data is not installed on 
Windows: The protocol is
  built from entirely separate sources on Windows, and the Windows-version was 
forgotten in this commit:
  
https://cgit.kde.org/kio.git/commit/src/ioslaves/trash/CMakeLists.txt?id=a3fee508c6c42b1b86155719e38a84b1128360eb

TEST PLAN
  This patch fixes the problem for me on Windows 8.1, MinGW64

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26365

AFFECTED FILES
  src/ioslaves/trash/kio_trash_win.cpp

To: tfry
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

[Méven Car]

meven planned changes to this revision.
meven added a comment.


  In D26361#586350 , @ervin wrote:
  
  > Indeed will have to wait KF6 branching AFAICT. Could you add a task for it 
in the KF6 board in the waiting for branching column? Just to make sure we 
don't forget it.
  
  
  Added a bullet to https://phabricator.kde.org/T12147 and created 
https://phabricator.kde.org/T12480

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26361

To: meven, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25673: Deprecate KServiceTypeProfile

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:486af98fe900: Deprecate KServiceTypeProfile (authored by 
nicolasfella).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25673?vs=72590=72612

REVISION DETAIL
  https://phabricator.kde.org/D25673

AFFECTED FILES
  src/CMakeLists.txt
  src/services/kservicetypeprofile.cpp
  src/services/kservicetypeprofile.h

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26208: [KEmailAddress] Remove redundant bool var

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R270:9e8f0306b549: [KEmailAddress] Remove redundant bool var 
(authored by ahmadsamir).

REPOSITORY
  R270 KCodecs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26208?vs=72142=72611

REVISION DETAIL
  https://phabricator.kde.org/D26208

AFFECTED FILES
  src/kemailaddress.cpp

To: ahmadsamir, dfaure, ngraham
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

[Kevin Funk]

kfunk added a reviewer: broulik.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26364

To: kfunk, chinmoyr, davidedmundson, dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

[Kevin Funk]

kfunk added reviewers: chinmoyr, davidedmundson, dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26364

To: kfunk, chinmoyr, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

[Kevin Funk]

kfunk created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kfunk requested review of this revision.

REVISION SUMMARY
  Old version of the code:
  
ms = qMax(d->nextTimeout.elapsed() - d->nextTimeoutMsecs, 1);
  
  ... will mean the sleep is for as long as the timer has run *minus* the
  intended duration, so if nextTimeoutMsecs is ever set and the timer just
  started this becomes very negative, and 1ms is the result.
  
  Inverting the subtraction:
  
ms = qMax(d->nextTimeoutMsecs - d->nextTimeout.elapsed(), 1);
  
  Means sleeping for the remaining time, and so far my CPU seems much
  happier, with my KIO-HTTP using apps looking fine.
  
  BUG: 392768

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26364

AFFECTED FILES
  src/core/slavebase.cpp

To: kfunk
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

[Kevin Ottens]

ervin added a comment.


  Indeed will have to wait KF6 branching AFAICT. Could you add a task for it in 
the KF6 board in the waiting for branching column? Just to make sure we don't 
forget it.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26361

To: meven, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 251 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/251/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 02 Jan 2020 12:48:48 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/45/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 02 Jan 2020 12:49:58 +
 Build duration:
3 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 489 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testcalendarobserverFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 88 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/88/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 02 Jan 2020 12:42:38 +
 Build duration:
3 min 27 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.66.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6895/9073)43%
(10751/24743)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2893/2985)49%
(6176/12687)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(678/794)42%
(952/2255)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(422/827)47%
(988/2121)src.lib.util100%
(15/15)100%
(15/15)83%
(986/1183)51%
(1006/1989)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/85/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 02 Jan 2020 12:42:38 +
 Build duration:
2 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

[Méven Car]

meven added a comment.


  The methods are straight copy-paste compared to KCoreConfigSkeleton.
  The binary compatiblity might be affected though so we might want to do it 
for KF6 only.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26361

To: meven, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:2d40d4f5f0f1: Remove endl in qDebug its already add 
\n at the end + port endl + flush when… (authored by mlaurent).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26301?vs=72594=72606

REVISION DETAIL
  https://phabricator.kde.org/D26301

AFFECTED FILES
  src/kbookmarkimporter_ns.cpp
  src/kbookmarkimporter_opera.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26302: Port endl to "\n" + flush at the end

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R298:f9e10975740d: Port endl to \n + flush at the 
end (authored by mlaurent).

REPOSITORY
  R298 KDesignerPlugin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26302?vs=72593=72604

REVISION DETAIL
  https://phabricator.kde.org/D26302

AFFECTED FILES
  src/kgendesignerplugin.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

[Méven Car]

meven created this revision.
meven added reviewers: ervin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26361

AFFECTED FILES
  src/kcmodule.cpp
  src/kcmodule.h
  src/kconfigdialogmanager.cpp
  src/kconfigdialogmanager.h

To: meven, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/47/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 02 Jan 2020 12:33:08 +
 Build duration:
56 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in kuitmarkup.cpp:412
> Why did you change [i] to at(i)?

According to the QList docs, at() should be used for read-only access, it could 
be faster than [] and it never causes a detach.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26360

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: apol, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26359: Port QRegExp to QRegularExpression

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:ab6743ffc5f3: Port QRegExp to QRegularExpression 
(authored by ahmadsamir).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26359?vs=72598=72603

REVISION DETAIL
  https://phabricator.kde.org/D26359

AFFECTED FILES
  src/kpackage/private/packagejobthread.cpp

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kuitmarkup.cpp:412
>  // Normalize key, trim and all lower-case.
> -QString nkey = keys[i].trimmed().toLower();
> +const QString nkey = keys.at(i).trimmed().toLower();
>  keys[i] = keyNames.contains(nkey) ? 
> keyNames[nkey].toString(languages)

Why did you change [i] to at(i)?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26360

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: apol, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26359: Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26359

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26358: KIO/SMB convert kio protocol declaration to json format

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kio_smb.cpp:42
> +Q_OBJECT
> +Q_PLUGIN_METADATA(IID "org.kde.kio.slave.smb" FILE "smb.json")
> +};

Shouldn't this go in the SMBSlave class?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26358

To: meven, #frameworks, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26301

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26302: Port endl to "\n" + flush at the end

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26302

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26277: KFilePlaceEditDialog: move logic into isIconEditable()

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26277

To: elvisangelaccio, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Port KuitStaticData::toKeyCombo() and KuitStaticData::toInterfacePath()
  to QRegularExpression.

TEST PLAN
  make && ctest

REPOSITORY
  R249 KI18n

BRANCH
  l-toKeyCombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26360

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven added a comment.


  In D17595#580655 , @ngraham wrote:
  
  > Awesome. Does this need a rebase?
  
  
  It should not, the API has not changed and this is new code.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, 
dhaumann, pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26191: Add support for FileJob->truncate() in smb/sftp slaves

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.

INLINE COMMENTS

> kio_sftp.cpp:1478
> +void sftpProtocol::truncate(KIO::filesize_t length) {
> +qCDebug(KIO_SFTP_LOG) << "truncate, length = " << length;
> +

[minor: qDebug already appends spaces between arguments, so you get two here 
after the '=']

> kio_sftp.cpp:1497
> +if (errorCode) {
> +errorCode = errorCode == KIO::ERR_INTERNAL ? 
> KIO::ERR_CANNOT_TRUNCATE : errorCode;
> +error(errorCode, mOpenUrl.path());

self-assignment in some cases is a weird thing to do.
Why not if (errorCode==..) { errorCode = ..; } ?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D26191

To: feverfew, sitter, dfaure, fvogt
Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D25673: Deprecate KServiceTypeProfile

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R309 KService

BRANCH
  arcpatch-D25673

REVISION DETAIL
  https://phabricator.kde.org/D25673

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23384_1

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, 
LeGast00n, GB_2, michaelh, bruns

D26331: Removed reading description from desktop files

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I looked into the git/svn history and this actually is from before my time 
(lol), and a remnant of the fact that in the initial design by Torben, desktop 
files were a kmimetype-subclass which reimplemented a virtual method to read 
the description from the desktop file. I don't think there was any real thought 
being that, more of an object-orientation accident. I'm fine with this going 
away.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

[David Faure]

dfaure renamed this task from "KService: Look application that still use 
KService for plugins" to "KService: provide solution to migrate away from 
KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts".
dfaure updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T12173

To: dfaure
Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ahmadsamir, 
ngraham, kpiwowarski, asturmlechner, jucato, cfeck, cullmann, vkrause, 
cordlandwehr, knauss

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

mlaurent added a comment.


  nm  -gDC libQt5Core.so.5.15.0 | grep endl
  00336680 T endl(QTextStream&)
  00336500 T QTextStreamFunctions::endl(QTextStream&)
  003361e0 T Qt::endl(QTextStream&)

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns