D26600: Refator fstab handling

hallas added a comment. @meven - I am a little unsure if I have broken the fix you have done in commit c97f0b2a3076731b35435f200bd09a22859f3e03 - could you please check? I have not tested with NFS or SMB

D26600: Refator fstab handling

hallas created this revision. hallas added reviewers: Frameworks, bruns, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Refactor fstab handling Splits the fstab/mtab handling code into

D23682: Make use of KPluginMetaData where we can

kossebau added inline comments. INLINE COMMENTS > containmentactions.h:67 > > +#if PLASMA_ENABLE_DEPRECATED_SINCE(5, 64) > /** The visibility wrappers also need bumping to 5, 67, so the version were the API got deprecated, to not break things for people who use

D26595: Add network-wireless-hotspot icon

ngraham added a comment. Hmm, at normal size, the 8, 16, and 22px versions look too busy to me.: F7878586: Screenshot_20200111_220052.png For the 16 and 22px versions, maybe reduce the number of waves and increase the spacing between them. And

D22875: Offer toolTipDelay as a plasma unit

apol abandoned this revision. apol added a comment. This was eventually fixed in a different way REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22875 To: apol, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23586: Improve code that detects useful elements in an Svg file

apol updated this revision to Diff 73324. apol added a comment. address fregl's commetn REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23586?vs=65005=73324 BRANCH arcpatch-D23586 REVISION DETAIL https://phabricator.kde.org/D23586

D23586: Improve code that detects useful elements in an Svg file

apol marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23586 To: apol, #plasma, #frameworks Cc: gladhorn, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

This revision was automatically updated to reflect the committed changes. Closed by commit R242:591aceb3f926: Make use of KPluginMetaData where we can (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=73322=73323

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 73322. apol added a comment. Addressed kossebau's comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=68546=73322 BRANCH arcpatch-D23682 REVISION DETAIL

D23682: Make use of KPluginMetaData where we can

apol marked 8 inline comments as done. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma, mart Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26596: Drop unused dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R252:08b1eabe3f54: Drop unused dependency (authored by asturmlechner). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26596?vs=73318=73320 REVISION

D26597: Drop HAVE_X11 remnants

asturmlechner closed this revision. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D26597 To: asturmlechner, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26597: Drop HAVE_X11 remnants

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH no-have-x11 REVISION DETAIL https://phabricator.kde.org/D26597 To: asturmlechner, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26596: Drop unused dependency

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH unused-deps REVISION DETAIL https://phabricator.kde.org/D26596 To: asturmlechner, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26596: Drop unused dependency

asturmlechner created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. asturmlechner requested review of this revision. REPOSITORY R252 Framework Integration BRANCH unused-deps REVISION DETAIL https://phabricator.kde.org/D26596 AFFECTED

D26597: Drop HAVE_X11 remnants

asturmlechner created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. asturmlechner requested review of this revision. REPOSITORY R252 Framework Integration BRANCH no-have-x11 REVISION DETAIL https://phabricator.kde.org/D26597 AFFECTED

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.13 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.13/28/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 11 Jan 2020 20:05:44 + Build duration: 4 hr 11 min and counting JUnit Tests

D26594: Deprecate raiseWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R289:b5ba64a0545d: Deprecate raiseWidget (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26594?vs=73314=73317 REVISION DETAIL

D26594: Deprecate raiseWidget

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH raise REVISION DETAIL https://phabricator.kde.org/D26594 To: nicolasfella, #frameworks, broulik, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26588: Simplify usage of QMimeDatabase.

apol accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26588 To: dfaure, chinmoyr, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26595: Add network-wireless-hotspot icon

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26595 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26595: Add network-wireless-hotspot icon

cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH hotspot-icon (branched from master) REVISION DETAIL

D26594: Deprecate raiseWidget

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It is unused. Furthermore, it relies on QtWidgets API

D26588: Simplify usage of QMimeDatabase.

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26588 To: dfaure, chinmoyr, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. Looking at the review you it's a bis strange to see that I'v touched some test reference generated code, I did this only on *whitespace only changes* where the new whitespace made more sense than the old one. there is *one* bug I havent fixed on this code that I

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73310. tcanabrava added a comment. - Fix whitespace on the reference code / genreator REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73301=73310 BRANCH arcpatch-D26202 REVISION DETAIL

D26191: Add support for FileJob->truncate() in smb/sftp slaves

This revision was automatically updated to reflect the committed changes. Closed by commit R320:3bb841890e5a: Add support for FileJob-truncate() in smb/sftp slaves (authored by feverfew). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=73308=73309

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 73308. feverfew added a comment. - Merge branch 'master' into arcpatch-D26191 - adhere to protcol -> json switch REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=73306=73308 BRANCH arcpatch-D26191

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 73306. feverfew added a comment. Cleanup code according to comments REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72584=73306 BRANCH arcpatch-D26191 REVISION DETAIL

KDE CI: Frameworks » kparts » kf5-qt5 WindowsMSVCQt5.13 - Build # 42 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20WindowsMSVCQt5.13/42/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 11 Jan 2020 18:02:01 + Build duration: 3 hr 21 min and counting JUnit Tests Name:

D26484: Add KIO::DelayPopup flag and DropJob::menuPopup()

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I agree with the approach. Just naming needs to be improved. I'd call the method "showMenu" or "showPopup". DelayPopup hints at a builtin timer, better call it something

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73301. tcanabrava added a comment. - More whiteespaces fixed - Fix *space only* issues with the test reference headers - More whitespace fixes, only six files to go - Way more tests passing - space fixes REPOSITORY R237 KConfig CHANGES SINCE

D26057: Deprecate the top-level IconSize() function

dfaure added a comment. Please port kdeclarative. kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not declared in this scope pixmap = QIcon::fromTheme(source.at(0)).pixmap(IconSize(KIconLoader::Desktop)); Detected by http://www.davidfaure.fr/2020/542.diff

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.13 - Build # 27 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.13/27/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 11 Jan 2020 17:59:30 + Build duration: 2 hr 2 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 53 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/53/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 11 Jan 2020 19:28:09 + Build duration: 33 min and counting JUnit Tests Name:

KDE CI: Frameworks » kxmlgui » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20FreeBSDQt5.13/76/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 19:28:08 + Build duration: 21 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kxmlrpcclient » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kxmlrpcclient/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 19:28:07 + Build duration: 20 min and counting JUnit Tests Name:

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 19:28:05 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 270 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/270/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 11 Jan 2020 18:00:15 + Build duration: 1 hr 47 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 52 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/52/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 11 Jan 2020 18:03:37 + Build duration: 1 hr 44 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 54 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/54/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 11 Jan 2020 18:03:55 + Build duration: 1 hr 43 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 140 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/140/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 19:28:04 + Build duration: 18 min and counting JUnit Tests Name:

D26588: Simplify usage of QMimeDatabase.

dfaure created this revision. dfaure added a reviewer: chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY suffixForFileName is case insensitive, no need to lowercase the path. Also no

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73292. tcanabrava added a comment. - Fix many small whitespace issues REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73290=73292 BRANCH arcpatch-D26202 REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/95/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 11 Jan 2020 17:57:39 + Build duration: 1 hr 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/55/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:05:25 + Build duration: 1 hr 3 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 139 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/139/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:04:50 + Build duration: 1 hr 0 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 52 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/52/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 11 Jan 2020 17:55:58 + Build duration: 1 hr 9 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kxmlrpcclient » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kxmlrpcclient/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:04:09 + Build duration: 1 hr 0 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:04:34 + Build duration: 1 hr 0 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kxmlgui » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20FreeBSDQt5.13/75/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:04:02 + Build duration: 1 hr 0 min and counting CONSOLE OUTPUT Started by

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 161 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/161/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Jan 2020 18:05:04 + Build duration: 58 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 164 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/164/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:03:02 + Build duration: 57 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/46/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:03:37 + Build duration: 54 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 262 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/262/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:00:15 + Build duration: 47 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/43/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 11 Jan 2020 17:56:48 + Build duration: 50 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:02:27 + Build duration: 42 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/50/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:01:50 + Build duration: 39 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/55/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 17:58:14 + Build duration: 29 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/34/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 17:58:29 + Build duration: 27 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/67/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 17:57:59 + Build duration: 26 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 90 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/90/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 17:57:39 + Build duration: 25 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/47/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 17:56:50 + Build duration: 21 min and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/87/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 11 Jan 2020 17:55:58 + Build duration: 17 min and counting JUnit Tests Name:

D24401: Use exposed DBus methods to switch activities in CLI

muesli added a comment. @ivan Do you think we can merge this now? REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D24401 To: muesli, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73290. tcanabrava added a comment. - Rebase on master REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=72715=73290 BRANCH arcpatch-D26202 REVISION DETAIL https://phabricator.kde.org/D26202 AFFECTED

D23420: Use solid to check if a KFileItem is located on a network mount

meven abandoned this revision. meven added a comment. Abandoned in favor of D26407 using KMountPoint which does close to the same thing as solid. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73282. meven marked 2 inline comments as done. meven added a comment. Move static variables to KFileItemPrivate::getMountPoints REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73261=73282 BRANCH arcpatch-D26407

D26484: Add KIO::DelayPopup flag and DropJob::menuPopup()

trmdi marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26484: Add KIO::DelayPopup flag and DropJob::menuPopup()

trmdi retitled this revision from "Popup menu again to reposition it" to "Add KIO::DelayPopup flag and DropJob::menuPopup()". trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson,

D26484: Popup menu again to reposition it

trmdi updated this revision to Diff 73273. trmdi added a comment. - use the flag approach and add DropJob::menuPopup() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73175=73273 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484

D26484: Popup menu again to reposition it

trmdi added inline comments. INLINE COMMENTS > elvisangelaccio wrote in dropjob.cpp:415 > `QCursor::pos()` should be avoided as it's not reliable on wayland. > > The whole "popup() again" here looks like a workaround to me. Can't this be > fixed on the plasma side? > Can't this be fixed on

D26484: Popup menu again to reposition it

trmdi added inline comments. INLINE COMMENTS > elvisangelaccio wrote in dropjob.cpp:415 > `QCursor::pos()` should be avoided as it's not reliable on wayland. > > The whole "popup() again" here looks like a workaround to me. Can't this be > fixed on the plasma side? I'm having a plan to make

D26484: Popup menu again to reposition it

elvisangelaccio added inline comments. INLINE COMMENTS > dropjob.cpp:415 > +// popup again to update position. BUG: 415917 > +menu->popup(window ? window->mapToGlobal(m_relativePos) : > QCursor::pos()); > } `QCursor::pos()` should be avoided as it's not reliable on

D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again

This revision was automatically updated to reflect the committed changes. Closed by commit R263:6f08f7ae576a: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D26484: Popup menu again to reposition it

trmdi added a comment. In D26484#591782 , @dfaure wrote: > Sorry I have no idea about the calling side in plasma. It sounds buggy indeed, if those are all calls on the same DropJob instance. Yes, you could check it here:

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven retitled this revision from "KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs" to "KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow

D26532: Don't use KWindowSystem on Android

dfaure accepted this revision. dfaure added a comment. I agree with the reasoning, we can break BC on Android. REPOSITORY R289 KNotifications BRANCH nokwindowsystem REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella, #frameworks, vkrause, apol, dfaure Cc: dfaure,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven updated this revision to Diff 73261. meven added a comment. remove a commo in comment, fix @since version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73260=73261 BRANCH arcpatch-D26407 REVISION DETAIL https://phabricator.kde.org/D26407

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven updated this revision to Diff 73260. meven marked an inline comment as done. meven added a comment. And KMountPoint::List::findByPathDirectly to check mount point without resolving symlinks REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26159: Drop KWindowSystem dependency

davidedmundson added a comment. There's a big difference between "I want to raise my window" and I "I want to raise $random window". We don't need to use this kwindowsystem api for the former, but kwin and plasma's task manager still need to use the latter. REPOSITORY R310

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

dfaure added a comment. Right, from a performance point of view, I believe this code was flushing far too much. In fact even now those calls to flush() are all unnecessary. Just one flush before closing the file is enough to be sure, or even without it, it will work (socket notifier says

D26487: [Kuit] Revert changes in parseUiMarker()

This revision was automatically updated to reflect the committed changes. Closed by commit R249:fff18126b973: [Kuit] Revert changes in parseUiMarker() (authored by ahmadsamir). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26487?vs=72955=73251 REVISION DETAIL

D26159: Drop KWindowSystem dependency

dfaure added a comment. Why isn't KWindowSystem::activateWindow deprecated then? Because of the `time` argument? REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D26159 To: davidedmundson, apol Cc: dfaure, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2,

D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH catchdockwidgetsshowninstate REVISION DETAIL https://phabricator.kde.org/D26501 To: kossebau, #frameworks, #kdevelop, dfaure Cc: SGOrava, kde-frameworks-devel, LeGast00n, GB_2,

D26484: Popup menu again to reposition it

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Sorry I have no idea about the calling side in plasma. It sounds buggy indeed, if those are all calls on the same DropJob instance. INLINE COMMENTS > dropjob.cpp:409 >

D26487: [Kuit] Revert changes in parseUiMarker()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH l-parseMarkup (branched from master) REVISION DETAIL https://phabricator.kde.org/D26487 To: ahmadsamir, #frameworks, ilic, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26448: Add KRecentFilesMenu to replace KRecentFileAction

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krecentfilesmenu.cpp:99 > +setIcon(QIcon::fromTheme(QStringLiteral("document-open-recent"))); > +const QString fileName = >

D25877: [KColorschemeManager] Add option to reenable following global theme

asemke added a comment. +1 REPOSITORY R265 KConfigWidgets BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks, ngraham Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns