D26604: Check if there is an activatable service when notification service owner changes

broulik added a comment. What again was the reason for not just sending a notification where DBus activation will do its thing? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26604 To: nicolasfella, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73367. ahmadsamir added a comment. - Rebase\n- Move second match inside if condition, otherwise the control flow never passes through the next else if branch REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=720

D26614: Remove extra flush when we close file it will flush

mlaurent added a reviewer: dfaure. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26614 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26614: Remove extra flush when we close file it will flush

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Remove extra flush REPOSITORY R269 BluezQt BRANCH remove_extra_flush (branched from master) REVISION DETAIL h

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi updated this revision to Diff 73364. trmdi added a comment. - Typo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73363&id=73364 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src/widgets/dropjob.cpp sr

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi updated this revision to Diff 73363. trmdi added a comment. - Improve comment/doc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73337&id=73363 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src/widgets/d

Re: KApplicationTrader API

El diumenge, 12 de gener de 2020, a les 11:50:03 CET, David Faure va escriure: > I wrote a KApplicationTrader class in https://phabricator.kde.org/D25698 > and I need input on API. > > Use case: the user types "km" in krunner. > In order to find all applications that contain "km" (case insensitive

Re: KApplicationTrader API

> auto filter = [](const KService::Ptr &service) { return > service->name().contains("km", Qt::CaseInsensitive); } auto offers = > KApplicationTrader::self()->query(filter); I'd vote for lambda/function object/callable (hello std::invoke in KF6?). If a more terse syntax is needed, it could be lat

D26484: Add KIO::DropJobFlag to allow manually showing the menu

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Almost there. Please add @since 5.67 to the new enum and the new methods. INLINE COMMENTS > dfaure wrote in dropjob.cpp:416 > This '{' goes on its own line. Not fixed. > dr

D26457: Introduce shadows API

zzag retitled this revision from "Introduce shadow API" to "Introduce shadows API". REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D26457 To: zzag, #kwin Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26457: Introduce shadow API

zzag updated this revision to Diff 73352. zzag added a comment. - Make KWindowShadow a QObject subclass (for memory management) - Clarify that it is okay to call destroy() after window() had been removed - Check whether QWindow has QPlatformWindow associated with it REPOSITORY R278 KWind

D26607: Fix build on Windows

vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26607 AFFECTED FILES tests/kioslavetest.cpp To:

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. @dfaure , @ervin Right now the code passes all the tests and I tried to be extra careful not to break away with the general architecture. I think it's the first "safe" version to review. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73345. tcanabrava added a comment. - Fix bug ediging param variable that's supposed to be const - Const Correctness: REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73336&id=73345 BRANCH arcpatch-D26202

D26532: Don't use KWindowSystem on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R289:33742dde2f73: Don't use KWindowSystem on Android (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26532?vs=73095&id=73343 REVISION

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella added a dependent revision: D26605: Remove fallback to KPassivePopup. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26604 To: nicolasfella, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26605: Remove fallback to KPassivePopup

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY KNotifications has proper support for all major platforms (

D25517: Add an option to extract image data and add front cover property

astippich marked 2 inline comments as done. astippich added a comment. In D25517#588029 , @bruns wrote: > The problem is the extractor serves two different use cases: > > - retrieval for searching/caching properties > - on-demand extraction

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella updated this revision to Diff 73340. nicolasfella added a comment. - Move code REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26604?vs=73338&id=73340 BRANCH checkactivatable REVISION DETAIL https://phabricator.kde.org/D26604 AFFEC

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY At notification backend initialization we don't just check whet

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi retitled this revision from "Add KIO::DropJobFlag flag and DropJob::menuPopup()" to "Add KIO::DropJobFlag to allow manually showing the menu". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure

D26484: Add KIO::DropJobFlag flag and DropJob::menuPopup()

trmdi retitled this revision from "Add KIO::DelayPopup flag and DropJob::menuPopup()" to "Add KIO::DropJobFlag flag and DropJob::menuPopup()". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngr

D26484: Add KIO::DelayPopup flag and DropJob::menuPopup()

trmdi updated this revision to Diff 73337. trmdi added a comment. - Move the flag to DropJob header, rename REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73273&id=73337 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED F

D26202: WIP: Refactor KConfigXT

tcanabrava marked 8 inline comments as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava added inline comments. INLINE COMMENTS > tcanabrava wrote in kconfig_compiler.cpp:753 > that was a bit harder than I want, but done. Inside of the code generation > there was code that manipulated the ParseResult. I think this is one of the > good spots that show that this rewrite is

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73336. tcanabrava marked 4 inline comments as done. tcanabrava added a comment. - Rename KConfigCodeGenerator to KconfigCodeGeneratorBase - Simplify diff file saving - Add License Headers - Documentation, Privatization, Unused method / variable -

D26202: WIP: Refactor KConfigXT

tcanabrava marked 22 inline comments as done. tcanabrava added inline comments. INLINE COMMENTS > dfaure wrote in kconfigcompiler_test.cpp:129 > Why did you remove this? It's just a more user-friendly version of the > QVERIFY on the next line, so it can't possibly have failed while the next > l

D25660: Decouple KBookmarksMenu from KActionCollection

kossebau added a comment. Some API (docs) nitpicks :) INLINE COMMENTS > kbookmarkmenu.cpp:88 > +m_parentMenu(_parentMenu), > +m_parentAddress(QLatin1String("")) //TODO KBookmarkAdress::root > +{ Why the `QLatin1String("")` instead of QString()? Is there a need for a non-null empty

KDE CI: Frameworks » kglobalaccel » kf5-qt5 WindowsMSVCQt5.13 - Build # 35 - Failure!

ameworks/kglobalaccel/kf5-qt5 WindowsMSVCQt5.13/build/DartConfiguration.tcl[2020-01-12T12:14:50.514Z]Site: [2020-01-12T12:14:50.514Z]Build name: (empty)[2020-01-12T12:14:50.514Z] Create new tag: 20200112-1214 - Experimental[2020-01-12T12:14:50.514Z] Cannot find file: C:/CI/workspace/Fr

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 96 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/96/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 12 Jan 2020 11:32:09 + Build duration: 31 min and counting BUILD ARTIFACTS abi-compatibility-re

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 41 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/41/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 12 Jan 2020 11:30:42 + Build duration: 28 min and counting JUnit Tests Name: proj

D25660: Decouple KBookmarksMenu from KActionCollection

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks for the patch. Please call setObjectName() on the actions so that their object name is fixed (no matter which ctor is used). (this is because KActionCollection::addAct

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 165 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/165/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 12 Jan 2020 11:33:44 + Build duration: 22 min and counting JUnit Tests Name: projectr

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 12 Jan 2020 11:46:44 + Build duration: 5 min 20 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/51/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 12 Jan 2020 11:32:49 + Build duration: 15 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 12 Jan 2020 11:31:34 + Build duration: 13 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 12 Jan 2020 11:31:20 + Build duration: 12 min and counting JUnit Tests Name: projectroot Fa

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 265 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/265/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 12 Jan 2020 11:23:45 + Build duration: 9 min 47 sec and counting JUnit Tests Name: projectro

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven added inline comments. INLINE COMMENTS > dfaure wrote in desktopexecparser.cpp:213 > Move result of method call into local const variable. The usual > range-for-detaches problem. > > Can you call mimeTypes() instead of serviceTypes() here? I'm trying to slowly > split the two notions, af

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/69/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 12 Jan 2020 11:27:42 + Build duration: 4 min 43 sec and counting JUnit Tests Name: p

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please add me as reviewer when touching my code in KIO. I almost didn't notice this one. INLINE COMMENTS > desktopexecparser.cpp:213 > +// add x-scheme-handler/ > +for (c

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 44 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/44/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 12 Jan 2020 10:54:03 + Build duration: 28 min and counting JUnit Tests Name: p

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/68/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 12 Jan 2020 11:04:31 + Build duration: 1 min 58 sec and counting JUnit Tests Name: p

D26603: Port away from deprecated IconSize() method

This revision was automatically updated to reflect the committed changes. Closed by commit R296:3489a1d049fb: Port away from deprecated IconSize() method (authored by vkrause). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26603?vs=73332&id=7 REVISI

D26603: Port away from deprecated IconSize() method

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, simpler than I thought. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D26603 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB

D26057: Deprecate the top-level IconSize() function

vkrause added a comment. In D26057#592147 , @dfaure wrote: > Please port kdeclarative. > > kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not declared in this scope > > pixmap = QIcon::fromTheme(source.at(0)).pixma

D26603: Port away from deprecated IconSize() method

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D26603 AF

D26564: Clean kbuildsycoca4 support

dfaure added a comment. Code added by Eike Hein in commit ee5303a337876914 , let's get his input. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26564 To: meven, ervin, #frameworks, hein Cc: df

D26564: Clean kbuildsycoca4 support

dfaure added a reviewer: hein. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26564 To: meven, ervin, #frameworks, hein Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KApplicationTrader API

I wrote a KApplicationTrader class in https://phabricator.kde.org/D25698 and I need input on API. Use case: the user types "km" in krunner. In order to find all applications that contain "km" (case insensitive), do we want to write auto offers = KApplicationTrader::self()->query("'km' ~~ Name");

D26595: Add network-wireless-hotspot icon

ndavis added a comment. In D26595#592368 , @ngraham wrote: > Hmm, at normal size, the 8, 16, and 22px versions look too busy to me.: I kind of agree. > For the 16 and 22px versions, maybe reduce the number of waves and increase the s

D26602: Define K_DOXYGEN as macro to check if kapidox/doxygen is run

kossebau added a comment. Some similar macro definitions used by other projects, as I found by doing some random grepping over my system includes: - `__GTK_DOC_IGNORE__` - `Q_QDOC` & `Q_CLANG_QDOC` - `DO_NOT_DOCUMENT` - `EIGEN_PARSED_BY_DOXYGEN` - `DOXYGEN` - `U_IN_DOXYGEN` -

D26602: Define K_DOXYGEN as macro to check if kapidox/doxygen is run

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Currently kapidox uses the macro DOXYGEN_SHOULD_S

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > meven wrote in kfileitem.cpp:787 > I did not mean to avoid android, just surfaced the comment in > KMountPoint::currentMountPoints regarding its limitation to

D26202: WIP: Refactor KConfigXT

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kconfigcompiler_test.cpp:129 > -// use split('\n') to avoid > -// the whole output shown inline > -QCOMPARE(content.split('\n'), contentRef.split('

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 264 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/264/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 12 Jan 2020 10:05:57 + Build duration: 9 min 47 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 263 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/263/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 12 Jan 2020 09:56:46 + Build duration: 8 min 59 sec and counting JUnit Tests Name: projectro

D26588: Simplify usage of QMimeDatabase.

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26588 To: dfaure, chinmoyr, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns