D26703: Add icon for text/vnd.kde.kcrash-report

broulik closed this revision. broulik added a comment. https://cgit.kde.org/breeze-icons.git/commit/?id=22286e6a67a1e46c3022d76bb2a2daf73438d646 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26703 To: broulik, #vdg, ndavis Cc: kde-frameworks-devel,

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 89 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/89/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 07:41:33 + Build duration: 3 min 13 sec and counting JUnit Tests

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kcoredirlister.cpp:2306 > I think you said this would anchor twice, in another review? Needs to be > fixed then. > > (Good for readability!) Right. (I searched through all the porting commits, I missed this one as it hasn't

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 63 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/63/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 17 Jan 2020 06:28:33 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.13 - Build # 50 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.13/50/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 06:28:33 + Build duration: 4 min 22 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 407 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/407/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Jan 2020 06:00:51 + Build duration: 15 min and counting BUILD ARTIFACTS

Re: Updating our coding conventions and coding style for C++11

Am Donnerstag, 16. Januar 2020, 23:27:57 CET schrieb David Faure: > On jeudi 16 janvier 2020 18:29:11 CET Vlad Zahorodnii wrote: > > I would like us to copy Qt's policy [1] for consistency: > OK, please do. +1, thanks for the initiative, Vlad. > Kai-Uwe wrote: > > for "auto" I think we should

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 274 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/274/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 17 Jan 2020 06:04:18 + Build duration: 7 min 27 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 273 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/273/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 17 Jan 2020 05:38:27 + Build duration: 25 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 251 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/251/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 05:55:18 + Build duration: 7 min 19 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 406 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/406/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Jan 2020 05:38:27 + Build duration: 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 250 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/250/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 05:38:27 + Build duration: 9 min 37 sec and counting CONSOLE OUTPUT

D26713: Adapt to Qt 5.14 Android changes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26713 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26440: Add KSharedConfig::openStateConfig for storing state information

ngraham added a task: T12549: Remove cache data from config files. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26440 To: nicolasfella, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Updating our coding conventions and coding style for C++11

On Thursday 16 Jan 2020 18:46:06 Kai Uwe Broulik wrote: > Hi, > > for "auto" I think we should always annotate it with const, *, and/or & > where appropriate: > > auto *something = new MyCustomType; > auto *keyEvent = static_cast(event); > const auto myList =

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kmountpoint.cpp:438 > +QStringList splitted = path.split(QDir::separator()); > +splitted.pop_back(); > +QString parentPath; Hmm, what

D26677: Port away from KLineEdit and KComboBox to Q equivalent

gassaf edited reviewers, added: Frameworks; removed: kde-frameworks-devel. REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D26677 To: gassaf, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

dfaure added a comment. Thanks for looking into this, I'm glad that finally someone does dig into this code. I'm a bit surprised by the solution though. The spec simply says - add any "Default Applications" and then "Added Associations" in the first mimeapps.list This doesn't

Re: Updating our coding conventions and coding style for C++11

Well, the * is completely redundant in those cases, so it doesn't bring anything. I'd be tempted to say, let's not require it. But then it raises the question of consistency (without a guideline, we'll have some places with * and some places without *). It provides useful visual

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-qregularexpression-too-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D26692 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n,

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoredirlister.cpp:2306 > +d->settings.lstFilters.append(QRegularExpression( > + >

Re: Updating our coding conventions and coding style for C++11

On jeudi 16 janvier 2020 18:29:11 CET Vlad Zahorodnii wrote: > I would like us to copy Qt's policy [1] for consistency: OK, please do. > for (a:b) +1 Kai-Uwe wrote: > for "auto" I think we should always annotate it with const, *, and/or & > where appropriate: > auto *something = new

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 WindowsMSVCQt5.13 - Build # 49 - Failure!

0-01-16T19:24:09.457Z]Build name: (empty)[2020-01-16T19:24:09.457Z] Create new tag: 20200116-1924 - Experimental[2020-01-16T19:24:09.457Z] Cannot find file: C:/CI/workspace/Frameworks/kconfigwidgets/kf5-qt5 WindowsMSVCQt5.13/build/DartConfiguration.tcl[2020-01-16T19:24:09.457Z] Test project C:

D25877: [KColorschemeManager] Add option to reenable following global theme

This revision was automatically updated to reflect the committed changes. Closed by commit R265:a9e1079eba40: [KColorschemeManager] Add option to reenable following global theme (authored by davidre). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D26670: ki18n_wrap_ui: error when file doesn't exist

cullmann added inline comments. INLINE COMMENTS > kossebau wrote in KF5I18nMacros.cmake.in:52 > This assumes a relative path given. It might make sense to also deal with > absolute path, and only append CMAKE_CURRENT_LIST_DIR if not absolute, then > check for existance? Some lines below we

D26457: Introduce shadows API

zzag updated this revision to Diff 73733. zzag added a comment. Update doc. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=73728=73733 BRANCH kwindowshadow REVISION DETAIL https://phabricator.kde.org/D26457 AFFECTED FILES

KDE CI: Frameworks » kwallet » kf5-qt5 WindowsMSVCQt5.13 - Build # 36 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20WindowsMSVCQt5.13/36/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 16 Jan 2020 18:04:59 + Build duration: 3 min 6 sec and counting JUnit Tests Name:

D26707: Fix QRegularExpression::wildcardToRegularExpression() usage

This revision was automatically updated to reflect the committed changes. Closed by commit R311:d4980443755f: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE

D26457: Introduce shadows API

zzag updated this revision to Diff 73728. zzag added a comment. No `noexcept` `noexcept` is a very rare thing to see in KF code so let's not deviate too much. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=73352=73728 BRANCH

D26713: Adapt to Qt 5.14 Android changes

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY - Library names now have the ABI as a suffix, dependency files need to follow that. - The Gradle version shipped

Re: Updating our coding conventions and coding style for C++11

Hi, for "auto" I think we should always annotate it with const, *, and/or & where appropriate: auto *something = new MyCustomType; auto *keyEvent = static_cast(event); const auto myList = QStringList({QLatin1String("FooThing"), QLatin1String("BarThing")}); auto = foo[bar]; The common

Updating our coding conventions and coding style for C++11

Hi, I would like to update our coding conventions https://community.kde.org/Policies/Library_Code_Policy. The auto keyword is not mentioned leading to it being a common point of contention in reviews as we can't point to a reference. I would like us to copy Qt's policy [1] for consistency:

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 WindowsMSVCQt5.13 - Build # 48 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20WindowsMSVCQt5.13/48/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 16 Jan 2020 17:17:51 + Build duration: 4 min 59 sec and counting CONSOLE

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 128 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/128/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 16 Jan 2020 17:06:30 + Build duration: 14 min and counting JUnit Tests Name:

D26205: KWallet: Port QRegExp to QRegularExpression

blaze added a comment. In D26205#595428 , @ahmadsamir wrote: > I still fail to see what's broken, I tested with the system kwallet (5.65 on tumbleweed) and I don't see any difference between it and a build from a git checkout; i.e. falkon

D26648: Improved quality of JPEG thumbnails

ngraham added a comment. Very nice first patch. May it be the first of many! :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg, cfeck, ngraham Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel,

D26648: Improved quality of JPEG thumbnails

This revision was automatically updated to reflect the committed changes. Closed by commit R320:b18be2ed1a80: Improved quality of JPEG thumbnails (authored by chroniceel, committed by ngraham). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D26648: Improved quality of JPEG thumbnails

ngraham added a comment. no in a comment is fine REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg, cfeck, ngraham Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio,

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. wktradew...@gmail.com ... unless you wanted that in the summary? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg, cfeck, ngraham Cc: meven, volkov, cfeck, bruns, ngraham,

D26648: Improved quality of JPEG thumbnails

ngraham accepted this revision. ngraham added a comment. @chroniceel Can you provid an email address so we can land this patch with correct authorship information? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg,

D26648: Improved quality of JPEG thumbnails

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Thanks for the detailed investigation, Stefan! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg, cfeck Cc: meven,

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. Updated diff. It's setting the quality now, and added a brief comment. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel,

D26648: Improved quality of JPEG thumbnails

chroniceel updated this revision to Diff 73722. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26648?vs=73480=73722 REVISION DETAIL https://phabricator.kde.org/D26648 AFFECTED FILES thumbnail/jpegcreator.cpp To: chroniceel, broulik, #frameworks, #vdg

D26707: Fix QRegularExpression::wildcardToRegularExpression() usage

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH l-qregularexpression-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D26707 To: ahmadsamir, #frameworks, apol, dfaure Cc: kde-frameworks-devel,

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 127 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/127/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 16 Jan 2020 16:28:38 + Build duration: 12 min and counting CONSOLE OUTPUT

D26691: Optimize code when dropping files into the desktop

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. m_dropActions is conceptually linked to the menu we are showing It shouldn't a direct member variable of ContainmentInterface If we're following the existing

D26704: KateMessageWidget: remove unused event filter installation

This revision was automatically updated to reflect the committed changes. Closed by commit R39:9499d28ba80b: KateMessageWidget: remove unused event filter installation (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D26648: Improved quality of JPEG thumbnails

bruns added a comment. Having had a look at https://code.woboq.org/qt5/qtbase/src/plugins/imageformats/jpeg/qjpeghandler.cpp.html#_M/HIGH_QUALITY_THRESHOLD, the jpeg handler actually know two different quality settings, `< 50` and `> 50`, the default being 75, i.e. high. High quality

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 73716. trmdi added a comment. - Change the cursor to the busy state when the first file is not local REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=73694=73716 BRANCH improve-file-drop-menu

D26704: KateMessageWidget: remove unused event filter installation

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess this change is correct :-) REPOSITORY R39 KTextEditor BRANCH removeunusedeventfilter REVISION DETAIL https://phabricator.kde.org/D26704 To: kossebau, dhaumann Cc:

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. Ping! I think this got buried. Unless someone else is testing this? REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio,

D26703: Add icon for text/vnd.kde.kcrash-report

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26703 To: broulik, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25682: add initial wsdiscovery support

sitter updated this revision to Diff 73704. sitter added a comment. redesign finish system it occured to me that the blocking nature of the finish system is entirely pointless. we already have an eventloop running anyway, so all we need to do is track whether all entities have been

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26205#595111 , @blaze wrote: > > otherwise, we could just revert this patch > > The rest of the code is OK. The part that works funny is just the wildcard method, and since it's relatively new, I hope there

D26707: Fix QRegularExpression::wildcardToRegularExpression() usage

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY It turns out that QRegularExpression::wildcardToRegularExpression() returns an anchored (with \A and \z)

D26085: KCModuleQml: Ensure defaulted is emitted with the current configModule->representsDefaults on load

This revision was automatically updated to reflect the committed changes. Closed by commit R295:abd2e496efaa: KCModuleQml: Ensure defaulted is emitted with the current configModule… (authored by meven). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

This revision was automatically updated to reflect the committed changes. Closed by commit R304:198e589d5df5: Unbreak the KNSQuick::Engine::changedEntries functionality (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir updated this revision to Diff 73698. leinir added a comment. Some housekeeping (rebase on master) - Actually update the entry when it's updated, don't just ignore it - As 5.66 was released, update @since to 5.67 - Actually use the correct type for the list property REPOSITORY

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir added a comment. In D26543#595374 , @davidedmundson wrote: > Given timeframes and where we've ended up. Accepted. Thanks! :) > I would like to see some KF6 workboard tasks for the future. That would be a good idea, yup.

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Given timeframes and where we've ended up. Accepted. I would like to see some KF6 workboard tasks for the future. QVariantList + QGadget should work, though that does

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 272 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/272/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 12:56:29 + Build duration: 23 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 280 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/280/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 16 Jan 2020 12:56:29 + Build duration: 19 min and counting BUILD ARTIFACTS

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir added a comment. In D26543#595368 , @davidedmundson wrote: > I've gone through this again, and I'm somewhat confused. > Entry (via EntryWrapper) doesn't seem usable by QML. It doesn't have any properties. > > If it's just proxying

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

davidedmundson added a comment. I've gone through this again, and I'm somewhat confused. Entry (via EntryWrapper) doesn't seem usable by QML. It doesn't have any properties. If it's just proxying through QML to other C++, then QVariant should be fine, no need for a custom box type no

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 73694. trmdi marked an inline comment as done. trmdi added a comment. - Remove unneeded code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=73693=73694 BRANCH improve-file-drop-menu

D26691: Optimize code when dropping files into the desktop

trmdi marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 73693. trmdi added a comment. - Remove unneeded code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=73634=73693 BRANCH improve-file-drop-menu REVISION DETAIL

D26691: Optimize code when dropping files into the desktop

trmdi added reviewers: broulik, VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26602: Define K_DOXYGEN as macro to check if kapidox/doxygen is run

kossebau added a comment. No one any opinion? Guess most people have not run into the need to do pre-processor switches for the doc generation, and also never seen DOXYGEN_SHOULD_SKIP_THIS before. So would move forward with this on Thursday, 23rd January, if no-one objects until then.

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73690. meven added a comment. Fix poping .length() > 0 ordering REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73687=73690 BRANCH arcpatch-D26407 REVISION DETAIL https://phabricator.kde.org/D26407 AFFECTED

D26704: KateMessageWidget: remove unused event filter installation

kossebau created this revision. kossebau added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY Left-over from removal of event filter when this code was

D26202: WIP: Refactor KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R237:98c32e29f504: WIP: Refactor KConfigXT (authored by tcanabrava). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73608=73688 REVISION DETAIL

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven updated this revision to Diff 73687. meven marked an inline comment as done. meven added a comment. Check parent dir transitive symlinks, aka manual canonicalPath REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=73524=73687 BRANCH

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/92/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 09:31:31 + Build duration: 37 min and counting JUnit Tests Name:

D26594: Deprecate raiseWidget

kossebau added a comment. Hi. When introducing the deprecation macros to a lib with `ecm_generate_export_header`, one also needs to help kapidox & ecm_add_qch. Sadly this was only discovered later, so it is also missing from the first set of such commits introducing the use of

D26405: Add mime type for backtraces saved from DrKonqi

This revision was automatically updated to reflect the committed changes. Closed by commit R244:ae1fb551ce19: Add mime type for backtraces saved from DrKonqi (authored by broulik). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26405?vs=72716=73684

D26703: Add icon for text/vnd.kde.kcrash-report

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is for backtraces saved from DrKonqi TEST PLAN F7858683:

D26405: Add mime type for backtraces saved from DrKonqi

broulik added a comment. > there's also text/x-apport I just noticed that Breeze had an icon for that, I don't actually find it in mime info REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26405 To: broulik, #frameworks, sitter, mpyne Cc: mpyne,

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir added a comment. Thanks to David for making me look at that again, the original choice was based on a false-positive test INLINE COMMENTS > davidedmundson wrote in quickengine.h:54 > Why QObject here? > > One of the main advantages of using QQmlListProperty over QList is > that you

D26543: Unbreak the KNSQuick::Engine::changedEntries functionality

leinir updated this revision to Diff 73680. leinir marked an inline comment as done. leinir added a comment. - Actually use the correct type for the list property REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26543?vs=73408=73680 BRANCH

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven updated this revision to Diff 73679. meven added a comment. Update code to have a better implementation reusing existant API REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73633=73679 BRANCH master REVISION DETAIL

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven added a reviewer: Frameworks. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven retitled this revision from "[WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme" to "Make "Default Applications" in mimeapps.list the preferred applications". meven edited the summary of this revision. REPOSITORY R309 KService REVISION

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir added a comment. INLINE COMMENTS > blaze wrote in kwallet.cpp:180 > > The transformation is targeting file path globbing, which means in > > particular that path separators receive special treatment. > > I'm pretty sure the file path case is different from what we have here. > >

D26202: WIP: Refactor KConfigXT

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH arcpatch-D26202 REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D26690: [WIP] Add KMimeTypeTrader::defaultSchemaHandler to return default service associated with scheme

meven added a comment. In D26690#595221 , @dfaure wrote: > s/Schema/Scheme/ everywhere (method name, commit log) > > I want to deprecate KMimeTypeTrader, this should rather go into the upcoming KApplicationTrader D25698

D26693: Fix QRegularExpression::wildcardToRegularExpression() usage

This revision was automatically updated to reflect the committed changes. Closed by commit R495:ce27c7cf1121: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73676. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Add TODO KF6 notes to remove doNameFilter() and doMimeFilter() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26659?vs=73605=73676

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > meven wrote in kfileitem.cpp:787 > I meant this and this what KMountPoint does, better be precise here. I see. Sorry, I hadn't realized that there is a

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ahmadsamir wrote in kcoredirlister.h:595 > Thanks, fixed. Luckily it's a convenience function of sorts and replacing the > one instance it was used in

D26691: Optimize code when dropping files into the desktop

anthonyfieroni added inline comments. INLINE COMMENTS > containmentinterface.cpp:589 > +} > +qDebug() << "clearDataForMimeJob() ends."; > } Don't add uncategorized qDebug, i see it exists in code base but they should be ported as well. > containmentinterface.cpp:816-819 > +