KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/64/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 18 Jan 2020 07:39:35 + Build duration: 2 min 48 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/94/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 18 Jan 2020 07:17:41 + Build duration: 2 min 59 sec and counting JUnit Tests Name: pr

D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one

This revision was automatically updated to reflect the committed changes. Closed by commit R244:aa908f7b2006: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp… (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kd

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 73815. trmdi added a comment. - Add DropMenu class to combine choices/dropjobMenu - Only 1 menu can be created - Fix some possible memory leaks REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?v

D26737: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to QCborValue::fromCbor

This revision was automatically updated to reflect the committed changes. Closed by commit R495:c0bc818c744e: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to… (authored by mlaurent). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D26736: QHash::insertMulti is deprecated in qt5.15 => port to QMultiHash

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1e5966147de1: QHash::insertMulti is deprecated in qt5.15 => port to QMultiHash (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir updated this revision to Diff 73808. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Tweak commit message REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26734?vs=73786&id=73808 BRANCH l-fix (branched from master) R

D26735: [Components 3]Make slider tickmarks optional

gvgeo added a comment. My case would be solved with `stepCount > 1`. But AFAIK there are keyboards with 3-4 steps. F7889338: Screenshot_20200118_064621.png > Is there a way to achieve this with the existing qqc2 API? Not that I know. And need

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/93/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 18 Jan 2020 01:55:55 + Build duration: 2 min 8 sec and counting JUnit Tests Name: pro

D26742: Adding new exchangerate-api source for currencies

avaldes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. avaldes requested review of this revision. REPOSITORY R292 KUnitConversion BRANCH new-currencies REVISION DETAIL https://phabricator.kde.org/D26742 AFFECTED FILES src/curr

D26735: [Components 3]Make slider tickmarks optional

apol added a comment. You should only see them if you have very a few discrete number of steps. Can you show a screenshot of what you see that you don't like? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26735 To: gvgeo, #plasma, #vdg Cc: apol,

D26740: Add KService::isSubseq as a public API for filtering queries.

apol added a comment. Other than that, makes sense. INLINE COMMENTS > kservice.h:576 > + */ > +static bool isSubseq(const QString& pattern, const QString& text, > Qt::CaseSensitivity cs = Qt::CaseSensitive); > + Can we give it a better name? How about something like `isContained`? o

D26736: QHash::insertMulti is deprecated in qt5.15 => port to QMultiHash

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH use_multihash (branched from master) REVISION DETAIL https://phabricator.kde.org/D26736 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26737: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to QCborValue::fromCbor

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH port_to_QCborValue (branched from master) REVISION DETAIL https://phabricator.kde.org/D26737 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

aacid added inline comments. INLINE COMMENTS > kapplicationtrader.h:57 > + * > + * The @p constraint language is rather full. The most common > + * keywords are AND, OR, NOT, IN, and EXIST, all used in an all this "constraint" definition needs updating REVISION DETAIL https://pha

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

dfaure updated this revision to Diff 73800. dfaure added a comment. Remove self() Replace trader language with std::function Port tests to std::function, including KService::isSubSeq CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25698?vs=70787&id=73800 BRANCH kapplicationtrad

D26740: Add KService::isSubseq as a public API for filtering queries.

dfaure updated this revision to Diff 73798. dfaure added a comment. Add default value, much like QString::compare() REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26740?vs=73797&id=73798 BRANCH subseq REVISION DETAIL https://phabricator.kde.org/D2674

D26740: Add KService::isSubseq as a public API for filtering queries.

dfaure created this revision. dfaure added reviewers: michaeleden, aacid, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY The plan is to use a filter function in KApplicationTrader,

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73796. ahmadsamir added a comment. - Don't use anchoredPattern() with wilcardToRegularExpression() as the latter already returns an anchored pattern - Remove the bit about setNameFilter() from the commit message, wildcardToRegularExpression() should

D26735: [Components 3]Make slider tickmarks optional

davidedmundson added a comment. We've previously avoided adding any API to PC3 so it can be used as a Qqc2-style. Is there a way to achieve this with the existing qqc2 API? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26735 To: gvgeo, #pla

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir added a comment. See D26205 for details. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D26734 To: ahmadsamir, #frameworks, dfaure, apol Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre updated this revision to Diff 73793. davidre added a comment. arc diff so pending changes is reset REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26670?vs=73791&id=73793 BRANCH error (branched from master) REVISION DETAIL https://phabricator.kde

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre added a comment. Well it seems I forgot to create the test.ui file... F731: CMakeLists.txt Output: CMake Error at /home/david/kde/lib/x86_64-linux-gnu/cmake/KF5I18n/KF5I18nMacros.cmake:56 (message): Cannot find ui file:

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre planned changes to this revision. davidre added a comment. Doesn't seem right taking a closer look REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26670 To: davidre, #framework_syntax_highlighting, #localization, #build_system Cc: cullmann, ngraham, kossebau, k

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre added a comment. Output of cmake_minimum_required(VERSION 2.8.12) find_package(ECM) set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH}) find_package(Qt5Widgets) find_package(KF5I18n) ki18n_wrap_ui(var test.ui) ki18n_wrap_ui(var test.uia) ki1

D26737: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to QCborValue::fromCbor

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY QJsonDocument::fromBinaryData is deprecated in qt5.15 Port to QCborValue::fromCbor REPOSITORY R495 Purpose Library

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre updated this revision to Diff 73791. davidre added a comment. Don't change whitespace REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26670?vs=73790&id=73791 BRANCH error (branched from master) REVISION DETAIL https://phabricator.kde.org/D26670

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre updated this revision to Diff 73790. davidre added a comment. Remove debug message REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26670?vs=73788&id=73790 BRANCH error (branched from master) REVISION DETAIL https://phabricator.kde.org/D26670 AFF

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre marked 2 inline comments as done. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26670 To: davidre, #framework_syntax_highlighting, #localization, #build_system Cc: cullmann, ngraham, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26736: QHash::insertMulti is deprecated in qt5.15 => port to QMultiHash

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QMultiHash REPOSITORY R242 Plasma Framework (Library) BRANCH use_multihash (branched from master) REVIS

D26735: [Components 3]Make slider tickmarks optional

gvgeo retitled this revision from "[Components 3]Make Slider tickmarks optional" to "[Components 3]Make slider tickmarks optional". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26735 To: gvgeo, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_

D26670: ki18n_wrap_ui: error when file doesn't exist

davidre updated this revision to Diff 73788. davidre added a comment. So much easier, thanks Christoph REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26670?vs=73564&id=73788 BRANCH error (branched from master) REVISION DETAIL https://phabricator.kde.org

D26735: [Components 3]Make Slider tickmarks optional

gvgeo added a comment. Added to disable tickmarks, in battery's keyboard brightness control. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26735 To: gvgeo, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26735: [Components 3]Make Slider tickmarks optional

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gvgeo requested review of this revision. REVISION SUMMARY Add tickmarksEnabled variable. TEST PLAN Test with `tickmarksEnabled: false` REPOSIT

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir updated this revision to Diff 73786. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Tweak commit message and test plan REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir added a comment. Another way to fix the issue, would be to pass an empty QString as the first argument to readEntryList(), in which case readEntryList() returns all the entries, and to change the behaviour of readEntryList to use a full-fledged regex pattern to use instead of supp

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The issue with QRegularExpression::wildcardToRegularExpression() is that it's more strict in its interpreta

D26560: Fix selection printing

cullmann added a comment. Cool! Thanks for taking care of this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26560 To: hoffmannrobert, dhaumann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demskin

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven edited the summary of this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven added a comment. In D26690#596116 , @ngraham wrote: > Does this fix https://bugs.kde.org/show_bug.cgi?id=403499? Partially I believe, D26557 should have helped too. Currently a file change of m

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of those patches. Thanks @meven! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17372 To: ngraham, #plasma, #vdg, #frameworks, dfaure Cc: meven, GB_2, dfaure, abetts, davidedmundson

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

meven added a comment. In D17372#472624 , @dfaure wrote: > Writing into the user's home dir is a "hack". > > There are better ways for distros to set defaults (such as the global mimeapps.list) but it seems KIO ignores that... (to be checked.

D26690: Make "Default Applications" in mimeapps.list the preferred applications

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=403499? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26560: Fix selection printing

hoffmannrobert added a comment. Yes, I am working on it. Now, I have a solution for 1, but 2 is more difficult to fix. Probably next week. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26560 To: hoffmannrobert, dhaumann Cc: kwrite-devel, kde-frameworks-devel, r

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven updated this revision to Diff 73781. meven added a comment. KCM/Component Revamp browser config REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73778&id=73781 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26690 AFFECTED FI

D26690: Make "Default Applications" in mimeapps.list the preferred applications

meven updated this revision to Diff 73778. meven marked 4 inline comments as done. meven added a comment. Review : Add an enum AddServiceFlag REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73679&id=73778 BRANCH master REVISION DETAIL https:/

D25743: Expose IndexerState enum to QML

broulik added inline comments. INLINE COMMENTS > baloomonitorplugin.cpp:31 > qmlRegisterType(uri, 0, 1, "Monitor"); > +qmlRegisterUncreatableMetaObject(Baloo::staticMetaObject, uri, 0, 1, > "Baloo", "Error: only enums"); > } I have to also add a qRegisterMetaType(); in order to be

D25743: Expose IndexerState enum to QML

ngraham added a subscriber: broulik. ngraham added a comment. @broulik discovered that this needs `qRegisterMetaType();` added REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/70/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 17 Jan 2020 15:16:12 + Build duration: 1 min 4 sec and counting JUnit Tests Name: pr

D26634: Correctly compute bottom margin for grid delegates with subtitles

This revision was automatically updated to reflect the committed changes. Closed by commit R296:083b21c4073f: Correctly compute bottom margin for grid delegates with subtitles (authored by ngraham). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26634?vs=

D25743: Expose IndexerState enum to QML

ngraham added a comment. Thanks! `Baloo::Suspended` doesn't seem to be exported properly or set. Also it seems like `toggleSuspendState()` only ever suspends and never resumes. Looking at the code in `monitor.cpp`, it seems like these may be related. REPOSITORY R293 Baloo REVISION DE

D26205: KWallet: Port QRegExp to QRegularExpression

blaze added a comment. I was debugging the code locally and here's what I found: simple wildcard like `*` is being replaced with cool stuff like `\\A(?:[^/]*)\\z`. As you can see, this pattern excludes forward slashes, which may be a good thing for a file path, but it is exactly the source

D26634: Correctly compute bottom margin for grid delegates with subtitles

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH compute-bottom-margin-correctly (branched from master) REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham, #vdg, #plasma, broulik, davidedmundson Cc: gvg

D26634: Correctly compute bottom margin for grid delegates with subtitles

ngraham added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham, #vdg, #plasma, broulik Cc: gvgeo, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25815: Transmission-Qt tray icon added

ngraham added a comment. @vinzenzv are you interested in finishing this, or should someone else take it over? REVISION DETAIL https://phabricator.kde.org/D25815 To: vinzenzv, #vdg, ndavis, ngraham Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2,

D25820: SimpleScreenRecorder icon added

ngraham added a comment. @vinzenzv are you interested in finishing this, or should someone else take it over? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25820 To: vinzenzv, #vdg, ndavis Cc: ngraham, filipf, ndavis, kde-frameworks-devel, LeGast00n, fbampalo

D26652: Unbreak module imports for Python2

This revision was automatically updated to reflect the committed changes. Closed by commit R264:eae0cd8a6ed9: Unbreak module imports for Python2 (authored by kossebau). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26652?vs=73513&id=73762 REVISION DETAIL h

D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R264:77a7a08abb6e: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org (authored by kossebau). REPOSITOR

D25743: Expose IndexerState enum to QML

davidedmundson updated this revision to Diff 73757. davidedmundson added a comment. rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25743?vs=70985&id=73757 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 AFFECTED FILES src/file

Re: Updating our coding conventions and coding style for C++11

On 1/17/20 12:27 AM, David Faure wrote: > On jeudi 16 janvier 2020 18:29:11 CET Vlad Zahorodnii wrote: >> I would like us to copy Qt's policy [1] for consistency: > > OK, please do. Done. Please notice that I did not annotate auto keywords with '*'. Once we have an official policy, we can fix cod

D26457: Introduce shadows API

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Good stuff! INLINE COMMENTS > kwindowshadow_p_x11.h:45 > + > +KWindowShadowTile::Ptr emptyTile; > +}; We typically have an m_ prefix for member variables *3 REPOSITOR

Re: Updating our coding conventions and coding style for C++11

On 1/16/20 7:29 PM, Vlad Zahorodnii wrote: > The common practice used in KDE seems to be: > > for (a:b) Alright, it looks like we all agree on this one, so I'm going to update the Frameworks Coding Style.

Re: Updating our coding conventions and coding style for C++11

On 1/16/20 7:46 PM, Kai Uwe Broulik wrote: > for "auto" I think we should always annotate it with const, *, and/or & > where appropriate: > > auto *something = new MyCustomType; > auto *keyEvent = static_cast(event); > const auto myList = QStringList({QLatin1String("FooThing"), > QLatin1String("

Re: Updating our coding conventions and coding style for C++11

On 1/17/20 12:46 AM, Kai Uwe Broulik wrote: > It provides useful visual information. > > auto foo = bar(); > auto baz = &bla; I don't think that you should use auto in either case since it's not clear what type foo and baz have. Cheers, Vlad

D26202: WIP: Refactor KConfigXT

kossebau added a comment. In D26202#595817 , @kossebau wrote: > where "full" would also need to mean "clean fresh build dirs" :) so that the codegenerator is triggered to be run, as the current cmake code seems to not inject a build dep between

D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler

kossebau added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26723 To: kossebau, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

cgiboudeaux added a comment. In D26202#595846 , @tcanabrava wrote: > I Just reverted this and I'm working on a full build of kde using kdesrc-build --refresh-build, I'll reopen this patch when *all* projects build sucessfully, with a unittest f

D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN "touch"ing kconfig_compiler results in regeneration now. REPOSITORY R237 KConfig BRANCH dependonkconfigcompiler REVISI

D26202: WIP: Refactor KConfigXT

tcanabrava reopened this revision. tcanabrava added a comment. This revision is now accepted and ready to land. Reopening for review :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: kossebau, bport, ngraha

D26202: WIP: Refactor KConfigXT

tcanabrava requested review of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: kossebau, bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. In D26202#595820 , @tcanabrava wrote: > We can revert, and I’ll fix the full build. Doing that now. I Just reverted this and I'm working on a full build of kde using kdesrc-build --refresh-build, I'll reopen t

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. We can revert, and I’ll fix the full build. Doing that now. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: kossebau, bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michae

Re: D26202: WIP: Refactor KConfigXT

We can revert, and I’ll fix the full build. Doing that now. On Fri, 17 Jan 2020 at 09:03 Friedrich W. H. Kossebau < nore...@phabricator.kde.org> wrote: > kossebau added a comment. View Revision > > > where "full" would also need to mean "clean fresh build dirs

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.13 - Build # 51 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.13/51/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 08:47:57 + Build duration: 44 min and counting

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 90 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/90/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 08:47:56 + Build duration: 36 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 252 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/252/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 08:47:55 + Build duration: 28 min and counting

Re: Updating our coding conventions and coding style for C++11

On Thu, 16 Jan 2020, 22:46 Kai Uwe Broulik, wrote: > > > Well, the * is completely redundant in those cases, so it doesn't bring > anything. > > I'd be tempted to say, let's not require it. > > But then it raises the question of consistency (without a guideline, > we'll have some places with * an

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 129 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/129/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 08:47:54 + Build duration: 19 min and counting JUnit Tests Name:

D26202: WIP: Refactor KConfigXT

kossebau added a comment. where "full" would also need to mean "clean fresh build dirs" :) so that the codegenerator is triggered to be run, as the current cmake code seems to not inject a build dep between generator instance and generated files, so a new version does not trigger regeneratio

KDE CI: Frameworks » kwallet » kf5-qt5 WindowsMSVCQt5.13 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20WindowsMSVCQt5.13/37/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 08:47:54 + Build duration: 8 min 17 sec and counting JUnit Tests Name:

D26202: WIP: Refactor KConfigXT

dfaure added a comment. Argh, I wanted to say "please do a full kdesrc-build of all modules" before approving, and forgot to do that. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: kossebau, bport, ngraham

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 WindowsMSVCQt5.13 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20WindowsMSVCQt5.13/50/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 08:47:53 + Build duration: 2 min 20 sec and counting

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 WindowsMSVCQt5.13 - Build # 50 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20WindowsMSVCQt5.13/50/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 08:43:26 + Build duration: 2 min 51 sec and counting JUnit Tests

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 WindowsMSVCQt5.13 - Build # 49 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20WindowsMSVCQt5.13/49/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 17 Jan 2020 08:43:27 + Build duration: 46 sec and counting CONSOLE OUTPUT

D26202: WIP: Refactor KConfigXT

kossebau added a comment. This morning it was found e.g. on opensuse build server (but reproduced by me locally) that this change broke KMyMoney & KDevelop, who now start to fail e.g. with (using `VERBOSE=1 make`) [ 38%] Generating kcfg_custombuildsystemconfig.h, kcfg_custombuildsyste