D25698: New query mechanism for applications: KApplicationTrader

2020-01-20 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > kapplicationtrader.cpp:87 > +KService::List::iterator it = lst.begin(); > +while (it != lst.end()) { > +KService::Ptr serv = *it; I would prefer the std::erase(std::remove_if(...), ...end()); idiom here. Assuming the list is a

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-20 Thread Kevin Ottens
ervin added inline comments. INLINE COMMENTS > meven wrote in kmimeassociations.cpp:104 > The first 25 with the highest preferences cannot be affected but then they > can have the same base reference as the next most category loaded. > Like the 26th "Default Applications" would have the same

D26801: Really fix the Windows backend for KNotifications

2020-01-20 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > brute4s99 wrote in notifybysnore.cpp:143 > KNotif objects by default have `d->id = -1` > > `notify()` is invoked by the base with -1 ID and later updated with the > correct ID and the actions. > > Weirdly though, `pairingRequest`

D26786: Port away from deprecated QList::toSet() method

2020-01-20 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R286:c36ecf9c474a: Port away from deprecated QList::toSet() method (authored by ahmadsamir). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26786?vs=73926=73986

D26801: Really fix the Windows backend for KNotifications

2020-01-20 Thread Piyush Aggarwal
brute4s99 added inline comments. INLINE COMMENTS > brute4s99 wrote in notifybysnore.cpp:143 > KNotif objects by default have `d->id = -1` > > `notify()` is invoked by the base with -1 ID and later updated with the > correct ID and the actions. > > Weirdly though, `pairingRequest`

D26801: Really fix the Windows backend for KNotifications

2020-01-20 Thread Piyush Aggarwal
brute4s99 added inline comments. INLINE COMMENTS > notifybysnore.cpp:143 > { > -Q_UNUSED(config); > -// HACK work around that notification->id() is only populated after > returning from here > -// note that config will be invalid at that point, so we can't pass that > along > -

D26800: autotests: use local desktop file to avoid relying on konsole

2020-01-20 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D26800 To: dfaure, meven, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26801: Really fix the Windows backend for KNotifications

2020-01-20 Thread Piyush Aggarwal
brute4s99 created this revision. brute4s99 added reviewers: vonreth, broulik, KDE Connect. brute4s99 added a project: KDE Connect. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY This patch fixes

D26767: [KMessageWidget] Subtract the correct margin

2020-01-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah yep, this was probably my oversight when I ported it to use the flatter Kirigami style. REPOSITORY R236 KWidgetsAddons BRANCH margins (branched from master) REVISION DETAIL

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-20 Thread Nathaniel Graham
ngraham added a comment. Oh, I thought we already did this. +1 since it was explicitly the plan. But should we just hide them, or not even create them in the first place? Creating hidden-by-default entries seems a bit off. INLINE COMMENTS > kfileplacesmodel.cpp:361 >

D18778: [KRun] Fall back to reading text/html in mimeapps.list if others aren't there

2020-01-20 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Thanks. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18778 To: ngraham, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26677: Port away from KLineEdit and KComboBox to Q equivalent

2020-01-20 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig BRANCH port_to_q_ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D26677 To: gassaf, #frameworks, nicolasfella Cc: kde-frameworks-devel, LeGast00n,

T12567: Reduce code/effort duplication around color scheme support

2020-01-20 Thread Noah Davis
ndavis updated the task description. TASK DETAIL https://phabricator.kde.org/T12567 To: ndavis Cc: plasma-devel, kde-frameworks-devel, ndavis, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, davidre, fbampaloukas, GB_2, ekasprzak, ragreen, domson, michaelh, ahmadsamir, dkardarakos,

D26786: Port away from deprecated QList::toSet() method

2020-01-20 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH l-toset (branched from master) REVISION DETAIL https://phabricator.kde.org/D26786 To: ahmadsamir, dfaure, apol, bruns Cc: kde-frameworks-devel, #baloo, hurikhan77,

D26800: autotests: use local desktop file to avoid relying on konsole

2020-01-20 Thread David Faure
dfaure added a comment. It's not installed. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26800 To: dfaure, meven, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26800: autotests: use local desktop file to avoid relying on konsole

2020-01-20 Thread Méven Car
meven added inline comments. INLINE COMMENTS > org.kde.testapp.desktop:6 > +Icon=utilities-terminal > +Terminal=false > +Categories=Qt;KDE;System;TerminalEmulator; Add NoDisplay or testiers will have double konsole, or remove test desktop file on teardown. REPOSITORY R309 KService REVISION

D26781: Fix test since Konsole added icons to its actions

2020-01-20 Thread David Faure
dfaure added a comment. > D26800 REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26781 To: meven, #frameworks, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26800: autotests: use local desktop file to avoid relying on konsole

2020-01-20 Thread David Faure
dfaure created this revision. dfaure added reviewers: meven, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Test was unstable since konsole commit :

D26781: Fix test since Konsole added icons to its actions

2020-01-20 Thread Méven Car
meven abandoned this revision. meven added a comment. In D26781#597778 , @dfaure wrote: > Yep, this would break the test for users of an older konsole, let's ship our own. I'm working on it. All right REPOSITORY R309 KService

D26781: Fix test since Konsole added icons to its actions

2020-01-20 Thread David Faure
dfaure added a comment. Yep, this would break the test for users of an older konsole, let's ship our own. I'm working on it. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26781 To: meven, #frameworks, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2,

D26798: Fix broken SQL query in allResourcesQuery

2020-01-20 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R159:e36497a6734d: Fix broken SQL query in allResourcesQuery (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26798?vs=73976=73981

D26798: Fix broken SQL query in allResourcesQuery

2020-01-20 Thread Ivan Čukić
ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D26798 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

2020-01-20 Thread Méven Car
meven added inline comments. INLINE COMMENTS > resultset.cpp:399 > +AND from_table.usedActivity = rsc.usedActivity > AND rl.initiatingAgent = rsc.initiatingAgent > Missing table name update fix in D26798

D26798: Fix broken SQL query in allResourcesQuery

2020-01-20 Thread Méven Car
meven retitled this revision from "Fix broken SQL query" to "Fix broken SQL query in allResourcesQuery". REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D26798 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26798: Fix broken SQL query

2020-01-20 Thread Méven Car
meven created this revision. meven added reviewers: ivan, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The regression was introduced by D22717 TEST

D26564: Clean kbuildsycoca4 support

2020-01-20 Thread Méven Car
meven added a comment. It seemed to In D26564#597474 , @ervin wrote: > I'm wondering if that's the right point in time for this. Wouldn't it be better once we branched KF6? There are still people transitioning from 4 to 5 out there I

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-20 Thread Méven Car
meven added inline comments. INLINE COMMENTS > dfaure wrote in kmimeassociations.cpp:104 > More precisely, it assumes that a single mimetype entry doesn't have more > than 25 desktop files associated with it. And even then, what would happen is > that the ordering is wrong after the first 25.

D26793: Exclude the KSharedConfig::openStateConfig from the sip parser

2020-01-20 Thread Juraj Oravec
SGOrava added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26793 To: SGOrava, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.12 - Build # 117 - Fixed!

2020-01-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.12/117/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 20 Jan 2020 17:19:39 + Build duration: 2 min 12 sec and counting BUILD ARTIFACTS

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-20 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > meven wrote in kmimeassociations.cpp:104 > The code kinda assumes we don't have more than 25 entries by configgroup. More precisely, it assumes that a single mimetype entry doesn't have more than 25 desktop files associated with it. And even

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-20 Thread Méven Car
meven added inline comments. INLINE COMMENTS > dfaure wrote in kmimeassociations.cpp:104 > No. What about my job security? ;-) > > It's half of the +50 from line 86. > > The range 1000-1025 is used by Added Associations, the range 1025-1050 is > used by Default Applications, and so on for the

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.12 - Build # 116 - Failure!

2020-01-20 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.12/116/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 20 Jan 2020 15:59:12 + Build duration: 1 min 8 sec and counting CONSOLE OUTPUT

D26573: Add missing Import Env Variable

2020-01-20 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH add_missing_env_var REVISION DETAIL https://phabricator.kde.org/D26573 To: tcanabrava, mart Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,

D26779: Updates nasm.xml with the latest instructions

2020-01-20 Thread Anders Ponga
meganomic added a comment. I would appreciate it if you did it. I barely know how to use this thing. I'll probably mess it up. REPOSITORY R216 Syntax Highlighting BRANCH nasm (branched from master) REVISION DETAIL https://phabricator.kde.org/D26779 To: meganomic,

D26794: [WIP] Implement comment posting (and reenable voting)

2020-01-20 Thread Dan Leinir Turthra Jensen
leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This is a work in progress for adding support for posting comments to the KNewStuffCore framework, and cleaning up

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-20 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > ervin wrote in kmimeassociations.cpp:104 > Shouldn't the comment also include why the value 25 (and not 1, or 42 or NaN > ;-)) for mere mortals like me? No. What about my job security? ;-) It's half of the +50 from line 86. The range 1000-1025

D26779: Updates nasm.xml with the latest instructions

2020-01-20 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. Can you commit or shall we push this for you? REPOSITORY R216 Syntax Highlighting BRANCH nasm (branched from master) REVISION DETAIL

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-20 Thread Kevin Ottens
ervin added inline comments. INLINE COMMENTS > kmimeassociations.cpp:104 > +// Other than that, they work the same... > +parseAddedAssociations(KConfigGroup(, "Default Applications"), > file, basePreference + 25); > } Shouldn't the comment also include why the value 25 (and not 1, or

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2020-01-20 Thread Kevin Ottens
ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > managedconfigmodule.cpp:175 > +if (it->isNull()) { > +d->_skeletons.erase(it); > +} Careful there you should use the return value

D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-20 Thread Kevin Ottens
ervin added a comment. Inviting @dfaure in here, he was around at the time, I wasn't I started only the summer after. ;-) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26623 To: meven, #frameworks, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-20 Thread Kevin Ottens
ervin added a reviewer: dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26623 To: meven, #frameworks, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-20 Thread Kevin Ottens
ervin added a comment. That being said we did that change on purpose in 2002 (commit 38d35cec68bb718ebc97f965b66313082ab2c3b6 in kdelibs), granted xdg-email wasn't around at the time but I wonder if we thus want to

D26047: Expose KConfig settings to allow registration in KCM Notification

2020-01-20 Thread Cyril Rossi
crossi planned changes to this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26047 To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26691: Optimize code when dropping files into the desktop

2020-01-20 Thread Tranter Madi
trmdi added inline comments. INLINE COMMENTS > davidedmundson wrote in dropmenu.cpp:48 > where does this menu get deleted? It seems to leak It is set to be deleted on close, at line 43. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To:

D26791: prefer the new kcm plugins to the old

2020-01-20 Thread Marco Martin
mart marked an inline comment as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26791 To: mart, #plasma, sitter, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

2020-01-20 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > containmentinterface.cpp:548 > + > +if (!m_dropMenu->urls().at(0).isLocalFile()) { > +QApplication::restoreOverrideCursor(); can you be sure urls has at least 1 at this point? > dropmenu.cpp:36 > + >

D26791: prefer the new kcm plugins to the old

2020-01-20 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R295:9afc55415793: prefer the new kcm plugins to the old (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26791?vs=73932=73936#toc REPOSITORY R295 KCMUtils CHANGES SINCE LAST

D26791: prefer the new kcm plugins to the old

2020-01-20 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. INLINE COMMENTS > kcmoduleloader.cpp:98 > +if (!factory) { > +qWarning() << "Error loading plugin:" << loader.errorString(); > } else { I

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-20 Thread Konrad Materka
kmaterka added a comment. Few comments from someone who was recently using `PlasmaCore.SortFilterModel` and had trouble understanding sorting :) INLINE COMMENTS > ksortfilterproxymodel_qml.cpp:111 > + > +void tst_KSortFilterProxyModelQml::testSortRole() > +{ Can you add a test for

D26564: Clean kbuildsycoca4 support

2020-01-20 Thread Kevin Ottens
ervin added a comment. I'm wondering if that's the right point in time for this. Wouldn't it be better once we branched KF6? There are still people transitioning from 4 to 5 out there I guess. I admit I'm unsure, they had a long time to transition already. REPOSITORY R241 KIO REVISION

D26791: prefer the new kcm plugins to the old

2020-01-20 Thread Marco Martin
mart created this revision. mart added reviewers: Plasma, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY swap the logic, if the same kcm has both the new and old plugins format (for instance

D26793: Exclude the KSharedConfig::openStateConfig from the sip parser

2020-01-20 Thread Juraj Oravec
SGOrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. SGOrava requested review of this revision. REVISION SUMMARY Fix python binding compilation error. - Add *.pyc files to .gitignore REPOSITORY R237 KConfig BRANCH

D26202: Refactor KConfigXT

2020-01-20 Thread Kevin Ottens
ervin added a comment. I'm admittedly very late to the party, so mostly pointing out stylistic things which are left. Since we're touching many lines anyway it's a good point in time to get that improved since the original was very foreign in some way. INLINE COMMENTS >

D26781: Fix test since Konsole added icons to its actions

2020-01-20 Thread Aleix Pol Gonzalez
apol added a comment. How about we ship a desktop file here to test instead of using the one in the system? It doesn't make much sense that there's this weird dependency here. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26781 To: meven, #frameworks,

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

2020-01-20 Thread patrick j pereira
patrickelectric added a comment. @apol I did update the commit body to explain why. For the text I used https://regex101.com with the icon in the commit body and printing the variables of CMAKE_MATCH_1 and CMAKE_MATCH_2 Let me know if you agree with this to land the patch, this is

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

2020-01-20 Thread patrick j pereira
patrickelectric updated this revision to Diff 73927. patrickelectric added a comment. Add commit body REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26751?vs=73830=73927 BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751

D26786: Port away from deprecated QList::toSet() method

2020-01-20 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, apol, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: Baloo. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R286 KFileMetaData BRANCH l-toset (branched from

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-20 Thread patrick j pereira
patrickelectric added a comment. Hi @cgiboudeaux, thanks for the explanation, I'll take a look and get back here. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To: patrickelectric, apol, tcanabrava, cgiboudeaux, bcooksley Cc: bcooksley,

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-20 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R309 KService BRANCH arcpatch-D26690 REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D18778: [KRun] Fall back to reading text/html in mimeapps.list if others aren't there

2020-01-20 Thread Méven Car
meven added a comment. I think you can abandon this one, because 26690 is fixing this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18778 To: ngraham, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-20 Thread Méven Car
meven added a comment. Too bad I missed the boat for KF 5.66 and Plasma 5.18. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26782 To: meven, ngraham, #vdg, #plasma, hein Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-20 Thread Méven Car
meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26782 To: meven, ngraham, #vdg, #plasma, hein Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-20 Thread Méven Car
meven updated this revision to Diff 73917. meven added a comment. Clean commit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=73916=73917 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26782 AFFECTED FILES

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-20 Thread Méven Car
meven created this revision. meven added reviewers: ngraham, VDG, Plasma, hein. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The entries timeline:/today and timeline:/yesterday are way less useful

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

2020-01-20 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D26752#597149 , @patrickelectric wrote: > Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ? > > In #kirogi

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-20 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Good solution :-) LOL. REPOSITORY R309 KService BRANCH arcpatch-D26690 REVISION DETAIL https://phabricator.kde.org/D26690 To: meven, dfaure, dvratil, ervin, #frameworks Cc:

D26781: Fix test since Konsole added icons to its actions

2020-01-20 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Test was unstable since konsole commit :

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-20 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > Why's this better? Or how is it different? It's "better" in the way that it actually works with NDK r20, while CMake 3.16 failed to even pass the basic compiler checks. For a toolchain file shipped with a

D26779: Updates nasm.xml with the latest instructions

2020-01-20 Thread Anders Ponga
meganomic edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D26779 To: meganomic, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking,

D26779: Updates nasm.xml with the latest instructions

2020-01-20 Thread Anders Ponga
meganomic added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D26779 To: meganomic, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham,

D26780: Update nasm.xml with instructions from the latest nasm docs

2020-01-20 Thread Anders Ponga
meganomic abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D26780 To: meganomic, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, gennad, GB_2, bmortimer, domson, michaelh, genethomas, ngraham,

D26690: Make "Default Applications" in mimeapps.list the preferred applications

2020-01-20 Thread Méven Car
meven updated this revision to Diff 73913. meven added a comment. Simplify implementation of Default Applications parsing, update tests REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26690?vs=73781=73913 BRANCH arcpatch-D26690 REVISION DETAIL

D26780: Update nasm.xml with instructions from the latest nasm docs

2020-01-20 Thread Anders Ponga
meganomic created this revision. meganomic added a reviewer: Framework: Syntax Highlighting. meganomic added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. meganomic requested review of this

D26779: Updates nasm.xml with the latest instructions

2020-01-20 Thread Anders Ponga
meganomic created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. meganomic requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH nasm (branched from master) REVISION DETAIL

D26735: [Components 3]Make slider tickmarks optional

2020-01-20 Thread George Vogiatzis
gvgeo abandoned this revision. gvgeo added a comment. Closing, when there are few steps, should be marked. > ...should be a checkbox for you? That's good idea. I 'll try to add a checkbox when a keyboard is on/off only. Not sure how it would look. REPOSITORY R242 Plasma