D27080: Don't warn for invalid plugin metata

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  See explanation in https://bugs.kde.org/show_bug.cgi?id=412464
  
  BUG: 412464
  FIXED-IN: 5.67

TEST PLAN
  restart plasmashell, see way less useless warning spam

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-warning-spam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27080

AFFECTED FILES
  src/plasma/pluginloader.cpp

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27075: Fixed tooltip corners and removed useless color attributes

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f7b4bbf86177: Fixed tooltip corners and removed useless 
color attributes (authored by niccolove).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27075?vs=74817=74821

REVISION DETAIL
  https://phabricator.kde.org/D27075

AFFECTED FILES
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/tooltip.svg

To: niccolove, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  In D26758#601718 , @gvgeo wrote:
  
  > Plasma theme explorer is fine. The difference is that it uses 
plasmaComponents, while D26271  uses 
plasmaComponents**3**.
  >
  > About plasmaComponents:
  >  There is some bug with the checkbox and the Label height. Fails to take 
the correct size (uses paintedHeight).
  >
  >   height: Math.round(Math.max(paintedHeight, 
theme.mSize(theme.defaultFont).height*1.6))
  >
  >
  > Radiobutton draws correctly the label height. But need indicator vertical 
placement or different label height.
  
  
  Sorry, I don't understand what the problem is and I don't know the QML code 
well. I didn't touch that code (I think), so I'm not sure it has anything to do 
with this patch. Can you state the problem in simpler terms?
  
  > Non relevant note: 
  >  There is a workaround in multiple places for 
  >  https://bugreports.qt.io/browse/QTBUG-67007
  >  Which was fixed in Qt 5.14.0 RC1 from
  >  https://bugreports.qt.io/browse/QTBUG-70481
  >  Should be removed or need to stay awhile?
  
  I'd suggest removing them when the minimum Qt requirement is raised up to or 
past that version. If the workarounds cause visual glitches, then ask whoever 
maintains the affected repos about it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg, ngraham
Cc: gvgeo, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D27075: Fixed tooltip corners and removed useless color attributes

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27075

To: niccolove, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22477: With auto completion don't show completions that don't match from beginning of typed word

[Ahmad Samir]

ahmadsamir abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27075: Fixed tooltip corners and removed useless color attributes

[Niccolò Venerandi]

niccolove added a reviewer: ndavis.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27075

To: niccolove, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27075: Fixed tooltip corners and removed useless color attributes

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27075

AFFECTED FILES
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/tooltip.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22477: With auto completion don't show completions that don't match from beginning of typed word

[Milian Wolff]

mwolff added a comment.


  I agree, this is a feature, not a bug. If people are annoyed, they are 
usually annoyed by other issues like the one shown by Sven

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22477

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, 
kfunk
Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23848: Add Breeze icons for Jupyter Notebook files

[Alex Debus]

alexde abandoned this revision.
alexde added a comment.


  I unfortunately no longer have time for this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23848

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added a comment.


  Something like this:
  F8059669: Screenshot_20200131_163146.PNG 


REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi updated this revision to Diff 74799.
crossi added a comment.


  code style

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=74756=74799

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25682: add initial wsdiscovery support

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> ngraham wrote in .gitignore:1
> shouldn't you be doing out-of-source builds lol

an unrelated subdir is still technically out-of-source from a cmake pov ;)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25682

To: sitter, dfaure, #frameworks, #dolphin, ngraham
Cc: meven, schmeisser, bcooksley, ngraham, caspermeijn, davidedmundson, 
kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D27067: Change "AutoSkip" to "Skip All"

[Nathaniel Graham]

ngraham added a comment.


  Sure, in another patch. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27067

To: ngraham, #frameworks, #vdg, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:9b77746a6b1e: QApplication::globalStrut() will be removed 
in qt6. Its deprecated in qt5.15… (authored by mlaurent).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27010?vs=74627=74783

REVISION DETAIL
  https://phabricator.kde.org/D27010

AFFECTED FILES
  src/kcolorbutton.cpp
  src/kdatepicker.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  remove_globalStrut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27010

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

[Laurent Montel]

mlaurent added a comment.


  ping ?:)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27010

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27067: Change "AutoSkip" to "Skip All"

[Kai Uwe Broulik]

broulik added a comment.


  +1 (also for considering the string freeze :)
  
  I think we should add some mnemonics, i.e. "" and "Skip "

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27067

To: ngraham, #frameworks, #vdg, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added a comment.


  In D27035#604026 , @ngraham wrote:
  
  > Uh-oh, now it looks like this in Konsole: F8056116: 
Screenshot_20200131_064332.png 
  >
  > Compare to the current appearance: F8056130: Screenshot_20200131_064445.png 

  >
  > I recall wrestling with this issue in D12508 
. Might be worth looking over that.
  
  
  That's because it wants to look transparent and mixes the background color 
with its color. One fix could be to also use the parent's text color (in this 
case white) or stop using `QPalette::Window` for data storage and mix with the 
window color of the widget's palette and use something else (maybe 
QPalette::Base). Opinions?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27067: Change "AutoSkip" to "Skip All"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, VDG, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  "AutoSkip" is not a word and makes it unclear what the button actually does.
  
  BUG: 416964
  FIXED-IN: 5.68

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27067

AFFECTED FILES
  src/widgets/skipdialog.cpp

To: ngraham, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26931: Introduce SPDX license headers

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R274 KIdleTime

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26931

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Uh-oh, now it looks like this in Konsole: F8056116: 
Screenshot_20200131_064332.png 
  
  Compare to the current appearance: F8056130: Screenshot_20200131_064445.png 

  
  I recall wrestling with this issue in D12508 
. Might be worth looking over that.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Sorry, couple of further style fixes I missed on the previous run

INLINE COMMENTS

> kcoreconfigskeleton.cpp:1616
> +
> +void KConfigCompilerSignallingItem::setGroup(const KConfigGroup& cg)
> +{

Space before & not after

> kcoreconfigskeleton.cpp:1621
> +
> +KConfigGroup KConfigCompilerSignallingItem::configGroup(KConfig* config) 
> const
> +{

Space before * not after

> kcoreconfigskeleton.h:453
> +void setGroup(const KConfigGroup );
> +KConfigGroup configGroup(KConfig* config) const;
> +// END TODO

Space before * not after

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26841: hardware tool: define syntax via syntax arg

[Harald Sitter]

sitter updated this revision to Diff 74780.
sitter added a comment.


  set HidenFromHelp flag on legacy option so it doesn't even show up anymore

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26841?vs=74112=74780

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26841

AFFECTED FILES
  src/tools/solid-hardware/solid-hardware.cpp

To: sitter
Cc: broulik, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
kossebau marked an inline comment as done.
Closed by commit R236:16385f0b6926: API dox: tell default values of 
KMessageWidgets wordWrap/closeButtonVisible (authored by kossebau).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27064?vs=74778=74779

REVISION DETAIL
  https://phabricator.kde.org/D27064

AFFECTED FILES
  src/kmessagewidget.h

To: kossebau, davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26841: hardware tool: define syntax via syntax arg

[Harald Sitter]

sitter added a comment.


  Splendid idea!

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26841

To: sitter
Cc: broulik, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

[David Redondo]

davidre accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  mentiondefaults

REVISION DETAIL
  https://phabricator.kde.org/D27064

To: kossebau, davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 74778.
kossebau added a comment.


  fix default visible=true

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27064?vs=74771=74778

BRANCH
  mentiondefaults

REVISION DETAIL
  https://phabricator.kde.org/D27064

AFFECTED FILES
  src/kmessagewidget.h

To: kossebau, davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> davidre wrote in kmessagewidget.h:258
> I think the close button is visible by default, isn't it?

Good catch. I fooled myself with having qt designer showing me still the file 
version with

  
  false
  

where I though it was the clean one.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27064

To: kossebau, davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> kmessagewidget.h:258
>   *
> + * By default the close button is set to be invisible.
> + *

I think the close button is visible by default, isn't it?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27064

To: kossebau, davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

[Milian Wolff]

mwolff added a reviewer: Frameworks.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27065

To: mwolff, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

[Milian Wolff]

mwolff created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mwolff requested review of this revision.

REVISION SUMMARY
  Reading through the code, I realized that the isRemovable check
  returned true when the kDADiskDescriptionDeviceInternalKey property
  is set to true. But that sounds like the check needs to be inverted:
  
  According to [1] e.g. a disk is non-removable when it is internal.
  And kDADiskDescriptionDeviceInternalKey returns whether the disk
  is internal, not external.
  
  [1]: 
https://stackoverflow.com/questions/38499860/thunderbolt-drives-not-marked-as-ejectable-in-disk-arbitration-iokit-although-th#comment64407405_38499860
  
  I do not own a device with IOKit platfor, so I cannot actually test
  whether this patch is correct or not.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27065

AFFECTED FILES
  src/solid/devices/backends/iokit/iokitstorage.cpp

To: mwolff
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @davidre: looking at the setter methods, I am also tempted to add early 
returns in case of no change. but I do not want to get in the way with your 
qpainter patch (good work), so waiting :)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27064

To: kossebau, davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: davidre.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  GIT_SILENT

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  mentiondefaults

REVISION DETAIL
  https://phabricator.kde.org/D27064

AFFECTED FILES
  src/kmessagewidget.h

To: kossebau, davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25682: add initial wsdiscovery support

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a comment.


  Works great, super cool to have this.
  
  Since `kdsoap-ws-discovery-client` is upstream now, do we still need to 
duplicate it here?

INLINE COMMENTS

> .gitignore:1
> +build/

shouldn't you be doing out-of-source builds lol

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25682

To: sitter, dfaure, #frameworks, #dolphin, ngraham
Cc: meven, schmeisser, bcooksley, ngraham, caspermeijn, davidedmundson, 
kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D26841: hardware tool: define syntax via syntax arg

[Kai Uwe Broulik]

broulik added a comment.


  Oh god yes.
  
  Since it's only for compat and superfluous, how about setting 
`HiddenFromHelp` on the `QCommandLineOption` then?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26841

To: sitter
Cc: broulik, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26931: Introduce SPDX license headers

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 74768.
cordlandwehr added a comment.


  Unify copyright header format

REPOSITORY
  R274 KIdleTime

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26931?vs=74452=74768

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26931

AFFECTED FILES
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/MIT.txt
  examples/KIdleTest.cpp
  examples/KIdleTest.h
  examples/main.cpp
  src/abstractsystempoller.cpp
  src/abstractsystempoller.h
  src/kidletime.cpp
  src/kidletime.h
  src/plugins/osx/macpoller.cpp
  src/plugins/osx/macpoller.h
  src/plugins/windows/windowspoller.cpp
  src/plugins/windows/windowspoller.h
  src/plugins/xscreensaver/xscreensaverbasedpoller.cpp
  src/plugins/xscreensaver/xscreensaverbasedpoller.h
  src/plugins/xsync/fixx11h.h
  src/plugins/xsync/xsyncbasedpoller.cpp
  src/plugins/xsync/xsyncbasedpoller.h
  src/widgetbasedpoller.cpp
  src/widgetbasedpoller.h

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added a comment.


  In D27035#603619 , @dhaumann wrote:
  
  > Better :) with corners I mean the 1-3 pixels left due to the rounding 
corners. These pixels were once also drawn as background although they are 
outside of the frame. It may be a minor detail, but imho such details are 
important. But indeed, the screenshots look good.
  >
  > Next test: open a file in kate. Now either change the file externally or 
delete it. Kate should show an animated KMessageWidget. Does it also correctly 
work with a small kate? I.e. small width of kate window?
  
  
  It seems to work better than before, on the left the current one, on the 
right this patch:
  F8053466: video.webm 

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre updated this revision to Diff 74766.
davidre marked an inline comment as done.
davidre added a comment.


  Use parentWidget()

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=74714=74766

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:317
> +constexpr float alpha = 0.2;
> +const auto parentWidget = qobject_cast(parent());
> +const QColor parentWindowColor = (parentWidget ? parentWidget->palette() 
> : qApp->palette()).color(QPalette::Window);

I knew there was a function like that but couldn't remember its name. Thanks!

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi updated this revision to Diff 74756.
crossi added a comment.


  code style

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=74754=74756

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> kcoreconfigskeleton.h:86
> +/**
> + * Set config file group bu giving the KConfigGroup.
> + * Allow the item to be in nested groups.

s/bu/but/

> kcoreconfigskeleton.h:97
> + */
> +KConfigGroup configGroup(KConfig* config) const;
> +

Space before * not after.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi created this revision.
crossi added a reviewer: ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Currently KConfgiSkeleton cannot manage item entry in subgroup.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> KConfigHeaderGenerator.cpp:267
> +
> +for (const auto signal : qAsConst(parseResult.signalList)) {
> +stream() << whitespace() << "  " << signalEnumName(signal.name) << " 
> = 0x" << hexValue << val << ",\n";

You use "const Signal &" a few lines below, makes me wonder shouldn't they both 
be "const auto &" then? at least for consistency?

REPOSITORY
  R237 KConfig

BRANCH
  remove_enum_hack

REVISION DETAIL
  https://phabricator.kde.org/D26876

To: tcanabrava, ervin, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

[Kevin Ottens]

ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  arcpatch-D26368

REVISION DETAIL
  https://phabricator.kde.org/D26368

To: meven, ervin, #frameworks
Cc: dfaure, tcanabrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo updated this revision to Diff 74749.
gvgeo edited the test plan for this revision.
gvgeo added a comment.
This revision is now accepted and ready to land.


  The last index is incorrect, and I can't find a way to get the proper one. 
Restoring first revision, which keeps the functionality as it was.
  
  Also haven't find exactly, why last index doesn't work. I miss something 
important around this code, despite knowing that it works fine as it is.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26983?vs=74690=74749

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns