D27028: Switch from download.k.o to autoconfig

2020-02-02 Thread Méven Car
meven added inline comments. INLINE COMMENTS > khotnewstuff.knsrc:2 > [KNewStuff3] > -ProvidersUrl=http://download.kde.org/ocs/providers.xml > +ProvidersUrl=http://autoconfig.kde.org/ocs/providers.xml > Categories=KDE Wallpaper 1920x1200,KDE Wallpaper 1600x1200 Shouldn't it be in https ?

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 284 - Still Unstable!

2020-02-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/284/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 03 Feb 2020 04:20:03 + Build duration: 13 min and counting JUnit Tests Name: projectroot

T11627: Improve KIO asynchronicity

2020-02-02 Thread Méven Car
meven updated the task description. TASK DETAIL https://phabricator.kde.org/T11627 To: meven Cc: broulik, ognarb, #dolphin, #frameworks, meven, dfaure, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-02 Thread Francis Herne
flherne added a comment. Thanks for this. ADB log of the Kirigami problem, which results in a blank screen ['gredit' is the name of the app]: libgredit_arm64-v8a.so: QQmlApplicationEngine failed to load component libgredit_arm64-v8a.so: qrc:/main.qml:5:1: Type

D27104: Convert license statements to SPDX headers

2020-02-02 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > krcc.cpp:4 > + > + SPDX-License-Identifier: LGPL-2.0-only OR LGPL-3.0-only OR > LicenseRef-KDE-Accepted-LGPL > */ Same thing here > krcc.h:4 > > - This library is free software; you can redistribute it and/or modify > - it under

D27112: Fix errors in the QRegularExpression porting commit

2020-02-02 Thread Ahmad Samir
ahmadsamir added a comment. I'll try and add some unit tests to catch those issues... REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

2020-02-02 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, drosca, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Properties::parse(): - The regex is case sensitive - Fix copy/paste error, it's just one

D27097: Port from QRegExp to QRegularExpression

2020-02-02 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 74871. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Add test plan section REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27097?vs=74850=74871 BRANCH l-qregularexpression

Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

2020-02-02 Thread Méven Car
meven added a comment. I have currently a couple of patches touching the same lines, so I will postpone this land after to save me some rebasing time. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25301 To: meven, #frameworks, dfaure Cc:

D25117: file ioslave: stop copying as soon as the ioslave is killed

2020-02-02 Thread Méven Car
meven added inline comments. INLINE COMMENTS > jobtest.cpp:82 > +// to make sure io is not too fast > +qputenv("KIOSLAVE_FILE_ENABLE_TESTMODE", "1"); > + It'd be nice to have an #idef BUILD_TEST to only include this code path only when tests are compiled. I didn't know how to achieve

D25117: file ioslave: stop copying as soon as the ioslave is killed

2020-02-02 Thread Méven Car
meven updated this revision to Diff 74870. meven marked 3 inline comments as done. meven added a comment. Reduce the size of the tempfile for JobTest::cancelCopyAndCleanDest and restrict testMode slowness to copy where destination is slow REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D22801: [KIO] silence a QFileInfo warning

2020-02-02 Thread René J . V . Bertin
rjvbb added a comment. Whatever, I'm staying at 5.60.0 anyway, with whatever patches I deem appropriate. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22801 To: rjvbb, #frameworks, dfaure Cc: dfaure, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D27106: Convert license statements to SPDX markers

2020-02-02 Thread Andreas Cord-Landwehr
cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D27106 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27106: Convert license statements to SPDX markers

2020-02-02 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX markers and add license files. REPOSITORY R235 Attica BRANCH spdx

D27104: Convert license statements to SPDX headers

2020-02-02 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX markers and add license files compatible with REUSE.software

D27104: Convert license statements to SPDX headers

2020-02-02 Thread Andreas Cord-Landwehr
cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D27104 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27103: Convert license headers to SPDX markers

2020-02-02 Thread Andreas Cord-Landwehr
cordlandwehr added a reviewer: dfaure. cordlandwehr added a comment. Can you have a look at the KDAB license statement changes? Specifically the point that now the copyright statement explicitly states the copyright for both the author and the company, where previously the author's copyright

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 283 - Still Unstable!

2020-02-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/283/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 02 Feb 2020 16:08:39 + Build duration: 9 min 33 sec and counting JUnit Tests Name:

D27103: Convert license headers to SPDX markers

2020-02-02 Thread Andreas Cord-Landwehr
cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D27103 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27103: Convert license headers to SPDX markers

2020-02-02 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX markers and add REUSE.software compliant licesne files. This update also

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Redondo
davidre added a comment. I just took a look at KSelector and it actually inherits minimum and maximum properties from QAbstractSlider so we could just drop these custom properties for KF6 REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26951 To: davidre,

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R265:db859852b577: Remove old code that is not used anymore (authored by davidre). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26951?vs=74856=74857 REVISION

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH arcpatch-D26951 REVISION DETAIL https://phabricator.kde.org/D26951 To: davidre, dfaure, ervin, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2,

D22801: [KIO] silence a QFileInfo warning

2020-02-02 Thread David Faure
dfaure added a comment. I disagree. Invalid method call, you get a warning already from Qt, no need to bloat this method more. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22801 To: rjvbb, #frameworks, dfaure Cc: dfaure, meven, kde-frameworks-devel, LeGast00n, GB_2,

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Redondo
davidre updated this revision to Diff 74856. davidre added a comment. Update comment REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26951?vs=74450=74856 BRANCH arcpatch-D26951 REVISION DETAIL https://phabricator.kde.org/D26951 AFFECTED FILES

D22801: [KIO] silence a QFileInfo warning

2020-02-02 Thread René J . V . Bertin
rjvbb added a comment. I might (if I can find the trouble location) but IMHO KIO should still account for the possibility of this situation too (or more in general, bail out this function for any path that cannot be a mountpoint). REPOSITORY R241 KIO REVISION DETAIL

Fixing QNetworkAccessManager use for KDE services

2020-02-02 Thread Friedrich W. H. Kossebau
Hi Ben, sorry to hear about this pain you have in all the good work you do that allows us to enjoy the high reliability of the KDE services. I would like to help to reduce that pain. Am Samstag, 1. Februar 2020, 23:24:14 CET schrieb Ben Cooksley: > Hi all, > > For an extremely long time now,

D23879: Add Qt Designer icon symlink

2020-02-02 Thread Björn Feber
GB_2 abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23879 To: GB_2, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I don't really know KConfigDialogManager. But indeed KSelector has properties with those names so if someone wanted to use e.g. KGradientSelector here it sounds like this would

Re: D26877: Simplify calls to whitespace() and use it in more places.

2020-02-02 Thread Tomaz Canabrava
I like indentedStream. On Sun, 2 Feb 2020 at 11:36 David Faure wrote: > dfaure requested changes to this revision. > dfaure added a comment. > This revision now requires changes to proceed. View Revision > > > I don't like it either. It doesn't "read" well.

D26877: Simplify calls to whitespace() and use it in more places.

2020-02-02 Thread Tomaz Canabrava
tcanabrava added a subscriber: ervin. tcanabrava added a comment. I like indentedStream. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26877 To: tcanabrava, dfaure, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26877: Simplify calls to whitespace() and use it in more places.

2020-02-02 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I don't like it either. It doesn't "read" well. Looking at cout or qDebug it's much more common to `[the usual stream] << [some modifier] << some more stuff`. Maybe it can

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

2020-02-02 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Well spotted. Sorry for the delay in my review. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25301 To: meven, #frameworks, dfaure Cc:

D22801: [KIO] silence a QFileInfo warning

2020-02-02 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. The bug is in the caller, fix it there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22801 To: rjvbb, #frameworks, dfaure Cc: dfaure, meven,

D25302: Remove stale symlink

2020-02-02 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks ok, although a unittest would have been even better. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D25302 To: sandsmark, dfaure Cc: dfaure,

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

2020-02-02 Thread David Faure
dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24951 To: ahmadsamir, dfaure, ngraham, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

2020-02-02 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > meven wrote in jobtest.cpp:2045 > Making an ioslave reading an env var for testing purposes is not a great > alternative. Does this mean the file could be made smaller again? (to reduce disk-space requirements) > file_unix.cpp:317 > + > +

D26342: Allow overriding to disable auto language detection

2020-02-02 Thread Simon Depiets
sdepiets added a comment. In D26342#585867 , @mludwig wrote: > I'd support such a change for the BackgroundChecker as well. KTextEditor needs a way to do its own language detection or override the detected language. I've updated the diff

D26342: Allow overriding to disable auto language detection

2020-02-02 Thread Simon Depiets
sdepiets updated this revision to Diff 74851. sdepiets added a comment. Allow overriding to disable auto language detection in BackGround Checker REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26342?vs=72540=74851 BRANCH master REVISION DETAIL

D27097: Port from QRegExp to QRegularExpression

2020-02-02 Thread Ahmad Samir
ahmadsamir added a comment. A couple of notes: - "Incremental" search isn't used by anything in KDE, AFAICS from lxr.kde.org, remove it (in a separate diff)? - Nothing in KDE uses the static KFind::find(... QRegExp..) directly; should we make the new one that takes a

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Fixed!

2020-02-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.14/6/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 02 Feb 2020 09:49:19 + Build duration: 2 min 28 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 156 - Fixed!

2020-02-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/156/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 02 Feb 2020 09:43:24 + Build duration: 5 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 85 - Fixed!

2020-02-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/85/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 02 Feb 2020 09:38:24 + Build duration: 3 min 56 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 82 - Fixed!

2020-02-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/82/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 02 Feb 2020 09:38:24 + Build duration: 2 min 5 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 111 - Fixed!

2020-02-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/111/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 02 Feb 2020 09:38:24 + Build duration: 2 min 41 sec and counting BUILD ARTIFACTS

D27097: Port from QRegExp to QRegularExpression

2020-02-02 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mlaurent, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::setMinimal() by making the regex pattern non-greedy, where possible. Deprecate the

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 84 - Still unstable!

2020-02-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/84/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 02 Feb 2020 09:23:09 + Build duration: 6 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 110 - Still unstable!

2020-02-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/110/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 02 Feb 2020 09:23:08 + Build duration: 6 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Still unstable!

2020-02-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 02 Feb 2020 09:23:08 + Build duration: 2 min 53 sec and counting JUnit Tests

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 81 - Still unstable!

2020-02-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/81/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 02 Feb 2020 09:23:08 + Build duration: 1 min 23 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 109 - Failure!

2020-02-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/109/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 02 Feb 2020 09:19:08 + Build duration: 2 min 7 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Failure!

2020-02-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 02 Feb 2020 09:19:08 + Build duration: 1 min 20 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 83 - Failure!

2020-02-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/83/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 02 Feb 2020 09:19:08 + Build duration: 1 min 28 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 80 - Failure!

2020-02-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/80/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 02 Feb 2020 09:19:08 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-02 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Regardless of issues, the change for the test is correct. We should break the test to highlight issues. Ship it! REPOSITORY R242 Plasma Framework (Library) BRANCH