D27152: Introduce FilesystemEntry class

2020-02-04 Thread Méven Car
meven added inline comments. INLINE COMMENTS > hallas wrote in filesystem_entry.cpp:47 > Yeah I agree ;) But I would really like for this class to be used more > generically so having a list of filesystems here would probably make it hard > for that. We could also have two methods, one similar

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 289 - Still Unstable!

2020-02-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/289/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 05 Feb 2020 04:46:20 + Build duration: 6 min 52 sec and counting JUnit Tests Name:

D25698: New query mechanism for applications: KApplicationTrader

2020-02-04 Thread David Faure
dfaure closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25698 To: dfaure, broulik, mart, vkrause, nicolasfella, aacid, davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27158: Fix some compiler warnings

2020-02-04 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > KConfigCodeGeneratorBase.cpp:45 > ParseResult ) > -: m_inputFile(inputFile), m_baseDir(baseDir), m_fileName(fileName), > m_cfg(parameters), parseResult(parseResult) > +: parseResult(parseResult),

D27148: update d->m_file in ReadOnlyPart::setUrl()

2020-02-04 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. statJob->exec() creates a nested event loop, which processes timers and socket events etc. -- this can create unexpected re-entrancy and is a nasty source of bugs. Therefore it

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

2020-02-04 Thread Noah Davis
ndavis marked 3 inline comments as done. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

2020-02-04 Thread Noah Davis
ndavis updated this revision to Diff 75022. ndavis marked an inline comment as done. ndavis added a comment. - More edits based on comments REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27017?vs=75021=75022 BRANCH hue-chroma (branched from master)

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

2020-02-04 Thread Noah Davis
ndavis marked 5 inline comments as done. ndavis added inline comments. INLINE COMMENTS > mwoehlke wrote in kcolorutils.h:36 > "0.999..." is a little odd, and I wonder if it is accurate for e.g. > `QColor::fromRgba64(0x, 0, 1}`? Maybe something like "just under 1.0 > (also red)" would be

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

2020-02-04 Thread Noah Davis
ndavis updated this revision to Diff 75021. ndavis added a comment. - Address comments REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27017?vs=74964=75021 BRANCH hue-chroma (branched from master) REVISION DETAIL https://phabricator.kde.org/D27017

D27152: Introduce FilesystemEntry class

2020-02-04 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:3 > +filesystem_entry.cpp > +filesystem_entry.h > fstabmanager.cpp remove > filesystem_entry.cpp:59 > +{ > +if (m_type == QLatin1Literal("fuse.encfs")) { > +return m_device + QLatin1Char('@') + m_mountPath;

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

2020-02-04 Thread Matthew Woehlke
mwoehlke added inline comments. INLINE COMMENTS > kcolorutils.cpp:60 > *c = khcy.c; > *h = khcy.h; > *y = khcy.y; I guess it will be less confusing if this is also normalized? *h = khcy.h + (khcy.h < 0.0 ? 1.0 : 0.0); > kcolorutils.h:36 > +/** > + * Calculate the hue of a

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove added a comment. I'm unable to build anything right now unluckly so I tried to use code from the breeze folder but I'm not good at cmake. I will try to make cmake for me tomorrow REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Nathaniel Graham
ngraham added a comment. Still not installing the file for me. Is this working for you? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75019. niccolove added a comment. Replace dialogs with widgets as that's the actual one REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75018=75019 BRANCH

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75018. niccolove added a comment. Fix cmake REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75017=75018 BRANCH contrast_effect_background_color (branched from master) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:12 > > +FILE(GLOB translucent_dialogs translucent/dialogs/*.svg) > +plasma_install_desktoptheme_svgs(default SUBPATH translucent/dialogs

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75017. niccolove added a comment. Updated cmake REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75010=75017 BRANCH contrast_effect_background_color (branched from master) REVISION

D27152: Introduce FilesystemEntry class

2020-02-04 Thread Stefan Brüns
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27152 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27148: update d->m_file in ReadOnlyPart::setUrl()

2020-02-04 Thread Piotr Dabrowski
pdabrowski marked an inline comment as done. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27148 To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure Cc: marten, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27148: update d->m_file in ReadOnlyPart::setUrl()

2020-02-04 Thread Piotr Dabrowski
pdabrowski updated this revision to Diff 75015. REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27148?vs=74970=75015 REVISION DETAIL https://phabricator.kde.org/D27148 AFFECTED FILES src/readonlypart.cpp src/readonlypart.h To: pdabrowski,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Nathaniel Graham
ngraham added a comment. Light version still looks good to me. For the dark version, I still see a difference between the background opacity of the panel and the pop-up: F8085688: Screenshot_20200204_132412.png REPOSITORY R242 Plasma Framework

D27148: update d->m_file in ReadOnlyPart::setUrl()

2020-02-04 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, dfaure. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27148 To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure Cc: marten, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27148: update d->m_file in ReadOnlyPart::setUrl()

2020-02-04 Thread Piotr Dabrowski
pdabrowski added inline comments. INLINE COMMENTS > readonlypart.cpp:80 > > +QUrl ReadOnlyPart::mostLocalUrl(QUrl url) const { > +KIO::StatJob* statJob = KIO::mostLocalUrl(url); TODO: mostLocalUrl(const QUrl ) REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27148

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove added a comment. I've done the dark theme again, should be nice now REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75010. niccolove added a comment. Tweaked contrast effect for dark and light versions, added new panel file for dark REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=74911=75010 BRANCH

D27148: update d->m_file in ReadOnlyPart::setUrl()

2020-02-04 Thread Piotr Dabrowski
pdabrowski added a comment. In D27148#605830 , @marten wrote: > Yes, I'd concluded that the real place to fix the problem was at the KParts level, but not being a KParts expert wanted to leave that decision to its maintainers. +1 for the

D25698: New query mechanism for applications: KApplicationTrader

2020-02-04 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. +1 Makes sense. REPOSITORY R309 KService BRANCH kapplicationtrader REVISION DETAIL https://phabricator.kde.org/D25698 To: dfaure, broulik, mart, vkrause, nicolasfella, aacid,

D25698: New query mechanism for applications: KApplicationTrader

2020-02-04 Thread Albert Astals Cid
aacid added a comment. For me it can go in, but i'm not really really netiher a Frameworks developer nor potentially a user of this class, so i'd feel more confortable if someone else also +1'ed On the other hand you're the mega-manintainer of everything, so i guess it can go in :)

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

2020-02-04 Thread Fabian Vogt
fvogt added a comment. In D27002#605999 , @ngraham wrote: > Could this be the fix for https://bugs.kde.org/show_bug.cgi?id=398908, or part of it? This leak presented itself by steadily growing memory use while something still unknown

D27158: Fix some compiler warnings

2020-02-04 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Fix order of member initialisation (compiling with -Wreorder) - Use Q_UNUSED where needed -

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

2020-02-04 Thread Nathaniel Graham
ngraham added a comment. Could this be the fix for https://bugs.kde.org/show_bug.cgi?id=398908, or part of it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks, davidedmundson, meven Cc: ngraham, anthonyfieroni, meven, kde-frameworks-devel,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove added a comment. In D27122#605987 , @ndavis wrote: > Don't make a color file for the breeze desktop theme. It doesn't have one so that it can use any system color scheme. Uhm; but then, there's no way for the default theme to

D27157: [KConfigLoader] Code cleanup

2020-02-04 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Drop redundant args to startElement()/endEelement() - Use range-for - Drop ConfigLoaderHandler methods

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Noah Davis
ndavis added a comment. In D27122#605982 , @niccolove wrote: > In D27122#605981 , @ndavis wrote: > > > In D27122#605976 , @niccolove wrote: > > > > >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove added a comment. In D27122#605981 , @ndavis wrote: > In D27122#605976 , @niccolove wrote: > > > In D27122#605975 , @ndavis wrote: > > > > >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Noah Davis
ndavis added a comment. In D27122#605976 , @niccolove wrote: > In D27122#605975 , @ndavis wrote: > > > Also, you can set contrast effects per desktop theme. If you do that, you may be able to

D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr

2020-02-04 Thread Piotr Wójcik
pwojcik added a comment. I want to remind about topic. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26245 To: pwojcik, kossebau, alexmerry Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-04 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R242:dccf6c4dd629: [Tests]Make radiobutton3.qml use PC3 (authored by gvgeo, committed by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-04 Thread Nathaniel Graham
ngraham added a comment. All right, your choice. I'll land this for you now. Great work! REPOSITORY R242 Plasma Framework (Library) BRANCH radiobutton (branched from master) REVISION DETAIL https://phabricator.kde.org/D27082 To: gvgeo, #plasma, davidedmundson Cc: ngraham,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove added a comment. In D27122#605975 , @ndavis wrote: > Also, you can set contrast effects per desktop theme. If you do that, you may be able to improve the look of breeze light without hurting breeze dark. Let the Breeze desktop theme

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Noah Davis
ndavis added a comment. Also, you can set contrast effects per desktop theme. If you do that, you may be able to improve the look of breeze light without hurting breeze dark. Let the Breeze desktop theme be a fairly neutral one that works well with most colorschemes. REPOSITORY R242

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Noah Davis
ndavis added a comment. In D27122#605969 , @niccolove wrote: > In D27122#605804 , @ndavis wrote: > > > Using View Background is semantically incorrect. If you want to change the color, you should

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove added a comment. In D27122#605973 , @ndavis wrote: > In D27122#605969 , @niccolove wrote: > > > In D27122#605804 , @ndavis wrote: > > > > >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Niccolò Venerandi
niccolove added a comment. In D27122#605804 , @ndavis wrote: > Using View Background is semantically incorrect. If you want to change the color, you should patch the color scheme. But in order to change ColorScheme-Background I should

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

2020-02-04 Thread Noah Davis
ndavis added a comment. Anyone want to accept this? REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

2020-02-04 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R237:d46739294d04: Add an isPropertyNameImmutable to know if a property is immutable (authored by meven). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-04 Thread Francis Herne
flherne added a comment. I got my Kirigami app to load by patching kirigami.{cpp,h}: Altered `resolveFilePath()` to `return QStringLiteral("qrc:/android_rcc_bundle/qml/org/kde/kirigami.2/") + path;` and similarly for `resolveFileUrl()`. Added

D27152: Introduce FilesystemEntry class

2020-02-04 Thread David Hallas
hallas added inline comments. INLINE COMMENTS > meven wrote in filesystem_entry.cpp:47 > It would be great to expose an enum (KIO's KFileSystemType does this a > little). > But given the number of filesystems this days, it may be overcomplicated. Yeah I agree ;) But I would really like for

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-02-04 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH arcpatch-D25326 REVISION DETAIL https://phabricator.kde.org/D25326 To: davidedmundson, broulik Cc: kmaterka, iasensio, ahmadsamir, broulik, ahiemstra, mart,

D25117: file ioslave: stop copying as soon as the ioslave is killed

2020-02-04 Thread Méven Car
meven added a task: T11627: Improve KIO asynchronicity. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11627: Improve KIO asynchronicity

2020-02-04 Thread Méven Car
meven added a revision: D25117: file ioslave: stop copying as soon as the ioslave is killed. TASK DETAIL https://phabricator.kde.org/T11627 To: meven Cc: ahartmetz, broulik, ognarb, #dolphin, #frameworks, meven, dfaure, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde,

D26342: Allow overriding to disable auto language detection

2020-02-04 Thread Simon Depiets
sdepiets added reviewers: cullmann, mlaurent. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks, cullmann, mlaurent Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27153: port sftp to Result system to force serialization of error/finish condition

2020-02-04 Thread Harald Sitter
sitter created this revision. sitter added reviewers: dfaure, feverfew. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the Result system was originally introduced to the FTP slave

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 288 - Still Unstable!

2020-02-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/288/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 04 Feb 2020 10:46:12 + Build duration: 8 min 5 sec and counting JUnit Tests Name:

D26858: Provide an implementation for the tablet interface

2020-02-04 Thread David Edmundson
davidedmundson added a comment. Feedback from some testing: - we're adding the same tool a bunch of times when a new client is created - sometimes we fail to enter the surface leaving the cursor "stuck" (with gtk3-demo) I'll see if I can spot why. FWIW, Qt have a tablet test

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

2020-02-04 Thread Méven Car
meven added a comment. In D27002#605864 , @fvogt wrote: > In D27002#605860 , @meven wrote: > > > User feedback: "so far so good, 160 MB Memory usage" > > Does not sound reassuring, I guess the

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

2020-02-04 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R241:213ed50634c0: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu (authored by fvogt). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27002?vs=74645=74989

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

2020-02-04 Thread Fabian Vogt
fvogt added a comment. In D27002#605860 , @meven wrote: > User feedback: "so far so good, 160 MB Memory usage" > Does not sound reassuring, I guess the user meant 160 MB compared to 200MB or similar prior to patch. Updated - should be

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

2020-02-04 Thread Fabian Vogt
fvogt edited the test plan for this revision. REPOSITORY R241 KIO BRANCH noleak REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks, davidedmundson, meven Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27123: Add a default provider (as per documentation)

2020-02-04 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R235:5f799b92559f: Add a default provider (as per documentation) (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27123?vs=74917=74988 REVISION

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

2020-02-04 Thread Méven Car
meven accepted this revision. meven added a comment. User feedback: "so far so good, 160 MB Memory usage" Does not sound reassuring, I guess the use meant 160 MB compared to 200MB prior to patch. REPOSITORY R241 KIO BRANCH noleak REVISION DETAIL https://phabricator.kde.org/D27002

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

2020-02-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH noleak REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks, davidedmundson Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

2020-02-04 Thread Fabian Vogt
fvogt added a comment. I'll land tomorrow if no objections. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27002 To: fvogt, #frameworks Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: WARNING: was bad recommendation (Re: Recommendation: drop ProvidersUrl entry to rely on default value)

2020-02-04 Thread Dan Leinir Turthra Jensen
On Friday, 31 January 2020 01:08:35 GMT Friedrich W. H. Kossebau wrote: > Hi, > > TLDR: removing the ProvidersUrl entry actually breaks things in non-Plasma > installations, so for now has to be hardcoded, using the non-deprecated > > ProvidersUrl=https://autoconfig.kde.org/ocs/providers.xml >

Re: Banning QNetworkAccessManager

2020-02-04 Thread Johan Ouwerkerk
On Mon, Feb 3, 2020 at 11:27 AM laurent Montel wrote: > > Le lundi 3 février 2020, 10:49:10 CET David Edmundson a écrit : > > I updated: > > > > https://community.kde.org/Policies/API_to_Avoid > > > > Which had no mention of this. > > > > David > > I think that you made an error > >

T12641: Refactor KFileProtocol::copy

2020-02-04 Thread Méven Car
meven created this task. meven triaged this task as "Normal" priority. meven added projects: Frameworks, Dolphin. TASK DESCRIPTION Our man file copy function has some glaring issues that I'd like to tackle in a few steps: - Split the sendfile and read/write code path to function, to make

Re: Banning QNetworkAccessManager

2020-02-04 Thread Johnny Jazeix
[...] > All of the places where we have actively hit this issue have already > been fixed (Marble and Attica come immediately to mind, not sure if > GCompris fixed their code). > I took a quick look and we use some code to handle redirection:

D26600: Refactor fstab handling

2020-02-04 Thread Méven Car
meven added inline comments. INLINE COMMENTS > system_filesystem_table_test.cpp:55 > +"devices /sys/fs/cgroup/devices cgroup > rw,nosuid,nodev,noexec,relatime,devices 0 0\n" > +"freezer /sys/fs/cgroup/freezer cgroup > rw,nosuid,nodev,noexec,relatime,freezer 0 0\n" > +"net_cls

D27152: Introduce FilesystemEntry class

2020-02-04 Thread Méven Car
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Nice one. Good step splitting out this. INLINE COMMENTS > filesystem_entry.cpp:47 > + > +QString FilesystemEntry::type() const > +{ It would be great to expose an enum (KIO's

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still Unstable!

2020-02-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/74/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 04 Feb 2020 08:44:49 + Build duration: 13 min and counting JUnit Tests Name:

D27148: update d->m_file in ReadOnlyPart::setUrl()

2020-02-04 Thread Jonathan Marten
marten added a comment. Yes, I'd concluded that the real place to fix the problem was at the KParts level, but not being a KParts expert wanted to leave that decision to its maintainers. +1 for the elegant fix. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27148

D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule

2020-02-04 Thread Benjamin Port
This revision was automatically updated to reflect the committed changes. Closed by commit R296:cacff0a30bc8: Allow to use KPropertySkeletonItem in ManagedConfigModule (authored by bport). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule

2020-02-04 Thread Kevin Ottens
ervin accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27132 To: bport, #plasma, ervin, meven, crossi Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule

2020-02-04 Thread Benjamin Port
bport updated this revision to Diff 74980. bport added a comment. cleanup REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27132?vs=74979=74980 REVISION DETAIL https://phabricator.kde.org/D27132 AFFECTED FILES

D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule

2020-02-04 Thread Benjamin Port
bport updated this revision to Diff 74979. bport added a comment. Don't cast twice if not needed REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27132?vs=74935=74979 REVISION DETAIL https://phabricator.kde.org/D27132 AFFECTED FILES

D26691: Optimize code when dropping files into the desktop

2020-02-04 Thread Tranter Madi
trmdi added a comment. In D26691#605802 , @jjazeix wrote: > Compilation fails: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/288/console > Missing the new file in the CMakeLists.txt

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Noah Davis
ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-04 Thread Noah Davis
ndavis added a comment. Why View Background? That's semantically incorrect. If you want to change the color, you should patch the color scheme. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: ndavis, filipf, ngraham,