D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me :) REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system,

D27185: Use the right translation catalog to show translations

yurchor created this revision. yurchor added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. yurchor requested review of this revision. REVISION SUMMARY Now translations for QML are not shown. Patch by Victor Ryzhykh TEST PLAN Run

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 290 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/290/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 06 Feb 2020 04:40:16 + Build duration: 8 min 37 sec and counting JUnit Tests Name:

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

ndavis added a comment. Any more suggestions? REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27178: Use ecm_qt_install_logging_categories over manual categories file

kossebau added a comment. Another example, here with categories declared in different directories, yet a single place where the categories file is generated and installed. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27178 To: kossebau, #build_system,

D27178: Use ecm_qt_install_logging_categories over manual categories file

kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27178 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27178: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau updated this revision to Diff 75069. kossebau added a comment. in doc also be explicit that ecm_qt_install_logging_categories can be in another directory, just needs to be called last REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D27178: Use ecm_qt_install_logging_categories over manual categories file

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Entries of generated file match existing file,

D27092: Update license statements to SPDX identifiers

cgiboudeaux added a comment. +1 LGTM REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27092 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27106: Convert license statements to SPDX markers

cgiboudeaux added inline comments. INLINE COMMENTS > COPYING:485 > > -This library is free software; you can redistribute it and/or > -modify it under the terms of the GNU Lesser General Public > -License as published by the Free Software Foundation; either > -version 2.1 of

About SPDX Header Reviews

Hi, I was asked to write about the starting (long) list of SPDX header conversion review requests and how deeply to review them. Here is my opinion -- and please feel free to take even a complete different opinion ;) -- about this: I am using a mostly automated conversion tooling for doing the

D27104: Convert license statements to SPDX headers

cordlandwehr added a comment. Thanks for the review, I requested David to clarify the license statement. (Unfortunately, exact this license statement is also used in different frameworks, but we will have to solve those issues when coming to there.) INLINE COMMENTS > cgiboudeaux wrote in

License Statement Clarification in KArchive

Hi David, during the SPDX license marker introduction into KArchive we found the following two files in KArchive with ambiguous license statements, which mix LGPL and GPL terms: https://cgit.kde.org/karchive.git/tree/src/krcc.cpp https://cgit.kde.org/karchive.git/tree/src/krcc.h For both

D27148: update d->m_file in ReadOnlyPart::setUrl()

ahmadsamir added a comment. I thought of making ReadOnlyPart::setUrl() set d->m_file if the url is a local file... but I am guessing d->m_file and d->m_url are kept separate on purpose, so the idea seemed a bit off. REPOSITORY R306 KParts REVISION DETAIL

D27148: update d->m_file in ReadOnlyPart::setUrl()

marten added a comment. @ahmadsamir: Yes, the problem could be fixed in Dolphin, but that leaves a potential trap for any other KPart that reimplements openUrl(). As a minimum, if it is decided that the fix belongs in the application then KParts::ReadOnlyPart should have a caution in

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi updated this revision to Diff 75056. crossi added a comment. fix compiling error for kcfgfile arg="true" REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27133?vs=75032=75056 REVISION DETAIL https://phabricator.kde.org/D27133 AFFECTED FILES

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi updated this revision to Diff 75059. crossi added a comment. update tests REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27133?vs=75056=75059 REVISION DETAIL https://phabricator.kde.org/D27133 AFFECTED FILES

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/75/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 05 Feb 2020 14:22:20 + Build duration: 2 min 15 sec and counting JUnit Tests Name:

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

This revision was automatically updated to reflect the committed changes. Closed by commit R296:7c4f46aded18: Allow ManagedConfigModule derived class to register explicitly… (authored by crossi). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

bport accepted this revision. bport added inline comments. INLINE COMMENTS > bport wrote in managedconfigmodule.cpp:145-146 > Those calls are done for each skeleton perhaps we can do only one call registerSettings is not on the hot path, so it will be ok REPOSITORY R296 KDeclarative

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

crossi updated this revision to Diff 75052. crossi added a comment. rebase REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26046?vs=74128=75052 REVISION DETAIL https://phabricator.kde.org/D26046 AFFECTED FILES

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

bport added inline comments. INLINE COMMENTS > managedconfigmodule.cpp:145-146 > + > +auto settingsChangedSlotIndex = > metaObject()->indexOfMethod("settingsChanged()"); > +auto settingsChangedSlot = > metaObject()->method(settingsChangedSlotIndex); > + Those calls are done for each

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

bport accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26046 To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27028: Switch from download.k.o to autoconfig

leinir added a reviewer: KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D27028 To: leinir, bcooksley, #frameworks, #knewstuff Cc: meven, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27028: Switch from download.k.o to autoconfig

leinir updated this revision to Diff 75044. leinir marked an inline comment as done. leinir added a comment. During some cleanup and addition, i realised it was silly to have the documentation for knsrc files in the widgets bits, and in two places. In addition, those places were both at

D27133: kconfig_compiler : generate kconfig settings with subgroup

meven added inline comments. INLINE COMMENTS > crossi wrote in KConfigSourceGenerator.cpp:335 > I'm open for another separator, btw this part is not intended for the user, > they have super user friendly KCM to edit their settings. > > Adding nested as you mentioned has bigger impact on

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi added inline comments. INLINE COMMENTS > meven wrote in KConfigSourceGenerator.cpp:335 > This character won't be easy on the user. > Ideally we perhaps would want to allow users to add > > We could use alternatively attributes. I'm open for another separator, btw this part is not

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi updated this revision to Diff 75032. crossi added a comment. remove TODO comment that was addressed REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27133?vs=74938=75032 REVISION DETAIL https://phabricator.kde.org/D27133 AFFECTED FILES

D27133: kconfig_compiler : generate kconfig settings with subgroup

meven added inline comments. INLINE COMMENTS > KConfigSourceGenerator.cpp:335 > +// TODO : what happened when same group is repeated ? > +if (mCurrentGroup.contains(QStringLiteral("\u241D"))) { > +stream() << " " << itemPath(entry, cfg()) << "->setGroup(cg" << >

D27148: update d->m_file in ReadOnlyPart::setUrl()

ahmadsamir added a comment. IIUC, this diff is fixing https://bugs.kde.org/show_bug.cgi?id=416989 (Konqueror -> Tools -> open terminal, doesn't work after D26140 ). Looking at the code in dolphin/src/dolphinpart.cpp, openUrl() is reimplemented[1],

D26749: WIP: Support NDK r20 and Qt 5.14

vkrause added a comment. Excellent news! Could you post your Kirigami patch somewhere maybe? Makes this easier to test here :) For icons we probably need a similar adjustment, I bet they got affected by the same Qt change. Same for translations I think, in ki18n. REPOSITORY R240

D27157: [KConfigLoader] Code cleanup

ahmadsamir updated this revision to Diff 75029. ahmadsamir added a comment. Tweak commit message REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27157?vs=75008=75029 BRANCH l-configloader (branched from master) REVISION DETAIL

D27158: Fix some compiler warnings

ahmadsamir updated this revision to Diff 75028. ahmadsamir added a comment. Add missing space after , REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27158?vs=75009=75028 BRANCH l-compiler-warnings (branched from master) REVISION DETAIL