D27640: templates: Convert license statements to SPDX headers

kossebau created this revision. kossebau added reviewers: Plasma, cordlandwehr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Also consistently use LGPL-2.1-or-later as default license

D27637: kill twitter support

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH killtwitter REVISION DETAIL https://phabricator.kde.org/D27637 To: nicolasfella, #frameworks, apol, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 441 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/441/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Feb 2020 04:43:05 + Build duration: 9 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 307 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/307/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 25 Feb 2020 04:43:05 + Build duration: 6 min 1 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 316 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/316/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 25 Feb 2020 04:43:05 + Build duration: 5 min 50 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 355 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/355/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Feb 2020 00:44:25 + Build duration: 2 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 208 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/208/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 25 Feb 2020 00:44:25 + Build duration: 2 min 31 sec and counting BUILD ARTIFACTS

D27633: Port to KPluginLoader

This revision was automatically updated to reflect the committed changes. Closed by commit R155:27487ab9276c: Port to KPluginLoader (authored by nicolasfella). REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27633?vs=76326=76335 REVISION DETAIL

D27637: kill twitter support

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, apol, bshah. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Twitter support in KAccounts has been reportedly

D27153: port sftp to Result system to force serialization of error/finish condition

feverfew accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH sftp-errors REVISION DETAIL https://phabricator.kde.org/D27153 To: sitter, dfaure, feverfew Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D27633: Port to KPluginLoader

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R155 KAccounts Integration BRANCH kpluginloader REVISION DETAIL https://phabricator.kde.org/D27633 To: nicolasfella, bshah, leinir, #frameworks, apol

D27633: Port to KPluginLoader

nicolasfella added reviewers: leinir, Frameworks. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27633 To: nicolasfella, bshah, leinir, #frameworks

D27635: Restore kio-webdav plugin

nicolasfella added a reviewer: Frameworks. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27635 To: nicolasfella, bshah, leinir, #frameworks

D27632: Implement UString operator= to make gcc happy

porten added a comment. On first sight I don't get how the class' memory management works these days. Before commenting on the patch I have to refresh my knowledge. REPOSITORY R314 KJs REVISION DETAIL https://phabricator.kde.org/D27632 To: aacid Cc: porten, kde-frameworks-devel,

D27632: Implement UString operator= to make gcc happy

aacid added a subscriber: porten. REPOSITORY R314 KJs REVISION DETAIL https://phabricator.kde.org/D27632 To: aacid Cc: porten, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27632: Implement UString operator= to make gcc happy

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY otherwise complains that there's a copy constructor but not an assignment operator REPOSITORY R314 KJs BRANCH

D27557: Auto-generate 24px monochrome icons

ngraham added a comment. Thanks so much everyone! @sitter I'll read up on CMake a bit and try to implement your suggestions. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: davidre, bcooksley, kossebau,

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 259 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/259/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 21:31:00 + Build duration: 2 min 9 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 151 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/151/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 21:31:00 + Build duration: 2 min 7 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 144 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/144/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 21:31:00 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in plasmawindowmanagement_interface.cpp:129 > how is this 9 already? Git blame shows that it's been 9 since 2018. Looks like someone made a mistake a while back? REPOSITORY R127 KWayland REVISION DETAIL

D27153: port sftp to Result system to force serialization of error/finish condition

dfaure accepted this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27153 To: sitter, dfaure, feverfew Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D27596: Load QM files from assets: URLs on Android

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. They used to work back when I added the code for it. Maybe it broke over time. If it works for you, go for it. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D27596: Load QM files from assets: URLs on Android

vkrause added a comment. In D27596#616554 , @apol wrote: > Don't we need an if Qt 5.13 elseif Qt 5.14? > > In other Qt versions it won't be in the assets... Are you sure about this? I had tested this on my Qt 5.13 setup and the files

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 440 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/440/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 17:20:31 + Build duration: 8 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 315 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/315/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 17:20:31 + Build duration: 6 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 306 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/306/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 17:20:31 + Build duration: 6 min 55 sec and counting JUnit Tests Name:

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 76317. hchain added a comment. const, change method name, reformat code REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75987=76317 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27607: Deprecate KDBusConnectionPool

vkrause updated this revision to Diff 76316. vkrause added a comment. Set EXCLUDE_DEPRECATED_BEFORE_AND_AT. REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27607?vs=76241=76316 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27607

D27594: Remove unused KDBusConnectionPool include

This revision was automatically updated to reflect the committed changes. Closed by commit R241:faace55f0bea: Remove unused KDBusConnectionPool include (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27594?vs=76207=76315 REVISION DETAIL

D23339: Fix memory leak in ConfigView and Dialog

davidedmundson accepted this revision as: davidedmundson. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23339 REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D25743: Expose IndexerState enum to QML

ngraham added a comment. Ping. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo, ngraham Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson,

D27628: Buttons: allow to scale up icons

ngraham added a comment. +1 visually and behaviorally; fixes the issues described in D27260 and D27449 . REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27628 To: mart,

D27628: Buttons: allow to scale up icons

mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27628 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27628: Buttons: allow to scale up icons

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY always scale icons unless a size is specified in the api. this makes icon sizing more in

D27617: [breeze-icons] Add telegram-desktop tray icons

ngraham added a comment. Yes, I have 1.9.12. I don't yet have an available update to 1.19.14 or later, sadly. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27617 To: rocka, #vdg, Fuchs Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27627: Fix initialization order

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27627 To: dvratil, #plasma, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D23339: Fix memory leak in ConfigView and Dialog

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23339 REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27616: [UrlHandler] optimise the code and less if nesting

apol added a comment. LGTM otherwise INLINE COMMENTS > urlhandler.cpp:55 > +// not a KDE application > +QDesktopServices::openUrl(u); > } won't this recurse forever? REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27616 To: ahmadsamir,

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

apol accepted this revision. REPOSITORY R252 Framework Integration BRANCH messagewidget (branched from master) REVISION DETAIL https://phabricator.kde.org/D27039 To: davidre, #frameworks, aacid, anthonyfieroni, apol Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27620: [krun] Share implementation of runService and runApplication

apol added a comment. Don't we need KDesktopFile::isAuthorizedDesktopFile now? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27620 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27620: [krun] Share implementation of runService and runApplication

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > krun.cpp:716 > +if (!flags.testFlag(DeleteTemporaryFiles)) { > +// Remember we opened those urls, for the "recent documents" menu in > kicker > +for

D27497: Fix code generation for entries with min/max

ervin added a comment. A few smallish issues only, otherwise LGTM. INLINE COMMENTS > KConfigSourceGenerator.cpp:316 > { > - stream() << " " << itemPath(entry, cfg()) << " = " > +QString innerItemVarStr(innerItemVar(entry, cfg())); > +if (!entry->signalList.isEmpty()) { I'd const

D27497: Fix code generation for entries with min/max

ervin requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27497 To: hchain, meven, crossi, ervin, bport, tcanabrava Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D24641: Collect more information from version control systems

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I guess nobody has further input then. LGTM. Ship it. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24641 To: thomasfischer, sitter, kossebau Cc:

D27504: WIP: RFC: smb faster copy to local

sitter added inline comments. INLINE COMMENTS > hallas wrote in kio_smb_dir.cpp:49 > Yes, you could (and should ;) ) use standard C++ for this, i.e.: > > std::unique_ptr buf; > buf = std::make_unique(segmentSize); we use c++11 so can't use make_unique and QBA seems excessive given the use.

D27502: Create ConfigView an unmanaged ConfigWidget

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > loader.h:6 > */ > -#ifndef SONNET_LOADER_P_H > -#define SONNET_LOADER_P_H > +#ifndef SONNET_LOADER_H > +#define SONNET_LOADER_H What's the reason for loader

D27627: Fix initialization order

dvratil created this revision. dvratil added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D23339: Fix memory leak in ConfigView and Dialog

dvratil added reviewers: Plasma, Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D23339: Fix memory leak in ConfigView and Dialog

dvratil updated this revision to Diff 76305. dvratil added a comment. - Rebase on current master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23339?vs=64284=76305 BRANCH arcpatch-D23339 REVISION DETAIL

D25682: add initial wsdiscovery support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:41397521423b: add initial wsdiscovery support (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25682?vs=73704=76301#toc REPOSITORY R320 KIO Extras CHANGES SINCE LAST

D27617: [breeze-icons] Add telegram-desktop tray icons

rocka added a comment. What's the version of telegram-desktop? Would it still be blue if change workspace theme to breeze-dark? If it works fine in breeze-dark and telegram version is 1.9.12, it maybe a upstream bug

D27153: port sftp to Result system to force serialization of error/finish condition

sitter updated this revision to Diff 76300. sitter added a comment. fix problems found by dfaure I've also added Q_REQUIRED_RESULT to fail() and pass() to help not forget to do something with the return value. there's no reason to call them and ignore the constructed object

D27617: [breeze-icons] Add telegram-desktop tray icons

ndavis added a comment. In D27617#616925 , @ngraham wrote: > Thanks for the patch! > > But...it's blue: :) > > F8128783: Screenshot_20200224_073346.png Weird. I can't see anything obviously

D27617: [breeze-icons] Add telegram-desktop tray icons

ngraham added a comment. Thanks for the patch! But...it's blue: :) F8128783: Screenshot_20200224_073346.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27617 To: rocka, #vdg, Fuchs Cc: ngraham,

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 258 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/258/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 13:54:12 + Build duration: 2 min 33 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/33/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 13:54:12 + Build duration: 2 min 48 sec and counting JUnit Tests

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 150 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/150/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 13:54:12 + Build duration: 2 min 37 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/143/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 13:54:12 + Build duration: 1 min 44 sec and counting JUnit Tests Name:

D27624: only install generated icons if they were generated

This revision was automatically updated to reflect the committed changes. Closed by commit R266:22a845115bc2: only install generated icons if they were generated (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27624?vs=76288=76292

D27622: only find bash once

This revision was automatically updated to reflect the committed changes. Closed by commit R266:82fc5404d041: only find bash once (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27622?vs=76285=76291#toc REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D27624: only install generated icons if they were generated

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27624 To: sitter, bshah, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27622: only find bash once

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27622 To: sitter, bshah, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27624: only install generated icons if they were generated

sitter created this revision. sitter added a reviewer: bshah. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY which is conditional on not being win32. this should fix win32 builds REPOSITORY R266

D27622: only find bash once

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:79 > +find_program(BASH_EXE bash) > +add_feature_info("24x24 generation" BASH_EXE "'bash' is require to > generate 24x24 variants") > + *required REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL

D27622: only find bash once

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27622 To: sitter, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27622: only find bash once

sitter created this revision. sitter added a reviewer: bshah. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27622

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre updated this revision to Diff 76284. davidre added a comment. - Introduce Plasma::Theme::palette REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27589?vs=76197=76284 BRANCH qiconcolor (branched from master) REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 142 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/142/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 13:34:52 + Build duration: 1 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 149 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/149/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 13:34:52 + Build duration: 2 min 12 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 257 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/257/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 13:34:52 + Build duration: 2 min 17 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 32 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/32/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 13:34:52 + Build duration: 53 sec and counting CONSOLE OUTPUT

D27557: Auto-generate 24px monochrome icons

sitter added a comment. This is now working again. The symlink tests fail though. That still needs fixing by someone who isn't me. Here's my feedback: For bash or sh scripts: - make sure a sh script is actually POSIX compliant by running it through a POSIX sh implementation

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 256 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/256/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 13:01:12 + Build duration: 3 min 52 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 141 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/141/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 13:01:12 + Build duration: 2 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 148 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/148/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 13:01:12 + Build duration: 2 min 8 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 31 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/31/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 13:01:12 + Build duration: 1 min 9 sec and counting CONSOLE OUTPUT

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

This revision was automatically updated to reflect the committed changes. Closed by commit R237:c8bf5e96cf2f: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in… (authored by crossi). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

ervin accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks, mdawson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 30 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/30/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 12:39:21 + Build duration: 1 min 33 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 147 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/147/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 12:39:20 + Build duration: 50 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 255 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/255/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 12:39:21 + Build duration: 50 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 140 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/140/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 12:39:20 + Build duration: 31 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 146 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/146/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 12:30:46 + Build duration: 1 min 0 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 29 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/29/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 12:30:46 + Build duration: 57 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 254 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/254/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 12:30:46 + Build duration: 49 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 139 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/139/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 12:30:45 + Build duration: 26 sec and counting CONSOLE OUTPUT

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks, mdawson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi updated this revision to Diff 76281. crossi added a comment. fix comment REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27059?vs=75829=76281 REVISION DETAIL https://phabricator.kde.org/D27059 AFFECTED FILES src/core/kcoreconfigskeleton.cpp

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/28/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 11:42:35 + Build duration: 1 min 28 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 145 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/145/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 11:42:36 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 253 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/253/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 11:42:36 + Build duration: 54 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 138 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/138/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 11:42:36 + Build duration: 25 sec and counting CONSOLE OUTPUT

D27614: build: fix the build where install prefix is not user-writable

This revision was automatically updated to reflect the committed changes. Closed by commit R266:462c5dfe2e9a: build: fix the build where install prefix is not user-writable (authored by bshah). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D27614: build: fix the build where install prefix is not user-writable

bshah updated this revision to Diff 76278. bshah added a comment. rebase REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27614?vs=76256=76278 BRANCH bshah/fix-build REVISION DETAIL https://phabricator.kde.org/D27614 AFFECTED FILES

D27557: Auto-generate 24px monochrome icons

davidre added a comment. I disagree but it's not my call REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27557: Auto-generate 24px monochrome icons

sitter added a comment. @davidre we provide a theme, if someone explicitly looks for a specific file within that theme that'd be squarely outside the supported realm of a theme. it'd prevent improving the theme which may mean changing scaling rules and removing the then useless sizes.

D27557: Auto-generate 24px monochrome icons

davidre added a comment. Also we need to have this on Windows, too. Breeze-icons is part of Frameworks and these were exported/installed files. A user could easily have a reference to one of the files somewhere. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27557: Auto-generate 24px monochrome icons

ndavis added a comment. Should we just revert for now? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27614: build: fix the build where install prefix is not user-writable

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I'd rather have the excess spaces been done away with. Otherwise LGTM, please rebase and land. REPOSITORY R266 Breeze Icons BRANCH bshah/fix-build REVISION DETAIL

  1   2   >