D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2020-02-27 Thread Nathaniel Graham
ngraham added a reviewer: meven.
ngraham added a comment.


  @emateli are you going to be able to finish this? Should someone take over? 
It would be a shame for such great work to get stalled so close to the finish 
line.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent, meven
Cc: meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, 
ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2020-02-27 Thread Nathaniel Graham
ngraham added a reviewer: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent, meven, #dolphin
Cc: meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, 
ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 111 - Still Unstable!

2020-02-27 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/111/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 28 Feb 2020 01:53:42 +
 Build duration:
2 min 7 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.

2020-02-27 Thread jonathan poelen
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27714

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D25654: Rename actions to be consistent

2020-02-27 Thread Nicolas Fella
nicolasfella updated this revision to Diff 76587.
nicolasfella added a comment.


  rebase

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25654?vs=70674=76587

BRANCH
  arcpatch-D25654

REVISION DETAIL
  https://phabricator.kde.org/D25654

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D25654: Rename actions to be consistent

2020-02-27 Thread Nicolas Fella
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:dddb013871ba: Rename actions to be consistent (authored 
by nicolasfella).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25654?vs=76587=76588

REVISION DETAIL
  https://phabricator.kde.org/D25654

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27654: [kio] Fix running konsole on Wayland

2020-02-27 Thread David Faure
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Hum. OK. Weird.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27654

To: wbauer, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27709: Move job classes to kaccounts lib and rename to *Job

2020-02-27 Thread Nicolas Fella
nicolasfella retitled this revision from "Move job classes to kaccounts lib" to 
"Move job classes to kaccounts lib and rename to *Job".

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27709

To: nicolasfella, #frameworks, bshah, leinir


D27709: Move job classes to kaccounts lib

2020-02-27 Thread Nicolas Fella
nicolasfella updated this revision to Diff 76580.
nicolasfella added a comment.


  - Rename to *Job

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27709?vs=76573=76580

BRANCH
  decl

REVISION DETAIL
  https://phabricator.kde.org/D27709

AFFECTED FILES
  example/accounts.qml
  src/declarative/CMakeLists.txt
  src/declarative/kaccountsdeclarativeplugin.cpp
  src/jobs/accountservicetoggle.cpp
  src/jobs/accountservicetoggle.h
  src/jobs/createaccount.cpp
  src/jobs/createaccount.h
  src/kcm/package/contents/ui/AvailableAccounts.qml
  src/kcm/package/contents/ui/AvailableServices.qml
  src/lib/CMakeLists.txt
  src/lib/accountservicetogglejob.cpp
  src/lib/accountservicetogglejob.h
  src/lib/createaccountjob.cpp
  src/lib/createaccountjob.h
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir


D27528: Adapt action numbering in Android to work like in KNotifications

2020-02-27 Thread Nicolas Fella
nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Let's get this in. Can you please give me your full name and email address so 
I can merge this?

REPOSITORY
  R289 KNotifications

BRANCH
  adapt-action-numbering-in-android-as-in-knotifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27709: Move job classes to kaccounts lib

2020-02-27 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This makes including them from the qml plugin less weird and they might be 
interesting to use from C++ too.

TEST PLAN
  builds, kcm opens

REPOSITORY
  R155 KAccounts Integration

BRANCH
  decl

REVISION DETAIL
  https://phabricator.kde.org/D27709

AFFECTED FILES
  src/declarative/CMakeLists.txt
  src/declarative/kaccountsdeclarativeplugin.cpp
  src/jobs/accountservicetoggle.cpp
  src/jobs/accountservicetoggle.h
  src/jobs/createaccount.cpp
  src/jobs/createaccount.h
  src/lib/CMakeLists.txt
  src/lib/accountservicetoggle.cpp
  src/lib/accountservicetoggle.h
  src/lib/createaccount.cpp
  src/lib/createaccount.h
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76572.
niccolove marked an inline comment as done.
niccolove added a comment.


  Fixed margin

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76534=76572

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27708: Cleanup accounts kded module

2020-02-27 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Rename to emphasize it's a kded module plus some random cleanup

TEST PLAN
  builds, kded5 starts

REPOSITORY
  R155 KAccounts Integration

BRANCH
  kded

REVISION DETAIL
  https://phabricator.kde.org/D27708

AFFECTED FILES
  src/CMakeLists.txt
  src/daemon/CMakeLists.txt
  src/daemon/daemon.cpp
  src/daemon/daemon.h
  src/daemon/kded_accounts.json
  src/daemon/kio-webdav/CMakeLists.txt
  src/daemon/kio-webdav/createkioservice.cpp
  src/daemon/kio-webdav/createkioservice.h
  src/daemon/kio-webdav/createnetattachjob.cpp
  src/daemon/kio-webdav/createnetattachjob.h
  src/daemon/kio-webdav/kioservices.cpp
  src/daemon/kio-webdav/kioservices.h
  src/daemon/kio-webdav/removekioservice.cpp
  src/daemon/kio-webdav/removekioservice.h
  src/daemon/kio-webdav/removenetattachjob.cpp
  src/daemon/kio-webdav/removenetattachjob.h
  src/daemon/kio-webdav/tests/CMakeLists.txt
  src/daemon/kio-webdav/tests/testnetattachjobs.cpp
  src/kded/CMakeLists.txt
  src/kded/kded_accounts.cpp
  src/kded/kded_accounts.h
  src/kded/kded_accounts.json
  src/kded/kio-webdav/CMakeLists.txt
  src/kded/kio-webdav/createkioservice.cpp
  src/kded/kio-webdav/createkioservice.h
  src/kded/kio-webdav/createnetattachjob.cpp
  src/kded/kio-webdav/createnetattachjob.h
  src/kded/kio-webdav/kioservices.cpp
  src/kded/kio-webdav/kioservices.h
  src/kded/kio-webdav/removekioservice.cpp
  src/kded/kio-webdav/removekioservice.h
  src/kded/kio-webdav/removenetattachjob.cpp
  src/kded/kio-webdav/removenetattachjob.h
  src/kded/kio-webdav/tests/CMakeLists.txt
  src/kded/kio-webdav/tests/testnetattachjobs.cpp

To: nicolasfella, #frameworks, bshah, leinir


D27707: Use kcoreaddons_add_plugin for kded module

2020-02-27 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REPOSITORY
  R155 KAccounts Integration

BRANCH
  plug

REVISION DETAIL
  https://phabricator.kde.org/D27707

AFFECTED FILES
  src/daemon/CMakeLists.txt
  src/daemon/accounts.desktop
  src/daemon/kded_accounts.json

To: nicolasfella, #frameworks, bshah, leinir


D27706: Random cmake cleanup

2020-02-27 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Remove unneeded calls, make coding style a bit more consistent

TEST PLAN
  builds

REPOSITORY
  R155 KAccounts Integration

BRANCH
  cmakecleanup

REVISION DETAIL
  https://phabricator.kde.org/D27706

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt

To: nicolasfella, #frameworks, bshah, leinir


D27705: Use QStringLiteral

2020-02-27 Thread Nicolas Fella
nicolasfella updated this revision to Diff 76566.
nicolasfella added a comment.


  Remove unintended change

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27705?vs=76565=76566

BRANCH
  arcpatch-D27705

REVISION DETAIL
  https://phabricator.kde.org/D27705

AFFECTED FILES
  src/jobs/createaccount.cpp
  src/kcm/accounts.cpp
  src/lib/getcredentialsjob.cpp
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir


D27705: Use QStringLiteral

2020-02-27 Thread Nicolas Fella
nicolasfella updated this revision to Diff 76565.
nicolasfella added a comment.


  Remove unintended changes

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27705?vs=76563=76565

BRANCH
  arcpatch-D27705

REVISION DETAIL
  https://phabricator.kde.org/D27705

AFFECTED FILES
  CMakeLists.txt
  src/jobs/createaccount.cpp
  src/kcm/accounts.cpp
  src/lib/getcredentialsjob.cpp
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir


D27705: Use QStringLiteral

2020-02-27 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Don't use naked strings

TEST PLAN
  builds

REPOSITORY
  R155 KAccounts Integration

BRANCH
  qsl

REVISION DETAIL
  https://phabricator.kde.org/D27705

AFFECTED FILES
  CMakeLists.txt
  src/jobs/createaccount.cpp
  src/kcm/accounts.cpp
  src/lib/getcredentialsjob.cpp
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir


D27444: Added top area

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76562.
niccolove added a comment.


  Hardcoded colors

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27444?vs=76378=76562

BRANCH
  top_area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27444

AFFECTED FILES
  src/desktoptheme/breeze/widgets/toparea.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27704: Drop FindAccountsFileDir.cmake

2020-02-27 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REVISION SUMMARY
  no one is using it

REPOSITORY
  R155 KAccounts Integration

BRANCH
  cma

REVISION DETAIL
  https://phabricator.kde.org/D27704

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/cmake/CMakeLists.txt
  src/lib/cmake/FindAccountsFileDir.cmake

To: nicolasfella, #frameworks, bshah, leinir


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Nathaniel Graham
ngraham added a dependent revision: D27697: WIP: Added top area to notification 
header.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-27 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R273:1275529bc2d5: [UrlHandler] Handle opening the online docs 
for KCM modules (authored by ahmadsamir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27616?vs=76522=76555#toc

REPOSITORY
  R273 KGuiAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27616?vs=76522=76555

REVISION DETAIL
  https://phabricator.kde.org/D27616

AFFECTED FILES
  src/util/urlhandler.cpp

To: ahmadsamir, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 217 - Fixed!

2020-02-27 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/217/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 27 Feb 2020 15:32:48 +
 Build duration:
2 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.68.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513 Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(3/4)62%
(13/21)62%
(13/21)47%
(1301/2759)26%
(482/1837)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src69%
(9/13)69%
(9/13)40%
(834/2108)24%
(343/1422)src.libkirigami50%
(3/6)50%
(3/6)73%
(466/642)33%
(139/415)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 364 - Fixed!

2020-02-27 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/364/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 27 Feb 2020 15:32:48 +
 Build duration:
2 min 6 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.68.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(3/4)62%
(13/21)62%
(13/21)47%
(1301/2759)26%
(482/1837)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src69%
(9/13)69%
(9/13)40%
(834/2108)24%
(343/1422)src.libkirigami50%
(3/6)50%
(3/6)73%
(466/642)33%
(139/415)

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 41 - Fixed!

2020-02-27 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/41/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 27 Feb 2020 15:32:48 +
 Build duration:
2 min 4 sec and counting
   JUnit Tests
  Name: projectrootC_.CI.Job_Build Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-27 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R273 KGuiAddons

BRANCH
  l-urlhandler-optimi (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27616

To: ahmadsamir, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 363 - Still Unstable!

2020-02-27 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/363/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 27 Feb 2020 13:01:08 +
 Build duration:
2 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.68.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 4 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/20)0%
(0/20)0%
(0/2704)0%
(0/1837)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/13)0%
(0/13)0%
(0/2068)0%
(0/1422)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/628)0%
(0/415)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 216 - Still Unstable!

2020-02-27 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/216/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 27 Feb 2020 13:01:08 +
 Build duration:
2 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.68.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513 Failed: 4 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/20)0%
(0/20)0%
(0/2704)0%
(0/1837)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/13)0%
(0/13)0%
(0/2068)0%
(0/1422)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/628)0%
(0/415)

D27633: Port to KPluginLoader

2020-02-27 Thread Luca Beltrame
lbeltrame added a comment.


  This currently causes a compile error:
  

/home/abuild/rpmbuild/BUILD/kaccounts-integration-20.03.70git.20200225T132248~74e770c/src/daemon/daemon.cpp:62:78:
 error: call of overloaded 'create(AccountsDaemon*, )' is ambiguous

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol
Cc: lbeltrame


KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 362 - Still Unstable!

2020-02-27 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/362/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 27 Feb 2020 12:16:18 +
 Build duration:
2 min 51 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.68.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 4 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/20)0%
(0/20)0%
(0/2704)0%
(0/1837)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/13)0%
(0/13)0%
(0/2068)0%
(0/1422)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/628)0%
(0/415)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 215 - Still Unstable!

2020-02-27 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/215/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 27 Feb 2020 12:16:18 +
 Build duration:
2 min 21 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.68.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513 Failed: 4 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/20)0%
(0/20)0%
(0/2704)0%
(0/1837)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/13)0%
(0/13)0%
(0/2068)0%
(0/1422)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/628)0%
(0/415)

D27696: Fix scrolling on the EntryDetails page

2020-02-27 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:94015abda31b: Fix scrolling on the EntryDetails page 
(authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27696?vs=76532=76535

REVISION DETAIL
  https://phabricator.kde.org/D27696

AFFECTED FILES
  src/qtquick/qml/EntryDetails.qml

To: leinir, ngraham, #frameworks, #plasma, hexchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27696: Fix scrolling on the EntryDetails page

2020-02-27 Thread hexchain
hexchain accepted this revision.
hexchain added a comment.
This revision is now accepted and ready to land.


  Looks good on khotnewstuff-dialog. Thanks!

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-scrolling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27696

To: leinir, ngraham, #frameworks, #plasma, hexchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove marked an inline comment as done.
niccolove added inline comments.

INLINE COMMENTS

> ahiemstra wrote in TopArea.qml:40
> This conditional is wrong. The syntax is `condition ? true_case : false_case` 
> so you want to write `flipped ? -topAreaSvg.margins.top : 
> -topAreaSvg.margins.bottom` or something similar.

Dumb me. I'm used to python.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76534.
niccolove added a comment.


  Fixed conditionals

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76531=76534

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Arjen Hiemstra
ahiemstra added inline comments.

INLINE COMMENTS

> TopArea.qml:40
> +rightInset: -topAreaSvg.margins.right
> +topInset: -topAreaSvg.margins.bottom ? flipped : -topAreaSvg.margins.top
> +bottomInset: -topAreaSvg.margins.bottom ? flipped : 
> -topAreaSvg.margins.top

This conditional is wrong. The syntax is `condition ? true_case : false_case` 
so you want to write `flipped ? -topAreaSvg.margins.top : 
-topAreaSvg.margins.bottom` or something similar.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27696: Fix scrolling on the EntryDetails page

2020-02-27 Thread Dan Leinir Turthra Jensen
leinir added reviewers: ngraham, Frameworks, Plasma, hexchain.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27696

To: leinir, ngraham, #frameworks, #plasma, hexchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27696: Fix scrolling on the EntryDetails page

2020-02-27 Thread Dan Leinir Turthra Jensen
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  For ScrollablePage to be able to scroll, the scrollable content must
  be the last Item on the page.
  
  BUG:418191

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-scrolling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27696

AFFECTED FILES
  src/qtquick/qml/EntryDetails.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76531.
niccolove added a comment.


  Fixed svg path

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76528=76531

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove added a dependent revision: D27189: Created a top area based on 
widgets/toparea.svg.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76528.
niccolove added a comment.


  Added licence

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=76527=76528

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove added a reviewer: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This creates a new component that uses the widgets/toparea svg. First time I 
try to add something to PlasmaComponents, so I probably got stuff wrong and I 
probably have to still do thing like adding documentation. I'm creating the 
diff to get feedback on how to move forward with this.
  
  Depends on D27444 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/TopArea.qml

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27444: Added top area

2020-02-27 Thread Niccolò Venerandi
niccolove added a dependent revision: D27695: WIP: Create a new TopArea element 
using widgets/toparea svg.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-27 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 76522.
ahmadsamir added a comment.


  Really revert some changes

REPOSITORY
  R273 KGuiAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27616?vs=76474=76522

BRANCH
  l-urlhandler-optimi (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27616

AFFECTED FILES
  src/util/urlhandler.cpp

To: ahmadsamir, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-27 Thread Kevin Ottens
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> settings.cpp:62
>  
> -bool Settings::setCheckUppercase(bool check)
> +void Settings::setSkipUppercase(bool check)
>  {

Rename the parameter to skip as well please

> settingsimpl.cpp:260
>  //same defaults are in the default filter (filter.cpp)
> -d->checkUppercase = settings.value(QStringLiteral("checkUppercase"), 
> true).toBool();
> -d->skipRunTogether = settings.value(QStringLiteral("skipRunTogether"), 
> true).toBool();
> +d->checkUppercase = settings.value(QStringLiteral("checkUppercase"), 
> Settings::defaultSkipUppercase()).toBool();
> +d->skipRunTogether = settings.value(QStringLiteral("skipRunTogether"), 
> Settings::defauktSkipRunTogether()).toBool();

I'd expect a negation here... if by default skip is false, check in 
settingsimpl should be true (which was the old default).

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27502

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns