D27152: Introduce FilesystemEntry class

2020-03-03 Thread David Hallas
hallas updated this revision to Diff 76898. hallas marked 9 inline comments as done. hallas added a comment. Addressed review comments REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27152?vs=75961=76898 BRANCH introduce_filesystem_entry REVISION DETAIL

D27152: Introduce FilesystemEntry class

2020-03-03 Thread David Hallas
hallas added a comment. @bruns - thanks a lot for the feedback, I have updated the patch with your suggestions. INLINE COMMENTS > bruns wrote in filesystem_entry.cpp:77 > Why don't you just keep the string? It was merely meant as an optimization, I don't know if it makes sense - I'll

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-03 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:55a43cf13514: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-03 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:0bbe57ef7f33: [ModifiedFileIndexer] Correct time checks for new files (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27767?vs=76744=76892

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Carson Black
cblack added a dependent revision: D27818: [wayland/AbstractClient] Broadcast application menu events. REPOSITORY R127 KWayland BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag, davidedmundson Cc: davidedmundson,

D27816: KI18N_WRAP_UI macro: set SKIP_AUTOUIC property on ui file and gen. header

2020-03-03 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, ilic. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R249 KI18n BRANCH setskipautouic REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Vlad Zahorodnii
zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Thanks. Even though the patch is accepted, please do not land it yet. https://phabricator.kde.org/D27464#621521 REPOSITORY R127 KWayland BRANCH cblack/appmenu-listener REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Carson Black
cblack updated this revision to Diff 76886. cblack added a comment. Add missing documentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76885=76886 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Vlad Zahorodnii
zzag added a comment. Looks good to me, but please don't land without corresponding KWin patch. INLINE COMMENTS > plasmawindowmanagement.h:700 > +/** > + * TODO: Documentation. > + **/ You missed this one. REPOSITORY R127 KWayland REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Carson Black
cblack updated this revision to Diff 76885. cblack added a comment. Address feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76811=76885 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement.cpp:372 > + > +Q_UNUSED(window); > +} Please move it to the top of the method and remove the semicolon. > plasmawindowmanagement.h:526-527 > > +QString applicationMenuServiceName() const; > +QString

D27810: Correctly disable UDS_ACCESS being set

2020-03-03 Thread Alexander Saoutkin
feverfew added a comment. In D27810#621427 , @sitter wrote: > I am pretty sure I picked that up somewhere, might be worth asking lxr for possible other places we set ACCESS to -1 grep through kio/kio-extras doesn't reveal this being a

D27801: smb: add a unit test for smburl

2020-03-03 Thread Aleix Pol Gonzalez
apol added a comment. +1 from me INLINE COMMENTS > apol wrote in smburl.cpp:67 > Can't we then just rename the method to `::cdUp()`? it can return void too, nobody is checking it anyway. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27801 To: sitter, ngraham

D27810: Correctly disable UDS_ACCESS being set

2020-03-03 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R320:01e442c75140: Correctly disable UDS_ACCESS being set (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27810?vs=76872=76879#toc REPOSITORY R320 KIO Extras

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-03 Thread Alexander Stippich
astippich added a comment. I would like to request a clear answer for https://phabricator.kde.org/D25517 once again REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27767 To: bruns, #baloo, ngraham, astippich Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs,

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Carson Black
cblack added a comment. @zzag does anything else look off to you? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-03 Thread Alexander Stippich
astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27767 To: bruns, #baloo, ngraham, astippich Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas,

D25388: Make constructor explicit and cleanup QWebPluginFactory #include.

2020-03-03 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R300 KDEWebKit REVISION DETAIL https://phabricator.kde.org/D25388 To: jhayes Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-03 Thread Alexander Stippich
astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27766 To: bruns, #baloo, ngraham, astippich Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 66 - Still Unstable!

2020-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/66/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 03 Mar 2020 18:47:30 + Build duration: 3 min 56 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 100 - Still Unstable!

2020-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/100/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Mar 2020 18:47:30 + Build duration: 4 min 21 sec and counting JUnit Tests

D26749: Support NDK r20 and Qt 5.14

2020-03-03 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c9ebd3917e59: Support NDK r20 and Qt 5.14 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26749?vs=73822=76876 REVISION DETAIL

D27811: [KConfigGui] Check font weight when clearing styleName property

2020-03-03 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, davidedmundson, cfeck, ervin, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This is an addendum for commit a2774ff5b41987c3919a9e

D27810: Correctly disable UDS_ACCESS being set

2020-03-03 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I am pretty sure I picked that up somewhere, might be worth asking lxr for possible other places we set ACCESS to -1 REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D27810: Correctly disable UDS_ACCESS being set

2020-03-03 Thread David Edmundson
davidedmundson edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27810 To: davidedmundson, sitter, feverfew Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2,

D27810: Correctly disable UDS_ACCESS being set

2020-03-03 Thread David Edmundson
davidedmundson created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY 718abcb69b78385123dd7a05a66a656af772d581

D27810: Correctly disable UDS_ACCESS being set

2020-03-03 Thread David Edmundson
davidedmundson added reviewers: sitter, feverfew. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27810 To: davidedmundson, sitter, feverfew Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2,

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Nathaniel Graham
ngraham added a comment. In D27807#621347 , @ndavis wrote: > It's strange that the plasma-devel mailing list isn't automatically added, even when it's a reviewer group. Because then people who are both subscribed to the mailing list and

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Noah Davis
ndavis added a subscriber: plasma-devel. ndavis added a comment. It's strange that the plasma-devel mailing list isn't automatically added, even when it's a reviewer group. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove,

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Noah Davis
ndavis added a comment. Wouldn't it make more sense to use different pressed and hovered states instead of designing the pressed state to be used as a hover state because the hover state isn't used? Also, it's strange that listitem.svg and viewitem.svg both exist and are both used for

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-03-03 Thread Méven Car
meven added a comment. I fixed an issue when testing this with D27477 and it is fixed and the issue it revealed is tested. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc:

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-03-03 Thread Méven Car
meven updated this revision to Diff 76866. meven added a comment. Improve naming, fix case of normal entries, adding a test for this case REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=76856=76866 BRANCH arcpatch-D27463_1 REVISION DETAIL

D27802: smb: fix ipv6 support

2020-03-03 Thread Thiago Macieira
thiago added a comment. STD3 also forbids domain labels ending in dash, so can you add a test for `smb://[fe80::]/` too? You'll need to adjust your code REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27802 To: sitter, ngraham Cc: thiago, kde-frameworks-devel,

D27504: WIP: RFC: smb faster copy to local

2020-03-03 Thread Harald Sitter
sitter updated this revision to Diff 76865. sitter added a comment. - refine code a bit - extend to ::get works same as smbCopyGet. in fact I feel like the two functions should be merged. at their hearts they both could read into QIODevices (QFile/QBuffer(QBA)) - use segment class for

D27804: smb: add hack to support spaces in workgroup names

2020-03-03 Thread Thiago Macieira
thiago added a comment. Looks good, but testing should be extended. I suggest: 1. A workgroup with non-US-ASCII characters in the name, if that's permitted 2. A workgroup with % in the name: the URL should have "%25" 3. Roundtrip checking. The test only does toSmbcUrl(), so please

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Marco Martin
mart added a comment. I would call the component PlasmoidHeading, to make clear it's only for use in plasmoids INLINE COMMENTS > TopArea.qml:28 > + > +property bool flipped: false > + enum Location { Header, Footer (maybe a middle as well?) } property Location

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76862. niccolove added a comment. Replace test with widgets/toparea REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76860=76862 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove added a comment. In D27695#621305 , @davidedmundson wrote: > PC3 is designed to be only a theme for QQC2 That's why I moved it to plasmaextracomponent with the last commit, actually REPOSITORY R242 Plasma Framework (Library)

D27801: smb: add a unit test for smburl

2020-03-03 Thread Harald Sitter
sitter updated this revision to Diff 76861. sitter added a comment. follow Aleix' suggestion and change cd() to cdUp() seeing as it now only cds up REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27801?vs=76832=76861 BRANCH smb-smburl-static-autotest

D27800: smb: split module into two targets of which one is a static lib

2020-03-03 Thread Harald Sitter
sitter added a comment. used in D27801 REPOSITORY R320 KIO Extras BRANCH smb-smburl-static REVISION DETAIL https://phabricator.kde.org/D27800 To: sitter, ngraham, apol Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread David Edmundson
davidedmundson added a comment. PC3 is designed to be only a theme for QQC2 For new API this is the wrong place. INLINE COMMENTS > TopArea.qml:44 > +id: topAreaSvg > +imagePath: "test" > +prefix: flipped? 'flipped' : '' test? REPOSITORY R242 Plasma Framework

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76860. niccolove added a comment. Moved the file to Extra components REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76822=76860 BRANCH master REVISION DETAIL

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove added reviewers: VDG, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY The style of pressed- listitem (which is actually often used for hover as well, while the hover- listitem is never

D27805: Add a screenshot capture item and use it to test rendering

2020-03-03 Thread David Edmundson
davidedmundson added a comment. I love the direction. + INLINE COMMENTS > ItemCapture.cpp:59 > +qWarning() << "No previous image found for capture" << d->name; > +QVERIFY2(result->saveToFile(dir.absoluteFilePath(filePath)), "Unable > to store first version of capture.");

D27800: smb: split module into two targets of which one is a static lib

2020-03-03 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good, it's not being used though so as is it feels wrong. REPOSITORY R320 KIO Extras BRANCH smb-smburl-static REVISION DETAIL https://phabricator.kde.org/D27800 To: sitter,

D27801: smb: add a unit test for smburl

2020-03-03 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > smburl.cpp:67 > > bool SMBUrl::cd(const QString ) > { Can't we then just rename the method to `::cdUp()`? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27801 To: sitter, ngraham Cc: apol, kde-frameworks-devel,

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-03-03 Thread Méven Car
meven updated this revision to Diff 76856. meven added a comment. Fix no value set case REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=76849=76856 BRANCH arcpatch-D27463_1 REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES

D27805: Add a screenshot capture item and use it to test rendering

2020-03-03 Thread Arjen Hiemstra
ahiemstra created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds the ItemCapture item to the test runner, which can be used to capture images of items and compare them

D23457: Port the search interface from QRegExp to QRegularExpression

2020-03-03 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 76852. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Modify the extended context menu: - QRegularExpression supports fixed-length positive/negative lookbehind - With QRegularExpression/PCRE, \x escape sequences

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 447 - Still Unstable!

2020-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/447/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Mar 2020 13:42:47 + Build duration: 9 min 43 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 313 - Still Unstable!

2020-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/313/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Mar 2020 13:42:48 + Build duration: 8 min 12 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 322 - Still Unstable!

2020-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/322/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 03 Mar 2020 13:42:48 + Build duration: 7 min 33 sec and counting BUILD ARTIFACTS

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-03-03 Thread Méven Car
meven updated this revision to Diff 76849. meven added a comment. Move values attribute for ItemEnum::Choice to KCoreConfigSkeleton::ItemEnum::ItemEnum::mValues to preserve Binary compatiblity REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D27787: Remove 48px telegram icons

2020-03-03 Thread Noah Davis
ndavis added a comment. In D27787#621050 , @rocka wrote: > Could we please not remove this icon, or at least keep it available as an alternative? It fits the general style so well. The only way to have alternative icons is to make an

D27804: smb: add hack to support spaces in workgroup names

2020-03-03 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY workgroup names are as best I can tell always still netbios names

D27152: Introduce FilesystemEntry class

2020-03-03 Thread Stefan Brüns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > filesystem_entry.cpp:77 > +{ > +return m_type == FilesystemType::Unknown ? m_typeString : > FilesystemTypeToString(m_type); > +} Why don't you just keep

D27802: smb: fix ipv6 support

2020-03-03 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY libsmbc doesn't presently support smb://[ABCD::DCBA]/ uris because it

D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-03-03 Thread Cyril Rossi
crossi edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27801: smb: add a unit test for smburl

2020-03-03 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY only tests some of the obvious scenarios I can see right now.

D27133: kconfig_compiler : generate kconfig settings with subgroup

2020-03-03 Thread Cyril Rossi
crossi updated this revision to Diff 76833. crossi added a comment. rework: introduce parentGroup attribute to group element REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27133?vs=75059=76833 REVISION DETAIL https://phabricator.kde.org/D27133 AFFECTED

D27800: smb: split module into two targets of which one is a static lib

2020-03-03 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this allows us to use the intermediate static target for unit testing

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread David Edmundson
davidedmundson accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27676: smb: ecm clang-format the entire code base

2020-03-03 Thread Harald Sitter
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:a1775f44b8fb: smb: ecm clang-format the entire code base (authored by sitter). REPOSITORY R320 KIO Extras CHANGES

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 42 - Unstable!

2020-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/42/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 03 Mar 2020 09:16:09 + Build duration: 4 min 14 sec and counting JUnit Tests

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76822. niccolove added a comment. Width is fill anyway, no need to calculate it REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76572=76822 BRANCH master REVISION DETAIL

D27787: Remove 48px telegram icons

2020-03-03 Thread Rocket Aaron
rocka added a comment. Could we please not remove this icon, or at least keep it available as an alternative? It fits the general style so well. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27787 To: ndavis, #vdg Cc: rocka, kde-frameworks-devel, LeGast00n,

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

2020-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/54/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Mar 2020 08:00:21 + Build duration: 5 min 1 sec and counting JUnit Tests Name: