T11950: Reduce the pain of working on monochrome Breeze icons

2020-03-10 Thread Noah Davis
ndavis added a comment.


  @davidhurka pretty impressive. I'll have to try it myself. If the 
dependencies are minimal and it's easy to use, it might be worth it to have the 
tool in the breeze icons repo.

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, ndavis
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender


D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-03-10 Thread Tranter Madi
trmdi added a comment.


  In D27951#625470 , @ngraham wrote:
  
  > However dragging a URL still doesn't show the menu; it just downloads the 
entire page. We need the drop menu in this case because it's probably more 
common to want to create a link to the page than it is to download the entire 
thing.
  >
  > If introspecting the mimetype of every URL is too costly, could we maybe 
short-circuit the logic if the URL scheme is HTTP or HTTPS?
  
  
  Shouldn't this need another patch?
  
  > Also I notice that the cursor still shows a plus sign icon when dragging a 
local file, even though it will be moved, not copied.
  
  I think this need a patch in Dolphin. Could you help me to do it?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27910: Make sure warning output is enabled before testing if the correct warning is printed

2020-03-10 Thread David Faure
dfaure added a comment.


  I suggest a better solution: QStandardPaths::setTestModeEnabled(true) in 
initTestCase().
  
  Then the user settings won't interfere with the unittest.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D27910

To: sandsmark, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2020-03-10 Thread David Faure
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Huh. Sorry about the delays and the need to update version numbers once more.
  
  My last two comments are still not fixed. To see the issues, grep for 
"direcly" ('t' missing) and "Details int" (comma missing? or "int" should be 
removed?).
  Or just land as is and I'll fix them in a followup commit, it'll be faster...

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

2020-03-10 Thread David Faure
dfaure updated this revision to Diff 77381.
dfaure added a comment.


  Ensure no duplicates in partsForMimeType

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27966?vs=77340=77381

REVISION DETAIL
  https://phabricator.kde.org/D27966

AFFECTED FILES
  src/CMakeLists.txt
  src/partloader.cpp
  src/partloader.h
  tests/partviewer.cpp

To: dfaure, aacid, nicolasfella, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

2020-03-10 Thread David Faure
dfaure added inline comments.

INLINE COMMENTS

> aacid wrote in partloader.h:59
> What's the use for this? The function below doesn't let me chose which one i 
> want (i guess it always uses the one with the most preference?), so why would 
> i need to query which parts are available?
> 
> Maybe there should be a version of create that takes a KPluginMetadata?

This is an excellent point, thanks for this feedback.

Loading a part from a given KPluginMetadata is extremely simple, though:

  KPluginLoader loader(md.fileName());
  m_part = loader.factory()->create(this, this);

Just like any other plugin.
[maybe with md.keyword() as third argument in the future, once that's 
implemented]

I can see the idea of providing everything that is needed for KParts at the 
KParts level, so that one doesn't actually have to figure out that the above is 
the way to do it. But then again, this is the way to do it for any plugin, 
there's nothing specific about KParts there. So an alternative would be to put 
this into the documentation for partsForMimeType?

What do you think? Docu or wrapper for a two-liner?

BTW I just implemented part listing (in an actionlist) and part switching in 
partviewer (which is turning into a mini-konqueror, hehe). It shows that the 
above works. It also shows that the duplication between new-style JSON and 
old-style desktop files is a problem, I'll add some duplicate pruning...

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27966

To: dfaure, aacid, nicolasfella, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


T11950: Reduce the pain of working on monochrome Breeze icons

2020-03-10 Thread David Hurka
davidhurka added a comment.


  Whoops, this Task went past me //while// I created breeze-icon-cleaner 
. What a pity!
  
  I think with this tool, we can check the remaining four tasks of the TODO in 
the task description. Sounds optimistic? Well...:
  
  - breeze-icon-cleaner repository has change-to-dark.pl, which converts icons 
from Breeze to Breeze-Dark. (Easy task...)
  - It doesn’t “optimize” the icons, it creates new ones which //are// optimal. 
Below is an example, so you can judge yourself.
  - It embeds the stylesheets. It doesn’t even require additional attention 
while painting the icon in Inkscape, it simply deduces the classes from the 
colors. Easier than what @mglb suggested...
  - “adjust the text”? If code alignment is meant: see below.
  

http://www.w3.org/2000/svg;>


.ColorScheme-NegativeText {
color:#da4453;
}




  
  Let me know what you think.
  
  ---
  
  By the way: Nice that someone removed all that 24px icons and wrote a script 
to generate them. Thanks, @ngraham!

TASK DETAIL
  https://phabricator.kde.org/T11950

To: ngraham, davidhurka
Cc: davidhurka, mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, 
manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender


D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

2020-03-10 Thread Albert Astals Cid
aacid added inline comments.

INLINE COMMENTS

> partloader.h:59
> + */
> +KPARTS_EXPORT QVector partsForMimeType(const QString 
> );
> +

What's the use for this? The function below doesn't let me chose which one i 
want (i guess it always uses the one with the most preference?), so why would i 
need to query which parts are available?

Maybe there should be a version of create that takes a KPluginMetadata?

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27966

To: dfaure, aacid, nicolasfella, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27965: [KPasswdServer] replace foreach with range/index-based for

2020-03-10 Thread Aleix Pol Gonzalez
apol added a comment.


  Having the iterated value change under the hood will eventually break. I'd 
suggest preferring QList::erase to QList::removeOne.

INLINE COMMENTS

> kpasswdserver.cpp:648
> +  static_cast(time(nullptr)) > current->expireTime) {
>authList->removeOne(current);
>delete current;

Use erase.

> kpasswdserver.cpp:682
> {
>authList->removeOne(current);
>delete current;

Use erase.

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27913: Icons for emoji categories

2020-03-10 Thread Noah Davis
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I think I'll want to update some of these icons in the future, particularly 
the animal icon since that's using another project's mascot. Still, I don't 
think it'll be a problem since the TeX lion doesn't seem to have an official 
icon logo.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze, ndavis
Cc: ndavis, apol, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns


D27916: Add Overpass QL highlighting

2020-03-10 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:fdc762d23fdc: Add Overpass QL highlighting (authored by 
vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27916?vs=77179=77372#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27916?vs=77179=77372

REVISION DETAIL
  https://phabricator.kde.org/D27916

AFFECTED FILES
  autotests/folding/highlight.overpassql.fold
  autotests/html/highlight.overpassql.html
  autotests/input/highlight.overpassql
  autotests/reference/highlight.overpassql.ref
  data/syntax/overpassql.xml

To: vkrause, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars


D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-03-10 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-03-10 Thread Nathaniel Graham
ngraham added a comment.


  Nice, drag-and-drop now correctly shows the menu for the case of dragging an 
icon from Kickoff or the task manager. However dragging a URL still doesn't 
show the menu; it just downloads the entire page. We need the drop menu in this 
case because it's probably more common to want to create a link to the page 
than it is to download the entire thing.
  
  If introspecting the mimetype of every URL is too costly, could we maybe 
short-circuit the logic if the URL scheme is HTTP or HTTPS?
  
  Also I notice that the cursor still shows a plus sign icon when dragging a 
local file, even though it will be moved, not copied.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-10 Thread Vlad Zahorodnii
zzag added a comment.


  In D27464#625403 , @broulik wrote:
  
  > Didn't we have a dedicated protocol for window menu in plasma-integration? 
Or is this just for reading? We surely don't want all apps to use plasma 
surface interface for announcing the global menu?
  
  
  Okay, let's step back. We have a proprietary protocol that is used to 
announce application menus. The problem is that only kwin knows that a 
particular window has that particular application menu. We need a way to share 
this information with a global menu applet.
  
  > We surely don't want all apps to use plasma surface interface for 
announcing the global menu?
  
  Could you please explain why we need to announce global menus?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: broulik, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-10 Thread Kai Uwe Broulik
broulik added a comment.


  In D27464#625405 , @zzag wrote:
  
  > Could you please clarify what you mean by "plasma surface interface"?
  
  
  The thing we use in plasmashell to position panels and everything absolutely

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: broulik, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-10 Thread Vlad Zahorodnii
zzag added a comment.


  In D27464#625403 , @broulik wrote:
  
  > Didn't we have a dedicated protocol for window menu in plasma-integration?
  
  
  That protocol is for announcing global menus.
  
  > Or is this just for reading?
  
  Yes, it's for reading.
  
  > We surely don't want all apps to use plasma surface interface for 
announcing the global menu?
  
  Could you please clarify what you mean by "plasma surface interface"?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: broulik, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-10 Thread Kai Uwe Broulik
broulik added a comment.


  Didn't we have a dedicated protocol for window menu in plasma-integration? Or 
is this just for reading? We surely don't want all apps to use plasma surface 
interface for announcing the global menu?
  
  
https://cgit.kde.org/plasma-integration.git/tree/src/platformtheme/kwaylandintegration.cpp
  
  Or was that still using that custom Qt surface protocol that is being 
discontinued?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: broulik, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns


D27965: [KPasswdServer] replace foreach with range/index-based for

2020-03-10 Thread Méven Car
meven added a comment.


  In D27965#625381 , @apol wrote:
  
  > Looks good to me, I wonder why you turned some to for+iterators.
  
  
  Those modified the list as they iterated through the list : 
`authList->removeOne(current);`

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27455: FileWidgets: Ignore Return events from KDirOperator

2020-03-10 Thread Méven Car
meven added a comment.


  Well I meant to do some checking, despite this works, it does not look nice.
  Adding a test would be nice too.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27455

To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27965: [KPasswdServer] replace foreach with range/index-based for

2020-03-10 Thread Aleix Pol Gonzalez
apol added a comment.


  Looks good to me, I wonder why you turned some to for+iterators.

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27455: FileWidgets: Ignore Return events from KDirOperator

2020-03-10 Thread Nathaniel Graham
ngraham added a comment.


  Ping

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27455

To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27152: Introduce FilesystemEntry class

2020-03-10 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> bruns wrote in fstabhandling.cpp:209
> add temporary for fstype

The temporary for fstype is gone it seems.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27928: [VIM Mode] Add g g commands

2020-03-10 Thread Mikhail Zolotukhin
gikari added a comment.


  I added a unit test, but I do not know why it is failing. Actually I do not 
know if I've added it correctly at all. Help is very necsasary.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars


D27928: [VIM Mode] Add g g commands

2020-03-10 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 77355.
gikari added a comment.


  - Add unit-test

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27928?vs=77199=77355

BRANCH
  g-up-g-down-commands (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27928

AFFECTED FILES
  autotests/src/vimode/keys.cpp
  src/vimode/modes/normalvimode.cpp
  src/vimode/modes/visualvimode.cpp

To: gikari, #kate, #frameworks
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars


D27504: smb faster copy to local

2020-03-10 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, Dolphin.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck, #frameworks, #dolphin
Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov


D26841: hardware tool: define syntax via syntax arg

2020-03-10 Thread Harald Sitter
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:8dfb727dd105: hardware tool: define syntax via syntax arg 
(authored by sitter).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26841?vs=74780=77352

REVISION DETAIL
  https://phabricator.kde.org/D26841

AFFECTED FILES
  src/tools/solid-hardware/solid-hardware.cpp

To: sitter
Cc: broulik, bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham


KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Still Unstable!

2020-03-10 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/67/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Mar 2020 13:35:11 +
 Build duration:
1 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-03-10 Thread Tranter Madi
trmdi updated this revision to Diff 77351.
trmdi added a comment.


  Move comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=77350=77351

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-03-10 Thread Tranter Madi
trmdi retitled this revision from "Allow users to change dropAction to 
MoveAction through workspace kcm" to "Allow users to change dropAction to 
MoveAction through kdeglobals".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27871: sftp: fix seekPos + file resuming when part file is of size 11

2020-03-10 Thread Harald Sitter
sitter added inline comments.

INLINE COMMENTS

> bruns wrote in kio_sftp.cpp:1687
> Essentially, apply the change from the man page example to the code here:
> 
>   if (pos != sbPart->size) {
>   int errsv = errno;
>   qCDebug(KIO_SFTP_LOG) << "Failed to seek to" << sbPart->size << "bytes 
> in source file. Reason given:" << strerror(errsv);
>   }
> 
> As the errno value is now held in a local variable (and thus the 
> global/thread-local errno does not matter), no function called from qCDebug() 
> is able to mess with the value. qCDebug() *may* call all kind of functions 
> (remember, it may log to the terminal, to the system journal, ...) which may 
> fail in a non-fatal way ("if this does not work, try that"), overwriting 
> errno in the course.
> 
> Making assumptions about errno can lead to some surprises, and while it may 
> work most of the time it is better to be save than sorry.

Can **you** please make a diff for that?

  fish/fish.cpp:myDebug( << "socketpair failed, error: " << 
strerror(errno));
  fish/fish.cpp:myDebug( << "fork failed, error: " << strerror(errno));
  fish/fish.cpp:myDebug( << "could not exec! " << strerror(errno));
  fish/fish.cpp:myDebug( << "select failed, rc: " << rc << ", 
error: " << strerror(errno));
  fish/fish.cpp:myDebug( << "write failed, rc: " << rc << ", 
error: " << strerror(errno));
  fish/fish.cpp:myDebug( << "read failed, rc: " << rc << ", 
error: " << strerror(errno));
  fish/fish.cpp:myDebug( << "select failed, rc: " << rc << ", 
error: " << strerror(errno));
  fish/fish.cpp:myDebug( << "write failed, rc: " << rc << 
", error: " << strerror(errno));
  fish/fish.cpp:myDebug( << "read failed, rc: " << rc << ", 
error: " << strerror(errno));
  sftp/kio_sftp.cpp:qCDebug(KIO_SFTP_LOG) << "Failed to 
seek to" << sbPart->size << "bytes in source file. Reason given" << 
strerror(errno);
  smb/kio_smb_dir.cpp:qCDebug(KIO_SMB) << "failed to rename" << 
dstUrl << "to" << dstOrigUrl << "->" << strerror(errno);
  smb/kio_smb_browse.cpp:return SMBError{ ERR_INTERNAL, i18n("Unknown 
error condition in stat: %1", QString::fromLocal8Bit( strerror(errNum))) };

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27871

To: sitter, ngraham, feverfew
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
emmanuelp, mikesomov


D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-03-10 Thread Tranter Madi
trmdi marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27951: Allow users to change dropAction to MoveAction through workspace kcm

2020-03-10 Thread Tranter Madi
trmdi updated this revision to Diff 77350.
trmdi added a comment.


  Address meven's comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=77349=77350

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27951: Allow users to change dropAction to MoveAction through workspace kcm

2020-03-10 Thread Méven Car
meven added a comment.


  This does not include the workspace-option kcm setting.
  So I would title this "Allow users to change dropAction to MoveAction through 
a dndToMove kdeglobal setting"

INLINE COMMENTS

> dropjob.cpp:288
>  }
> +if (!m_destUrl.matches(url.adjusted(QUrl::RemoveFilename), 
> QUrl::StripTrailingSlash)) {
> +equalDestination = false;

You could add `equalDestination &&` here to save further checking.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27951: Allow users to change dropAction to MoveAction through workspace kcm

2020-03-10 Thread Tranter Madi
trmdi retitled this revision from "Allow users to change dropAction to 
MoveAction through workspace-option kcm" to "Allow users to change dropAction 
to MoveAction through workspace kcm".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

2020-03-10 Thread Tranter Madi
trmdi marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

2020-03-10 Thread Tranter Madi
trmdi updated this revision to Diff 77349.
trmdi added a comment.


  Move fileItem back to the local scope

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=77329=77349

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27928: [VIM Mode] Add g g commands

2020-03-10 Thread Dominik Haumann
dhaumann added a comment.


  The intimidating one :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars


D27455: FileWidgets: Ignore Return events from KDirOperator

2020-03-10 Thread Christoph Feck
cfeck edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27455

To: meven, dfaure, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D26969: fix type namespace requirement

2020-03-10 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R283:e6877dfa4fe6: fix type namespace requirement (authored by 
sitter).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26969?vs=77262=77344

REVISION DETAIL
  https://phabricator.kde.org/D26969

AFFECTED FILES
  src/backends/dbus/DBusHelperProxy.cpp
  src/kauthactionreply.h

To: sitter, apol, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27504: smb faster copy to local

2020-03-10 Thread Harald Sitter
sitter edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck
Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov


D27504: smb faster copy to local

2020-03-10 Thread Harald Sitter
sitter retitled this revision from "WIP: RFC: smb faster copy to local" to "smb 
faster copy to local".

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck
Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov


D27504: WIP: RFC: smb faster copy to local

2020-03-10 Thread Harald Sitter
sitter updated this revision to Diff 77343.
sitter added a comment.


  - rebase
  - move transfer impls to cpp
  - new unpop function to make the ring usage more consistent and make sure 
neither thread can overtake the other
  - new test for transfer tech. notably simulating imbalance in processing 
speed of the ring threads
  - segment now constructs from the file size instead of the segment size. this 
centralizes segment size code in the segment
  - make all transfers use a segment constructed with the relevant file size to 
get "smart" size calculation everywhere (ring buffer continues only for copyget 
and get)
  
  remote-to-remote copy is blocked on smb_context not being thread safe nor 
reentrant. unlikely to change any time soon. it's also blocking file change 
notification support for both kio and gvfs :(

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27504?vs=76865=77343

BRANCH
  smb-threaded-read

REVISION DETAIL
  https://phabricator.kde.org/D27504

AFFECTED FILES
  smb/CMakeLists.txt
  smb/autotests/CMakeLists.txt
  smb/autotests/transfertest.cpp
  smb/kio_smb.h
  smb/kio_smb_dir.cpp
  smb/kio_smb_file.cpp
  smb/transfer.cpp
  smb/transfer.h

To: sitter, ngraham, cfeck
Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov


D27965: [KPasswdServer] replace foreach with range/index-based for

2020-03-10 Thread Ahmad Samir
ahmadsamir added a comment.


  In D27965#625234 , @meven wrote:
  
  > Please wait for a second review, I am not authoritative here.
  
  
  OK, thanks.

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

2020-03-10 Thread David Faure
dfaure added a revision: D27966: KParts: add PartLoader as replacement to 
KMimeTypeTrader for parts.

TASK DETAIL
  https://phabricator.kde.org/T12173

To: dfaure
Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ekasprzak, 
ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner, jucato, cfeck, 
cgiboudeaux, cullmann, vkrause, cordlandwehr, knauss


T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

2020-03-10 Thread David Faure
dfaure added a revision: D27967: KParts: add unittest for PartLoader, required 
shuffling things around.

TASK DETAIL
  https://phabricator.kde.org/T12173

To: dfaure
Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ekasprzak, 
ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner, jucato, cfeck, 
cgiboudeaux, cullmann, vkrause, cordlandwehr, knauss


D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

2020-03-10 Thread David Faure
dfaure created this revision.
dfaure added reviewers: aacid, nicolasfella, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  It's based on the JSON metadata embedded into the plugins in kf5/parts/,
  but it also has fallback code using KMimeTypeTrader internally until
  KF6, so that we can start using PartLoader in applications.

TEST PLAN
  Tested with partviewer, see also next commit for unittest

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27966

AFFECTED FILES
  src/CMakeLists.txt
  src/partloader.cpp
  src/partloader.h
  tests/partviewer.cpp

To: dfaure, aacid, nicolasfella, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27965: [KPasswdServer] replace foreach with range/index-based for

2020-03-10 Thread Méven Car
meven added a comment.


  Please wait for a second review, I am not authoritative here.

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27965: [KPasswdServer] replace foreach with range/index-based for

2020-03-10 Thread Méven Car
meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

2020-03-10 Thread Méven Car
meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  l-http-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27963

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27965: [KPasswdServer] replace foreach with range/index-based for

2020-03-10 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven.
ahmadsamir added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kpasswdserver.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

2020-03-10 Thread Cyril Rossi
crossi added a comment.


  Tested as an alternative to D27944 
  At initialization, the apply button is enabled.
  Unfortunately, if the user clicks on reset button at first, the apply button 
is disabled an stays disabled.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27724

To: davidedmundson
Cc: iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27964: [KPasswdServer] replace foreach with range/index-based for

2020-03-10 Thread Ahmad Samir
ahmadsamir abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27964

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27964: [KPasswdServer] replace foreach with range/index-based for

2020-03-10 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27964

AFFECTED FILES
  src/kpasswdserver/kpasswdserver.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

2020-03-10 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Use prefix increment operator.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-http-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27963

AFFECTED FILES
  src/ioslaves/http/http_cache_cleaner.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

2020-03-10 Thread Méven Car
meven requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

2020-03-10 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> dropjob.cpp:150
>  Qt::KeyboardModifiers m_keyboardModifiers;
> +KFileItemList m_fileItems;
> +KFileItemListProperties m_itemProps;

I think you don't need a member here, a local variable should suffice.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27704: Drop FindAccountsFileDir.cmake

2020-03-10 Thread Luca Beltrame
lbeltrame requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27704

To: nicolasfella, #frameworks, bshah, leinir, lbeltrame
Cc: lbeltrame


D27704: Drop FindAccountsFileDir.cmake

2020-03-10 Thread Luca Beltrame
lbeltrame reopened this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  "No one using it" is not correct. Or at least, `ACCOUNTS_SERVICES_DIR`, set 
in that file, is used by kaccounts-providers. I'll revert the change (breaks 
building other projects), but probably it can be fixed if that variable is not 
used anywhere.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27704

To: nicolasfella, #frameworks, bshah, leinir
Cc: lbeltrame